)]}'
{"searchlight/elasticsearch/plugins/openstack_clients.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"cddabc502efcd298a4baf61c7ce0a18c367ace9e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"def get_glanceclient():"},{"line_number":64,"context_line":"    session \u003d _get_session()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    return glance_client.Client("},{"line_number":67,"context_line":"        version\u003d\u00272\u0027,"},{"line_number":68,"context_line":"        session\u003dsession,"},{"line_number":69,"context_line":"        region_name\u003dcfg.CONF.service_credentials.os_region_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_e3eeda89","line":66,"range":{"start_line":66,"start_character":11,"end_line":66,"end_character":24},"updated":"2016-05-16 15:16:34.000000000","message":"glanceclient also needs to support os-endpoint-type","commit_id":"569ba7ea4091c4a7c8740d496de916f55502aa7f"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"b10d8754b9c6cbe0425d113a6c6a57a7ef993fbd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    )"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    # if keystone client contains the catalog, grab the glance url"},{"line_number":74,"context_line":"    if keystone.has_service_catalog():"},{"line_number":75,"context_line":"        kwargs \u003d {"},{"line_number":76,"context_line":"            \u0027service_type\u0027: \u0027image\u0027,"},{"line_number":77,"context_line":"            \u0027endpoint_type\u0027: endpoint_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_71cc6e6a","line":74,"range":{"start_line":74,"start_character":7,"end_line":74,"end_character":15},"updated":"2016-05-20 15:57:05.000000000","message":"This isn\u0027t working for me. It will never return true because unless auth_ref is set the catalog information isn\u0027t in keystoneclient; it\u0027s in the session. I don\u0027t think instantiating ks client is going to accomplish anything","commit_id":"5d653e7c9d95ec4bdab499585140638ac5984ff9"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"b10d8754b9c6cbe0425d113a6c6a57a7ef993fbd","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return glance_client.Client("},{"line_number":81,"context_line":"            version\u003d\u00272\u0027,"},{"line_number":82,"context_line":"            session\u003dsession,"},{"line_number":83,"context_line":"            endpoint\u003dkeystone.service_catalog.url_for(**kwargs),"},{"line_number":84,"context_line":"            region_name\u003dregion_name"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_c6b75fd6","line":83,"range":{"start_line":83,"start_character":12,"end_line":83,"end_character":20},"updated":"2016-05-20 15:57:05.000000000","message":"Insteda of this, looks like using \u0027interface\u0027 will work; internally, the SessionClient expects \u0027interface\u0027 as a keyword argument. The other clients all translate endpoint_type -\u003e interface but glance is special. This should allow the glance code to be the same as for the others.","commit_id":"5d653e7c9d95ec4bdab499585140638ac5984ff9"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"b10d8754b9c6cbe0425d113a6c6a57a7ef993fbd","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    return neutronclient.v2_0.client.Client("},{"line_number":118,"context_line":"        session\u003dsession,"},{"line_number":119,"context_line":"        region_name\u003dcfg.CONF.service_credentials.os_region_name,"},{"line_number":120,"context_line":"        endpoint_type\u003dcfg.CONF.service_credentials.os_endpoint_type"},{"line_number":121,"context_line":"    )"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_f6833454","line":120,"range":{"start_line":120,"start_character":8,"end_line":120,"end_character":21},"updated":"2016-05-20 15:57:05.000000000","message":"Worth noting that although neutronclient defaults endpoint_type to \u0027public\u0027 (rather than \u0027publicURL\u0027) it doesn\u0027t matter which you use; the keystone session innards normalize it","commit_id":"5d653e7c9d95ec4bdab499585140638ac5984ff9"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"7db346c25a2aadb4973270425f2b784d0c3664ca","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient import auth as ks_auth"},{"line_number":21,"context_line":"from keystoneclient import session as ks_session"},{"line_number":22,"context_line":"import keystoneclient.v2_0.client as ks_client"},{"line_number":23,"context_line":"import neutronclient.v2_0.client"},{"line_number":24,"context_line":"from novaclient import client as nova_client"},{"line_number":25,"context_line":"import swiftclient"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_b853d26b","line":23,"range":{"start_line":23,"start_character":26,"end_line":23,"end_character":32},"updated":"2016-05-24 15:04:56.000000000","message":"Maybe for consistency rename this one too to neutron_client?","commit_id":"6b1422df44e827bf68c4431e0f07592c9fb1f672"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ac4e2dab50146e8ba64521ba21c130cfa401c782","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient import auth as ks_auth"},{"line_number":21,"context_line":"from keystoneclient import session as ks_session"},{"line_number":22,"context_line":"import keystoneclient.v2_0.client as ks_client"},{"line_number":23,"context_line":"import neutronclient.v2_0.client"},{"line_number":24,"context_line":"from novaclient import client as nova_client"},{"line_number":25,"context_line":"import swiftclient"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_ddbcafdd","line":23,"range":{"start_line":23,"start_character":26,"end_line":23,"end_character":32},"in_reply_to":"bab6814e_b853d26b","updated":"2016-05-24 23:21:51.000000000","message":"Done","commit_id":"6b1422df44e827bf68c4431e0f07592c9fb1f672"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"7db346c25a2aadb4973270425f2b784d0c3664ca","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def get_glanceclient():"},{"line_number":64,"context_line":"    session \u003d _get_session()"},{"line_number":65,"context_line":"    region_name \u003d cfg.CONF.service_credentials.os_region_name"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    return glance_client.Client("},{"line_number":68,"context_line":"        version\u003d\u00272\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_f81f1ab5","line":65,"range":{"start_line":65,"start_character":27,"end_line":65,"end_character":46},"updated":"2016-05-24 15:04:56.000000000","message":"Minor stylistic nit - this doesn\u0027t need to be a separate variable now, but no big deal","commit_id":"6b1422df44e827bf68c4431e0f07592c9fb1f672"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ac4e2dab50146e8ba64521ba21c130cfa401c782","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def get_glanceclient():"},{"line_number":64,"context_line":"    session \u003d _get_session()"},{"line_number":65,"context_line":"    region_name \u003d cfg.CONF.service_credentials.os_region_name"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    return glance_client.Client("},{"line_number":68,"context_line":"        version\u003d\u00272\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_fdb9b3ed","line":65,"range":{"start_line":65,"start_character":27,"end_line":65,"end_character":46},"in_reply_to":"bab6814e_f81f1ab5","updated":"2016-05-24 23:21:51.000000000","message":"Done","commit_id":"6b1422df44e827bf68c4431e0f07592c9fb1f672"}]}
