)]}'
{"searchlight/elasticsearch/plugins/glance/__init__.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c5afb7200fca782596ab56e5f6da940140e64a00","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    document \u003d {k: v for k, v in image.items() if k not in fields_to_ignore}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    # Only snapshot images return image_state field."},{"line_number":70,"context_line":"    # Default to \u0027image\u0027 for non-snapshot image."},{"line_number":71,"context_line":"    if \u0027image_type\u0027 not in document:"},{"line_number":72,"context_line":"        document[\u0027image_type\u0027] \u003d \u0027image\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_8e7dd7b3","line":69,"updated":"2016-05-19 02:17:30.000000000","message":"s/image_state/image_type ?","commit_id":"7741d249394258dc6feec37c7ed778853612b12f"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"8319f705cf97677bbfc0a74acee1124bce8b85fc","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    document \u003d {k: v for k, v in image.items() if k not in fields_to_ignore}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    # Only snapshot images return image_state field."},{"line_number":70,"context_line":"    # Default to \u0027image\u0027 for non-snapshot image."},{"line_number":71,"context_line":"    if \u0027image_type\u0027 not in document:"},{"line_number":72,"context_line":"        document[\u0027image_type\u0027] \u003d \u0027image\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_7cde696e","line":69,"in_reply_to":"bab6814e_3c586132","updated":"2016-05-19 02:48:14.000000000","message":"I meant the comment","commit_id":"7741d249394258dc6feec37c7ed778853612b12f"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"51372f5eb66759952e0728c3953fd56a8ce02b37","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    document \u003d {k: v for k, v in image.items() if k not in fields_to_ignore}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    # Only snapshot images return image_state field."},{"line_number":70,"context_line":"    # Default to \u0027image\u0027 for non-snapshot image."},{"line_number":71,"context_line":"    if \u0027image_type\u0027 not in document:"},{"line_number":72,"context_line":"        document[\u0027image_type\u0027] \u003d \u0027image\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_3c5981ff","line":69,"in_reply_to":"bab6814e_7cde696e","updated":"2016-05-19 02:52:16.000000000","message":"oh. will change on next commit","commit_id":"7741d249394258dc6feec37c7ed778853612b12f"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"1c0326a7b584a951bbde23e3b09073c8c07d2516","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    document \u003d {k: v for k, v in image.items() if k not in fields_to_ignore}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    # Only snapshot images return image_state field."},{"line_number":70,"context_line":"    # Default to \u0027image\u0027 for non-snapshot image."},{"line_number":71,"context_line":"    if \u0027image_type\u0027 not in document:"},{"line_number":72,"context_line":"        document[\u0027image_type\u0027] \u003d \u0027image\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_3c586132","line":69,"in_reply_to":"bab6814e_8e7dd7b3","updated":"2016-05-19 02:41:50.000000000","message":"Its already image_type. Are you looking at any old code?","commit_id":"7741d249394258dc6feec37c7ed778853612b12f"}],"searchlight/elasticsearch/plugins/glance/images.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c5afb7200fca782596ab56e5f6da940140e64a00","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                \u0027updated_at\u0027: {\u0027type\u0027: \u0027date\u0027},"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"                # For images based on snapshot"},{"line_number":74,"context_line":"                \u0027image_type\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":75,"context_line":"                \u0027base_image_ref\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":76,"context_line":"                \u0027image_state\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":77,"context_line":"                \u0027user_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_919b3672","line":74,"updated":"2016-05-19 02:17:30.000000000","message":"There is another property: image_location","commit_id":"7741d249394258dc6feec37c7ed778853612b12f"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"76f3015fee8ee79fc32b08bb23caba92b0a0ef0b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                \u0027updated_at\u0027: {\u0027type\u0027: \u0027date\u0027},"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"                # For images based on snapshot"},{"line_number":74,"context_line":"                \u0027image_type\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":75,"context_line":"                \u0027base_image_ref\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":76,"context_line":"                \u0027image_state\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"},{"line_number":77,"context_line":"                \u0027user_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027},"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_31e9aa81","line":74,"in_reply_to":"bab6814e_919b3672","updated":"2016-05-19 02:25:29.000000000","message":"Ignoring that property since image_type gives us the same info","commit_id":"7741d249394258dc6feec37c7ed778853612b12f"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c5afb7200fca782596ab56e5f6da940140e64a00","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                },"},{"line_number":84,"context_line":"                \"base_image_ref\": {"},{"line_number":85,"context_line":"                    \"resource_type\": resource_types.GLANCE_IMAGE"},{"line_number":86,"context_line":"                }"},{"line_number":87,"context_line":"            }"},{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_1102a66f","line":86,"updated":"2016-05-19 02:17:30.000000000","message":"should instance_uuid here also?","commit_id":"7741d249394258dc6feec37c7ed778853612b12f"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"76f3015fee8ee79fc32b08bb23caba92b0a0ef0b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                },"},{"line_number":84,"context_line":"                \"base_image_ref\": {"},{"line_number":85,"context_line":"                    \"resource_type\": resource_types.GLANCE_IMAGE"},{"line_number":86,"context_line":"                }"},{"line_number":87,"context_line":"            }"},{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_11a3c650","line":86,"in_reply_to":"bab6814e_1102a66f","updated":"2016-05-19 02:25:29.000000000","message":"I added that and user_id too. My rebase got screwed up.","commit_id":"7741d249394258dc6feec37c7ed778853612b12f"}],"searchlight/tests/functional/data/load/images.json":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d475fce34448cf215089246100ebfff8f4280abb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        \"min_disk\": 0,"},{"line_number":20,"context_line":"        \"virtual_size\": null,"},{"line_number":21,"context_line":"        \"id\": \"ef9cc70f-94a4-412b-815b-de3e7f4b87ec\","},{"line_number":22,"context_line":"        \"image_type\": \"image\","},{"line_number":23,"context_line":"        \"size\": 25165824"},{"line_number":24,"context_line":"    },"},{"line_number":25,"context_line":"    {"}],"source_content_type":"application/json","patch_set":4,"id":"bab6814e_a578862c","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":23},"updated":"2016-05-19 19:03:04.000000000","message":"The glance API won\u0027t include image_type, correct? These should be as close as we can get to what the API will provide","commit_id":"8982cee3d17f4960b2bd740ea514879335e1daea"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"f038e45b9b830d918b8e4bc66b88b18cfa032b06","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        \"min_disk\": 0,"},{"line_number":20,"context_line":"        \"virtual_size\": null,"},{"line_number":21,"context_line":"        \"id\": \"ef9cc70f-94a4-412b-815b-de3e7f4b87ec\","},{"line_number":22,"context_line":"        \"image_type\": \"image\","},{"line_number":23,"context_line":"        \"size\": 25165824"},{"line_number":24,"context_line":"    },"},{"line_number":25,"context_line":"    {"}],"source_content_type":"application/json","patch_set":4,"id":"7aa08908_8ffff132","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":23},"in_reply_to":"bab6814e_a578862c","updated":"2016-06-14 19:10:59.000000000","message":"Yes its not provided for default value.  Will have a value of \u0027snapshot\u0027 only for images based on snapshots. I will remove it to make it similar to glance api result for type \u0027image\u0027.","commit_id":"8982cee3d17f4960b2bd740ea514879335e1daea"}],"searchlight/tests/functional/test_api.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d475fce34448cf215089246100ebfff8f4280abb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \"name\": \"owned by tenant 1\","},{"line_number":56,"context_line":"            \"owner\": TENANT1,"},{"line_number":57,"context_line":"            \"created_at\": \"2016-04-06T12:48:18Z\","},{"line_number":58,"context_line":"            \"image_type\": \"image\""},{"line_number":59,"context_line":"        }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        self._index(images_plugin,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_a5c6c646","line":58,"range":{"start_line":58,"start_character":27,"end_line":58,"end_character":32},"updated":"2016-05-19 19:03:04.000000000","message":"This shouldn\u0027t be necessary; self._index will run documents through the serialization function","commit_id":"8982cee3d17f4960b2bd740ea514879335e1daea"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"f038e45b9b830d918b8e4bc66b88b18cfa032b06","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \"name\": \"owned by tenant 1\","},{"line_number":56,"context_line":"            \"owner\": TENANT1,"},{"line_number":57,"context_line":"            \"created_at\": \"2016-04-06T12:48:18Z\","},{"line_number":58,"context_line":"            \"image_type\": \"image\""},{"line_number":59,"context_line":"        }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        self._index(images_plugin,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_2f97ddec","line":58,"range":{"start_line":58,"start_character":27,"end_line":58,"end_character":32},"in_reply_to":"bab6814e_a5c6c646","updated":"2016-06-14 19:10:59.000000000","message":"Yes. removed it.","commit_id":"8982cee3d17f4960b2bd740ea514879335e1daea"}],"searchlight/tests/functional/test_glance_plugins.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d475fce34448cf215089246100ebfff8f4280abb","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"spl_read_only_prop\": \"spl_role only\","},{"line_number":51,"context_line":"            \"visibility\": \"public\","},{"line_number":52,"context_line":"            \"created_at\": \"2016-04-06T12:48:18Z\","},{"line_number":53,"context_line":"            \"image_type\": \"image\""},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"        self._index(self.images_plugin,"},{"line_number":56,"context_line":"                    [doc_with_properties])"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_65021e71","line":53,"range":{"start_line":53,"start_character":26,"end_line":53,"end_character":27},"updated":"2016-05-19 19:03:04.000000000","message":"Shouldn\u0027t be necessary to include this here since serialization will add it","commit_id":"8982cee3d17f4960b2bd740ea514879335e1daea"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"f038e45b9b830d918b8e4bc66b88b18cfa032b06","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"spl_read_only_prop\": \"spl_role only\","},{"line_number":51,"context_line":"            \"visibility\": \"public\","},{"line_number":52,"context_line":"            \"created_at\": \"2016-04-06T12:48:18Z\","},{"line_number":53,"context_line":"            \"image_type\": \"image\""},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"        self._index(self.images_plugin,"},{"line_number":56,"context_line":"                    [doc_with_properties])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_cf8c59d9","line":53,"range":{"start_line":53,"start_character":26,"end_line":53,"end_character":27},"in_reply_to":"bab6814e_65021e71","updated":"2016-06-14 19:10:59.000000000","message":"Done","commit_id":"8982cee3d17f4960b2bd740ea514879335e1daea"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d475fce34448cf215089246100ebfff8f4280abb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # here"},{"line_number":64,"context_line":"        expect_removed \u003d [\"x_none_permitted\", \"x_foo_matcher\", \"x_none_read\","},{"line_number":65,"context_line":"                          \"any_old_property\", \"spl_read_only_prop\","},{"line_number":66,"context_line":"                          \u0027image_type\u0027]"},{"line_number":67,"context_line":"        expected_result \u003d dict((k, v)"},{"line_number":68,"context_line":"                               for k, v in six.iteritems(doc_with_properties)"},{"line_number":69,"context_line":"                               if k not in expect_removed)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_e5f8ce4b","line":66,"range":{"start_line":66,"start_character":27,"end_line":66,"end_character":37},"updated":"2016-05-19 19:03:04.000000000","message":"I may have misunderstood.. why would we expect this to be removed?","commit_id":"8982cee3d17f4960b2bd740ea514879335e1daea"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"f038e45b9b830d918b8e4bc66b88b18cfa032b06","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # here"},{"line_number":64,"context_line":"        expect_removed \u003d [\"x_none_permitted\", \"x_foo_matcher\", \"x_none_read\","},{"line_number":65,"context_line":"                          \"any_old_property\", \"spl_read_only_prop\","},{"line_number":66,"context_line":"                          \u0027image_type\u0027]"},{"line_number":67,"context_line":"        expected_result \u003d dict((k, v)"},{"line_number":68,"context_line":"                               for k, v in six.iteritems(doc_with_properties)"},{"line_number":69,"context_line":"                               if k not in expect_removed)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_5a65c6de","line":66,"range":{"start_line":66,"start_character":27,"end_line":66,"end_character":37},"in_reply_to":"bab6814e_da619213","updated":"2016-06-14 19:10:59.000000000","message":"Added more comment to the source file. See above.","commit_id":"8982cee3d17f4960b2bd740ea514879335e1daea"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"f038e45b9b830d918b8e4bc66b88b18cfa032b06","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # here"},{"line_number":64,"context_line":"        expect_removed \u003d [\"x_none_permitted\", \"x_foo_matcher\", \"x_none_read\","},{"line_number":65,"context_line":"                          \"any_old_property\", \"spl_read_only_prop\","},{"line_number":66,"context_line":"                          \u0027image_type\u0027]"},{"line_number":67,"context_line":"        expected_result \u003d dict((k, v)"},{"line_number":68,"context_line":"                               for k, v in six.iteritems(doc_with_properties)"},{"line_number":69,"context_line":"                               if k not in expect_removed)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_3a6c3acf","line":66,"range":{"start_line":66,"start_character":27,"end_line":66,"end_character":37},"in_reply_to":"bab6814e_e5f8ce4b","updated":"2016-06-14 19:10:59.000000000","message":"This is due to the property protection defined in\ntests/etc/property-protections.conf which allows extra properties only for admin role which is also a good test condition.\n\n\u0027image_type\u0027 is considered a meta property governed by property protections if present.","commit_id":"8982cee3d17f4960b2bd740ea514879335e1daea"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"8f65796e2b33d410151269e141d4f5a6b0afa6f6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # here"},{"line_number":64,"context_line":"        expect_removed \u003d [\"x_none_permitted\", \"x_foo_matcher\", \"x_none_read\","},{"line_number":65,"context_line":"                          \"any_old_property\", \"spl_read_only_prop\","},{"line_number":66,"context_line":"                          \u0027image_type\u0027]"},{"line_number":67,"context_line":"        expected_result \u003d dict((k, v)"},{"line_number":68,"context_line":"                               for k, v in six.iteritems(doc_with_properties)"},{"line_number":69,"context_line":"                               if k not in expect_removed)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_da619213","line":66,"range":{"start_line":66,"start_character":27,"end_line":66,"end_character":37},"in_reply_to":"bab6814e_e5f8ce4b","updated":"2016-05-25 03:26:17.000000000","message":"Yeah a bit more commentary would be helpful, but I\u0027m guessing it is due to glance not providing it via API unless it is snapshot.","commit_id":"8982cee3d17f4960b2bd740ea514879335e1daea"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d475fce34448cf215089246100ebfff8f4280abb","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            \"visibility\": \"private\","},{"line_number":106,"context_line":"            \"members\": [test_api.TENANT1],"},{"line_number":107,"context_line":"            \"created_at\": \"2016-04-06T12:48:18Z\","},{"line_number":108,"context_line":"            \"image_type\": \"image\""},{"line_number":109,"context_line":"        }"},{"line_number":110,"context_line":"        metadef_doc \u003d {"},{"line_number":111,"context_line":"            \"owner\": test_api.TENANT2,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_65397e41","line":108,"range":{"start_line":108,"start_character":26,"end_line":108,"end_character":27},"updated":"2016-05-19 19:03:04.000000000","message":"Same, shouldn\u0027t need this","commit_id":"8982cee3d17f4960b2bd740ea514879335e1daea"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"f038e45b9b830d918b8e4bc66b88b18cfa032b06","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            \"visibility\": \"private\","},{"line_number":106,"context_line":"            \"members\": [test_api.TENANT1],"},{"line_number":107,"context_line":"            \"created_at\": \"2016-04-06T12:48:18Z\","},{"line_number":108,"context_line":"            \"image_type\": \"image\""},{"line_number":109,"context_line":"        }"},{"line_number":110,"context_line":"        metadef_doc \u003d {"},{"line_number":111,"context_line":"            \"owner\": test_api.TENANT2,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_afb2ad91","line":108,"range":{"start_line":108,"start_character":26,"end_line":108,"end_character":27},"in_reply_to":"bab6814e_65397e41","updated":"2016-06-14 19:10:59.000000000","message":"Done","commit_id":"8982cee3d17f4960b2bd740ea514879335e1daea"}]}