)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"8f65a84876822dd26100f9745734977281849f34","unresolved":false,"context_lines":[{"line_number":13,"context_line":"returne these subfields instead of the actual field."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iae0622186934d1583f18c6c3c480e936e418fc3e"},{"line_number":16,"context_line":"Closes-Bugs: #1558884"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_84b1bd91","line":16,"updated":"2016-05-26 19:45:43.000000000","message":"Closes-Bug (singular)","commit_id":"e39894d2b06ee3fa6d2f37495b18332468462d16"},{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"3ed8555d2ca5d64e9080a7aa07f931bbdb9b79d1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"returne these subfields instead of the actual field."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iae0622186934d1583f18c6c3c480e936e418fc3e"},{"line_number":16,"context_line":"Closes-Bugs: #1558884"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_4cfabcbe","line":16,"in_reply_to":"bab6814e_84b1bd91","updated":"2016-05-30 14:33:54.000000000","message":"Done","commit_id":"e39894d2b06ee3fa6d2f37495b18332468462d16"}],"doc/source/searchlightapi.rst":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c2762f8803c6b03993ff5b8f5e544dd5ec40baf3","unresolved":false,"context_lines":[{"line_number":426,"context_line":"      {"},{"line_number":427,"context_line":"        \"name\": \"name\","},{"line_number":428,"context_line":"        \"type\": \"string\","},{"line_number":429,"context_line":"        \"fact_field\": \"name.raw\""},{"line_number":430,"context_line":"      },"},{"line_number":431,"context_line":"      ..."},{"line_number":432,"context_line":"    ],"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abb7d3a_f5912748","line":429,"updated":"2016-06-01 20:45:34.000000000","message":"Should be \"facet_field\", not \"fact_field\".","commit_id":"41c707c6a3a736a3d7204eb3c55c99452358da06"},{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"f06bfca7aa4d007b8111a764d60a7e7c3cd3c80c","unresolved":false,"context_lines":[{"line_number":426,"context_line":"      {"},{"line_number":427,"context_line":"        \"name\": \"name\","},{"line_number":428,"context_line":"        \"type\": \"string\","},{"line_number":429,"context_line":"        \"fact_field\": \"name.raw\""},{"line_number":430,"context_line":"      },"},{"line_number":431,"context_line":"      ..."},{"line_number":432,"context_line":"    ],"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abb7d3a_ff6f39c1","line":429,"in_reply_to":"9abb7d3a_f5912748","updated":"2016-06-02 02:16:51.000000000","message":"Good catch, I must be drunk at that time","commit_id":"41c707c6a3a736a3d7204eb3c55c99452358da06"}],"searchlight/elasticsearch/plugins/base.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"8f65a84876822dd26100f9745734977281849f34","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                        facet_name \u003d prefix + name"},{"line_number":224,"context_line":"                        # Use raw subfield as facet if it\u0027s an analyzed field,"},{"line_number":225,"context_line":"                        # aggregation on analyzed sting field doesn\u0027t play well"},{"line_number":226,"context_line":"                        if properties[\u0027type\u0027] \u003d\u003d \u0027string\u0027 \\"},{"line_number":227,"context_line":"                                and properties.get(\u0027index\u0027) !\u003d \u0027not_analyzed\u0027 \\"},{"line_number":228,"context_line":"                                and \u0027raw\u0027 in properties.get(\u0027fields\u0027, {}):"},{"line_number":229,"context_line":"                            facet_name \u003d \u0027%s.raw\u0027 % facet_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_84d25dfe","line":226,"range":{"start_line":226,"start_character":45,"end_line":226,"end_character":46},"updated":"2016-05-26 19:45:43.000000000","message":"Style point - openstack prefers not to use slashes for multiline statements, instead prefers (double indented for pep8)\n\nif (properties[\u0027type\u0027]... and\n        properties.get(\u0027index\u0027)... and\n        ....):\n    facet_name \u003d","commit_id":"e39894d2b06ee3fa6d2f37495b18332468462d16"},{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"3ed8555d2ca5d64e9080a7aa07f931bbdb9b79d1","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                        facet_name \u003d prefix + name"},{"line_number":224,"context_line":"                        # Use raw subfield as facet if it\u0027s an analyzed field,"},{"line_number":225,"context_line":"                        # aggregation on analyzed sting field doesn\u0027t play well"},{"line_number":226,"context_line":"                        if properties[\u0027type\u0027] \u003d\u003d \u0027string\u0027 \\"},{"line_number":227,"context_line":"                                and properties.get(\u0027index\u0027) !\u003d \u0027not_analyzed\u0027 \\"},{"line_number":228,"context_line":"                                and \u0027raw\u0027 in properties.get(\u0027fields\u0027, {}):"},{"line_number":229,"context_line":"                            facet_name \u003d \u0027%s.raw\u0027 % facet_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_cc4d0c74","line":226,"range":{"start_line":226,"start_character":45,"end_line":226,"end_character":46},"in_reply_to":"bab6814e_84d25dfe","updated":"2016-05-30 14:33:54.000000000","message":"Done","commit_id":"e39894d2b06ee3fa6d2f37495b18332468462d16"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"8f65a84876822dd26100f9745734977281849f34","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                        if properties[\u0027type\u0027] \u003d\u003d \u0027string\u0027 \\"},{"line_number":227,"context_line":"                                and properties.get(\u0027index\u0027) !\u003d \u0027not_analyzed\u0027 \\"},{"line_number":228,"context_line":"                                and \u0027raw\u0027 in properties.get(\u0027fields\u0027, {}):"},{"line_number":229,"context_line":"                            facet_name \u003d \u0027%s.raw\u0027 % facet_name"},{"line_number":230,"context_line":"                        facet \u003d {"},{"line_number":231,"context_line":"                            \u0027name\u0027: facet_name,"},{"line_number":232,"context_line":"                            \u0027type\u0027: properties[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_648779b5","line":229,"range":{"start_line":229,"start_character":45,"end_line":229,"end_character":48},"updated":"2016-05-26 19:45:43.000000000","message":"This is going to mean that the UI will see e.g. \"field.raw\" as the facet, which probably isn\u0027t ideal. It might make sense instead to add a field to the \u0027facet\u0027 dict below with the .raw field and have the UI do the substitution if it wishes","commit_id":"e39894d2b06ee3fa6d2f37495b18332468462d16"},{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"3ed8555d2ca5d64e9080a7aa07f931bbdb9b79d1","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                        if properties[\u0027type\u0027] \u003d\u003d \u0027string\u0027 \\"},{"line_number":227,"context_line":"                                and properties.get(\u0027index\u0027) !\u003d \u0027not_analyzed\u0027 \\"},{"line_number":228,"context_line":"                                and \u0027raw\u0027 in properties.get(\u0027fields\u0027, {}):"},{"line_number":229,"context_line":"                            facet_name \u003d \u0027%s.raw\u0027 % facet_name"},{"line_number":230,"context_line":"                        facet \u003d {"},{"line_number":231,"context_line":"                            \u0027name\u0027: facet_name,"},{"line_number":232,"context_line":"                            \u0027type\u0027: properties[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_4cc59c8c","line":229,"range":{"start_line":229,"start_character":45,"end_line":229,"end_character":48},"in_reply_to":"bab6814e_648779b5","updated":"2016-05-30 14:33:54.000000000","message":"Done, add to all analyzed fields with raw fields, no matter whether they are listed in facet options, is that OK? Or should expose raw fields only on options fields","commit_id":"e39894d2b06ee3fa6d2f37495b18332468462d16"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"a7990dfddb66e8ef4d1cd99cb537fbec94643c01","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                        }"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"                        # Add raw field if it\u0027s an analyzed field,"},{"line_number":230,"context_line":"                        # aggregation on analyzed sting field doesn\u0027t work well"},{"line_number":231,"context_line":"                        if (properties[\u0027type\u0027] \u003d\u003d \u0027string\u0027 and"},{"line_number":232,"context_line":"                                properties.get(\u0027index\u0027) !\u003d \u0027not_analyzed\u0027 and"},{"line_number":233,"context_line":"                                \u0027raw\u0027 in properties.get(\u0027fields\u0027, {})):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_885cfd19","line":230,"range":{"start_line":230,"start_character":50,"end_line":230,"end_character":55},"updated":"2016-06-01 23:22:48.000000000","message":"Typo: \"string\"\n\nOr maybe not. I\u0027ve been stung by an analyzed field in the past :)","commit_id":"41c707c6a3a736a3d7204eb3c55c99452358da06"},{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"f06bfca7aa4d007b8111a764d60a7e7c3cd3c80c","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                        }"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"                        # Add raw field if it\u0027s an analyzed field,"},{"line_number":230,"context_line":"                        # aggregation on analyzed sting field doesn\u0027t work well"},{"line_number":231,"context_line":"                        if (properties[\u0027type\u0027] \u003d\u003d \u0027string\u0027 and"},{"line_number":232,"context_line":"                                properties.get(\u0027index\u0027) !\u003d \u0027not_analyzed\u0027 and"},{"line_number":233,"context_line":"                                \u0027raw\u0027 in properties.get(\u0027fields\u0027, {})):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_bfd5b143","line":230,"range":{"start_line":230,"start_character":50,"end_line":230,"end_character":55},"in_reply_to":"9abb7d3a_885cfd19","updated":"2016-06-02 02:16:51.000000000","message":"Good catch, my vocabulary is growing : )","commit_id":"41c707c6a3a736a3d7204eb3c55c99452358da06"}],"searchlight/elasticsearch/plugins/utils.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"8f65a84876822dd26100f9745734977281849f34","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            facet_name, actual_field \u003d facet"},{"line_number":391,"context_line":"        else:"},{"line_number":392,"context_line":"            facet_name, actual_field \u003d facet, facet"},{"line_number":393,"context_line":"        if \u0027.\u0027 in facet_name and not facet_name.endswith(\u0027.raw\u0027):"},{"line_number":394,"context_line":"            # Needs a nested aggregate except for raw fields"},{"line_number":395,"context_line":"            term_aggregations[facet_name] \u003d {"},{"line_number":396,"context_line":"                \"nested\": {\"path\": facet_name.split(\u0027.\u0027)[0]},"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_a471610e","line":393,"range":{"start_line":393,"start_character":37,"end_line":393,"end_character":47},"updated":"2016-05-26 19:45:43.000000000","message":"This will fail on e.g. nested.field.raw. I can\u0027t remember why i did the tuple check above, but could we instead change this so that for raw fields we pass in (field, field.raw) ?","commit_id":"e39894d2b06ee3fa6d2f37495b18332468462d16"},{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"3ed8555d2ca5d64e9080a7aa07f931bbdb9b79d1","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            facet_name, actual_field \u003d facet"},{"line_number":391,"context_line":"        else:"},{"line_number":392,"context_line":"            facet_name, actual_field \u003d facet, facet"},{"line_number":393,"context_line":"        if \u0027.\u0027 in facet_name and not facet_name.endswith(\u0027.raw\u0027):"},{"line_number":394,"context_line":"            # Needs a nested aggregate except for raw fields"},{"line_number":395,"context_line":"            term_aggregations[facet_name] \u003d {"},{"line_number":396,"context_line":"                \"nested\": {\"path\": facet_name.split(\u0027.\u0027)[0]},"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_6c686088","line":393,"range":{"start_line":393,"start_character":37,"end_line":393,"end_character":47},"in_reply_to":"bab6814e_a471610e","updated":"2016-05-30 14:33:54.000000000","message":"Done","commit_id":"e39894d2b06ee3fa6d2f37495b18332468462d16"}]}