)]}'
{"searchlight/elasticsearch/plugins/helper.py":[{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"cb151cc53fa7986010f7acab3cd6d5228dc4abfa","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        exc_info_error \u003d getattr(e, \u0027info\u0027, {}).get(\u0027error\u0027, {})"},{"line_number":510,"context_line":"        if ALIAS_EXCEPTION_STRING in exc_info_error.get(\u0027reason\u0027, \u0027\u0027):"},{"line_number":511,"context_line":"            return True"},{"line_number":512,"context_line":"    except AttributeError:"},{"line_number":513,"context_line":"        pass"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_c082f151","line":512,"updated":"2016-06-07 07:30:28.000000000","message":"Is the exception handling required here? Using default values should prevent exceptions happening.","commit_id":"778a8897daffe6f86874131dcc67dd028b3d5fde"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"6657aa7d6edb0a876071393733967a3b47598103","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        exc_info_error \u003d getattr(e, \u0027info\u0027, {}).get(\u0027error\u0027, {})"},{"line_number":510,"context_line":"        if ALIAS_EXCEPTION_STRING in exc_info_error.get(\u0027reason\u0027, \u0027\u0027):"},{"line_number":511,"context_line":"            return True"},{"line_number":512,"context_line":"    except AttributeError:"},{"line_number":513,"context_line":"        pass"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_e8fa4c74","line":512,"in_reply_to":"7aa08908_c082f151","updated":"2016-06-07 16:56:55.000000000","message":"Only if \u0027error\u0027 turns out not to be a dictionary, but i guess in that case it\u0027s maybe best to fail since something else may have changed. I\u0027ll remove the block.","commit_id":"778a8897daffe6f86874131dcc67dd028b3d5fde"}]}
