)]}'
{"searchlight/elasticsearch/plugins/designate/notification_handlers.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"ac6ba9aebb9ad212b30306cb4b4f3abdd3499169","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    def _serialize(self, obj):"},{"line_number":258,"context_line":"        if not obj[\u0027updated_at\u0027] and obj[\u0027created_at\u0027]:"},{"line_number":259,"context_line":"            obj[\u0027updated_at\u0027] \u003d obj[\u0027created_at\u0027]"},{"line_number":260,"context_line":"            obj[\u0027project_id\u0027] \u003d obj.pop(\u0027tenant_id\u0027)"},{"line_number":261,"context_line":"        return obj"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def create_or_update(self, payload, timestamp):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_93c7db44","line":260,"range":{"start_line":260,"start_character":17,"end_line":260,"end_character":27},"updated":"2016-06-20 16:29:47.000000000","message":"Indentation?","commit_id":"c559ba943517ab6d027b7a7d98a925ebe20ec3fd"}],"searchlight/elasticsearch/plugins/designate/pools.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"ac6ba9aebb9ad212b30306cb4b4f3abdd3499169","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # but pools managed by designate-manage using a config file doesn\u0027t"},{"line_number":70,"context_line":"        # add project_id info to pool data. Making it more restrictive here by"},{"line_number":71,"context_line":"        # allowing it only for admins"},{"line_number":72,"context_line":"        return []"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def get_objects(self):"},{"line_number":75,"context_line":"        from searchlight.elasticsearch.plugins import openstack_clients"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_13948b35","line":72,"range":{"start_line":72,"start_character":15,"end_line":72,"end_character":17},"updated":"2016-06-20 16:29:47.000000000","message":"This needs to be accompanied with a change to policy.json to make the plugin accessible only to admins","commit_id":"c559ba943517ab6d027b7a7d98a925ebe20ec3fd"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"ac6ba9aebb9ad212b30306cb4b4f3abdd3499169","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    def serialize(self, obj):"},{"line_number":82,"context_line":"        obj.pop(\"links\", None)"},{"line_number":83,"context_line":"        if not obj[\u0027updated_at\u0027] and obj[\u0027created_at\u0027]:"},{"line_number":84,"context_line":"            obj[\u0027updated_at\u0027] \u003d obj[\u0027created_at\u0027]"},{"line_number":85,"context_line":"        return obj"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_f3dbbf19","line":84,"range":{"start_line":84,"start_character":17,"end_line":84,"end_character":27},"updated":"2016-06-20 16:29:47.000000000","message":"Need to add project id?","commit_id":"c559ba943517ab6d027b7a7d98a925ebe20ec3fd"}],"searchlight/elasticsearch/plugins/designate/zones.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"4bc3045846035f5c8de19bf4e2a37205fe107959","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return {\u0027project_id\u0027: True}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get_parent_id_field(self):"},{"line_number":102,"context_line":"        return \u0027pool_id\u0027"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":105,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_68a2384d","line":102,"range":{"start_line":102,"start_character":16,"end_line":102,"end_character":23},"updated":"2016-06-15 21:49:38.000000000","message":"pool_id isn\u0027t mapped explicitly. In addition, I don\u0027t know if it makes sense to treat this as a parent-child relationship. It\u0027s true that zones are assigned to a pool for sharding purposes, but it\u0027s not likely that you\u0027d make use of the parent-child relationship frequently.\n\nIn addition, pools are an admin-only concept (similar to hypervisors) which creates additional access issues.","commit_id":"ca6ff4da453ac2f5ba39114e62f06851f113cca2"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"f9bef073a2bc477b2f7c00cceb233f2346b9d5e0","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        return {\u0027project_id\u0027: True}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get_parent_id_field(self):"},{"line_number":102,"context_line":"        return \u0027pool_id\u0027"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":105,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_a5a9747e","line":102,"range":{"start_line":102,"start_character":16,"end_line":102,"end_character":23},"in_reply_to":"7aa08908_68a2384d","updated":"2016-06-17 20:11:57.000000000","message":"designate has two way of managing pools designate-manage cli and \u0027openstack pool xxx\u0027 cli. \ndesignate-manage sets null value for project_id\u0027s which i was also concerned if that\u0027s a bug but it makes sense to be admin only.\nI will remove rbac for pool","commit_id":"ca6ff4da453ac2f5ba39114e62f06851f113cca2"}]}