)]}'
{"doc/source/plugins/neutron.rst":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"aed5d09922a4ea977157b35bc2c6dc379bdf8c7f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    resource_group_name \u003d searchlight"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Plugin: OS::Neutron::FloatingIP"},{"line_number":75,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":76,"context_line":"::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [resource_plugin:os_neutron_floatingip]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_b702460a","line":75,"updated":"2016-06-18 00:18:30.000000000","message":"Nit. We should have the line of \u0027^\u0027 extend to the end of \"FloatingIP\".","commit_id":"ce0281d6b09489f34cd0bcbf2a5de12bc1c80ae1"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"aed5d09922a4ea977157b35bc2c6dc379bdf8c7f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"* searchlight/elasticsearch/plugins/neutron/routers.py"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Floating IP addresses are mapped as type \u0027ip\u0027 which only supports ipv4 in"},{"line_number":162,"context_line":"Elasticsearch prior to the 5.0 release. Neutron doesn\u0027t seem to support ipv6"},{"line_number":163,"context_line":"floating IPs since translating ipv4 FIPs to ipv6 internal addresses isn\u0027t"},{"line_number":164,"context_line":"supported and mapping ipv6-\u003eipv6 is deemed unnecessary."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_e909922c","line":162,"range":{"start_line":162,"start_character":27,"end_line":162,"end_character":30},"updated":"2016-06-18 00:18:30.000000000","message":"Confusing. Implies that release 5.0 is for ES.","commit_id":"ce0281d6b09489f34cd0bcbf2a5de12bc1c80ae1"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"62ba25a9ef9dd778ff336477e8b79ce15e11036e","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [resource_plugin:os_neutron_floatingip]"},{"line_number":79,"context_line":"    enabled \u003d true"},{"line_number":80,"context_line":"    resource_group_name \u003d searchlight"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Neutron Configuration"},{"line_number":83,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3aaa91ec_65d1d7cd","line":80,"updated":"2016-06-22 00:11:20.000000000","message":"Probably should add to sample local.conf","commit_id":"f57e87b23593ae908d3b0911497a91bbd2d89792"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"a3d3345d93e4c12adedc16ac1f5f4d2691fb1077","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [resource_plugin:os_neutron_floatingip]"},{"line_number":79,"context_line":"    enabled \u003d true"},{"line_number":80,"context_line":"    resource_group_name \u003d searchlight"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Neutron Configuration"},{"line_number":83,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3aaa91ec_ebb0bbdf","line":80,"in_reply_to":"3aaa91ec_65d1d7cd","updated":"2016-06-22 22:16:38.000000000","message":"Done","commit_id":"f57e87b23593ae908d3b0911497a91bbd2d89792"}],"releasenotes/notes/bp-neutron-floatingip-1291f3a76f0e4aed.yaml":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"62ba25a9ef9dd778ff336477e8b79ce15e11036e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"  Added support for neutron floating IPs."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Adds neutron floating IP support."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_e5f147cf","line":5,"updated":"2016-06-22 00:11:20.000000000","message":"Nit (change only if another change is needed) Please put in the resource type (OS::Neutron::FloatingIP).\nMight mention the neutron bug here.","commit_id":"f57e87b23593ae908d3b0911497a91bbd2d89792"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"a3d3345d93e4c12adedc16ac1f5f4d2691fb1077","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"  Added support for neutron floating IPs."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Adds neutron floating IP support."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_2bf92381","line":5,"in_reply_to":"3aaa91ec_e5f147cf","updated":"2016-06-22 22:16:38.000000000","message":"Done","commit_id":"f57e87b23593ae908d3b0911497a91bbd2d89792"}],"searchlight/elasticsearch/plugins/neutron/floatingips.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"aed5d09922a4ea977157b35bc2c6dc379bdf8c7f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                \u0027project_id\u0027: {"},{"line_number":57,"context_line":"                    \u0027resource_type\u0027: resource_types.KEYSTONE_PROJECT"},{"line_number":58,"context_line":"                },"},{"line_number":59,"context_line":"                \u0027router_id\u0027: {"},{"line_number":60,"context_line":"                    \u0027resource_type\u0027: resource_types.KEYSTONE_PROJECT"},{"line_number":61,"context_line":"                },"},{"line_number":62,"context_line":"                \u0027floating_network_id\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_09efbe1d","line":59,"range":{"start_line":59,"start_character":18,"end_line":59,"end_character":26},"updated":"2016-06-18 00:18:30.000000000","message":"Is this supposed to be tenant_id? Otherwise the resource type should be resource_type.NEUTRON_ROUTER.","commit_id":"ce0281d6b09489f34cd0bcbf2a5de12bc1c80ae1"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"aed5d09922a4ea977157b35bc2c6dc379bdf8c7f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        fields should not be offered as facet options, or those that should"},{"line_number":79,"context_line":"        only be available to administrators."},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        return {\u0027tenant_id\u0027: True, \u0027project_id\u0027: True}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":84,"context_line":"        \"\"\"Return any RBAC field filters to be injected into an indices"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_a9edca26","line":81,"range":{"start_line":81,"start_character":49,"end_line":81,"end_character":53},"updated":"2016-06-18 00:18:30.000000000","message":"Is there a reason for project_id to be available to admins? All of the other Neutron plugins have this set to \u0027False\u0027.","commit_id":"ce0281d6b09489f34cd0bcbf2a5de12bc1c80ae1"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"808879718291ba0c440a75d44f98fbe79392425d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                \u0027port_id\u0027: str_not_analyzed,"},{"line_number":53,"context_line":"                \u0027id\u0027: str_not_analyzed"},{"line_number":54,"context_line":"            },"},{"line_number":55,"context_line":"            \u0027_meta\u0027: {"},{"line_number":56,"context_line":"                \u0027project_id\u0027: {"},{"line_number":57,"context_line":"                    \u0027resource_type\u0027: resource_types.KEYSTONE_PROJECT"},{"line_number":58,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_ac8771b3","line":55,"updated":"2016-06-24 22:28:00.000000000","message":"similar to instances, we should also put the resource type on tenant_id\n\nhttps://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/nova/servers.py#L117-L122","commit_id":"0c579a70d0b07a465d322921ef42537e6b981997"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"3079d56a605228d06581806202f48dcfa6d9b216","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                \u0027port_id\u0027: str_not_analyzed,"},{"line_number":53,"context_line":"                \u0027id\u0027: str_not_analyzed"},{"line_number":54,"context_line":"            },"},{"line_number":55,"context_line":"            \u0027_meta\u0027: {"},{"line_number":56,"context_line":"                \u0027project_id\u0027: {"},{"line_number":57,"context_line":"                    \u0027resource_type\u0027: resource_types.KEYSTONE_PROJECT"},{"line_number":58,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_045d7cec","line":55,"in_reply_to":"3aaa91ec_ac8771b3","updated":"2016-06-27 16:24:30.000000000","message":"Done","commit_id":"0c579a70d0b07a465d322921ef42537e6b981997"}],"searchlight/elasticsearch/plugins/neutron/notification_handlers.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"aed5d09922a4ea977157b35bc2c6dc379bdf8c7f","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    def create_or_update(self, payload, timestamp):"},{"line_number":218,"context_line":"        fip_id \u003d payload[\u0027floatingip\u0027][\u0027id\u0027]"},{"line_number":219,"context_line":"        LOG.debug(\"Updating floatingip information for %s\", fip_id)"},{"line_number":220,"context_line":"        floatingip \u003d serialize_router("},{"line_number":221,"context_line":"            payload[\u0027floatingip\u0027],"},{"line_number":222,"context_line":"            updated_at\u003dutils.timestamp_to_isotime(timestamp))"},{"line_number":223,"context_line":"        version \u003d self.get_version(floatingip, timestamp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_c95db6ed","line":220,"range":{"start_line":220,"start_character":21,"end_line":220,"end_character":37},"updated":"2016-06-18 00:18:30.000000000","message":"Copy-paste error? This should be serialize_floatingip(). We also will need to add an import at the top of the file:\n\nfrom searchlight.elasticsearch_plugins.neutron import serialize_floatingip","commit_id":"ce0281d6b09489f34cd0bcbf2a5de12bc1c80ae1"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"aed5d09922a4ea977157b35bc2c6dc379bdf8c7f","unresolved":false,"context_lines":[{"line_number":230,"context_line":"            self.index_helper.delete_document({\u0027_id\u0027: fip_id})"},{"line_number":231,"context_line":"        except Exception as exc:"},{"line_number":232,"context_line":"            LOG.error(_LE("},{"line_number":233,"context_line":"                \u0027Error deleting router %(router)s \u0027"},{"line_number":234,"context_line":"                \u0027from index: %(exc)s\u0027) %"},{"line_number":235,"context_line":"                {\u0027router\u0027: fip_id, \u0027exc\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_49f9c6c7","line":233,"range":{"start_line":233,"start_character":32,"end_line":233,"end_character":47},"updated":"2016-06-18 00:18:30.000000000","message":"Should be \"floating IP %(tip)s\"","commit_id":"ce0281d6b09489f34cd0bcbf2a5de12bc1c80ae1"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"aed5d09922a4ea977157b35bc2c6dc379bdf8c7f","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            LOG.error(_LE("},{"line_number":233,"context_line":"                \u0027Error deleting router %(router)s \u0027"},{"line_number":234,"context_line":"                \u0027from index: %(exc)s\u0027) %"},{"line_number":235,"context_line":"                {\u0027router\u0027: fip_id, \u0027exc\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_29f6fad6","line":235,"range":{"start_line":235,"start_character":18,"end_line":235,"end_character":24},"updated":"2016-06-18 00:18:30.000000000","message":"Should be \"fip\".","commit_id":"ce0281d6b09489f34cd0bcbf2a5de12bc1c80ae1"}],"searchlight/tests/unit/test_neutron_floatingip.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"8ae40bc1fe214cc280c3c1afccbe401ce1849a7b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"USER1 \u003d u\u002727f4d76b-be62-4e4e-aa33bb11cc55\u0027"},{"line_number":28,"context_line":"ID1 \u003d u\u0027813dd936-663e-4e5b-877c-986021b73e2c\u0027"},{"line_number":29,"context_line":"TENANT1 \u003d u\u00278eaac046b2c44ab99246cb0850c7f06d\u0027"},{"line_number":30,"context_line":"NETWORK1 \u003d u\u0027bc0adf22-3aef-4e7b-8b99-12670b5a76b5\u0027"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_7a820402","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":3},"updated":"2016-06-20 15:51:15.000000000","message":"Not used since it was replaced with the FIP_ID* brothers. It can be deleted.","commit_id":"e987c6f4d220cf7ed8ac2e8e69004d8ae66bfefa"}]}