)]}'
{"doc/source/plugins.rst":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"f3416c08b9d0be74b003986302e75d62653edd04","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    enabled \u003d True"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    [resource_plugin:os_nova_servergroup]"},{"line_number":92,"context_line":"    enabled \u003d True"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    [resource_plugin:os_glance_image]"},{"line_number":95,"context_line":"    enabled \u003d True"}],"source_content_type":"text/x-rst","patch_set":23,"id":"bacf61ea_cfb2b105","line":92,"range":{"start_line":92,"start_character":14,"end_line":92,"end_character":18},"updated":"2016-08-05 15:15:28.000000000","message":"I\u0027m a little hesitant to enable this by default. Since there are no notifications, and it\u0027s a user-created entity, it\u0027s guaranteed to require reindexing regularly.","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c223aceb6ddfb55d19f4ed53e86a3bf2ad98bf2d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    enabled \u003d True"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    [resource_plugin:os_nova_servergroup]"},{"line_number":92,"context_line":"    enabled \u003d True"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    [resource_plugin:os_glance_image]"},{"line_number":95,"context_line":"    enabled \u003d True"}],"source_content_type":"text/x-rst","patch_set":23,"id":"bacf61ea_3758d489","line":92,"range":{"start_line":92,"start_character":14,"end_line":92,"end_character":18},"in_reply_to":"bacf61ea_cfb2b105","updated":"2016-08-08 04:00:50.000000000","message":"Done","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"}],"doc/source/plugins/nova.rst":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    often you re-sync the data."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Plugin: OS::Nova::SeverGroups"},{"line_number":98,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":99,"context_line":"::"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"bacf61ea_d52874e4","line":97,"range":{"start_line":97,"start_character":18,"end_line":97,"end_character":29},"updated":"2016-08-05 21:33:06.000000000","message":"Isn\u0027t this OS::Nova::ServerGroup?","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c223aceb6ddfb55d19f4ed53e86a3bf2ad98bf2d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    often you re-sync the data."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Plugin: OS::Nova::SeverGroups"},{"line_number":98,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":99,"context_line":"::"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"bacf61ea_b79164f3","line":97,"range":{"start_line":97,"start_character":18,"end_line":97,"end_character":29},"in_reply_to":"bacf61ea_d52874e4","updated":"2016-08-08 04:00:50.000000000","message":"Done","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Plugin: OS::Nova::SeverGroups"},{"line_number":98,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":99,"context_line":"::"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    [resource_plugin:os_nova_servergroup]"}],"source_content_type":"text/x-rst","patch_set":23,"id":"bacf61ea_552da4fc","line":98,"updated":"2016-08-05 21:33:06.000000000","message":"Nit: This line \"^^^^^\" should extend to the end of the line above:\n\nPlugin: OS::Nova::ServerGroup\n^^^^^^^^^^^^^^^^^^^^^^^^^^^^^","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c223aceb6ddfb55d19f4ed53e86a3bf2ad98bf2d","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Plugin: OS::Nova::SeverGroups"},{"line_number":98,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":99,"context_line":"::"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    [resource_plugin:os_nova_servergroup]"}],"source_content_type":"text/x-rst","patch_set":23,"id":"bacf61ea_37cf342a","line":98,"in_reply_to":"bacf61ea_552da4fc","updated":"2016-08-08 04:00:50.000000000","message":"Done","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20c48ec343f725ce3c4a93b25604f931c6751138","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    resource_group_name \u003d searchlight"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Plugin: OS::Nova::Hypervisor"},{"line_number":64,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":65,"context_line":"::"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    [resource_plugin:os_nova_hypervisor]"}],"source_content_type":"text/x-rst","patch_set":27,"id":"9ad45d7e_d19ab862","line":64,"updated":"2016-08-09 19:36:36.000000000","message":"I think you missed a rebase. This need the ^^^^ under the rest of the word.","commit_id":"b7f260cba51d1f0ad96302f3706d5e748f319efc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20c48ec343f725ce3c4a93b25604f931c6751138","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    [resource_plugin:os_nova_hypervisor]"},{"line_number":68,"context_line":"    enabled \u003d true"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    There are no notifications for hypervisor from nova yet, so we recommend"},{"line_number":73,"context_line":"    putting it to its own resource group and scheduling a cron job to re-sync"}],"source_content_type":"text/x-rst","patch_set":27,"id":"9ad45d7e_71baecc1","line":70,"updated":"2016-08-09 19:36:36.000000000","message":"See: https://review.openstack.org/#/c/334871/23..27/doc/source/plugins/nova.rst\n\nYou missed a rebase to master and overwrote some changes.","commit_id":"b7f260cba51d1f0ad96302f3706d5e748f319efc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20c48ec343f725ce3c4a93b25604f931c6751138","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    There are no notifications for flavor from nova yet, so we recommend"},{"line_number":86,"context_line":"    putting it in its own resource group and scheduling a cron job to re-sync"},{"line_number":87,"context_line":"    with little overhead."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Plugin: OS::Nova::SeverGroup"}],"source_content_type":"text/x-rst","patch_set":27,"id":"9ad45d7e_d1b118e3","line":87,"updated":"2016-08-09 19:36:36.000000000","message":"Missed rebase","commit_id":"b7f260cba51d1f0ad96302f3706d5e748f319efc"}],"etc/policy.json":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \"resource:OS::Glance::Image:allow\": \"\","},{"line_number":10,"context_line":"    \"resource:OS::Glance::Metadef:allow\": \"\","},{"line_number":11,"context_line":"    \"resource:OS::Nova::Server:allow\": \"\","},{"line_number":12,"context_line":"    \"resource:OS::Nova::ServerGroups:allow\": \"\","},{"line_number":13,"context_line":"    \"resource:OS::Nova::Hypervisor:allow\": \"role:admin\","},{"line_number":14,"context_line":"    \"resource:OS::Nova::Flavor:allow\": \"\","},{"line_number":15,"context_line":"    \"resource:OS::Cinder::Volume:allow\": \"\","}],"source_content_type":"application/json","patch_set":23,"id":"bacf61ea_9558bc8b","line":12,"updated":"2016-08-05 21:33:06.000000000","message":"Shouldn\u0027t this be \"OS::Nova::ServerGroup\"?","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c223aceb6ddfb55d19f4ed53e86a3bf2ad98bf2d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \"resource:OS::Glance::Image:allow\": \"\","},{"line_number":10,"context_line":"    \"resource:OS::Glance::Metadef:allow\": \"\","},{"line_number":11,"context_line":"    \"resource:OS::Nova::Server:allow\": \"\","},{"line_number":12,"context_line":"    \"resource:OS::Nova::ServerGroups:allow\": \"\","},{"line_number":13,"context_line":"    \"resource:OS::Nova::Hypervisor:allow\": \"role:admin\","},{"line_number":14,"context_line":"    \"resource:OS::Nova::Flavor:allow\": \"\","},{"line_number":15,"context_line":"    \"resource:OS::Cinder::Volume:allow\": \"\","}],"source_content_type":"application/json","patch_set":23,"id":"bacf61ea_978c20d8","line":12,"in_reply_to":"bacf61ea_9558bc8b","updated":"2016-08-08 04:00:50.000000000","message":"Done","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"}],"releasenotes/notes/add-server-groups-plugin-3dff1b85a3f716f5.yaml":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Adds nova plugin for server groups."},{"line_number":4,"context_line":"issues:"},{"line_number":5,"context_line":"  - There are no notifications for server groups from nova yet, so we recommend"},{"line_number":6,"context_line":"    putting it to its own resource group and scheduling a cron job to re-sync"},{"line_number":7,"context_line":"    with little overhead."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bacf61ea_f5e01828","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":17},"updated":"2016-08-05 21:33:06.000000000","message":"Nit: Should be \"in\".\n\nActually when you merge with his patch with Travis\u0027s \"plugin warning\" patch we should change this description to be\nconsistent. Travis added a new way of describing this issue.\n\nThere are no notifications for server groups from\nnova yet, so we recommend putting it in its own resource group and scheduling a cron job to periodically re-sync. This\nwill create a very low overhead way to keep the index up to \ndate. The index latency will be dependent on how often you\nre-sync the data.","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c223aceb6ddfb55d19f4ed53e86a3bf2ad98bf2d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Adds nova plugin for server groups."},{"line_number":4,"context_line":"issues:"},{"line_number":5,"context_line":"  - There are no notifications for server groups from nova yet, so we recommend"},{"line_number":6,"context_line":"    putting it to its own resource group and scheduling a cron job to re-sync"},{"line_number":7,"context_line":"    with little overhead."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bacf61ea_57ad882f","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":17},"in_reply_to":"bacf61ea_f5e01828","updated":"2016-08-08 04:00:50.000000000","message":"Done","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"}],"searchlight/common/resource_types.py":[{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"20389cc225a6be4535481549ab7ad2cb2569ef0e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"NEUTRON_SECURITY_GROUP \u003d \"OS::Neutron::SecurityGroup\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"NOVA_SERVER \u003d \"OS::Nova::Server\""},{"line_number":34,"context_line":"NOVA_SERVERGROUPS \u003d \"OS::Nova::ServerGroups\""},{"line_number":35,"context_line":"NOVA_HYPERVISOR \u003d \"OS::Nova::Hypervisor\""},{"line_number":36,"context_line":"NOVA_FLAVOR \u003d \"OS::Nova::Flavor\""},{"line_number":37,"context_line":"NOVA_AVAILABILITY_ZONE \u003d \"OS::Nova::AvailabilityZone\""}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_d2ea2f0e","line":34,"updated":"2016-07-13 16:25:03.000000000","message":"Should be NOVA_SERVER_GROUP \u003d \"OS::Nova::ServerGroup\", see http://docs.openstack.org/developer/heat/template_guide/openstack.html#OS::Nova::ServerGroup","commit_id":"f53a0044e55ce5157d2778a11c90d859eeb2efc1"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":31,"context_line":"NEUTRON_SECURITY_GROUP \u003d \"OS::Neutron::SecurityGroup\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"NOVA_SERVER \u003d \"OS::Nova::Server\""},{"line_number":34,"context_line":"NOVA_SERVERGROUPS \u003d \"OS::Nova::ServerGroups\""},{"line_number":35,"context_line":"NOVA_HYPERVISOR \u003d \"OS::Nova::Hypervisor\""},{"line_number":36,"context_line":"NOVA_FLAVOR \u003d \"OS::Nova::Flavor\""},{"line_number":37,"context_line":"NOVA_AVAILABILITY_ZONE \u003d \"OS::Nova::AvailabilityZone\""}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_75b70885","line":34,"updated":"2016-08-05 21:33:06.000000000","message":"Shouldn\u0027t this be \"OS::Nova::ServerGroup\"?","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c223aceb6ddfb55d19f4ed53e86a3bf2ad98bf2d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"NEUTRON_SECURITY_GROUP \u003d \"OS::Neutron::SecurityGroup\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"NOVA_SERVER \u003d \"OS::Nova::Server\""},{"line_number":34,"context_line":"NOVA_SERVERGROUPS \u003d \"OS::Nova::ServerGroups\""},{"line_number":35,"context_line":"NOVA_HYPERVISOR \u003d \"OS::Nova::Hypervisor\""},{"line_number":36,"context_line":"NOVA_FLAVOR \u003d \"OS::Nova::Flavor\""},{"line_number":37,"context_line":"NOVA_AVAILABILITY_ZONE \u003d \"OS::Nova::AvailabilityZone\""}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_f7647c22","line":34,"in_reply_to":"bacf61ea_75b70885","updated":"2016-08-08 04:00:50.000000000","message":"Done","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"}],"searchlight/elasticsearch/plugins/nova/__init__.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"def serialize_nova_servergroup(servergroup, updated_at\u003dNone):"},{"line_number":110,"context_line":"    serialized \u003d servergroup.to_dict()"},{"line_number":111,"context_line":"    serialized[\u0027updated_at\u0027] \u003d updated_at or utils.get_now_str()"},{"line_number":112,"context_line":"    return serialized"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_58015b04","line":111,"updated":"2016-08-05 21:33:06.000000000","message":"Is it guaranteed that the field \u0027updated_at\u0027 is never present?\n\nUsually when a plugin\u0027s serializer takes an \u0027updated_at\u0027 parameter, we verify that it is not already present in the payload before adding it.","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c223aceb6ddfb55d19f4ed53e86a3bf2ad98bf2d","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"def serialize_nova_servergroup(servergroup, updated_at\u003dNone):"},{"line_number":110,"context_line":"    serialized \u003d servergroup.to_dict()"},{"line_number":111,"context_line":"    serialized[\u0027updated_at\u0027] \u003d updated_at or utils.get_now_str()"},{"line_number":112,"context_line":"    return serialized"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_176e70ff","line":111,"in_reply_to":"bacf61ea_58015b04","updated":"2016-08-08 04:00:50.000000000","message":"Done","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"}],"searchlight/elasticsearch/plugins/nova/notification_handler.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"f3416c08b9d0be74b003986302e75d62653edd04","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        # TODO(): Currently there is no notification for flavor,"},{"line_number":316,"context_line":"        #            this needs to be changed once the notification for"},{"line_number":317,"context_line":"        #            flavor in nova is implemented:"},{"line_number":318,"context_line":"        return [\u0027nova\u0027]"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"class ServerGroupsHandler(base.NotificationBase):"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_ef9335a1","line":318,"range":{"start_line":318,"start_character":8,"end_line":318,"end_character":14},"updated":"2016-08-05 15:15:28.000000000","message":"Should this have gone in get_notification_exchanges? Maybe a copy of https://review.openstack.org/#/c/349427/. The ServerGroupsHandler will need this until we fix the underlying issue","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c223aceb6ddfb55d19f4ed53e86a3bf2ad98bf2d","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        # TODO(): Currently there is no notification for flavor,"},{"line_number":316,"context_line":"        #            this needs to be changed once the notification for"},{"line_number":317,"context_line":"        #            flavor in nova is implemented:"},{"line_number":318,"context_line":"        return [\u0027nova\u0027]"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"class ServerGroupsHandler(base.NotificationBase):"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_77608c01","line":318,"range":{"start_line":318,"start_character":8,"end_line":318,"end_character":14},"in_reply_to":"bacf61ea_58603ba5","updated":"2016-08-08 04:00:50.000000000","message":"Done","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        # TODO(): Currently there is no notification for flavor,"},{"line_number":316,"context_line":"        #            this needs to be changed once the notification for"},{"line_number":317,"context_line":"        #            flavor in nova is implemented:"},{"line_number":318,"context_line":"        return [\u0027nova\u0027]"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"class ServerGroupsHandler(base.NotificationBase):"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_58603ba5","line":318,"range":{"start_line":318,"start_character":8,"end_line":318,"end_character":14},"in_reply_to":"bacf61ea_ef9335a1","updated":"2016-08-05 21:33:06.000000000","message":"I\u0027m not sure why we are modifying flavor\u0027s get_event_handlers() in this patch. In any case it should be returning a dict and not a list.","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c223aceb6ddfb55d19f4ed53e86a3bf2ad98bf2d","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        # TODO(): Currently there is no notification for flavor,"},{"line_number":316,"context_line":"        #            this needs to be changed once the notification for"},{"line_number":317,"context_line":"        #            flavor in nova is implemented:"},{"line_number":318,"context_line":"        return [\u0027nova\u0027]"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"class ServerGroupsHandler(base.NotificationBase):"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_9751c032","line":318,"range":{"start_line":318,"start_character":8,"end_line":318,"end_character":14},"in_reply_to":"bacf61ea_ef9335a1","updated":"2016-08-08 04:00:50.000000000","message":"This must be a mistake","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        return [\u0027nova\u0027]"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"class ServerGroupsHandler(base.NotificationBase):"},{"line_number":322,"context_line":"    \"\"\"Handles nova server groups notifications."},{"line_number":323,"context_line":"    \"\"\""},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_f8448f47","line":321,"updated":"2016-08-05 21:33:06.000000000","message":"Should this be \"ServerGroupHandler\" to match the resource type?","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20c48ec343f725ce3c4a93b25604f931c6751138","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    _provisioning_states \u003d {\u0027networking\u0027: None,"},{"line_number":44,"context_line":"                            \u0027block_device_mapping\u0027: \u0027networking\u0027,"},{"line_number":45,"context_line":"                            \u0027spawning\u0027: \u0027block_device_mapping\u0027}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @classmethod"},{"line_number":48,"context_line":"    def _get_notification_exchanges(cls):"}],"source_content_type":"text/x-python","patch_set":27,"id":"9ad45d7e_31d8741d","line":45,"updated":"2016-08-09 19:36:36.000000000","message":"Missed rebase here and didn\u0027t pick up the patch which added additional notification states:\n\nhttps://review.openstack.org/#/c/334871/23..27/searchlight/elasticsearch/plugins/nova/notification_handler.py","commit_id":"b7f260cba51d1f0ad96302f3706d5e748f319efc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"20c48ec343f725ce3c4a93b25604f931c6751138","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @classmethod"},{"line_number":272,"context_line":"    def _get_notification_exchanges(cls):"},{"line_number":273,"context_line":"        return []"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def get_event_handlers(self):"},{"line_number":276,"context_line":"        # TODO(Kevin_Zheng): Currently there is no notification for"}],"source_content_type":"text/x-python","patch_set":27,"id":"9ad45d7e_1141f0a9","line":273,"updated":"2016-08-09 19:36:36.000000000","message":"This is going to need [\u0027nova\u0027] to work around the same issue as flavors:\n\nhttps://review.openstack.org/#/c/349427/","commit_id":"b7f260cba51d1f0ad96302f3706d5e748f319efc"}],"searchlight/elasticsearch/plugins/nova/servergroups.py":[{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"20389cc225a6be4535481549ab7ad2cb2569ef0e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \u0027policies\u0027: {"},{"line_number":45,"context_line":"                    \u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027"},{"line_number":46,"context_line":"                },"},{"line_number":47,"context_line":"                \u0027members\u0027: {"},{"line_number":48,"context_line":"                    \u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027"},{"line_number":49,"context_line":"                },"},{"line_number":50,"context_line":"                \u0027metadata\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_065599f8","line":47,"updated":"2016-07-13 16:25:03.000000000","message":"Does \u0027members\u0027 contain list of instance ids? If so, should include it in _meta.","commit_id":"f53a0044e55ce5157d2778a11c90d859eeb2efc1"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"5c985438a021116b93d36a5abdaba22f5b0a0ae2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \u0027policies\u0027: {"},{"line_number":45,"context_line":"                    \u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027"},{"line_number":46,"context_line":"                },"},{"line_number":47,"context_line":"                \u0027members\u0027: {"},{"line_number":48,"context_line":"                    \u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027"},{"line_number":49,"context_line":"                },"},{"line_number":50,"context_line":"                \u0027metadata\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_35406635","line":47,"in_reply_to":"1aa78d24_065599f8","updated":"2016-07-15 02:36:32.000000000","message":"Done","commit_id":"f53a0044e55ce5157d2778a11c90d859eeb2efc1"},{"author":{"_account_id":16150,"name":"Lei Zhang","email":"lei.a.zhang@intel.com","username":"leizhang"},"change_message_id":"20389cc225a6be4535481549ab7ad2cb2569ef0e","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @property"},{"line_number":74,"context_line":"    def facets_with_options(self):"},{"line_number":75,"context_line":"        return \u0027policies\u0027, \u0027name\u0027, \u0027id\u0027, \u0027members\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":78,"context_line":"        \"\"\"Return any RBAC field filters to be injected into an indices"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_68ff0c02","line":75,"updated":"2016-07-13 16:25:03.000000000","message":"I think only \u0027policies\u0027 needs to return options.","commit_id":"f53a0044e55ce5157d2778a11c90d859eeb2efc1"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"5c985438a021116b93d36a5abdaba22f5b0a0ae2","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @property"},{"line_number":74,"context_line":"    def facets_with_options(self):"},{"line_number":75,"context_line":"        return \u0027policies\u0027, \u0027name\u0027, \u0027id\u0027, \u0027members\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":78,"context_line":"        \"\"\"Return any RBAC field filters to be injected into an indices"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_d5580234","line":75,"in_reply_to":"1aa78d24_68ff0c02","updated":"2016-07-15 02:36:32.000000000","message":"Done","commit_id":"f53a0044e55ce5157d2778a11c90d859eeb2efc1"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d7e93246310c44b9d2d27517aa120d37fbe156ab","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                    \u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027"},{"line_number":46,"context_line":"                },"},{"line_number":47,"context_line":"                \u0027members\u0027: {"},{"line_number":48,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":49,"context_line":"                    \u0027index\u0027: \u0027not_analyzed\u0027,"},{"line_number":50,"context_line":"                    \u0027properties\u0027: {"},{"line_number":51,"context_line":"                        \u0027instance_uuid\u0027: {"}],"source_content_type":"text/x-python","patch_set":16,"id":"bacf61ea_4513c066","line":48,"range":{"start_line":48,"start_character":28,"end_line":48,"end_character":29},"updated":"2016-07-28 16:14:36.000000000","message":"This is illegal and causing the test failures - should be \"nested\" and remove \"index\"","commit_id":"729b2446c94f3e1e1ca8cfb7d631c1ee8d8e7814"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"67c542e5ca7085c91f5a8d754d500324eaa9fa2e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                    \u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027"},{"line_number":46,"context_line":"                },"},{"line_number":47,"context_line":"                \u0027members\u0027: {"},{"line_number":48,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":49,"context_line":"                    \u0027index\u0027: \u0027not_analyzed\u0027,"},{"line_number":50,"context_line":"                    \u0027properties\u0027: {"},{"line_number":51,"context_line":"                        \u0027instance_uuid\u0027: {"}],"source_content_type":"text/x-python","patch_set":16,"id":"bacf61ea_ecb0bc45","line":48,"range":{"start_line":48,"start_character":28,"end_line":48,"end_character":29},"in_reply_to":"bacf61ea_4513c066","updated":"2016-07-29 08:26:35.000000000","message":"Done","commit_id":"729b2446c94f3e1e1ca8cfb7d631c1ee8d8e7814"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d7e93246310c44b9d2d27517aa120d37fbe156ab","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027members\u0027: {"},{"line_number":48,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":49,"context_line":"                    \u0027index\u0027: \u0027not_analyzed\u0027,"},{"line_number":50,"context_line":"                    \u0027properties\u0027: {"},{"line_number":51,"context_line":"                        \u0027instance_uuid\u0027: {"},{"line_number":52,"context_line":"                            \u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027}"},{"line_number":53,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":16,"id":"bacf61ea_b730efe9","line":50,"range":{"start_line":50,"start_character":21,"end_line":50,"end_character":31},"updated":"2016-07-28 16:14:36.000000000","message":"Is it necessary to make this nested if it only has one field? It makes querying a bit more complex for little benefit. Fields can be multivalued without needing to be nested (e.g. you could set \"members\": [\"a\", \"b\"] while defining it as \"members\": {\"type\": \"string\"})","commit_id":"729b2446c94f3e1e1ca8cfb7d631c1ee8d8e7814"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"67c542e5ca7085c91f5a8d754d500324eaa9fa2e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027members\u0027: {"},{"line_number":48,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":49,"context_line":"                    \u0027index\u0027: \u0027not_analyzed\u0027,"},{"line_number":50,"context_line":"                    \u0027properties\u0027: {"},{"line_number":51,"context_line":"                        \u0027instance_uuid\u0027: {"},{"line_number":52,"context_line":"                            \u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027}"},{"line_number":53,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":16,"id":"bacf61ea_8ca940e2","line":50,"range":{"start_line":50,"start_character":21,"end_line":50,"end_character":31},"in_reply_to":"bacf61ea_b730efe9","updated":"2016-07-29 08:26:35.000000000","message":"Done","commit_id":"729b2446c94f3e1e1ca8cfb7d631c1ee8d8e7814"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d7e93246310c44b9d2d27517aa120d37fbe156ab","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                \u0027metadata\u0027: {"},{"line_number":56,"context_line":"                    \u0027type\u0027: \u0027nested\u0027,"},{"line_number":57,"context_line":"                    \u0027properties\u0027: {"},{"line_number":58,"context_line":"                        \u0027metadata\u0027: {"},{"line_number":59,"context_line":"                            \u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027"},{"line_number":60,"context_line":"                        }"},{"line_number":61,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":16,"id":"bacf61ea_576ff3c4","line":58,"range":{"start_line":58,"start_character":25,"end_line":58,"end_character":33},"updated":"2016-07-28 16:14:36.000000000","message":"Same here, not sure if it\u0027s worth nesting this","commit_id":"729b2446c94f3e1e1ca8cfb7d631c1ee8d8e7814"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"67c542e5ca7085c91f5a8d754d500324eaa9fa2e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                \u0027metadata\u0027: {"},{"line_number":56,"context_line":"                    \u0027type\u0027: \u0027nested\u0027,"},{"line_number":57,"context_line":"                    \u0027properties\u0027: {"},{"line_number":58,"context_line":"                        \u0027metadata\u0027: {"},{"line_number":59,"context_line":"                            \u0027type\u0027: \u0027string\u0027, \u0027index\u0027: \u0027not_analyzed\u0027"},{"line_number":60,"context_line":"                        }"},{"line_number":61,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":16,"id":"bacf61ea_aca6c40d","line":58,"range":{"start_line":58,"start_character":25,"end_line":58,"end_character":33},"in_reply_to":"bacf61ea_576ff3c4","updated":"2016-07-29 08:26:35.000000000","message":"Done","commit_id":"729b2446c94f3e1e1ca8cfb7d631c1ee8d8e7814"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @property"},{"line_number":58,"context_line":"    def admin_only_fields(self):"},{"line_number":59,"context_line":"        return []"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @property"},{"line_number":62,"context_line":"    def facets_with_options(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_ec2df18f","line":59,"updated":"2016-08-05 21:33:06.000000000","message":"This is \"covering\" up any admin only fields from the base class. If we do not have any admin_only fields in the plugin, we should not define this method. Instead we will let the admin_only_fields() method in the base class handle it.\n\nIf we do decide to define this admin_only_fields in the plugin, we need to combine it with the results of the base class:\n\n    ADMIN_ONLY \u003d [\u0027field1\u0027, \u0027field2\u0027]\n\n    def admin_only_fields(self):\n        base_fields \u003d super(ServerGroupsIndex, self).admin_only_fields\n        return ServerGroupsIndex.ADMIN_ONLY + base_fields","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c223aceb6ddfb55d19f4ed53e86a3bf2ad98bf2d","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @property"},{"line_number":58,"context_line":"    def admin_only_fields(self):"},{"line_number":59,"context_line":"        return []"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @property"},{"line_number":62,"context_line":"    def facets_with_options(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_17131066","line":59,"in_reply_to":"bacf61ea_ec2df18f","updated":"2016-08-08 04:00:50.000000000","message":"Thanks a lot for the information","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @property"},{"line_number":62,"context_line":"    def facets_with_options(self):"},{"line_number":63,"context_line":"        return \u0027policies\u0027"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":66,"context_line":"        \"\"\"Return any RBAC field filters to be injected into an indices"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_c1971646","line":63,"updated":"2016-08-05 21:33:06.000000000","message":"We need to return a tuple here. Especially since we take the output of facets_with_options and place it into a set.\n\nThis should be:\n    return (\u0027policies\u0027,)","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c223aceb6ddfb55d19f4ed53e86a3bf2ad98bf2d","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @property"},{"line_number":62,"context_line":"    def facets_with_options(self):"},{"line_number":63,"context_line":"        return \u0027policies\u0027"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_rbac_field_filters(self, request_context):"},{"line_number":66,"context_line":"        \"\"\"Return any RBAC field filters to be injected into an indices"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_2207f418","line":63,"in_reply_to":"bacf61ea_c1971646","updated":"2016-08-08 04:00:50.000000000","message":"Done","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        ]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def get_objects(self):"},{"line_number":74,"context_line":"        \"\"\"Generator that lists all nova hypervisors.\"\"\""},{"line_number":75,"context_line":"        return openstack_clients.get_novaclient("},{"line_number":76,"context_line":"        ).server_groups.list(all_projects\u003dTrue)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_7836df51","line":74,"range":{"start_line":74,"start_character":41,"end_line":74,"end_character":52},"updated":"2016-08-05 21:33:06.000000000","message":"Should be \"server groups.\"","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def get_objects(self):"},{"line_number":74,"context_line":"        \"\"\"Generator that lists all nova hypervisors.\"\"\""},{"line_number":75,"context_line":"        return openstack_clients.get_novaclient("},{"line_number":76,"context_line":"        ).server_groups.list(all_projects\u003dTrue)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def serialize(self, servergroup):"},{"line_number":79,"context_line":"        return serialize_nova_servergroup(servergroup)"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_81e6bead","line":76,"updated":"2016-08-05 21:33:06.000000000","message":"The method get_objects() needs to be a generator. It looks like server_groups.list() (which calls Manager._list()) is not a generator itself. We will need to add a \"yield\" here. Something like this:\n\nfor group in openstack_clients.get_novaclient().server_groups.list(all_projects\u003dTrue):\n    yield group","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"}],"searchlight/tests/functional/__init__.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"3030fbb42e801b4ed263bfc037f4b7dcd1426759","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            \u0027nova\u0027: {\u0027servers\u0027: \u0027ServerIndex\u0027,"},{"line_number":373,"context_line":"                     \u0027hypervisors\u0027: \u0027HypervisorIndex\u0027,"},{"line_number":374,"context_line":"                     \u0027flavors\u0027: \u0027FlavorIndex\u0027,"},{"line_number":375,"context_line":"                     \u0027servergroup\u0027: \u0027ServerGroupIndex\u0027},"},{"line_number":376,"context_line":"            \u0027cinder\u0027: {\u0027volumes\u0027: \u0027VolumeIndex\u0027, \u0027snapshots\u0027: \u0027SnapshotIndex\u0027},"},{"line_number":377,"context_line":"            \u0027neutron\u0027: {\u0027networks\u0027: \u0027NetworkIndex\u0027, \u0027ports\u0027: \u0027PortIndex\u0027,"},{"line_number":378,"context_line":"                        \u0027subnets\u0027: \u0027SubnetIndex\u0027, \u0027routers\u0027: \u0027RouterIndex\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"7ac969e8_40965295","line":375,"range":{"start_line":375,"start_character":22,"end_line":375,"end_character":33},"updated":"2016-08-13 00:00:31.000000000","message":"Should be \u0027servergroups\u0027 to match the file name.","commit_id":"587d464d56f4406a9d24d5bfcc0b0bab218f881a"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"3030fbb42e801b4ed263bfc037f4b7dcd1426759","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        plugins \u003d include_plugins or ("},{"line_number":389,"context_line":"            (\u0027glance\u0027, \u0027images\u0027), (\u0027glance\u0027, \u0027metadefs\u0027),"},{"line_number":390,"context_line":"            (\u0027nova\u0027, \u0027servers\u0027), (\u0027nova\u0027, \u0027hypervisors\u0027),"},{"line_number":391,"context_line":"            (\u0027nova\u0027, \u0027flavors\u0027), (\u0027nova\u0027, \u0027servergroup\u0027),"},{"line_number":392,"context_line":"            (\u0027cinder\u0027, \u0027volumes\u0027), (\u0027cinder\u0027, \u0027snapshots\u0027),"},{"line_number":393,"context_line":"            (\u0027neutron\u0027, \u0027networks\u0027), (\u0027neutron\u0027, \u0027ports\u0027),"},{"line_number":394,"context_line":"            (\u0027neutron\u0027, \u0027subnets\u0027), (\u0027neutron\u0027, \u0027routers\u0027),"}],"source_content_type":"text/x-python","patch_set":28,"id":"7ac969e8_c0e88219","line":391,"range":{"start_line":391,"start_character":43,"end_line":391,"end_character":54},"updated":"2016-08-13 00:00:31.000000000","message":"Should be \u0027servergroups\u0027 to match the file name.","commit_id":"587d464d56f4406a9d24d5bfcc0b0bab218f881a"}],"searchlight/tests/functional/test_nova_plugin.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.flavor_plugin \u003d self.initialized_plugins[\u0027OS::Nova::Flavor\u0027]"},{"line_number":36,"context_line":"        self.flavor_objects \u003d self._load_fixture_data(\u0027load/flavors.json\u0027)"},{"line_number":37,"context_line":"        self.server_groups_plugin \u003d \\"},{"line_number":38,"context_line":"            self.initialized_plugins[\u0027OS::Nova::ServerGroups\u0027]"},{"line_number":39,"context_line":"        self.server_groups_objects \u003d \\"},{"line_number":40,"context_line":"            self._load_fixture_data(\u0027load/server_groups.json\u0027)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_6c0d818e","line":38,"range":{"start_line":38,"start_character":48,"end_line":38,"end_character":60},"updated":"2016-08-05 21:33:06.000000000","message":"Should this be \"ServerGroup\"?","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"}],"searchlight/tests/unit/v1/test_search.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"77741f00cd828d9e3656705409d6d765b7d2c0ef","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            \u0027OS::Glance::Metadef\u0027,"},{"line_number":331,"context_line":"            \u0027OS::Nova::Flavor\u0027,"},{"line_number":332,"context_line":"            \u0027OS::Nova::Server\u0027,"},{"line_number":333,"context_line":"            \u0027OS::Nova::ServerGroups\u0027,"},{"line_number":334,"context_line":"            \u0027OS::Nova::Hypervisor\u0027,"},{"line_number":335,"context_line":"            \u0027OS::Neutron::FloatingIP\u0027,"},{"line_number":336,"context_line":"            \u0027OS::Neutron::Net\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_cc410dab","line":333,"updated":"2016-08-05 21:33:06.000000000","message":"Should this be \"OS::Nova::ServerGroup\"?","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c223aceb6ddfb55d19f4ed53e86a3bf2ad98bf2d","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            \u0027OS::Glance::Metadef\u0027,"},{"line_number":331,"context_line":"            \u0027OS::Nova::Flavor\u0027,"},{"line_number":332,"context_line":"            \u0027OS::Nova::Server\u0027,"},{"line_number":333,"context_line":"            \u0027OS::Nova::ServerGroups\u0027,"},{"line_number":334,"context_line":"            \u0027OS::Nova::Hypervisor\u0027,"},{"line_number":335,"context_line":"            \u0027OS::Neutron::FloatingIP\u0027,"},{"line_number":336,"context_line":"            \u0027OS::Neutron::Net\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_42aca8ec","line":333,"in_reply_to":"bacf61ea_cc410dab","updated":"2016-08-08 04:00:50.000000000","message":"Done","commit_id":"eddcf34f2e7831162ebb7bc2f756e1818984448c"}],"setup.cfg":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"3030fbb42e801b4ed263bfc037f4b7dcd1426759","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    os_glance_image \u003d searchlight.elasticsearch.plugins.glance.images:ImageIndex"},{"line_number":33,"context_line":"    os_glance_metadef \u003d searchlight.elasticsearch.plugins.glance.metadefs:MetadefIndex"},{"line_number":34,"context_line":"    os_nova_server \u003d searchlight.elasticsearch.plugins.nova.servers:ServerIndex"},{"line_number":35,"context_line":"    os_nova_servergroup \u003d searchlight.elasticsearch.plugins.nova.servergroup:ServerGroupIndex"},{"line_number":36,"context_line":"    os_nova_hypervisor \u003d searchlight.elasticsearch.plugins.nova.hypervisors:HypervisorIndex"},{"line_number":37,"context_line":"    os_neutron_floatingip \u003d searchlight.elasticsearch.plugins.neutron.floatingips:FloatingIPIndex"},{"line_number":38,"context_line":"    os_nova_flavor \u003d searchlight.elasticsearch.plugins.nova.flavors:FlavorIndex"}],"source_content_type":"text/x-ttcn-cfg","patch_set":28,"id":"7ac969e8_6069ce8b","line":35,"range":{"start_line":35,"start_character":65,"end_line":35,"end_character":76},"updated":"2016-08-13 00:00:31.000000000","message":"Should be \u0027servergroups\u0027 to match the file name.","commit_id":"587d464d56f4406a9d24d5bfcc0b0bab218f881a"}]}