)]}'
{"searchlight/common/utils.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"9702033c5abf91cab766fecd30cb12890da75a95","unresolved":false,"context_lines":[{"line_number":463,"context_line":"    for _type in types:"},{"line_number":464,"context_line":"        if _type.endswith(\u0027*\u0027):"},{"line_number":465,"context_line":"            matches \u003d []"},{"line_number":466,"context_line":"            for doc_type in document_types:"},{"line_number":467,"context_line":"                if doc_type.startswith(_type[:-1]):"},{"line_number":468,"context_line":"                    matches.append(doc_type)"},{"line_number":469,"context_line":"            if matches:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_f2bdba02","line":466,"range":{"start_line":466,"start_character":28,"end_line":466,"end_character":42},"updated":"2016-07-21 17:28:22.000000000","message":"I\u0027m seeing a failure when I specify multiple wildcard types.\n\nThis works:\n--type\u003dOS::Nova::*\n\nAs does this:\n--type\u003dOS::Cinder::*\n\nAnd this favorite also works:\n--type\u003dOS::Nova::Server,OS::Cinder::Volume\n\nBut this fails:\n--type\u003dOS::Nova::*,OS::Cinder::*\n\nIt looks like this iteration over document_types is the\nissue. The first time through the loop (for \nOS::Nova::Server*), we get all of the document_types.\nThe next time through the loop (for OS::Cinder::*) we do not\nget anything for document_types.\n\nI\u0027m assuming six.iteritems() is a generator and it cannot\niterate multiple times. Since we passed in\nsix.iteritems(plugins) as the parameter for document_types,\nwe only get one shot at the document_type list.","commit_id":"c9254f491303a3ce6c568ed6bf2a0a09ec0d8b96"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"5ed5f7bec2c6f11113b68e2c611d1af7499e1b32","unresolved":false,"context_lines":[{"line_number":463,"context_line":"    for _type in types:"},{"line_number":464,"context_line":"        if _type.endswith(\u0027*\u0027):"},{"line_number":465,"context_line":"            matches \u003d []"},{"line_number":466,"context_line":"            for doc_type in document_types:"},{"line_number":467,"context_line":"                if doc_type.startswith(_type[:-1]):"},{"line_number":468,"context_line":"                    matches.append(doc_type)"},{"line_number":469,"context_line":"            if matches:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_9ab3750a","line":466,"range":{"start_line":466,"start_character":28,"end_line":466,"end_character":42},"in_reply_to":"dada55a8_f2bdba02","updated":"2016-07-22 18:47:03.000000000","message":"Thanks. Replaced with viewkeys()","commit_id":"c9254f491303a3ce6c568ed6bf2a0a09ec0d8b96"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"18ab163bd76cc22579e8bb6231a5a4f417fd780e","unresolved":false,"context_lines":[{"line_number":462,"context_line":"    expanded_types \u003d []"},{"line_number":463,"context_line":"    for _type in types:"},{"line_number":464,"context_line":"        if _type.endswith(\u0027*\u0027):"},{"line_number":465,"context_line":"            matches \u003d []"},{"line_number":466,"context_line":"            for doc_type in document_types:"},{"line_number":467,"context_line":"                if doc_type.startswith(_type[:-1]):"},{"line_number":468,"context_line":"                    matches.append(doc_type)"},{"line_number":469,"context_line":"            if matches:"},{"line_number":470,"context_line":"                expanded_types.extend(matches)"},{"line_number":471,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_22b3adea","line":468,"range":{"start_line":465,"start_character":0,"end_line":468,"end_character":44},"updated":"2016-07-21 02:11:17.000000000","message":"Could merged into one line:\n\nmatches \u003d [doc_type for doc_type in document_types if doc_type.startswith(_type[:-1])]","commit_id":"c9254f491303a3ce6c568ed6bf2a0a09ec0d8b96"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"5ed5f7bec2c6f11113b68e2c611d1af7499e1b32","unresolved":false,"context_lines":[{"line_number":462,"context_line":"    expanded_types \u003d []"},{"line_number":463,"context_line":"    for _type in types:"},{"line_number":464,"context_line":"        if _type.endswith(\u0027*\u0027):"},{"line_number":465,"context_line":"            matches \u003d []"},{"line_number":466,"context_line":"            for doc_type in document_types:"},{"line_number":467,"context_line":"                if doc_type.startswith(_type[:-1]):"},{"line_number":468,"context_line":"                    matches.append(doc_type)"},{"line_number":469,"context_line":"            if matches:"},{"line_number":470,"context_line":"                expanded_types.extend(matches)"},{"line_number":471,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_7ab841e6","line":468,"range":{"start_line":465,"start_character":0,"end_line":468,"end_character":44},"in_reply_to":"dada55a8_22b3adea","updated":"2016-07-22 18:47:03.000000000","message":"Done","commit_id":"c9254f491303a3ce6c568ed6bf2a0a09ec0d8b96"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"18ab163bd76cc22579e8bb6231a5a4f417fd780e","unresolved":false,"context_lines":[{"line_number":470,"context_line":"                expanded_types.extend(matches)"},{"line_number":471,"context_line":"                continue"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        # If we got here, either wasn\u0027t a wildcard or didn\u0027t match anything"},{"line_number":474,"context_line":"        expanded_types.append(_type)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    return expanded_types"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_a2a5dd47","line":473,"updated":"2016-07-21 02:11:17.000000000","message":"wrong plugin end with \u0027*\u0027 will be returned here, imho it should return [] for this kind of  wrong plugin, so that we can provide more informative error message like \u0027xx::* doesn\u0027t match any registered plugins.\u0027  and reindex can be aborted right after there.","commit_id":"c9254f491303a3ce6c568ed6bf2a0a09ec0d8b96"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"5ed5f7bec2c6f11113b68e2c611d1af7499e1b32","unresolved":false,"context_lines":[{"line_number":470,"context_line":"                expanded_types.extend(matches)"},{"line_number":471,"context_line":"                continue"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        # If we got here, either wasn\u0027t a wildcard or didn\u0027t match anything"},{"line_number":474,"context_line":"        expanded_types.append(_type)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    return expanded_types"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_1aadc588","line":473,"in_reply_to":"dada55a8_a2a5dd47","updated":"2016-07-22 18:47:03.000000000","message":"It will get aborted because it\u0027s not recognized - \n\nsearchlight-manage --config-file etc/searchlight.conf index sync --type does-not-match-*\nSome index names or types do not have plugins registered. Index names: \u003cNone\u003e. Types: does-not-match-*\nAborting.","commit_id":"c9254f491303a3ce6c568ed6bf2a0a09ec0d8b96"}]}