)]}'
{"doc/source/plugins/nova.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fcdf00ed8733a2a9dc7718e651948fb6016378bc","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    resource_group_name \u003d searchlight"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Plugin: OS::Nova::Hypervisor"},{"line_number":64,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":65,"context_line":"::"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    [resource_plugin:os_nova_hypervisor]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_86cde988","line":64,"updated":"2016-08-02 21:19:54.000000000","message":"nit (or maybe not, not sure how strict the checking is): the heading indicator (^^^) should be the same length as the text","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"479873ac3cbe978a665d0894c3ae3345540dda62","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    resource_group_name \u003d searchlight"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Plugin: OS::Nova::Hypervisor"},{"line_number":64,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":65,"context_line":"::"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    [resource_plugin:os_nova_hypervisor]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_c204bcc7","line":64,"in_reply_to":"bacf61ea_86cde988","updated":"2016-08-03 17:14:42.000000000","message":"Done","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fcdf00ed8733a2a9dc7718e651948fb6016378bc","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    There are no notifications for hypervisors from nova yet, so we recommend"},{"line_number":73,"context_line":"    putting it in it\u0027s own resource group and scheduling a cron job to"},{"line_number":74,"context_line":"    periodically re-sync. This will create a very low overhead way to"},{"line_number":75,"context_line":"    keep the index up to date. The index latency will be dependent on how"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_e634a5fc","line":72,"range":{"start_line":72,"start_character":35,"end_line":72,"end_character":46},"updated":"2016-08-02 21:19:54.000000000","message":"What we\u0027re really talking about here are notifications from the computes.  I realize it\u0027s a bit late to make that point given the name of the plugin, but it would be good to mention that here.  Maybe something like \"There are no notifications from the compute nodes (\"hypervisors\") from nova yet, ...\"","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"479873ac3cbe978a665d0894c3ae3345540dda62","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    There are no notifications for hypervisors from nova yet, so we recommend"},{"line_number":73,"context_line":"    putting it in it\u0027s own resource group and scheduling a cron job to"},{"line_number":74,"context_line":"    periodically re-sync. This will create a very low overhead way to"},{"line_number":75,"context_line":"    keep the index up to date. The index latency will be dependent on how"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_c22afce6","line":72,"range":{"start_line":72,"start_character":35,"end_line":72,"end_character":46},"in_reply_to":"bacf61ea_e634a5fc","updated":"2016-08-03 17:14:42.000000000","message":"Done","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fcdf00ed8733a2a9dc7718e651948fb6016378bc","unresolved":false,"context_lines":[{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    There are no notifications for hypervisors from nova yet, so we recommend"},{"line_number":73,"context_line":"    putting it in it\u0027s own resource group and scheduling a cron job to"},{"line_number":74,"context_line":"    periodically re-sync. This will create a very low overhead way to"},{"line_number":75,"context_line":"    keep the index up to date. The index latency will be dependent on how"},{"line_number":76,"context_line":"    often you re-sync the data."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_460e51e6","line":73,"range":{"start_line":73,"start_character":18,"end_line":73,"end_character":22},"updated":"2016-08-02 21:19:54.000000000","message":"s/it\u0027s/its/","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"479873ac3cbe978a665d0894c3ae3345540dda62","unresolved":false,"context_lines":[{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    There are no notifications for hypervisors from nova yet, so we recommend"},{"line_number":73,"context_line":"    putting it in it\u0027s own resource group and scheduling a cron job to"},{"line_number":74,"context_line":"    periodically re-sync. This will create a very low overhead way to"},{"line_number":75,"context_line":"    keep the index up to date. The index latency will be dependent on how"},{"line_number":76,"context_line":"    often you re-sync the data."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_02353445","line":73,"range":{"start_line":73,"start_character":18,"end_line":73,"end_character":22},"in_reply_to":"bacf61ea_460e51e6","updated":"2016-08-03 17:14:42.000000000","message":"Done","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fcdf00ed8733a2a9dc7718e651948fb6016378bc","unresolved":false,"context_lines":[{"line_number":85,"context_line":".. note::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    There are no notifications for flavors from nova yet, so we recommend"},{"line_number":88,"context_line":"    putting it in it\u0027s own resource group and scheduling a cron job to"},{"line_number":89,"context_line":"    periodically re-sync. This will create a very low overhead way to"},{"line_number":90,"context_line":"    keep the index up to date. The index latency will be dependent on how"},{"line_number":91,"context_line":"    often you re-sync the data."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_861fa908","line":88,"range":{"start_line":88,"start_character":18,"end_line":88,"end_character":22},"updated":"2016-08-02 21:19:54.000000000","message":"s/it\u0027s/its/","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"592583b705be0ab34c59f5532ad7488361c16aae","unresolved":false,"context_lines":[{"line_number":85,"context_line":".. note::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    There are no notifications for flavors from nova yet, so we recommend"},{"line_number":88,"context_line":"    putting it in it\u0027s own resource group and scheduling a cron job to"},{"line_number":89,"context_line":"    periodically re-sync. This will create a very low overhead way to"},{"line_number":90,"context_line":"    keep the index up to date. The index latency will be dependent on how"},{"line_number":91,"context_line":"    often you re-sync the data."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_a1cee980","line":88,"range":{"start_line":88,"start_character":18,"end_line":88,"end_character":22},"in_reply_to":"bacf61ea_861fa908","updated":"2016-08-03 16:02:23.000000000","message":"Travis - where did you go to school, man?! I shall be over there with my Latin textbooks directly.","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"479873ac3cbe978a665d0894c3ae3345540dda62","unresolved":false,"context_lines":[{"line_number":85,"context_line":".. note::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    There are no notifications for flavors from nova yet, so we recommend"},{"line_number":88,"context_line":"    putting it in it\u0027s own resource group and scheduling a cron job to"},{"line_number":89,"context_line":"    periodically re-sync. This will create a very low overhead way to"},{"line_number":90,"context_line":"    keep the index up to date. The index latency will be dependent on how"},{"line_number":91,"context_line":"    often you re-sync the data."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_62e07097","line":88,"range":{"start_line":88,"start_character":18,"end_line":88,"end_character":22},"in_reply_to":"bacf61ea_a1cee980","updated":"2016-08-03 17:14:42.000000000","message":"I don\u0027t have time for such nonsense. Haven\u0027t you ever communicated with me in IRC? I think my demonstration of grammar in IRC should have taught you that I have no skills when it comes to written language.","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"}],"searchlight/cmd/manage.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"e2cc2d6d3167b5d684caca22313942464f0af135","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            # get_index_display_name(). Therefore any child plugins in the"},{"line_number":261,"context_line":"            # display list, will be listed twice."},{"line_number":262,"context_line":"            display_plugins \u003d []"},{"line_number":263,"context_line":"            no_notification_plugins \u003d []"},{"line_number":264,"context_line":"            for res, ext in plugins_list:"},{"line_number":265,"context_line":"                if not ext.obj.parent_plugin:"},{"line_number":266,"context_line":"                    display_plugins.append((res, ext))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_69253309","line":263,"updated":"2016-08-02 17:21:30.000000000","message":"It seems like this is left over from some previous version of the code. We do not use this list of no_notification_plugins. It is currently used as a boolean, so let\u0027s turn it into a straight boolean value.","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"592583b705be0ab34c59f5532ad7488361c16aae","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            # get_index_display_name(). Therefore any child plugins in the"},{"line_number":261,"context_line":"            # display list, will be listed twice."},{"line_number":262,"context_line":"            display_plugins \u003d []"},{"line_number":263,"context_line":"            no_notification_plugins \u003d []"},{"line_number":264,"context_line":"            for res, ext in plugins_list:"},{"line_number":265,"context_line":"                if not ext.obj.parent_plugin:"},{"line_number":266,"context_line":"                    display_plugins.append((res, ext))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_813ac532","line":263,"in_reply_to":"bacf61ea_69253309","updated":"2016-08-03 16:02:23.000000000","message":"I imagine this was previously used as a summary output line. Agree it can be a boolean","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"479873ac3cbe978a665d0894c3ae3345540dda62","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            # get_index_display_name(). Therefore any child plugins in the"},{"line_number":261,"context_line":"            # display list, will be listed twice."},{"line_number":262,"context_line":"            display_plugins \u003d []"},{"line_number":263,"context_line":"            no_notification_plugins \u003d []"},{"line_number":264,"context_line":"            for res, ext in plugins_list:"},{"line_number":265,"context_line":"                if not ext.obj.parent_plugin:"},{"line_number":266,"context_line":"                    display_plugins.append((res, ext))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_026d3404","line":263,"in_reply_to":"bacf61ea_813ac532","updated":"2016-08-03 17:14:42.000000000","message":"No, I did this because of the variable scoping with the multiple nested functions where this actually gets calculated. Using a list rather than globals seemed simpler.","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"e2cc2d6d3167b5d684caca22313942464f0af135","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                    if plugin_doc_type in es_reindex:"},{"line_number":278,"context_line":"                        display +\u003d \u0027 *\u0027"},{"line_number":279,"context_line":"                    if not event_list:"},{"line_number":280,"context_line":"                        display +\u003d \u0027 !!\u0027"},{"line_number":281,"context_line":"                        no_notification_plugins.append(plugin)"},{"line_number":282,"context_line":"                    return display + \u0027\u0027.join(_format_plugin(c, indent + 1)"},{"line_number":283,"context_line":"                                             for c in plugin.child_plugins)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_d4ecb22b","line":280,"updated":"2016-08-02 17:21:30.000000000","message":"Maybe not for this patch, but the output is starting to get confusing. We now have three different characteristics of plugins being communicated on each line.\n\n    An indented \"--\u003e\" to show a plugin parent/child relationship.\n    A \u0027*\" to show plugins being re-indexed from ElasticSearch.\n    A \u0027!!\u0027 to show plugins that need to be refreshed explicitly.\n\nPlus the explanations of these different meanings are scattered in different places in the parts of the out, i.e. some before the plugin listing, some after the plugin listing.","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"479873ac3cbe978a665d0894c3ae3345540dda62","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                    if plugin_doc_type in es_reindex:"},{"line_number":278,"context_line":"                        display +\u003d \u0027 *\u0027"},{"line_number":279,"context_line":"                    if not event_list:"},{"line_number":280,"context_line":"                        display +\u003d \u0027 !!\u0027"},{"line_number":281,"context_line":"                        no_notification_plugins.append(plugin)"},{"line_number":282,"context_line":"                    return display + \u0027\u0027.join(_format_plugin(c, indent + 1)"},{"line_number":283,"context_line":"                                             for c in plugin.child_plugins)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e884410c","line":280,"in_reply_to":"bacf61ea_d4ecb22b","updated":"2016-08-03 17:14:42.000000000","message":"Agreed, better to put the * and !! notes together. I\u0027ve moved them to the end.\n\nThe --\u003e doesn\u0027t seem to be weird to me.","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"e2cc2d6d3167b5d684caca22313942464f0af135","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                        display +\u003d \u0027 *\u0027"},{"line_number":279,"context_line":"                    if not event_list:"},{"line_number":280,"context_line":"                        display +\u003d \u0027 !!\u0027"},{"line_number":281,"context_line":"                        no_notification_plugins.append(plugin)"},{"line_number":282,"context_line":"                    return display + \u0027\u0027.join(_format_plugin(c, indent + 1)"},{"line_number":283,"context_line":"                                             for c in plugin.child_plugins)"},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_29821bc9","line":281,"updated":"2016-08-02 17:21:30.000000000","message":"Set the boolean to True.","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"479873ac3cbe978a665d0894c3ae3345540dda62","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                        display +\u003d \u0027 *\u0027"},{"line_number":279,"context_line":"                    if not event_list:"},{"line_number":280,"context_line":"                        display +\u003d \u0027 !!\u0027"},{"line_number":281,"context_line":"                        no_notification_plugins.append(plugin)"},{"line_number":282,"context_line":"                    return display + \u0027\u0027.join(_format_plugin(c, indent + 1)"},{"line_number":283,"context_line":"                                             for c in plugin.child_plugins)"},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_8876653c","line":281,"in_reply_to":"bacf61ea_29821bc9","updated":"2016-08-03 17:14:42.000000000","message":"See above. Without globals this would be assigning a new variable locally scoped and not affect the one above.","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"e2cc2d6d3167b5d684caca22313942464f0af135","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            if no_notification_plugins:"},{"line_number":298,"context_line":"                print(\"Any types marked with !! do not support listener based \""},{"line_number":299,"context_line":"                      \"updates and must be periodically re-indexed or \""},{"line_number":300,"context_line":"                      \"should be disabled.\\n\")"},{"line_number":301,"context_line":"            ans \u003d six.moves.input("},{"line_number":302,"context_line":"                \"\\nUse \u0027--force\u0027 to suppress this message.\\n\""},{"line_number":303,"context_line":"                \"OK to continue? [y/n]: \")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_89e1879d","line":300,"updated":"2016-08-02 17:21:30.000000000","message":"While we are making changes, it would be nice to break this line up into two lines. Being a single, long line, it wraps in almost all windows that an admin would use. This makes it hard to read.","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"592583b705be0ab34c59f5532ad7488361c16aae","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            if no_notification_plugins:"},{"line_number":298,"context_line":"                print(\"Any types marked with !! do not support listener based \""},{"line_number":299,"context_line":"                      \"updates and must be periodically re-indexed or \""},{"line_number":300,"context_line":"                      \"should be disabled.\\n\")"},{"line_number":301,"context_line":"            ans \u003d six.moves.input("},{"line_number":302,"context_line":"                \"\\nUse \u0027--force\u0027 to suppress this message.\\n\""},{"line_number":303,"context_line":"                \"OK to continue? [y/n]: \")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_c1a83d7a","line":300,"in_reply_to":"bacf61ea_89e1879d","updated":"2016-08-03 16:02:23.000000000","message":"Yeah, agree with breaking it up and maybe move above the previous line so it\u0027s directly underneath the \u0027types marked with *\u0027","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"479873ac3cbe978a665d0894c3ae3345540dda62","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            if no_notification_plugins:"},{"line_number":298,"context_line":"                print(\"Any types marked with !! do not support listener based \""},{"line_number":299,"context_line":"                      \"updates and must be periodically re-indexed or \""},{"line_number":300,"context_line":"                      \"should be disabled.\\n\")"},{"line_number":301,"context_line":"            ans \u003d six.moves.input("},{"line_number":302,"context_line":"                \"\\nUse \u0027--force\u0027 to suppress this message.\\n\""},{"line_number":303,"context_line":"                \"OK to continue? [y/n]: \")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_08e715e5","line":300,"in_reply_to":"bacf61ea_c1a83d7a","updated":"2016-08-03 17:14:42.000000000","message":"Done.  Both the lines are less the 80 chars now.","commit_id":"ea6d7f32389b91861c1cd50460cbb5d88c27e861"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"ae7912a8b162849381080d7ffaff0e6baa3d20e3","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            # get_index_display_name(). Therefore any child plugins in the"},{"line_number":261,"context_line":"            # display list, will be listed twice."},{"line_number":262,"context_line":"            display_plugins \u003d []"},{"line_number":263,"context_line":"            plugins_without_notifications \u003d []"},{"line_number":264,"context_line":"            for res, ext in plugins_list:"},{"line_number":265,"context_line":"                if not ext.obj.parent_plugin:"},{"line_number":266,"context_line":"                    display_plugins.append((res, ext))"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_bf0716c8","line":263,"updated":"2016-08-03 20:09:07.000000000","message":"I\u0027m confused about needing a global. The scope seems the same. When I switched it over to a boolean it worked. But if this works it works. Let\u0027s not focus too much on how this sausage is made!","commit_id":"3fd15c8c471a83002e36856d41681c621c80c4b7"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a2bc2cf9563924556775cfb1676738188f1dcc1e","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            # get_index_display_name(). Therefore any child plugins in the"},{"line_number":261,"context_line":"            # display list, will be listed twice."},{"line_number":262,"context_line":"            display_plugins \u003d []"},{"line_number":263,"context_line":"            plugins_without_notifications \u003d []"},{"line_number":264,"context_line":"            for res, ext in plugins_list:"},{"line_number":265,"context_line":"                if not ext.obj.parent_plugin:"},{"line_number":266,"context_line":"                    display_plugins.append((res, ext))"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_7f72be12","line":263,"in_reply_to":"bacf61ea_bf0716c8","updated":"2016-08-03 20:14:33.000000000","message":"pycharms created a bunch of warnings about scope shadowing for me... dunno. this isn\u0027t too big a deal.","commit_id":"3fd15c8c471a83002e36856d41681c621c80c4b7"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"3a0db29f6a5c78c69220e453d5e661b6ce65022f","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                print(\"Any types marked with !! do not support incremental \""},{"line_number":300,"context_line":"                      \"updates via the listener.\")"},{"line_number":301,"context_line":"                print(\"These types must be fully re-indexed periodically or \""},{"line_number":302,"context_line":"                      \"should be disabled.\\n\")"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"            ans \u003d six.moves.input("},{"line_number":305,"context_line":"                \"\\nUse \u0027--force\u0027 to suppress this message.\\n\""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_a8c9a927","line":302,"updated":"2016-08-03 17:19:16.000000000","message":"Note, I can switch this to be a larger concatenated string with \\n. Just thought it was easy to read each line being printed this way. Whatever you guys would prefer.","commit_id":"3fd15c8c471a83002e36856d41681c621c80c4b7"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"ae7912a8b162849381080d7ffaff0e6baa3d20e3","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                print(\"Any types marked with !! do not support incremental \""},{"line_number":300,"context_line":"                      \"updates via the listener.\")"},{"line_number":301,"context_line":"                print(\"These types must be fully re-indexed periodically or \""},{"line_number":302,"context_line":"                      \"should be disabled.\\n\")"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"            ans \u003d six.moves.input("},{"line_number":305,"context_line":"                \"\\nUse \u0027--force\u0027 to suppress this message.\\n\""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_49d62cc4","line":302,"in_reply_to":"bacf61ea_a8c9a927","updated":"2016-08-03 20:09:07.000000000","message":"Separate thoughts on separate lines. Good use of white space!","commit_id":"3fd15c8c471a83002e36856d41681c621c80c4b7"}]}