)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"3fcbe9fd292b3c3370c04d9ebadc9da252b90f68","unresolved":false,"context_lines":[{"line_number":215,"context_line":"###############"},{"line_number":216,"context_line":"# ELASTICSEARCH"},{"line_number":217,"context_line":"# Moving this here because the devstack team has determined that only"},{"line_number":218,"context_line":"# services supporting devstack core projects should live in devstack"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"function _wget_elasticsearch {"},{"line_number":221,"context_line":"    local file\u003d${1}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9ad45d7e_95c3d5ec","line":218,"updated":"2016-08-10 16:42:00.000000000","message":"The previous script \"pkg/elasticsearch\" would log the command being run.\n\n    Phase is download\n    Phase is install\n\nDid anyone (i.e. deployers) care or use these log messages? I don\u0027t think it\u0027s important, but I do not know how deployers use the logging messages. Just want to make sure we are not overlooking something.","commit_id":"dd104cda1ba898d457631cc06e0d7aa666678a0b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"95e49d1f6646246d1feea85dad37cb78110587ed","unresolved":false,"context_lines":[{"line_number":215,"context_line":"###############"},{"line_number":216,"context_line":"# ELASTICSEARCH"},{"line_number":217,"context_line":"# Moving this here because the devstack team has determined that only"},{"line_number":218,"context_line":"# services supporting devstack core projects should live in devstack"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"function _wget_elasticsearch {"},{"line_number":221,"context_line":"    local file\u003d${1}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9ad45d7e_979e0205","line":218,"in_reply_to":"9ad45d7e_95c3d5ec","updated":"2016-08-11 14:55:42.000000000","message":"Anyone doing production deployments with devstack is taking things into their own hands. There are also no deployers of searchlight at present","commit_id":"dd104cda1ba898d457631cc06e0d7aa666678a0b"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"3fcbe9fd292b3c3370c04d9ebadc9da252b90f68","unresolved":false,"context_lines":[{"line_number":220,"context_line":"function _wget_elasticsearch {"},{"line_number":221,"context_line":"    local file\u003d${1}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    if [ ! -f ${FILES}/${file} ]; then"},{"line_number":224,"context_line":"        wget $ELASTICSEARCH_BASEURL/${file} -O ${FILES}/${file}"},{"line_number":225,"context_line":"    fi"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9ad45d7e_759e2164","line":223,"range":{"start_line":223,"start_character":14,"end_line":223,"end_character":22},"updated":"2016-08-10 16:42:00.000000000","message":"Where is FILES being set? Does the script that calls plugin.sh export it? The previous script explicitly set it.","commit_id":"dd104cda1ba898d457631cc06e0d7aa666678a0b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"95e49d1f6646246d1feea85dad37cb78110587ed","unresolved":false,"context_lines":[{"line_number":220,"context_line":"function _wget_elasticsearch {"},{"line_number":221,"context_line":"    local file\u003d${1}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    if [ ! -f ${FILES}/${file} ]; then"},{"line_number":224,"context_line":"        wget $ELASTICSEARCH_BASEURL/${file} -O ${FILES}/${file}"},{"line_number":225,"context_line":"    fi"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9ad45d7e_d7debadb","line":223,"range":{"start_line":223,"start_character":14,"end_line":223,"end_character":22},"in_reply_to":"9ad45d7e_759e2164","updated":"2016-08-11 14:55:42.000000000","message":"By stack.sh. This script is only intended to run through devstack\u0027s plugin interface, not standalone. By default it\u0027ll be /path/to/devstack/files","commit_id":"dd104cda1ba898d457631cc06e0d7aa666678a0b"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"3fcbe9fd292b3c3370c04d9ebadc9da252b90f68","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    if is_ubuntu; then"},{"line_number":247,"context_line":"        _wget_elasticsearch elasticsearch-${ELASTICSEARCH_VERSION}.deb"},{"line_number":248,"context_line":"    elif is_fedora; then"},{"line_number":249,"context_line":"        _wget_elasticsearch elasticsearch-${ELASTICSEARCH_VERSION}.noarch.rpm"},{"line_number":250,"context_line":"    fi"},{"line_number":251,"context_line":"}"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9ad45d7e_d5b9cd7a","line":249,"range":{"start_line":249,"start_character":67,"end_line":249,"end_character":73},"updated":"2016-08-10 16:42:00.000000000","message":"This file extension no longer exists. For Elasticsearch 2.3.4, the extension should be only \".rpm\".\n\n        elasticsearch-2.3.4.rpm\n\nAnother breakage between 1.7.X and 2.3.X Elasticsearch!","commit_id":"dd104cda1ba898d457631cc06e0d7aa666678a0b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"95e49d1f6646246d1feea85dad37cb78110587ed","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    if is_ubuntu; then"},{"line_number":247,"context_line":"        _wget_elasticsearch elasticsearch-${ELASTICSEARCH_VERSION}.deb"},{"line_number":248,"context_line":"    elif is_fedora; then"},{"line_number":249,"context_line":"        _wget_elasticsearch elasticsearch-${ELASTICSEARCH_VERSION}.noarch.rpm"},{"line_number":250,"context_line":"    fi"},{"line_number":251,"context_line":"}"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9ad45d7e_f78dbed3","line":249,"range":{"start_line":249,"start_character":67,"end_line":249,"end_character":73},"in_reply_to":"9ad45d7e_d5b9cd7a","updated":"2016-08-11 14:55:42.000000000","message":"Thanks, will fix","commit_id":"dd104cda1ba898d457631cc06e0d7aa666678a0b"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"138de68d00baa0ed08db4b30a6406bcc4453ac84","unresolved":false,"context_lines":[{"line_number":42,"context_line":"SEARCHLIGHT_SERVICE_PORT_INT\u003d${SEARCHLIGHT_SERVICE_PORT_INT:-19393}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"ELASTICSEARCH_VERSION\u003d${ELASTICSEARCH_VERSION:-2.3.4}"},{"line_number":45,"context_line":"ELASTICSEARCH_BASEURL\u003d${ELASTICSEARCH_BASEURL:-https://download.elastic.co/elasticsearch/release/org/elasticsearch/distribution/}"},{"line_number":46,"context_line":"ELASTICSEARCH_BASEURL_DEB\u003d${ELASTICSEARCH_BASEURL}/deb/elasticsearch"},{"line_number":47,"context_line":"ELASTICSEARCH_BASEURL_RPM\u003d${ELASTICSEARCH_BASEURL}/rpm/elasticsearch"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7ac969e8_0fc12d81","line":45,"updated":"2016-08-12 22:43:49.000000000","message":"I\u0027m seeing a 403 forbidden error when downloading the package. The issue appears to be the ending \u0027/\u0027 on ELASTICSEARCH_BASEURL. The current value causes us to try to download the deb package from:\n\nhttps://download.elastic.co/elasticsearch/release/org/elasticsearch/distribution//deb/elasticsearch/elasticsearch/2.3.4/elasticsearch-2.3.4.deb\n\nNotice the double \"//\" after distribution. This causes the wget to fail with the aforementioned 403. Removing the \u0027/\u0027 from the end ELASTICSEARCH_BASEURL results in a successful wget.","commit_id":"057ee8475458741c851e56a1f7a1fc95eea9fb16"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"e96632ebba0740c6dac01ea2bf427a3a2e40fd39","unresolved":false,"context_lines":[{"line_number":42,"context_line":"SEARCHLIGHT_SERVICE_PORT_INT\u003d${SEARCHLIGHT_SERVICE_PORT_INT:-19393}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"ELASTICSEARCH_VERSION\u003d${ELASTICSEARCH_VERSION:-2.3.4}"},{"line_number":45,"context_line":"ELASTICSEARCH_BASEURL\u003d${ELASTICSEARCH_BASEURL:-https://download.elastic.co/elasticsearch/release/org/elasticsearch/distribution/}"},{"line_number":46,"context_line":"ELASTICSEARCH_BASEURL_DEB\u003d${ELASTICSEARCH_BASEURL}/deb/elasticsearch"},{"line_number":47,"context_line":"ELASTICSEARCH_BASEURL_RPM\u003d${ELASTICSEARCH_BASEURL}/rpm/elasticsearch"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3ac371cc_a5261514","line":45,"in_reply_to":"7ac969e8_0fc12d81","updated":"2016-08-15 15:11:53.000000000","message":"Oops, thanks. Though i think your example has an extra /elasticsearch near the end that isn\u0027t there. The double slashes are a problem; will fix.","commit_id":"057ee8475458741c851e56a1f7a1fc95eea9fb16"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"632f5642602861e9f73d53943422399dcbecee93","unresolved":false,"context_lines":[{"line_number":286,"context_line":"function _install_elasticsearch {"},{"line_number":287,"context_line":"    echo \"Installing elasticsearch\""},{"line_number":288,"context_line":"    pip_install_gr elasticsearch"},{"line_number":289,"context_line":"    if is_package_installed elasticsearch; then"},{"line_number":290,"context_line":"        echo \"Note: elasticsearch was already installed.\""},{"line_number":291,"context_line":"        return"},{"line_number":292,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3ac371cc_29dc3e72","line":289,"updated":"2016-08-17 15:59:37.000000000","message":"This will not allow us to update an existing ES1.7.5 to ES2.3.4 (or any other version update). The is_package_installed() function is making a call to \"pkg -s elasticsearch\". This will only verify the existence of Elasticsearch. If the older version of exists, we do stop and do not continue with installing the proper version of ES.\n\nIt seems this check needs to be a bit more complicated.\n\nIf this version of ES exist (dpkg -s elasticsearch | grep Version)\n    do nothing\nElse\n    If any version of ES exists (dpkg -s elasticsearch)\n        Uninstall ES\n    Install ES 2.3.4\nFi","commit_id":"26e73debb1bad5091d128a22542448288ce75665"}]}