)]}'
{"doc/source/authentication.rst":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"d9106b00f4b5a0290815e856124bedfdac2084f9","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":" # If set, will create a mapping field for region_name"},{"line_number":104,"context_line":" # os_region_name \u003d"},{"line_number":105,"context_line":" "},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Service integration account"},{"line_number":108,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_978fef73","line":105,"updated":"2016-08-30 18:10:44.000000000","message":"Nit: Remove the space at the beginning of the line.","commit_id":"87683d71fd8630d9d6d7b30ce3c069bda6c80a10"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"f164c04bf6ba54edfbc2e30f36961daffbfeb5e6","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":" # If set, will create a mapping field for region_name"},{"line_number":104,"context_line":" # os_region_name \u003d"},{"line_number":105,"context_line":" "},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Service integration account"},{"line_number":108,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_02246aad","line":105,"in_reply_to":"fa7ab95a_978fef73","updated":"2016-08-30 22:51:01.000000000","message":"Done","commit_id":"87683d71fd8630d9d6d7b30ce3c069bda6c80a10"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"1bfc578947112b874178662d2aa44879541420a4","unresolved":false,"context_lines":[{"line_number":100,"context_line":" tenant_name \u003d service"},{"line_number":101,"context_line":" auth_url \u003d http://127.0.0.1:35357"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":" # If set, will create a mapping field for region_name"},{"line_number":104,"context_line":" # os_region_name \u003d"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_9b08b593","line":103,"updated":"2016-08-31 16:11:22.000000000","message":"This comment is kind of confusing.  It should say that it also requires setting the include_region_name \u003d True in resource_plugin","commit_id":"acdb16f0cea7f6b01e521df1c24e7a264a39ea4d"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"224422c5c9bee1fd5864d5dac2e6fc4d7d47c175","unresolved":false,"context_lines":[{"line_number":100,"context_line":" tenant_name \u003d service"},{"line_number":101,"context_line":" auth_url \u003d http://127.0.0.1:35357"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":" # If set, will create a mapping field for region_name"},{"line_number":104,"context_line":" # os_region_name \u003d"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_6c5fb275","line":103,"in_reply_to":"fa7ab95a_9b08b593","updated":"2016-08-31 17:29:21.000000000","message":"Done","commit_id":"acdb16f0cea7f6b01e521df1c24e7a264a39ea4d"}],"doc/source/plugins.rst":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"d9106b00f4b5a0290815e856124bedfdac2084f9","unresolved":false,"context_lines":[{"line_number":280,"context_line":"|                     |               | Useful for multi-region deployments |                           |"},{"line_number":281,"context_line":"|                     |               | where a service is shared between   |                           |"},{"line_number":282,"context_line":"|                     |               | regions.                            |                           |"},{"line_number":283,"context_line":"+---------------------+---------------+-------------------------------------+---------------------------+"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":".. _individual-plugin-configuration:"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_57eac7db","line":283,"updated":"2016-08-30 18:10:44.000000000","message":"We need to add \"Restart services\" as the action required for this option.","commit_id":"87683d71fd8630d9d6d7b30ce3c069bda6c80a10"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"f164c04bf6ba54edfbc2e30f36961daffbfeb5e6","unresolved":false,"context_lines":[{"line_number":280,"context_line":"|                     |               | Useful for multi-region deployments |                           |"},{"line_number":281,"context_line":"|                     |               | where a service is shared between   |                           |"},{"line_number":282,"context_line":"|                     |               | regions.                            |                           |"},{"line_number":283,"context_line":"+---------------------+---------------+-------------------------------------+---------------------------+"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":".. _individual-plugin-configuration:"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_a24bbe5e","line":283,"in_reply_to":"fa7ab95a_57eac7db","updated":"2016-08-30 22:51:01.000000000","message":"Done","commit_id":"87683d71fd8630d9d6d7b30ce3c069bda6c80a10"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"1bfc578947112b874178662d2aa44879541420a4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    enabled \u003d True"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    [resource_plugin:os_glance_image]"},{"line_number":92,"context_line":"    enabled \u003d True"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    [resource_plugin:os_glance_metadef]"},{"line_number":95,"context_line":"    enabled \u003d True"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_7bc69117","line":92,"updated":"2016-08-31 16:11:22.000000000","message":"I think it would be good to add a commented out version of what override_region_name would look like for glance in a multiregion setup.  For example, should it be override_region_name \u003d RegionOne,RegionTwo?  And / or mention this in the config option text.","commit_id":"acdb16f0cea7f6b01e521df1c24e7a264a39ea4d"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"224422c5c9bee1fd5864d5dac2e6fc4d7d47c175","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    enabled \u003d True"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    [resource_plugin:os_glance_image]"},{"line_number":92,"context_line":"    enabled \u003d True"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    [resource_plugin:os_glance_metadef]"},{"line_number":95,"context_line":"    enabled \u003d True"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_6c1172af","line":92,"in_reply_to":"fa7ab95a_7bc69117","updated":"2016-08-31 17:29:21.000000000","message":"Done","commit_id":"acdb16f0cea7f6b01e521df1c24e7a264a39ea4d"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"1bfc578947112b874178662d2aa44879541420a4","unresolved":false,"context_lines":[{"line_number":278,"context_line":"|                     |               | instead of one configured in        |                           |"},{"line_number":279,"context_line":"|                     |               | service_credentials.os_region_name. |                           |"},{"line_number":280,"context_line":"|                     |               | Useful for multi-region deployments |                           |"},{"line_number":281,"context_line":"|                     |               | where a service is shared between   |                           |"},{"line_number":282,"context_line":"|                     |               | regions.                            |                           |"},{"line_number":283,"context_line":"+---------------------+---------------+-------------------------------------+---------------------------+"},{"line_number":284,"context_line":"| include_region_name |               | Defined for all plugins. Controls   | | Restart services        |"},{"line_number":285,"context_line":"|                     |               | whether or not to include           | | Reindex all             |"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_fb88e1c8","line":282,"range":{"start_line":281,"start_character":40,"end_line":282,"end_character":50},"updated":"2016-08-31 16:11:22.000000000","message":"I think it would be good to mention what override_region_name would look like in a multiregion setup.  For example, should it be override_region_name \u003d RegionOne,RegionTwo?  And / or mention this in the config option text.","commit_id":"acdb16f0cea7f6b01e521df1c24e7a264a39ea4d"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"224422c5c9bee1fd5864d5dac2e6fc4d7d47c175","unresolved":false,"context_lines":[{"line_number":278,"context_line":"|                     |               | instead of one configured in        |                           |"},{"line_number":279,"context_line":"|                     |               | service_credentials.os_region_name. |                           |"},{"line_number":280,"context_line":"|                     |               | Useful for multi-region deployments |                           |"},{"line_number":281,"context_line":"|                     |               | where a service is shared between   |                           |"},{"line_number":282,"context_line":"|                     |               | regions.                            |                           |"},{"line_number":283,"context_line":"+---------------------+---------------+-------------------------------------+---------------------------+"},{"line_number":284,"context_line":"| include_region_name |               | Defined for all plugins. Controls   | | Restart services        |"},{"line_number":285,"context_line":"|                     |               | whether or not to include           | | Reindex all             |"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_0c6aa61a","line":282,"range":{"start_line":281,"start_character":40,"end_line":282,"end_character":50},"in_reply_to":"fa7ab95a_fb88e1c8","updated":"2016-08-31 17:29:21.000000000","message":"Done","commit_id":"acdb16f0cea7f6b01e521df1c24e7a264a39ea4d"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"1bfc578947112b874178662d2aa44879541420a4","unresolved":false,"context_lines":[{"line_number":281,"context_line":"|                     |               | where a service is shared between   |                           |"},{"line_number":282,"context_line":"|                     |               | regions.                            |                           |"},{"line_number":283,"context_line":"+---------------------+---------------+-------------------------------------+---------------------------+"},{"line_number":284,"context_line":"| include_region_name |               | Defined for all plugins. Controls   | | Restart services        |"},{"line_number":285,"context_line":"|                     |               | whether or not to include           | | Reindex all             |"},{"line_number":286,"context_line":"|                     |               | region_name as a mapping field and  |                           |"},{"line_number":287,"context_line":"|                     |               | in each document. Defaults to off.  |                           |"},{"line_number":288,"context_line":"+---------------------+---------------+-------------------------------------+---------------------------+"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":".. _individual-plugin-configuration:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_fbf8e1c6","line":287,"range":{"start_line":284,"start_character":2,"end_line":287,"end_character":100},"updated":"2016-08-31 16:11:22.000000000","message":"This is actually a global configuration option.  It should go up on line 218.","commit_id":"acdb16f0cea7f6b01e521df1c24e7a264a39ea4d"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"224422c5c9bee1fd5864d5dac2e6fc4d7d47c175","unresolved":false,"context_lines":[{"line_number":281,"context_line":"|                     |               | where a service is shared between   |                           |"},{"line_number":282,"context_line":"|                     |               | regions.                            |                           |"},{"line_number":283,"context_line":"+---------------------+---------------+-------------------------------------+---------------------------+"},{"line_number":284,"context_line":"| include_region_name |               | Defined for all plugins. Controls   | | Restart services        |"},{"line_number":285,"context_line":"|                     |               | whether or not to include           | | Reindex all             |"},{"line_number":286,"context_line":"|                     |               | region_name as a mapping field and  |                           |"},{"line_number":287,"context_line":"|                     |               | in each document. Defaults to off.  |                           |"},{"line_number":288,"context_line":"+---------------------+---------------+-------------------------------------+---------------------------+"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":".. _individual-plugin-configuration:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_2c776a03","line":287,"range":{"start_line":284,"start_character":2,"end_line":287,"end_character":100},"in_reply_to":"fa7ab95a_fbf8e1c6","updated":"2016-08-31 17:29:21.000000000","message":"Done","commit_id":"acdb16f0cea7f6b01e521df1c24e7a264a39ea4d"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"470308d5de699648f5ac792e84d798eb4f642644","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    notifications_pool \u003d searchlight"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    [resource_plugin]"},{"line_number":76,"context_line":"    resource_group_name \u003d searchlight"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [service_credentials:nova]"},{"line_number":79,"context_line":"    compute_api_version \u003d 2.1"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_499c955d","line":76,"updated":"2016-08-31 20:38:22.000000000","message":"This is where line 84 should go. The configuration option code accesses \"resource_plugin.include_region_name\".","commit_id":"a15e5f319d069fde847e61faf685d0a32099a657"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"57f8b59f20edfcec4371ebb8c53e4897d7e64729","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    notifications_pool \u003d searchlight"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    [resource_plugin]"},{"line_number":76,"context_line":"    resource_group_name \u003d searchlight"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [service_credentials:nova]"},{"line_number":79,"context_line":"    compute_api_version \u003d 2.1"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_944f94bd","line":76,"in_reply_to":"fa7ab95a_499c955d","updated":"2016-08-31 21:04:42.000000000","message":"Thanks, done.","commit_id":"a15e5f319d069fde847e61faf685d0a32099a657"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"470308d5de699648f5ac792e84d798eb4f642644","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    [resource_plugin:os_nova_server]"},{"line_number":82,"context_line":"    enabled \u003d True"},{"line_number":83,"context_line":"    admin_only_fields \u003d OS-EXT-SRV*,OS-EXT-STS:vm_state"},{"line_number":84,"context_line":"    # include_region_name \u003d True"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    [resource_plugin:os_nova_hypervisor]"},{"line_number":87,"context_line":"    enabled \u003d True"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa7ab95a_c9a8a57a","line":84,"updated":"2016-08-31 20:38:22.000000000","message":"Move this line to line 76 above.","commit_id":"a15e5f319d069fde847e61faf685d0a32099a657"}],"searchlight/elasticsearch/plugins/base.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ba1b2f5220e1d637067aa9adef5d15c98089d43e","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    @property"},{"line_number":379,"context_line":"    def region_name(self):"},{"line_number":380,"context_line":"        \"\"\"Returns a region name if enabled by config and configured in"},{"line_number":381,"context_line":"        service_credentials. Adding it as per-plugin rather than global"},{"line_number":382,"context_line":"        in case at some point per-plugin credentials are supported."},{"line_number":383,"context_line":"        \"\"\""},{"line_number":384,"context_line":"        return getattr(CONF.service_credentials, \u0027os_region_name\u0027, None)"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_1a6ad480","line":382,"range":{"start_line":381,"start_character":29,"end_line":382,"end_character":67},"updated":"2016-08-15 20:01:43.000000000","message":"I don\u0027t understand this comment and might be missing something.  This isn\u0027t really per-plugin config.  I get that it is available on base.py, but it seems like this comment implies this is available per plugin.  However, in previous patches we created a distinct service credential per service, not per plugin because service credentials may be shared across plugins:\n\nhttps://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/openstack_clients.py#L100","commit_id":"42165df74edd6ec192d14c2122cb150d40c764e2"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"005ba44de1a6eefdfebed1dd728405381948a6e6","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    @property"},{"line_number":379,"context_line":"    def region_name(self):"},{"line_number":380,"context_line":"        \"\"\"Returns a region name if enabled by config and configured in"},{"line_number":381,"context_line":"        service_credentials. Adding it as per-plugin rather than global"},{"line_number":382,"context_line":"        in case at some point per-plugin credentials are supported."},{"line_number":383,"context_line":"        \"\"\""},{"line_number":384,"context_line":"        return getattr(CONF.service_credentials, \u0027os_region_name\u0027, None)"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_50351df5","line":382,"range":{"start_line":381,"start_character":29,"end_line":382,"end_character":67},"in_reply_to":"3ac371cc_1a6ad480","updated":"2016-08-16 15:49:27.000000000","message":"I\u0027ll reword. Right now, service_credentials (aside from the nova api version) is shared across all plugins and isn\u0027t overridable. I suspect that may change since many deployments will use per-service credentials. In this case, it may be the case that region_name isn\u0027t the same across all plugins (although I can\u0027t think of why). It makes sense to keep it here because it links initial indexing and the listeners, but I\u0027ll shorten the comment.","commit_id":"42165df74edd6ec192d14c2122cb150d40c764e2"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"1bfc578947112b874178662d2aa44879541420a4","unresolved":false,"context_lines":[{"line_number":553,"context_line":"                       help\u003d\"Override the region name configured in \""},{"line_number":554,"context_line":"                            \"\u0027service_credentials\u0027. This is useful when a \""},{"line_number":555,"context_line":"                            \"service is deployed as a cloud-wide service \""},{"line_number":556,"context_line":"                            \"rather than per region.\")"},{"line_number":557,"context_line":"        ]"},{"line_number":558,"context_line":"        if cls.NotificationHandlerCls:"},{"line_number":559,"context_line":"            opts.extend(cls.NotificationHandlerCls.get_plugin_opts())"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_bbb5797f","line":556,"range":{"start_line":556,"start_character":29,"end_line":556,"end_character":52},"updated":"2016-08-31 16:11:22.000000000","message":"see comment here about what to do for multi-region","commit_id":"acdb16f0cea7f6b01e521df1c24e7a264a39ea4d"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"a34d3582163ddc312a96304d9b2d90648245a01a","unresolved":false,"context_lines":[{"line_number":553,"context_line":"                       help\u003d\"Override the region name configured in \""},{"line_number":554,"context_line":"                            \"\u0027service_credentials\u0027. This is useful when a \""},{"line_number":555,"context_line":"                            \"service is deployed as a cloud-wide service \""},{"line_number":556,"context_line":"                            \"rather than per region.\")"},{"line_number":557,"context_line":"        ]"},{"line_number":558,"context_line":"        if cls.NotificationHandlerCls:"},{"line_number":559,"context_line":"            opts.extend(cls.NotificationHandlerCls.get_plugin_opts())"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_332fcda2","line":556,"range":{"start_line":556,"start_character":29,"end_line":556,"end_character":52},"in_reply_to":"fa7ab95a_bbb5797f","updated":"2016-08-31 16:54:38.000000000","message":"Yeah - this should actually be a ListOpt. Will correct.","commit_id":"acdb16f0cea7f6b01e521df1c24e7a264a39ea4d"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"470308d5de699648f5ac792e84d798eb4f642644","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        region_name \u003d self.options.override_region_name"},{"line_number":396,"context_line":"        return region_name or getattr(CONF.service_credentials,"},{"line_number":397,"context_line":"                                      \u0027os_region_name\u0027, None)"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    @property"},{"line_number":400,"context_line":"    def enabled(self):"},{"line_number":401,"context_line":"        return self.options.enabled"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_29359145","line":398,"updated":"2016-08-31 20:38:22.000000000","message":"These types do not match any more. self.options.override_region_name now returns a list. See line 551 below. The getattr(\u0027os_region_name\u0027) returns a string. Maybe we should have:\n\n    return region_name or [getattr(CONF.service_credentials,\n                                      \u0027os_region_name\u0027, None)]","commit_id":"a15e5f319d069fde847e61faf685d0a32099a657"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"57f8b59f20edfcec4371ebb8c53e4897d7e64729","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        region_name \u003d self.options.override_region_name"},{"line_number":396,"context_line":"        return region_name or getattr(CONF.service_credentials,"},{"line_number":397,"context_line":"                                      \u0027os_region_name\u0027, None)"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    @property"},{"line_number":400,"context_line":"    def enabled(self):"},{"line_number":401,"context_line":"        return self.options.enabled"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_8faa1dd1","line":398,"in_reply_to":"fa7ab95a_29359145","updated":"2016-08-31 21:04:42.000000000","message":"Somewhat against my better judgement but i\u0027ll change it to return a list.","commit_id":"a15e5f319d069fde847e61faf685d0a32099a657"}],"searchlight/elasticsearch/plugins/helper.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"d9106b00f4b5a0290815e856124bedfdac2084f9","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            version \u003d versions[index] if versions else None"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"            if self.plugin.region_name:"},{"line_number":501,"context_line":"                document[\u0027region_name\u0027] \u003d self.plugin.region_name"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"            if self.plugin.requires_role_separation:"},{"line_number":504,"context_line":"                LOG.debug(\"Applying role separation to %s id %s\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_921ffdb5","line":501,"updated":"2016-08-30 18:10:44.000000000","message":"Is this the correct behavior when the region name is not specified in the config file? In this case the documents will not have the \"region_name\" field. If the user is used to having this field (form now on) and searches on it, the search will fail.\n\nThis could be an issue if we have some documents with this field and some without. For example, have searchlight-manage run with a different region name settings than searchlight-listener. Admittedly, this is a corner case.\n\nTo be consistent, it seems we want to always have \"region_name\" as a field (and in the ES mappings). It can have a value of None if it is not defined. This will reduce possible bad interactions between searchlight-manage and searchlight-listener.","commit_id":"87683d71fd8630d9d6d7b30ce3c069bda6c80a10"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"f164c04bf6ba54edfbc2e30f36961daffbfeb5e6","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            version \u003d versions[index] if versions else None"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"            if self.plugin.region_name:"},{"line_number":501,"context_line":"                document[\u0027region_name\u0027] \u003d self.plugin.region_name"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"            if self.plugin.requires_role_separation:"},{"line_number":504,"context_line":"                LOG.debug(\"Applying role separation to %s id %s\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_c277e29d","line":501,"in_reply_to":"fa7ab95a_921ffdb5","updated":"2016-08-30 22:51:01.000000000","message":"I\u0027ve no problem always adding it, although the argument against was that in almost all cases it will be the same value throughout and therefore useless. Given that, I\u0027ll add a flag to turn this on or off but not make it conditional on each plugin\u0027s configuration.","commit_id":"87683d71fd8630d9d6d7b30ce3c069bda6c80a10"}],"searchlight/tests/functional/__init__.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"8e85a924da037318ea683bef6cc91c267365a053","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        json_content \u003d jsonutils.loads(content)"},{"line_number":548,"context_line":"        return json_content"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    def _delete_elasticsearch_doc(self, index_name, doc_type, doc_id):"},{"line_number":551,"context_line":"        es_url \u003d \"http://localhost:%s/%s/%s/%s\" % ("},{"line_number":552,"context_line":"            self.api_server.elasticsearch_port, index_name, doc_type, doc_id)"},{"line_number":553,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_54f3869e","line":550,"updated":"2016-08-15 18:31:04.000000000","message":"This function is not used anywhere. I\u0027m assuming it was called in an earlier version of test_with_region() and/or test_without_region(). We should remove it.","commit_id":"42165df74edd6ec192d14c2122cb150d40c764e2"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"005ba44de1a6eefdfebed1dd728405381948a6e6","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        json_content \u003d jsonutils.loads(content)"},{"line_number":548,"context_line":"        return json_content"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    def _delete_elasticsearch_doc(self, index_name, doc_type, doc_id):"},{"line_number":551,"context_line":"        es_url \u003d \"http://localhost:%s/%s/%s/%s\" % ("},{"line_number":552,"context_line":"            self.api_server.elasticsearch_port, index_name, doc_type, doc_id)"},{"line_number":553,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_d0c62d48","line":550,"in_reply_to":"3ac371cc_54f3869e","updated":"2016-08-16 15:49:27.000000000","message":"Done","commit_id":"42165df74edd6ec192d14c2122cb150d40c764e2"}]}