)]}'
{"searchlight/elasticsearch/plugins/neutron/floatingips.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"447c5172c5aa70ac8a4a29404a27f73f6c66209e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                \u0027floating_ip_address\u0027: {\"type\": \"ip\"},"},{"line_number":50,"context_line":"                \u0027tenant_id\u0027: str_not_analyzed,"},{"line_number":51,"context_line":"                \u0027project_id\u0027: str_not_analyzed,"},{"line_number":52,"context_line":"                \u0027updated_at\u0027: {\u0027type\u0027: \u0027date\u0027},"},{"line_number":53,"context_line":"                \u0027port_id\u0027: str_not_analyzed,"},{"line_number":54,"context_line":"                \u0027id\u0027: str_not_analyzed"},{"line_number":55,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_838f0e29","line":52,"range":{"start_line":52,"start_character":36,"end_line":52,"end_character":38},"updated":"2016-08-29 14:24:53.000000000","message":"I\u0027m ok doing it here, but another option is to add this in the base plugin code in get_full_mapping. Currently only the role_user_field is added there, but the region-field patch will also add a field there. If the updated_at field is purely ornamental (i.e. it\u0027s meaningless for these types and is being added only to prevent errors on sort) i\u0027d add it in get_full_mapping programatically. If it has useful meaning, here is better.","commit_id":"2a40bb57c39456b4cbe6d7b7aa7e54342800511e"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"c26856dcaab2701ca0d79830d20c3ea925acc937","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                \u0027floating_ip_address\u0027: {\"type\": \"ip\"},"},{"line_number":50,"context_line":"                \u0027tenant_id\u0027: str_not_analyzed,"},{"line_number":51,"context_line":"                \u0027project_id\u0027: str_not_analyzed,"},{"line_number":52,"context_line":"                \u0027updated_at\u0027: {\u0027type\u0027: \u0027date\u0027},"},{"line_number":53,"context_line":"                \u0027port_id\u0027: str_not_analyzed,"},{"line_number":54,"context_line":"                \u0027id\u0027: str_not_analyzed"},{"line_number":55,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_fdd31202","line":52,"range":{"start_line":52,"start_character":36,"end_line":52,"end_character":38},"in_reply_to":"fa7ab95a_838f0e29","updated":"2016-08-29 16:45:59.000000000","message":"I\u0027d prefer adding the field here than in get_full_mapping(), since it is more explicit. This will make it more likely that someone adding a new plugin will remember to add \u0027updated_at\u0027 to the serializer. If we hide this field in base.py it is more likely that this step will be overlooked.","commit_id":"2a40bb57c39456b4cbe6d7b7aa7e54342800511e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"4fbd5c7e72e0fa3c4ed0289cabcbea55e7a0c719","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                \u0027floating_ip_address\u0027: {\"type\": \"ip\"},"},{"line_number":50,"context_line":"                \u0027tenant_id\u0027: str_not_analyzed,"},{"line_number":51,"context_line":"                \u0027project_id\u0027: str_not_analyzed,"},{"line_number":52,"context_line":"                \u0027updated_at\u0027: {\u0027type\u0027: \u0027date\u0027},"},{"line_number":53,"context_line":"                \u0027port_id\u0027: str_not_analyzed,"},{"line_number":54,"context_line":"                \u0027id\u0027: str_not_analyzed"},{"line_number":55,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_92cfbab2","line":52,"range":{"start_line":52,"start_character":36,"end_line":52,"end_character":38},"in_reply_to":"fa7ab95a_fdd31202","updated":"2016-08-31 15:21:18.000000000","message":"Conversely, future people will think it is a bug and remove updated_at, because they don\u0027t see it in their data.  We already have these 5 plugins that didn\u0027t add it to their mapping and they all had examples with it to add it.  In addition, if somebody adds a custom plugin, it\u0027ll be missing.  Perhaps it would be best to do as Steve suggests and add mention of common fields into the developer guide.","commit_id":"2a40bb57c39456b4cbe6d7b7aa7e54342800511e"}],"searchlight/tests/functional/test_mappings.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"b66e4aac09e3879d575ea5e385b97a629ea3e421","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        # List of fields that are required."},{"line_number":30,"context_line":"        fields \u003d [\u0027updated_at\u0027]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        # Cycle through all plugins, grabbing each mapping."},{"line_number":33,"context_line":"        for resource in self.initialized_plugins.keys():"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_b6364450","line":30,"updated":"2016-08-27 18:52:06.000000000","message":"Nice test.  We are going to need the same for project_id... which has a few more questions to it.","commit_id":"d81e12f432430fd67ac0f10c09d75b5bb7c4d6fe"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"ecb66f7c6da305c1cfb2b022215a9ded8aa46000","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        # List of fields that are required."},{"line_number":30,"context_line":"        fields \u003d [\u0027updated_at\u0027]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        # Cycle through all plugins, grabbing each mapping."},{"line_number":33,"context_line":"        for resource in self.initialized_plugins.keys():"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_84a6580e","line":30,"in_reply_to":"fa7ab95a_b6364450","updated":"2016-08-29 03:02:26.000000000","message":"Do you want me to add the \"project_id\" as part of this patch? According to be script, it\u0027s missing from OS::Nova::Flavor and OS::Nova::Hypervisor.","commit_id":"d81e12f432430fd67ac0f10c09d75b5bb7c4d6fe"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"447c5172c5aa70ac8a4a29404a27f73f6c66209e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Hewlett-Packard Enterprise Development LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_c3291639","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":13},"updated":"2016-08-29 14:24:53.000000000","message":"I would be inclined to put this in test_plugin, where there exists already code to check mapping parameters (like doc values, the user_role_field) or alternatively move those tests out into this file.","commit_id":"2a40bb57c39456b4cbe6d7b7aa7e54342800511e"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"c26856dcaab2701ca0d79830d20c3ea925acc937","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Hewlett-Packard Enterprise Development LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_56305be8","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":13},"in_reply_to":"fa7ab95a_c3291639","updated":"2016-08-29 16:45:59.000000000","message":"The test_plugin is a unit test. It uses fake plugins. I wanted to test all of the real plugins with the real mapping values. This is why I added a new functional test. Since the unit tests are verifying the manipulation of the mappings without regard to the actual settings of a real mapping (e.g. adding user roles to a mapping), I think they should stay in the unit tests.\n\nIf it helps to clarify, I can add a comment to this file explaining that we need to verify the actual mapping contents for the plugins.","commit_id":"2a40bb57c39456b4cbe6d7b7aa7e54342800511e"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"1117d002e03dda06e507d5e44f5e5beb04c72ab1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from searchlight.tests import functional"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class TestMappings(functional.FunctionalTest):"},{"line_number":20,"context_line":"    def setUp(self):"},{"line_number":21,"context_line":"        super(TestMappings, self).setUp()"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_d87203e3","line":19,"range":{"start_line":19,"start_character":6,"end_line":19,"end_character":18},"updated":"2016-09-01 13:45:08.000000000","message":"There is already a unit test to check that mapping field definitions don\u0027t conflict (searchlight/tests/unit/test_plugin.py L308). Maybe makes more sense there? Both these tests could also use importlib discovery to check all the plugins that exist (versus the ones registered by the test framework) but that can be done later.","commit_id":"0ba89124cfe6c6013fbf4257699725f1225e2506"}]}
