)]}'
{"etc/policy.json":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"1e13d218b84c614239207baa6bb90e5b534ba851","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    \"default\": \"\","},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    \"search:query\": \"rule:admin_or_owner\","},{"line_number":7,"context_line":"    \"search:query:aggregations\": \"role:admin_or_owner\","},{"line_number":8,"context_line":"    \"search:plugins_info\": \"rule:admin_or_owner\","},{"line_number":9,"context_line":"    \"search:facets\": \"rule:admin_or_owner\","},{"line_number":10,"context_line":""}],"source_content_type":"application/json","patch_set":3,"id":"9a89bdaa_06f7578b","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":38},"updated":"2016-09-08 03:26:19.000000000","message":"This should be \"rule\" and not \"role\". Or is it a British thing and it should be \"roule\" :)","commit_id":"72ff0e04c65120cbc354a79a8e7cbd6928c45afb"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f7e5c26a5a9671592043cc0d5bb730c1508a7a3d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    \"default\": \"\","},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    \"search:query\": \"rule:admin_or_owner\","},{"line_number":7,"context_line":"    \"search:query:aggregations\": \"role:admin_or_owner\","},{"line_number":8,"context_line":"    \"search:plugins_info\": \"rule:admin_or_owner\","},{"line_number":9,"context_line":"    \"search:facets\": \"rule:admin_or_owner\","},{"line_number":10,"context_line":""}],"source_content_type":"application/json","patch_set":3,"id":"9a89bdaa_3670e5a3","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":38},"in_reply_to":"9a89bdaa_06f7578b","updated":"2016-09-08 14:39:57.000000000","message":"Funny, I tested the policy file with other items... But not this. Good catch.","commit_id":"72ff0e04c65120cbc354a79a8e7cbd6928c45afb"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"bb16ad0af677f28e59a649cbe077ee9bf86fd291","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    \"default\": \"\","},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    \"search:query\": \"rule:admin_or_owner\","},{"line_number":7,"context_line":"    \"search:query:aggregations\": \"role:admin_or_owner\","},{"line_number":8,"context_line":"    \"search:plugins_info\": \"rule:admin_or_owner\","},{"line_number":9,"context_line":"    \"search:facets\": \"rule:admin_or_owner\","},{"line_number":10,"context_line":""}],"source_content_type":"application/json","patch_set":3,"id":"9a89bdaa_3e527267","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":38},"in_reply_to":"9a89bdaa_3670e5a3","updated":"2016-09-08 17:22:22.000000000","message":"Thanks, done","commit_id":"72ff0e04c65120cbc354a79a8e7cbd6928c45afb"}],"searchlight/api/v1/search.py":[{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"1e13d218b84c614239207baa6bb90e5b534ba851","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                        \"which is not allowed\") % agg_name"},{"line_number":299,"context_line":"                    LOG.error(msg)"},{"line_number":300,"context_line":"                    raise webob.exc.HTTPForbidden(explanation\u003dmsg)"},{"line_number":301,"context_line":"        return aggregations"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def _get_es_query(self, context, query, resource_types,"},{"line_number":304,"context_line":"                      all_projects\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_c90bc022","line":301,"updated":"2016-09-08 03:26:19.000000000","message":"Nit: There doesn\u0027t seem to be a reason to return aggregations. We aren\u0027t modifying it, like the other _validate_* methods above. It seems that we should either raise an exception or do nothing.","commit_id":"72ff0e04c65120cbc354a79a8e7cbd6928c45afb"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"bb16ad0af677f28e59a649cbe077ee9bf86fd291","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                        \"which is not allowed\") % agg_name"},{"line_number":299,"context_line":"                    LOG.error(msg)"},{"line_number":300,"context_line":"                    raise webob.exc.HTTPForbidden(explanation\u003dmsg)"},{"line_number":301,"context_line":"        return aggregations"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def _get_es_query(self, context, query, resource_types,"},{"line_number":304,"context_line":"                      all_projects\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_7e8ddad1","line":301,"in_reply_to":"9a89bdaa_c90bc022","updated":"2016-09-08 17:22:22.000000000","message":"Yeah. I was trying to keep the structure the same as other validate_ functions. If we do start modifying it, it\u0027s much easier for testing etc to return a new object","commit_id":"72ff0e04c65120cbc354a79a8e7cbd6928c45afb"}]}