)]}'
{"searchlight/tests/functional/test_cinder_plugins.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"477e1213983a25a6bd671d8ec89d621fa9989125","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @mock.patch(volume_manager + \u0027.get\u0027)"},{"line_number":144,"context_line":"    def test_volume_cud(self, mock_volume_get):"},{"line_number":145,"context_line":"        mock_volume \u003d mock.Mock(id\u003dVOLUME_ID1, user_id\u003dUSER_ID,"},{"line_number":146,"context_line":"                                created_at\u003d\u00272016-03-07T16:51:09.000000\u0027,"},{"line_number":147,"context_line":"                                updated_at\u003d\u00272016-03-07T16:51:09.000000\u0027)"},{"line_number":148,"context_line":"        mock_volume_get.return_value \u003d mock_volume"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_857d7870","line":145,"range":{"start_line":145,"start_character":27,"end_line":145,"end_character":31},"updated":"2016-09-06 15:36:49.000000000","message":"It might make sense to use the DictObj class from searchlight\u0027s test utils.py which provides a to_dict() method","commit_id":"8c7e15c213e2b98b7efa090275451860a73f00f2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"dfd6f56d1594e5e595e65a96e2e0d5ff2d0c87a1","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @mock.patch(volume_manager + \u0027.get\u0027)"},{"line_number":144,"context_line":"    def test_volume_cud(self, mock_volume_get):"},{"line_number":145,"context_line":"        mock_volume \u003d mock.Mock(id\u003dVOLUME_ID1, user_id\u003dUSER_ID,"},{"line_number":146,"context_line":"                                created_at\u003d\u00272016-03-07T16:51:09.000000\u0027,"},{"line_number":147,"context_line":"                                updated_at\u003d\u00272016-03-07T16:51:09.000000\u0027)"},{"line_number":148,"context_line":"        mock_volume_get.return_value \u003d mock_volume"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_89eaddaa","line":145,"range":{"start_line":145,"start_character":27,"end_line":145,"end_character":31},"in_reply_to":"9a89bdaa_857d7870","updated":"2016-09-07 01:14:02.000000000","message":"Done","commit_id":"8c7e15c213e2b98b7efa090275451860a73f00f2"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"477e1213983a25a6bd671d8ec89d621fa9989125","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            {}.iteritems()"},{"line_number":162,"context_line":"            mock_volume_get.assert_has_calls(["},{"line_number":163,"context_line":"                mock.call(VOLUME_ID1),"},{"line_number":164,"context_line":"                mock.call().to_dict(),"},{"line_number":165,"context_line":"                mock.call().to_dict().iteritems(),"},{"line_number":166,"context_line":"                mock.call(VOLUME_ID1),"},{"line_number":167,"context_line":"                mock.call().to_dict(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_e56e4495","line":164,"range":{"start_line":164,"start_character":28,"end_line":164,"end_character":35},"updated":"2016-09-06 15:36:49.000000000","message":"This makes my eyes water :)   If the test is to ensure that mock_volume_get is called, i would change the mock to be a DictObj and change this test just to assert that mock_volume_get was called with VOLUME_ID1","commit_id":"8c7e15c213e2b98b7efa090275451860a73f00f2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"dfd6f56d1594e5e595e65a96e2e0d5ff2d0c87a1","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            {}.iteritems()"},{"line_number":162,"context_line":"            mock_volume_get.assert_has_calls(["},{"line_number":163,"context_line":"                mock.call(VOLUME_ID1),"},{"line_number":164,"context_line":"                mock.call().to_dict(),"},{"line_number":165,"context_line":"                mock.call().to_dict().iteritems(),"},{"line_number":166,"context_line":"                mock.call(VOLUME_ID1),"},{"line_number":167,"context_line":"                mock.call().to_dict(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_490b758e","line":164,"range":{"start_line":164,"start_character":28,"end_line":164,"end_character":35},"in_reply_to":"9a89bdaa_e56e4495","updated":"2016-09-07 01:14:02.000000000","message":"okay","commit_id":"8c7e15c213e2b98b7efa090275451860a73f00f2"}]}
