)]}'
{"searchlight/elasticsearch/plugins/neutron/ports.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"ee602f0843d81a7daed64f808f3fbd65b2e69080","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        for port in neutron_client.list_ports()[\u0027ports\u0027]:"},{"line_number":159,"context_line":"            if (not port[\u0027device_owner\u0027] or"},{"line_number":160,"context_line":"               not port[\u0027device_owner\u0027].lower().startswith(\u0027compute:\u0027)):"},{"line_number":161,"context_line":"                continue"},{"line_number":162,"context_line":"            \"\"\"The check/TODO below is superceded by the above check. When we"},{"line_number":163,"context_line":"               flesh out the device owner check, re-enable the check below."},{"line_number":164,"context_line":"            # TODO(sjmc7): Remove this once we can get proper notifications"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_49ed9624","line":161,"updated":"2016-09-20 03:22:19.000000000","message":"I think prefix with \u0027baremetal:\u0027 also need to be included [1]\n\n[1]: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L46","commit_id":"0abbffd8280366330c5890e827956a2f90b97ce7"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"692c9c58a2a0816d97d0827b0f1b04463ab7b9eb","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        for port in neutron_client.list_ports()[\u0027ports\u0027]:"},{"line_number":159,"context_line":"            if (not port[\u0027device_owner\u0027] or"},{"line_number":160,"context_line":"               not port[\u0027device_owner\u0027].lower().startswith(\u0027compute:\u0027)):"},{"line_number":161,"context_line":"                continue"},{"line_number":162,"context_line":"            \"\"\"The check/TODO below is superceded by the above check. When we"},{"line_number":163,"context_line":"               flesh out the device owner check, re-enable the check below."},{"line_number":164,"context_line":"            # TODO(sjmc7): Remove this once we can get proper notifications"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_e254b7cb","line":161,"in_reply_to":"7a8ec9b2_49ed9624","updated":"2016-09-20 05:35:34.000000000","message":"Hi Li,\n\nIs this a port owner we are currently getting through the notifications? The idea behind this change is for the initial indexing to match what we get from the notifications. We do not want stale data in Elasticsearch, ports that get indexed initially, but doesn\u0027t change as the ports are modified, deleted, etc.\n\nFor example, we are not getting any notifications for ports owned by a network (network:*). In this case, we want the initial index to match the notification and *not* index any ports owned by \u0027network\u0027.\n\nIf we are currently getting notifications from ports owned by \u0027baremetal\u0027, then we do want add them here. Do you know where I can verify that?\n\nAt least that was my understanding of this change :)","commit_id":"0abbffd8280366330c5890e827956a2f90b97ce7"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"71255a685835f23509db6b26f076f3724aeb968e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        for port in neutron_client.list_ports()[\u0027ports\u0027]:"},{"line_number":159,"context_line":"            if (not port[\u0027device_owner\u0027] or"},{"line_number":160,"context_line":"               not port[\u0027device_owner\u0027].lower().startswith(\u0027compute:\u0027)):"},{"line_number":161,"context_line":"                continue"},{"line_number":162,"context_line":"            \"\"\"The check/TODO below is superceded by the above check. When we"},{"line_number":163,"context_line":"               flesh out the device owner check, re-enable the check below."},{"line_number":164,"context_line":"            # TODO(sjmc7): Remove this once we can get proper notifications"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_de3a0fe7","line":161,"in_reply_to":"7a8ec9b2_e254b7cb","updated":"2016-09-20 16:45:01.000000000","message":"If baremetal-owned ports send out full notifications (as do compute-owned ones), we can \u0026 should include them. I have never seen a baremetal: one so i don\u0027t know if they do or not","commit_id":"0abbffd8280366330c5890e827956a2f90b97ce7"}]}