)]}'
{"searchlight/elasticsearch/plugins/base.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"393f300592d7a6609a43ad3d7e4caa205ba196c4","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    def filter_result(self, hit, request_context):"},{"line_number":505,"context_line":"        \"\"\"Filter each outgoing search result; document in hit[\u0027_source\u0027]."},{"line_number":506,"context_line":"        \"\"\""},{"line_number":507,"context_line":"        if \u0027highlight\u0027 in hit:"},{"line_number":508,"context_line":"            fields \u003d [ROLE_USER_FIELD]"},{"line_number":509,"context_line":"            # We need to clean up any fields \u0027leaked\u0027 by highlighting."},{"line_number":510,"context_line":"            for field in fields:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_55f3629e","line":507,"range":{"start_line":507,"start_character":12,"end_line":507,"end_character":21},"updated":"2016-09-22 19:49:14.000000000","message":"Can you add a comment here that \u0027highlight\u0027 (if requested) is a peer of _source for people who are easily confused like me?","commit_id":"5375fdd35e676ca93936fcb215882506d8ee76ac"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"9ec30c713211492e62e77a35684d2c0c5b229cea","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    def filter_result(self, hit, request_context):"},{"line_number":505,"context_line":"        \"\"\"Filter each outgoing search result; document in hit[\u0027_source\u0027]."},{"line_number":506,"context_line":"        \"\"\""},{"line_number":507,"context_line":"        if \u0027highlight\u0027 in hit:"},{"line_number":508,"context_line":"            fields \u003d [ROLE_USER_FIELD]"},{"line_number":509,"context_line":"            # We need to clean up any fields \u0027leaked\u0027 by highlighting."},{"line_number":510,"context_line":"            for field in fields:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_38240b0c","line":507,"range":{"start_line":507,"start_character":12,"end_line":507,"end_character":21},"in_reply_to":"5a8bc5a2_55f3629e","updated":"2016-09-22 20:58:45.000000000","message":"Yes I can.","commit_id":"5375fdd35e676ca93936fcb215882506d8ee76ac"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"393f300592d7a6609a43ad3d7e4caa205ba196c4","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        \"\"\"Filter each outgoing search result; document in hit[\u0027_source\u0027]."},{"line_number":506,"context_line":"        \"\"\""},{"line_number":507,"context_line":"        if \u0027highlight\u0027 in hit:"},{"line_number":508,"context_line":"            fields \u003d [ROLE_USER_FIELD]"},{"line_number":509,"context_line":"            # We need to clean up any fields \u0027leaked\u0027 by highlighting."},{"line_number":510,"context_line":"            for field in fields:"},{"line_number":511,"context_line":"                if field in hit[\u0027highlight\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_f5ec6ec9","line":508,"range":{"start_line":508,"start_character":22,"end_line":508,"end_character":37},"updated":"2016-09-22 19:49:14.000000000","message":"No reason for this to be a list until there\u0027s more than one of them","commit_id":"5375fdd35e676ca93936fcb215882506d8ee76ac"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"9ec30c713211492e62e77a35684d2c0c5b229cea","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        \"\"\"Filter each outgoing search result; document in hit[\u0027_source\u0027]."},{"line_number":506,"context_line":"        \"\"\""},{"line_number":507,"context_line":"        if \u0027highlight\u0027 in hit:"},{"line_number":508,"context_line":"            fields \u003d [ROLE_USER_FIELD]"},{"line_number":509,"context_line":"            # We need to clean up any fields \u0027leaked\u0027 by highlighting."},{"line_number":510,"context_line":"            for field in fields:"},{"line_number":511,"context_line":"                if field in hit[\u0027highlight\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_4391e898","line":508,"range":{"start_line":508,"start_character":22,"end_line":508,"end_character":37},"in_reply_to":"5a8bc5a2_f5ec6ec9","updated":"2016-09-22 20:58:45.000000000","message":"There meant to be a TODO here, asking the reviewers if there are other fields that need to popped from the highlight results. Talking with folks, it seems this is not the case so the list will be replaced.","commit_id":"5375fdd35e676ca93936fcb215882506d8ee76ac"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"393f300592d7a6609a43ad3d7e4caa205ba196c4","unresolved":false,"context_lines":[{"line_number":507,"context_line":"        if \u0027highlight\u0027 in hit:"},{"line_number":508,"context_line":"            fields \u003d [ROLE_USER_FIELD]"},{"line_number":509,"context_line":"            # We need to clean up any fields \u0027leaked\u0027 by highlighting."},{"line_number":510,"context_line":"            for field in fields:"},{"line_number":511,"context_line":"                if field in hit[\u0027highlight\u0027]:"},{"line_number":512,"context_line":"                    hit[\u0027highlight\u0027].pop(field)"},{"line_number":513,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_b5090698","line":510,"range":{"start_line":510,"start_character":24,"end_line":510,"end_character":25},"updated":"2016-09-22 19:49:14.000000000","message":"Can replace all this with highlight.pop(ROLE_USER_FIELD, None) - no need for the \u0027in\u0027 test or the loop","commit_id":"5375fdd35e676ca93936fcb215882506d8ee76ac"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"9ec30c713211492e62e77a35684d2c0c5b229cea","unresolved":false,"context_lines":[{"line_number":507,"context_line":"        if \u0027highlight\u0027 in hit:"},{"line_number":508,"context_line":"            fields \u003d [ROLE_USER_FIELD]"},{"line_number":509,"context_line":"            # We need to clean up any fields \u0027leaked\u0027 by highlighting."},{"line_number":510,"context_line":"            for field in fields:"},{"line_number":511,"context_line":"                if field in hit[\u0027highlight\u0027]:"},{"line_number":512,"context_line":"                    hit[\u0027highlight\u0027].pop(field)"},{"line_number":513,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_83e9301d","line":510,"range":{"start_line":510,"start_character":24,"end_line":510,"end_character":25},"in_reply_to":"5a8bc5a2_b5090698","updated":"2016-09-22 20:58:45.000000000","message":"See above. Replaced.","commit_id":"5375fdd35e676ca93936fcb215882506d8ee76ac"}],"searchlight/elasticsearch/plugins/cinder/snapshots.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"393f300592d7a6609a43ad3d7e4caa205ba196c4","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    def serialize(self, snapshot):"},{"line_number":155,"context_line":"        return serialize_cinder_snapshot(snapshot)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def filter_result(self, hit, request_context):"},{"line_number":158,"context_line":"        super(SnapshotIndex, self).filter_result(hit, request_context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_f53aae35","line":157,"range":{"start_line":157,"start_character":33,"end_line":157,"end_character":48},"updated":"2016-09-22 19:49:14.000000000","message":"This isn\u0027t necessary; an implementer should call the base function if they override it","commit_id":"5375fdd35e676ca93936fcb215882506d8ee76ac"},{"author":{"_account_id":14680,"name":"Rick Aulino","email":"rick.aulino@hpe.com","username":"ricka"},"change_message_id":"9ec30c713211492e62e77a35684d2c0c5b229cea","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    def serialize(self, snapshot):"},{"line_number":155,"context_line":"        return serialize_cinder_snapshot(snapshot)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def filter_result(self, hit, request_context):"},{"line_number":158,"context_line":"        super(SnapshotIndex, self).filter_result(hit, request_context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_83ba10e0","line":157,"range":{"start_line":157,"start_character":33,"end_line":157,"end_character":48},"in_reply_to":"5a8bc5a2_f53aae35","updated":"2016-09-22 20:58:45.000000000","message":"My copy/paste had too much momentum! I\u0027ll remove it here and in all of the other places that are not overriding it.","commit_id":"5375fdd35e676ca93936fcb215882506d8ee76ac"}]}