)]}'
{"searchlight/cmd/manage.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"5af8692aadb179995bcad32bdf05158d1dc93706","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            LOG.error(_LE(\"Invalid value for config file option \""},{"line_number":172,"context_line":"                          \"\u0027manage.workers\u0027. The number of thread workers \""},{"line_number":173,"context_line":"                          \"must be greater than 0.\"))"},{"line_number":174,"context_line":"            sys.exit(3)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        # Grab the list of plugins registered as entry points through stevedore"},{"line_number":177,"context_line":"        search_plugins \u003d utils.get_search_plugins()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_2b05f30f","line":174,"range":{"start_line":174,"start_character":16,"end_line":174,"end_character":20},"updated":"2016-10-03 14:52:24.000000000","message":"Should be return rather than sys.exit","commit_id":"b60cb279320da40a41e4c72762208869f2d24714"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"5af8692aadb179995bcad32bdf05158d1dc93706","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                  (\",\".join(group_set) or \"\u003cNone\u003e\","},{"line_number":246,"context_line":"                   \",\".join(type_set) or \"\u003cNone\u003e\"))"},{"line_number":247,"context_line":"            print(\"Aborting.\")"},{"line_number":248,"context_line":"            sys.exit(1)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        # As an optimization, if any types are explicitly requested, we"},{"line_number":251,"context_line":"        # will index them from their service APIs. The rest will be"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_0b29178a","line":248,"range":{"start_line":248,"start_character":20,"end_line":248,"end_character":21},"updated":"2016-10-03 14:52:24.000000000","message":"Should be \u0027return\u0027","commit_id":"b60cb279320da40a41e4c72762208869f2d24714"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"5af8692aadb179995bcad32bdf05158d1dc93706","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                \"OK to continue? [y/n]: \")"},{"line_number":321,"context_line":"            if ans.lower() !\u003d \u0027y\u0027:"},{"line_number":322,"context_line":"                print(\"Aborting.\")"},{"line_number":323,"context_line":"                sys.exit(0)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        # Start the re-indexing process."},{"line_number":326,"context_line":"        # Now we are starting to change Elasticsearch. Let\u0027s clean up"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_2b533318","line":323,"range":{"start_line":323,"start_character":20,"end_line":323,"end_character":24},"updated":"2016-10-03 14:52:24.000000000","message":"Should be \u0027return\u0027","commit_id":"b60cb279320da40a41e4c72762208869f2d24714"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"5af8692aadb179995bcad32bdf05158d1dc93706","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        print(_(\"Available commands:\"))"},{"line_number":561,"context_line":"        for command in COMMANDS:"},{"line_number":562,"context_line":"            print(_(\"\\t%s\") % command)"},{"line_number":563,"context_line":"        sys.exit(2)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    try:"},{"line_number":566,"context_line":"        logging.register_options(CONF)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_7046067c","line":563,"range":{"start_line":563,"start_character":12,"end_line":563,"end_character":16},"updated":"2016-10-03 14:52:24.000000000","message":"It\u0027d be more consistent to return 2 from this rather than sys.exit","commit_id":"b60cb279320da40a41e4c72762208869f2d24714"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"5af8692aadb179995bcad32bdf05158d1dc93706","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        return CONF.command.action_fn(*func_args, **func_kwargs)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"    except RuntimeError as e:"},{"line_number":587,"context_line":"        sys.exit(\"ERROR: %s\" % e)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_30371e00","line":587,"range":{"start_line":587,"start_character":18,"end_line":587,"end_character":23},"updated":"2016-10-03 14:52:24.000000000","message":"This should probably be the return value instead of sys.exit","commit_id":"b60cb279320da40a41e4c72762208869f2d24714"}]}