)]}'
{"releasenotes/notes/bp-reindex-interval-a43c37189e948d28.yaml":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"dd899f38edaad13d4df7ad8806b9b955aacec531","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds on option \"--notification-less\" to \"searchlight-manage index sync\""},{"line_number":4,"context_line":"    to re-sync only plugins that don\u0027t have notifications."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7a77a97e_f65ae029","line":4,"range":{"start_line":4,"start_character":7,"end_line":4,"end_character":14},"updated":"2016-11-21 03:22:29.000000000","message":"maybe sync will be more accurate, re-sync is just an usage of this","commit_id":"76074fd81f4c4a71a10e66b7a5c3a0a26d12fc85"}],"searchlight/cmd/manage.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"8d5617b21e6b48d98a68c1cbc58191313eb729eb","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            sys.exit(0)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if _type and notification_less:"},{"line_number":165,"context_line":"            LOG.warning(_LW(\"Ignoring --type since --notification-less \""},{"line_number":166,"context_line":"                            \"is specified.\"))"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_207758d5","line":164,"range":{"start_line":164,"start_character":17,"end_line":164,"end_character":20},"updated":"2016-11-22 17:16:43.000000000","message":"Maybe make this an error state as well. Even in quiet mode there\u0027s enough output that you likely won\u0027t see this warning.","commit_id":"1861f5bd978ae99f4f08d6655e23135157ed5f6b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"b7fe71425bf0b3b78c410a2a4c3d26d5622aa02b","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            sys.exit(0)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if _type and notification_less:"},{"line_number":165,"context_line":"            LOG.warning(_LW(\"Ignoring --type since --notification-less \""},{"line_number":166,"context_line":"                            \"is specified.\"))"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_c94e2196","line":164,"range":{"start_line":164,"start_character":17,"end_line":164,"end_character":20},"in_reply_to":"7a77a97e_207758d5","updated":"2016-11-23 01:19:38.000000000","message":"Done","commit_id":"1861f5bd978ae99f4f08d6655e23135157ed5f6b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"8d5617b21e6b48d98a68c1cbc58191313eb729eb","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        sync needs to be a separate step. The API states that if any invalid"},{"line_number":222,"context_line":"        plugin was specified by the caller, the entire operation fails."},{"line_number":223,"context_line":"        \"\"\""},{"line_number":224,"context_line":"        _plugins_without_notification \u003d []"},{"line_number":225,"context_line":"        if notification_less:"},{"line_number":226,"context_line":"            for res_type, ext in six.iteritems(search_plugins):"},{"line_number":227,"context_line":"                if not ext.obj.get_notification_handler():"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_db569905","line":224,"range":{"start_line":224,"start_character":8,"end_line":224,"end_character":37},"updated":"2016-11-22 17:16:43.000000000","message":"I\u0027d recommend moving this section up to line 194, because then notification-less just gets expanded to --type and the existing output will take effect","commit_id":"1861f5bd978ae99f4f08d6655e23135157ed5f6b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"b7fe71425bf0b3b78c410a2a4c3d26d5622aa02b","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        sync needs to be a separate step. The API states that if any invalid"},{"line_number":222,"context_line":"        plugin was specified by the caller, the entire operation fails."},{"line_number":223,"context_line":"        \"\"\""},{"line_number":224,"context_line":"        _plugins_without_notification \u003d []"},{"line_number":225,"context_line":"        if notification_less:"},{"line_number":226,"context_line":"            for res_type, ext in six.iteritems(search_plugins):"},{"line_number":227,"context_line":"                if not ext.obj.get_notification_handler():"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_c93541f8","line":224,"range":{"start_line":224,"start_character":8,"end_line":224,"end_character":37},"in_reply_to":"7a77a97e_db569905","updated":"2016-11-23 01:19:38.000000000","message":"Done","commit_id":"1861f5bd978ae99f4f08d6655e23135157ed5f6b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"8d5617b21e6b48d98a68c1cbc58191313eb729eb","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        _plugins_without_notification \u003d []"},{"line_number":225,"context_line":"        if notification_less:"},{"line_number":226,"context_line":"            for res_type, ext in six.iteritems(search_plugins):"},{"line_number":227,"context_line":"                if not ext.obj.get_notification_handler():"},{"line_number":228,"context_line":"                    _plugins_without_notification.append("},{"line_number":229,"context_line":"                        ext.obj.get_document_type())"},{"line_number":230,"context_line":"            # Override _type list."}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_fba7d508","line":227,"range":{"start_line":227,"start_character":31,"end_line":227,"end_character":55},"updated":"2016-11-22 17:16:43.000000000","message":"Agree that this would be a good place to add warnings that there are plugins that DO have notificaiton handlers that are in the same resource groups and will ultimately be reindexed from ES since that\u0027s not a desired situation and will likely cause churn","commit_id":"1861f5bd978ae99f4f08d6655e23135157ed5f6b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"b7fe71425bf0b3b78c410a2a4c3d26d5622aa02b","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        _plugins_without_notification \u003d []"},{"line_number":225,"context_line":"        if notification_less:"},{"line_number":226,"context_line":"            for res_type, ext in six.iteritems(search_plugins):"},{"line_number":227,"context_line":"                if not ext.obj.get_notification_handler():"},{"line_number":228,"context_line":"                    _plugins_without_notification.append("},{"line_number":229,"context_line":"                        ext.obj.get_document_type())"},{"line_number":230,"context_line":"            # Override _type list."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_649374fb","line":227,"range":{"start_line":227,"start_character":31,"end_line":227,"end_character":55},"in_reply_to":"7a77a97e_fba7d508","updated":"2016-11-23 01:19:38.000000000","message":"Seems L326 is a better place to LOG the warning, what do you think?","commit_id":"1861f5bd978ae99f4f08d6655e23135157ed5f6b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"8d5617b21e6b48d98a68c1cbc58191313eb729eb","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                    # Don\u0027t reindex this type"},{"line_number":287,"context_line":"                    plugins_to_index.remove((resource_type, ext))"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if not force and not notification_less:"},{"line_number":290,"context_line":"            # For display purpose, we want to iterate on only parthenogenetic"},{"line_number":291,"context_line":"            # plugins that are not the children of another plugin. If there"},{"line_number":292,"context_line":"            # are children plugins they will be displayed when we call"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_c01a247c","line":289,"range":{"start_line":289,"start_character":29,"end_line":289,"end_character":46},"updated":"2016-11-22 17:16:43.000000000","message":"Not sure why this is here; I still think it\u0027s worth showing the ones that are going to get re-indexed (as well as any that might be getting reindexed from ES because they\u0027re in the same group)","commit_id":"1861f5bd978ae99f4f08d6655e23135157ed5f6b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"b7fe71425bf0b3b78c410a2a4c3d26d5622aa02b","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                    # Don\u0027t reindex this type"},{"line_number":287,"context_line":"                    plugins_to_index.remove((resource_type, ext))"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if not force and not notification_less:"},{"line_number":290,"context_line":"            # For display purpose, we want to iterate on only parthenogenetic"},{"line_number":291,"context_line":"            # plugins that are not the children of another plugin. If there"},{"line_number":292,"context_line":"            # are children plugins they will be displayed when we call"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_0449e08b","line":289,"range":{"start_line":289,"start_character":29,"end_line":289,"end_character":46},"in_reply_to":"7a77a97e_c01a247c","updated":"2016-11-23 01:19:38.000000000","message":"I was intending to avoid typing \u0027y\u0027, will move the check to L336","commit_id":"1861f5bd978ae99f4f08d6655e23135157ed5f6b"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"d8f37f3324c7f0da506d7031a249b5559035e44d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            sys.exit(0)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if _type and notification_less:"},{"line_number":165,"context_line":"            LOG.error(_LE(\"Ignoring --type since --notification-less is \""},{"line_number":166,"context_line":"                          \"specified.\"))"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        if force_es and (_type or notification_less):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a74a57a_2e682dba","line":165,"range":{"start_line":165,"start_character":27,"end_line":165,"end_character":35},"updated":"2016-11-30 23:50:08.000000000","message":"Still think it\u0027d be better to fail out in this case but i\u0027m not too bothered","commit_id":"b47140909af9f975ef1a530957f91ac1ea8852b2"}]}