)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"68eb27fd55d6f70db9486ebdfb4815a7d71ecca3","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    $SEARCHLIGHT_BIN_DIR/searchlight-manage --config-file $SEARCHLIGHT_CONF index sync --force"},{"line_number":193,"context_line":"}"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"# Install Searchlight\u0027s requirements"},{"line_number":196,"context_line":"# See https://elasticsearch-py.readthedocs.io/en/master/#compatibility"},{"line_number":197,"context_line":"function _setup_searchlight_dev {"},{"line_number":198,"context_line":"    setup_develop $SEARCHLIGHT_DIR"},{"line_number":199,"context_line":"    if [[ $ELASTICSEARCH_VERSION \u003d~ ^5 ]]; then"},{"line_number":200,"context_line":"        echo \"Installing python elasticsearch for ES 5.x\""},{"line_number":201,"context_line":"        pip_install -U $SEARCHLIGHT_DIR/elasticsearch5.txt"},{"line_number":202,"context_line":"    elif [[ $ELASTICSEARCH_VERSION \u003d~ ^6 ]]; then"},{"line_number":203,"context_line":"        echo \"WARNING - Searchlight is not tested with ES 6.x!!!\""},{"line_number":204,"context_line":"        echo \"Installing python elasticsearch for ES 6.x\""},{"line_number":205,"context_line":"        pip_install -U $SEARCHLIGHT_DIR/elasticsearch6.txt"},{"line_number":206,"context_line":"    fi"},{"line_number":207,"context_line":"}"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# install_searchlight - Collect source and prepare"},{"line_number":210,"context_line":"function install_searchlight {"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3f79a3b5_198aa463","line":207,"range":{"start_line":195,"start_character":0,"end_line":207,"end_character":1},"updated":"2018-09-13 04:00:10.000000000","message":"This is a little dangerous as you\u0027re telling pip it\u0027s okay install eleasticsearch *and* upgrade any packages needed but you\u0027re not using constraints so you\u0027ll open yourself up to testing outside the scope of our existing CI expectations.\n\nA compromise would be to do something like(untested):\n\n  pip install -c $requirements_dir/upper-constarints.txt $requirements_dir\n  edit-constraints $requirements_dir/upper-constarints.txt eleasticsearch\n  pip install -c $requirements_dir/upper-constarints.txt install -U -r $SEARCHLIGHT_DIR/elasticsearch6.txt\n\nThat would *only* update elasticsearch.","commit_id":"bdf42158b7ee747c44960e0e6bf85320784a8fd3"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"6014fd62c2217d5b22905168fada74df8b8b777e","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    $SEARCHLIGHT_BIN_DIR/searchlight-manage --config-file $SEARCHLIGHT_CONF index sync --force"},{"line_number":193,"context_line":"}"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"# Install Searchlight\u0027s requirements"},{"line_number":196,"context_line":"# See https://elasticsearch-py.readthedocs.io/en/master/#compatibility"},{"line_number":197,"context_line":"function _setup_searchlight_dev {"},{"line_number":198,"context_line":"    setup_develop $SEARCHLIGHT_DIR"},{"line_number":199,"context_line":"    if [[ $ELASTICSEARCH_VERSION \u003d~ ^5 ]]; then"},{"line_number":200,"context_line":"        echo \"Installing python elasticsearch for ES 5.x\""},{"line_number":201,"context_line":"        pip_install -U $SEARCHLIGHT_DIR/elasticsearch5.txt"},{"line_number":202,"context_line":"    elif [[ $ELASTICSEARCH_VERSION \u003d~ ^6 ]]; then"},{"line_number":203,"context_line":"        echo \"WARNING - Searchlight is not tested with ES 6.x!!!\""},{"line_number":204,"context_line":"        echo \"Installing python elasticsearch for ES 6.x\""},{"line_number":205,"context_line":"        pip_install -U $SEARCHLIGHT_DIR/elasticsearch6.txt"},{"line_number":206,"context_line":"    fi"},{"line_number":207,"context_line":"}"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# install_searchlight - Collect source and prepare"},{"line_number":210,"context_line":"function install_searchlight {"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3f79a3b5_1c97f247","line":207,"range":{"start_line":195,"start_character":0,"end_line":207,"end_character":1},"in_reply_to":"3f79a3b5_198aa463","updated":"2018-09-13 05:50:12.000000000","message":"I updated a new patchset to add what you suggested. Let me test it out. Thanks :)","commit_id":"bdf42158b7ee747c44960e0e6bf85320784a8fd3"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"84692f0b210a0ec32e555a2c11952427515d25c5","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    if [[ $ELASTICSEARCH_VERSION \u003d~ ^5 ]]; then"},{"line_number":200,"context_line":"        echo \"Installing python elasticsearch for ES 5.x\""},{"line_number":201,"context_line":"        pip install -c $REQUIREMENTS_DIR/upper-constraints.txt $REQUIREMENTS_DIR"},{"line_number":202,"context_line":"        $REQUIREMENTS_DIR/.venv/bin/edit-constraints $REQUIREMENTS_DIR/upper-constraints.txt eleasticsearch"},{"line_number":203,"context_line":"        pip install -c $REQUIREMENTS_DIR/upper-constraints.txt install -U -r $SEARCHLIGHT_DIR/elasticsearch5.txt"},{"line_number":204,"context_line":"    elif [[ $ELASTICSEARCH_VERSION \u003d~ ^6 ]]; then"},{"line_number":205,"context_line":"        echo \"WARNING - Searchlight is not tested with ES 6.x!!!\""}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_3ca0ae91","line":202,"updated":"2018-09-13 05:53:41.000000000","message":"Oh it looks like there is a venv already installed in which case you don\u0027t need line 201","commit_id":"b0441c3416cdcbe8cd5aac1e4cb25fab23781acf"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"7a1371eb157c4be16eb05f5dc3f00fd84b18e398","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    if [[ $ELASTICSEARCH_VERSION \u003d~ ^5 ]]; then"},{"line_number":200,"context_line":"        echo \"Installing python elasticsearch for ES 5.x\""},{"line_number":201,"context_line":"        pip install -c $REQUIREMENTS_DIR/upper-constraints.txt $REQUIREMENTS_DIR"},{"line_number":202,"context_line":"        $REQUIREMENTS_DIR/.venv/bin/edit-constraints $REQUIREMENTS_DIR/upper-constraints.txt eleasticsearch"},{"line_number":203,"context_line":"        pip install -c $REQUIREMENTS_DIR/upper-constraints.txt install -U -r $SEARCHLIGHT_DIR/elasticsearch5.txt"},{"line_number":204,"context_line":"    elif [[ $ELASTICSEARCH_VERSION \u003d~ ^6 ]]; then"},{"line_number":205,"context_line":"        echo \"WARNING - Searchlight is not tested with ES 6.x!!!\""}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_7ce4e6e0","line":202,"in_reply_to":"3f79a3b5_3ca0ae91","updated":"2018-09-13 05:56:50.000000000","message":"Ah :) thanks.","commit_id":"b0441c3416cdcbe8cd5aac1e4cb25fab23781acf"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"15ac74550f5bc4d3441201b1179f89107f65d642","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    if [[ $ELASTICSEARCH_VERSION \u003d~ ^5 ]]; then"},{"line_number":200,"context_line":"        echo \"Installing python elasticsearch for ES 5.x\""},{"line_number":201,"context_line":"        pip install -c $REQUIREMENTS_DIR/upper-constraints.txt $REQUIREMENTS_DIR"},{"line_number":202,"context_line":"        $REQUIREMENTS_DIR/.venv/bin/edit-constraints $REQUIREMENTS_DIR/upper-constraints.txt eleasticsearch"},{"line_number":203,"context_line":"        pip install -c $REQUIREMENTS_DIR/upper-constraints.txt install -U -r $SEARCHLIGHT_DIR/elasticsearch5.txt"},{"line_number":204,"context_line":"    elif [[ $ELASTICSEARCH_VERSION \u003d~ ^6 ]]; then"},{"line_number":205,"context_line":"        echo \"WARNING - Searchlight is not tested with ES 6.x!!!\""}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_bdfc9c3f","line":202,"in_reply_to":"3f79a3b5_7ce4e6e0","updated":"2018-09-14 15:55:29.000000000","message":"Done","commit_id":"b0441c3416cdcbe8cd5aac1e4cb25fab23781acf"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"15ac74550f5bc4d3441201b1179f89107f65d642","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        echo \"Installing python elasticsearch for ES 5.x\""},{"line_number":201,"context_line":"        pip install -c $REQUIREMENTS_DIR/upper-constraints.txt $REQUIREMENTS_DIR"},{"line_number":202,"context_line":"        $REQUIREMENTS_DIR/.venv/bin/edit-constraints $REQUIREMENTS_DIR/upper-constraints.txt eleasticsearch"},{"line_number":203,"context_line":"        pip install -c $REQUIREMENTS_DIR/upper-constraints.txt install -U -r $SEARCHLIGHT_DIR/elasticsearch5.txt"},{"line_number":204,"context_line":"    elif [[ $ELASTICSEARCH_VERSION \u003d~ ^6 ]]; then"},{"line_number":205,"context_line":"        echo \"WARNING - Searchlight is not tested with ES 6.x!!!\""},{"line_number":206,"context_line":"        # echo \"Installing python elasticsearch for ES 6.x\""}],"source_content_type":"text/x-sh","patch_set":15,"id":"3f79a3b5_1dbcb06a","line":203,"range":{"start_line":203,"start_character":8,"end_line":203,"end_character":70},"updated":"2018-09-14 15:55:29.000000000","message":"actually, the devstack\u0027s pip_install function takes care of this already so we don\u0027t need to check upper-constraints.","commit_id":"b0441c3416cdcbe8cd5aac1e4cb25fab23781acf"}],"requirements.txt":[{"author":{"_account_id":27153,"name":"Nguyen Hai","email":"nguyentrihai93@gmail.com","username":"nguyentrihai"},"change_message_id":"c1029e37f4b00b37214787f1198c39016da8ccc5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"# elasticsearch\u003e\u003d2.0.0,\u003c3.0.0"},{"line_number":48,"context_line":"# See:"},{"line_number":49,"context_line":"# https://elasticsearch-py.readthedocs.io/en/master/#compatibility"},{"line_number":50,"context_line":"elasticsearch\u003c3.0.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Clients required for indexing plugins"},{"line_number":53,"context_line":"python-designateclient\u003e\u003d2.7.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":13,"id":"3f79a3b5_5c0b2a21","line":50,"range":{"start_line":50,"start_character":13,"end_line":50,"end_character":19},"updated":"2018-09-13 05:08:44.000000000","message":"\u003c6.0.0","commit_id":"2b34835babb5698f0ba68a94b59cfdfd894d1513"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"7111962edfeaf79d2e5982f24cca023d22a44e35","unresolved":false,"context_lines":[{"line_number":47,"context_line":"# elasticsearch\u003e\u003d2.0.0,\u003c3.0.0"},{"line_number":48,"context_line":"# See:"},{"line_number":49,"context_line":"# https://elasticsearch-py.readthedocs.io/en/master/#compatibility"},{"line_number":50,"context_line":"elasticsearch\u003c3.0.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Clients required for indexing plugins"},{"line_number":53,"context_line":"python-designateclient\u003e\u003d2.7.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":13,"id":"3f79a3b5_dcd2da5b","line":50,"range":{"start_line":50,"start_character":13,"end_line":50,"end_character":19},"in_reply_to":"3f79a3b5_5c0b2a21","updated":"2018-09-13 05:36:49.000000000","message":"We only do that after we remove ES 2.x support. Please look the devstack/plugin.sh to see the conditional requirement.","commit_id":"2b34835babb5698f0ba68a94b59cfdfd894d1513"}]}