)]}'
{"searchlight/elasticsearch/plugins/glance/__init__.py":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"628bf79c3397ac0d3c90e01618ee4aa8f90959d6","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_image_members(image):"},{"line_number":30,"context_line":"    if image[\u0027visibility\u0027] \u003d\u003d \u0027public\u0027 or image[\u0027visibility\u0027] \u003d\u003d \u0027private\u0027:"},{"line_number":31,"context_line":"        return []"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_28fbd37b","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":74},"updated":"2018-09-22 03:08:02.000000000","message":"It could be shorter as following:\n\nif image[\u0027visibility\u0027] in [\u0027public\u0027, \u0027private\u0027]:","commit_id":"5ac53fab0c515370b5f58b46be866825e8732478"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"e550518c623a616928e12ee6a4539fbf2bc68782","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_image_members(image):"},{"line_number":30,"context_line":"    if image[\u0027visibility\u0027] in [\u0027public\u0027, \u0027private\u0027]:"},{"line_number":31,"context_line":"        return []"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_6e00f3b2","line":30,"range":{"start_line":30,"start_character":42,"end_line":30,"end_character":49},"updated":"2018-09-22 12:33:38.000000000","message":"Just a quick search on Glance\u0027s docs, private images can have members [1]\n[1] https://docs.openstack.org/glance/latest/user/glanceapi.html#add-a-member-to-an-image","commit_id":"df49fdba1b07a21fd0f0966a584aa124b7470108"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"fc00799c4749fd21b6c8cb65186e7fc28e3be813","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_image_members(image):"},{"line_number":30,"context_line":"    if image[\u0027visibility\u0027] in [\u0027public\u0027, \u0027private\u0027]:"},{"line_number":31,"context_line":"        return []"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_eee163ff","line":30,"range":{"start_line":30,"start_character":42,"end_line":30,"end_character":49},"in_reply_to":"3f79a3b5_6e00f3b2","updated":"2018-09-22 12:57:09.000000000","message":"Ok, my bad, it\u0027s correct that a private image should not have members:\n\nhttps://wiki.openstack.org/wiki/Glance-v2-community-image-visibility-design","commit_id":"df49fdba1b07a21fd0f0966a584aa124b7470108"}],"searchlight/tests/unit/test_glance_image_plugin.py":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"fc00799c4749fd21b6c8cb65186e7fc28e3be813","unresolved":false,"context_lines":[{"line_number":777,"context_line":""},{"line_number":778,"context_line":"    @mock.patch(\u0027searchlight.elasticsearch.plugins.helper.IndexingHelper.\u0027"},{"line_number":779,"context_line":"                \u0027delete_document\u0027)"},{"line_number":780,"context_line":"    def test_create_or_update_exception(self, mock_delete):"},{"line_number":781,"context_line":"        notification \u003d _notification_fixture("},{"line_number":782,"context_line":"            self.members_image[\u0027id\u0027],"},{"line_number":783,"context_line":"            checksum\u003dself.members_image[\u0027checksum\u0027],"},{"line_number":784,"context_line":"            name\u003dself.members_image[\u0027name\u0027],"},{"line_number":785,"context_line":"            is_public\u003dFalse,"},{"line_number":786,"context_line":"            size\u003dself.members_image[\u0027size\u0027],"},{"line_number":787,"context_line":"            owner\u003dself.members_image[\u0027owner\u0027])"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"        with mock.patch(\u0027glanceclient.v2.image_members.Controller.list\u0027,"},{"line_number":790,"context_line":"                        side_effect\u003dglanceclient.exc.NotFound):"},{"line_number":791,"context_line":"            with mock.patch.object("},{"line_number":792,"context_line":"                    self.notification_handler,"},{"line_number":793,"context_line":"                    \u0027get_version\u0027,"},{"line_number":794,"context_line":"                    return_value\u003d\u0027fake_version\u0027):"},{"line_number":795,"context_line":"                self.notification_handler.create_or_update("},{"line_number":796,"context_line":"                    \"image.create\", notification, None)"},{"line_number":797,"context_line":"                mock_delete.assert_called_with("},{"line_number":798,"context_line":"                    {\u0027_id\u0027: self.members_image[\u0027id\u0027],"},{"line_number":799,"context_line":"                     \u0027_version\u0027: \u0027fake_version\u0027})"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def test_image_member_list(self):"},{"line_number":802,"context_line":"        with mock.patch(\u0027glanceclient.v2.image_members.Controller.list\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_4eb657fc","line":799,"range":{"start_line":780,"start_character":0,"end_line":799,"end_character":49},"updated":"2018-09-22 12:57:09.000000000","message":"Need to look into this too.","commit_id":"df49fdba1b07a21fd0f0966a584aa124b7470108"}]}