)]}'
{"id":"openstack%2Fsearchlight~657193","triplet_id":"openstack%2Fsearchlight~master~I5f2e98b59126e3e6758e5c1847f55d67fa82c039","project":"openstack/searchlight","branch":"master","topic":"self_cls","hashtags":[],"change_id":"I5f2e98b59126e3e6758e5c1847f55d67fa82c039","subject":"Do not use self in classmethod","status":"MERGED","created":"2019-05-05 03:44:06.000000000","updated":"2019-05-07 02:15:35.000000000","submitted":"2019-05-07 02:15:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"657193-1557195335029-bb67493d","meta_rev_id":"740685d5c710128ede60b28ee0652d9f1fd75f22","_number":657193,"virtual_id_number":657193,"owner":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},{"value":2,"date":"2019-05-07 02:15:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"all":[{"value":2,"date":"2019-05-07 01:54:49.000000000","_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"all":[{"value":1,"date":"2019-05-07 01:54:49.000000000","_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-07 01:54:49.000000000","updated_by":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"reviewer":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"state":"REVIEWER"},{"updated":"2019-05-07 02:15:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d64f4b1109998ed16cb10a0e7a72bf274ee7492d","author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"date":"2019-05-05 03:44:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9ef3cdf7a2f09c052f90fab027010ca5aeec7735","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-05 03:54:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/93/657193/1/check/openstack-tox-pep8/3f245be/ : SUCCESS in 3m 57s\n- openstack-tox-py27 http://logs.openstack.org/93/657193/1/check/openstack-tox-py27/8f1d807/ : SUCCESS in 6m 28s\n- openstack-tox-py36 http://logs.openstack.org/93/657193/1/check/openstack-tox-py36/0da36a6/ : SUCCESS in 6m 16s\n- openstack-tox-py37 http://logs.openstack.org/93/657193/1/check/openstack-tox-py37/73d7d45/ : SUCCESS in 6m 40s\n- openstack-tox-cover http://logs.openstack.org/93/657193/1/check/openstack-tox-cover/629cc35/cover/ : SUCCESS in 6m 28s\n- openstack-tox-docs http://logs.openstack.org/93/657193/1/check/openstack-tox-docs/5ab330c/html/ : SUCCESS in 3m 33s\n- openstack-tox-lower-constraints http://logs.openstack.org/93/657193/1/check/openstack-tox-lower-constraints/a2feae0/ : SUCCESS in 4m 51s","accounts_in_message":[],"_revision_number":1},{"id":"1e2d35c295026ae7c75252ffd41677a0079a80ff","author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"date":"2019-05-07 01:54:49.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM. Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"55a106d7f8f3a13ddd36f8cb521869537c1c7118","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-07 01:55:01.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"fec48e21174d34be843c85db1551075cb027bd26","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-07 02:15:34.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/93/657193/1/gate/openstack-tox-pep8/88bb35d/ : SUCCESS in 3m 52s\n- openstack-tox-py27 http://logs.openstack.org/93/657193/1/gate/openstack-tox-py27/63d930c/ : SUCCESS in 4m 58s\n- openstack-tox-py36 http://logs.openstack.org/93/657193/1/gate/openstack-tox-py36/1a25371/ : SUCCESS in 4m 45s\n- openstack-tox-py37 http://logs.openstack.org/93/657193/1/gate/openstack-tox-py37/bb88029/ : SUCCESS in 7m 44s\n- openstack-tox-docs http://logs.openstack.org/93/657193/1/gate/openstack-tox-docs/b423516/html/ : SUCCESS in 3m 32s\n- openstack-tox-lower-constraints http://logs.openstack.org/93/657193/1/gate/openstack-tox-lower-constraints/aba45b4/ : SUCCESS in 5m 43s","accounts_in_message":[],"_revision_number":1},{"id":"c633b9f204d704021f43d09757a4142c84aeb063","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-07 02:15:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"93c611fd3e425585d3182d9ddffb7f2890311def","revisions":{"93c611fd3e425585d3182d9ddffb7f2890311def":{"kind":"REWORK","_number":1,"created":"2019-05-05 03:44:06.000000000","uploader":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"ref":"refs/changes/93/657193/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/searchlight","ref":"refs/changes/93/657193/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/searchlight refs/changes/93/657193/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/searchlight refs/changes/93/657193/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/searchlight refs/changes/93/657193/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/searchlight refs/changes/93/657193/1"}}},"commit":{"parents":[{"commit":"3374cba06c651f4be196ad2fe8f6435fd20dfd35","subject":"Migrate to opendev.org","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/searchlight/commit/3374cba06c651f4be196ad2fe8f6435fd20dfd35"}]}],"author":{"name":"zhufl","email":"zhu.fanglei@zte.com.cn","date":"2019-05-05 03:34:41.000000000","tz":480},"committer":{"name":"zhufl","email":"zhu.fanglei@zte.com.cn","date":"2019-05-05 03:41:04.000000000","tz":480},"subject":"Do not use self in classmethod","message":"Do not use self in classmethod\n\ncls should be used in classmethd, instead of self.\nThis patch corrects this in the following places:\n    - searchlight/elasticsearch/plugins/cinder/snapshots.py\n    - searchlight/elasticsearch/plugins/cinder/volumes.py\n    - searchlight/elasticsearch/plugins/designate/recordsets.py\n    - searchlight/elasticsearch/plugins/ironic/chassis.py\n    - searchlight/elasticsearch/plugins/ironic/nodes.py\n    - searchlight/elasticsearch/plugins/ironic/ports.py\n    - searchlight/elasticsearch/plugins/neutron/networks.py\n    - searchlight/elasticsearch/plugins/neutron/ports.py\n    - searchlight/elasticsearch/plugins/neutron/routers.py\n    - searchlight/elasticsearch/plugins/neutron/security_groups.py\n    - searchlight/elasticsearch/plugins/neutron/subnets.py\n    - searchlight/elasticsearch/plugins/nova/flavors.py\n    - searchlight/elasticsearch/plugins/nova/hypervisors.py\n    - searchlight/elasticsearch/plugins/nova/servergroups.py\n    - searchlight/elasticsearch/plugins/nova/servers.py\n\nChange-Id: I5f2e98b59126e3e6758e5c1847f55d67fa82c039\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/searchlight/commit/93c611fd3e425585d3182d9ddffb7f2890311def"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/searchlight/commit/93c611fd3e425585d3182d9ddffb7f2890311def"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}