)]}'
{"doc/source/artifacts/keystonemiddleware/pike/architecture-page.rst":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7ba22a7df9b4f7a196f01ce037d65bc5376e529c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Architecture page template"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Project name architecture - version/release"},{"line_number":6,"context_line":"-------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a1ced50_48602dcf","line":3,"updated":"2017-03-17 21:35:08.000000000","message":"nit: this can be trimmed to fit the title (if it is suppose to be specific to keystonemiddleware)","commit_id":"bcd602ed4440c972eb02bd0f85e6bf60f428e27c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7ba22a7df9b4f7a196f01ce037d65bc5376e529c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Architecture page template"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Project name architecture - version/release"},{"line_number":6,"context_line":"-------------------------------------------"},{"line_number":7,"context_line":"**Status**: Draft/Ready for Review/Reviewed"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a1ced50_c8817d4c","line":5,"updated":"2017-03-17 21:35:08.000000000","message":"s/Project name/Keystonemiddleware/\n\nWe currently don\u0027t have a Pike release of keystonemiddleware, but I can create one (the latest one in Ocata was 4.14.0).","commit_id":"bcd602ed4440c972eb02bd0f85e6bf60f428e27c"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"411b785b7db46b1ec67771b14233fab636db4c07","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Architecture page template"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Project name architecture - version/release"},{"line_number":6,"context_line":"-------------------------------------------"},{"line_number":7,"context_line":"**Status**: Draft/Ready for Review/Reviewed"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a1ced50_e302ae6e","line":5,"in_reply_to":"1a1ced50_c8817d4c","updated":"2017-03-20 16:02:20.000000000","message":"Yeah I wasn\u0027t quite sure how to classify this (if we are doing this for O or P release). I can list the Ocata release and update it later if needed.","commit_id":"bcd602ed4440c972eb02bd0f85e6bf60f428e27c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7ba22a7df9b4f7a196f01ce037d65bc5376e529c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"-------------------------------------------"},{"line_number":7,"context_line":"**Status**: Draft/Ready for Review/Reviewed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"**Release**: Pike"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"**Version**: 4.14.0"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a1ced50_2891319a","line":9,"updated":"2017-03-17 21:35:08.000000000","message":"Not sure if this should be Pike or Ocata since we don\u0027t have a release of keystonemiddleware in Pike, yet. I\u0027ll defer to the opinion of other reviewers.","commit_id":"bcd602ed4440c972eb02bd0f85e6bf60f428e27c"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"411b785b7db46b1ec67771b14233fab636db4c07","unresolved":false,"context_lines":[{"line_number":6,"context_line":"-------------------------------------------"},{"line_number":7,"context_line":"**Status**: Draft/Ready for Review/Reviewed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"**Release**: Pike"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"**Version**: 4.14.0"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a1ced50_e339ce42","line":9,"in_reply_to":"1a1ced50_2891319a","updated":"2017-03-20 16:02:20.000000000","message":"I can put this for Ocata since that is the current release.","commit_id":"bcd602ed4440c972eb02bd0f85e6bf60f428e27c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7ba22a7df9b4f7a196f01ce037d65bc5376e529c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":24,"context_line":"A brief description of the purpose of the project. This should be a paragraph"},{"line_number":25,"context_line":"or two and can be cut/paste from wiki or other documentation. Include links"},{"line_number":26,"context_line":"to relevant presentations and further documentation if available."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Primary users and use-cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a1ced50_281e9163","line":26,"updated":"2017-03-17 21:35:08.000000000","message":"We could steal the description from the keystonemiddleware docs [0].\n\n[0] https://docs.openstack.org/developer/keystonemiddleware/#python-middleware-for-openstack-identity-api-keystone","commit_id":"bcd602ed4440c972eb02bd0f85e6bf60f428e27c"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"411b785b7db46b1ec67771b14233fab636db4c07","unresolved":false,"context_lines":[{"line_number":23,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":24,"context_line":"A brief description of the purpose of the project. This should be a paragraph"},{"line_number":25,"context_line":"or two and can be cut/paste from wiki or other documentation. Include links"},{"line_number":26,"context_line":"to relevant presentations and further documentation if available."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Primary users and use-cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a1ced50_434b82c9","line":26,"in_reply_to":"1a1ced50_281e9163","updated":"2017-03-20 16:02:20.000000000","message":"sure!","commit_id":"bcd602ed4440c972eb02bd0f85e6bf60f428e27c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7ba22a7df9b4f7a196f01ce037d65bc5376e529c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":31,"context_line":"A short statement about the expected primary users of the implemented"},{"line_number":32,"context_line":"architecture, \u0027users\u0027 can either be actors or other services within OpenStack."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For example:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"#. Administrators will use this tool to manage storage quotas"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a1ced50_a857e100","line":33,"updated":"2017-03-17 21:35:08.000000000","message":"The primary users of keystonemiddleware would be other services within an OpenStack deployment that require identity information supplied from OpenStack Identity (keystone).","commit_id":"bcd602ed4440c972eb02bd0f85e6bf60f428e27c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7ba22a7df9b4f7a196f01ce037d65bc5376e529c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"or became unavailable. These items are usually outside the control of the"},{"line_number":47,"context_line":"developer but within the control of the deployer, but may be operated by a"},{"line_number":48,"context_line":"third party."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"For example:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- Nova compute service is configured in accordance with security best practice."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a1ced50_0893955c","line":49,"updated":"2017-03-17 21:35:08.000000000","message":"A dependency we can list here would be the OpenStack Identity endpoint itself. Without that, keystonemiddleware is kind of stuck. Keystonemiddleware also requires a service configuration of the service it is protecting.","commit_id":"bcd602ed4440c972eb02bd0f85e6bf60f428e27c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7ba22a7df9b4f7a196f01ce037d65bc5376e529c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"~~~~~~~~~~~"},{"line_number":80,"context_line":"Data assets are user data, high-value data, configuration items, authorization"},{"line_number":81,"context_line":"tokens or other items that an attacker may target. Data assets should include a"},{"line_number":82,"context_line":"statement of where that asset is persisted."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"For example:"},{"line_number":85,"context_line":"- *ACL rules* - persisted in database"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a1ced50_087555ca","line":82,"updated":"2017-03-17 21:35:08.000000000","message":"Keystonemiddleware\u0027s configuration might be sensitive: \n\nhttps://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/_opts.py#L30","commit_id":"bcd602ed4440c972eb02bd0f85e6bf60f428e27c"},{"author":{"_account_id":17893,"name":"Luke Hinds","email":"lhinds@redhat.com","username":"lhinds"},"change_message_id":"90f304f4790d3550a699adb0470b9e4a1f4a60e6","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- PTL: Lance Bragstad - lbragstad"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- Architect: name - irc handle"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Security Reviewer: name - irc handle"},{"line_number":20,"context_line":"- Security Reviewer: name - irc handle"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f515b1d_8e63e3b1","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":30},"updated":"2017-09-25 12:33:15.000000000","message":"I think this would be you gage?","commit_id":"35a721ab04b5a8730a7f76892858c49877960361"},{"author":{"_account_id":17893,"name":"Luke Hinds","email":"lhinds@redhat.com","username":"lhinds"},"change_message_id":"90f304f4790d3550a699adb0470b9e4a1f4a60e6","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- Architect: name - irc handle"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Security Reviewer: name - irc handle"},{"line_number":20,"context_line":"- Security Reviewer: name - irc handle"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Project description and purpose"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f515b1d_2e74ef67","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":38},"updated":"2017-09-25 12:33:15.000000000","message":"I can help review here.","commit_id":"35a721ab04b5a8730a7f76892858c49877960361"},{"author":{"_account_id":17893,"name":"Luke Hinds","email":"lhinds@redhat.com","username":"lhinds"},"change_message_id":"90f304f4790d3550a699adb0470b9e4a1f4a60e6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- Architect: name - irc handle"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Security Reviewer: name - irc handle"},{"line_number":20,"context_line":"- Security Reviewer: name - irc handle"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Project description and purpose"},{"line_number":23,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f515b1d_ce68bb88","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":38},"updated":"2017-09-25 12:33:15.000000000","message":"Jeremy, would you be able to be the second reviewer?","commit_id":"35a721ab04b5a8730a7f76892858c49877960361"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3468d84f17809a802416c068e31d939079b701f7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- Architect: name - irc handle"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Security Reviewer: name - irc handle"},{"line_number":20,"context_line":"- Security Reviewer: name - irc handle"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Project description and purpose"},{"line_number":23,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f515b1d_716d2a03","line":20,"updated":"2017-09-25 13:25:25.000000000","message":"The point behind the process was to relieve VMT members from also doing in-depth analysis of deliverables proposing to be supported, but I\u0027m curious enough about how the process will work out that I\u0027m happy to get involved in one.","commit_id":"35a721ab04b5a8730a7f76892858c49877960361"},{"author":{"_account_id":17893,"name":"Luke Hinds","email":"lhinds@redhat.com","username":"lhinds"},"change_message_id":"d2247c85b0b93fbf5b7efe642e04e1f228e9f48f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- Architect: name - irc handle"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Security Reviewer: name - irc handle"},{"line_number":20,"context_line":"- Security Reviewer: name - irc handle"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Project description and purpose"},{"line_number":23,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f515b1d_82ea9272","line":20,"in_reply_to":"7f515b1d_716d2a03","updated":"2017-09-25 14:35:27.000000000","message":"I missed that snippet of info, if you could help that would be great..unfortunately the people who devised the TA process have all gone, so I am learning as we go.","commit_id":"35a721ab04b5a8730a7f76892858c49877960361"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"17b06458157d5bcaa906b52fd0fcf9079baeec07","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Architecture page template"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"keystonemiddleware architecture - 4.17.1/pike"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf659307_1f1e440c","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":26},"updated":"2018-03-23 21:19:56.000000000","message":"Does this page need to be updated yet?","commit_id":"569e06b8fdab401876ef05d2745168909595b7ae"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"5e28b497aa77ca969583b41bbe0a8f22fa886ac8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"~~~~~~~~~~~"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"- *Authorization Tokens* - persisted in memcache"},{"line_number":63,"context_line":"- *memcache encrytion keys* - persisted in keystonemiddleware.conf"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Data asset impact analysis"}],"source_content_type":"text/x-rst","patch_set":7,"id":"df7087c5_8641223c","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":21},"updated":"2018-03-23 01:53:33.000000000","message":"encryption","commit_id":"569e06b8fdab401876ef05d2745168909595b7ae"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"79f5ebceb52029e45578ba7b776830f909514112","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- *keystonemiddleware.conf*:"},{"line_number":75,"context_line":"  - Integrity Failure Impact: Attacker who can read the config file can gain"},{"line_number":76,"context_line":"    access to the memcache encryption key, which can allow them access to"},{"line_number":77,"context_line":"    all stored tokens."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf659307_3f0d4890","line":76,"range":{"start_line":76,"start_character":63,"end_line":76,"end_character":71},"updated":"2018-03-23 21:35:05.000000000","message":"and modify","commit_id":"569e06b8fdab401876ef05d2745168909595b7ae"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"79f5ebceb52029e45578ba7b776830f909514112","unresolved":false,"context_lines":[{"line_number":74,"context_line":"- *keystonemiddleware.conf*:"},{"line_number":75,"context_line":"  - Integrity Failure Impact: Attacker who can read the config file can gain"},{"line_number":76,"context_line":"    access to the memcache encryption key, which can allow them access to"},{"line_number":77,"context_line":"    all stored tokens."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Interfaces"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf659307_5f127cb3","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":14},"updated":"2018-03-23 21:35:05.000000000","message":"cached","commit_id":"569e06b8fdab401876ef05d2745168909595b7ae"}],"doc/source/artifacts/keystonemiddleware/pike/review-findings.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f604a8b4b42348a9c11af67ff58e14e4488150af","unresolved":false,"context_lines":[{"line_number":28,"context_line":"1. Security memcache with Pycrypto library"},{"line_number":29,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- Risk: Project documentation recommends use of the pycrypto libary to secure"},{"line_number":32,"context_line":"  memcache. Pycrypto is no longer maintained [0] with a last release made in"},{"line_number":33,"context_line":"  2014. Its also contains an unpatched CVE [1]."},{"line_number":34,"context_line":"- Impact: \u003cDescription of the Impact of this risk\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf659307_9f3254a7","line":31,"range":{"start_line":31,"start_character":61,"end_line":31,"end_character":67},"updated":"2018-03-23 21:19:26.000000000","message":"library","commit_id":"569e06b8fdab401876ef05d2745168909595b7ae"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f604a8b4b42348a9c11af67ff58e14e4488150af","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- Risk: Project documentation recommends use of the pycrypto libary to secure"},{"line_number":32,"context_line":"  memcache. Pycrypto is no longer maintained [0] with a last release made in"},{"line_number":33,"context_line":"  2014. Its also contains an unpatched CVE [1]."},{"line_number":34,"context_line":"- Impact: \u003cDescription of the Impact of this risk\u003e"},{"line_number":35,"context_line":"- Likelihood: Medium"},{"line_number":36,"context_line":"- Impact: Medium"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf659307_3f278867","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":11},"updated":"2018-03-23 21:19:26.000000000","message":"It","commit_id":"569e06b8fdab401876ef05d2745168909595b7ae"}]}