)]}'
{"security-guide/section_networking-services-security-best-practices.xml":[{"author":{"_account_id":14046,"name":"Chris Cannon","email":"ccannon@hp.com","username":"Helimaniac"},"change_message_id":"a82013d0991d4464955d518618b705fbf55cd817","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \u003c/listitem\u003e"},{"line_number":70,"context_line":"      \u003c/itemizedlist\u003e"},{"line_number":71,"context_line":"      \u003cpara\u003eA security group is a container for security group rules. Security groups and their rules allow administrators and tenants the ability to specify the type of traffic and direction (ingress/egress) that is allowed to pass through a virtual interface port. When a virtual interface port is created in OpenStack Networking it is associated with a security group. If a security group is not specified, the port will be associated with a \u0027default\u0027 security group. By default this group will drop all ingress traffic and allow all egress. Rules can be added to this group in order to change the behaviour.\u003c/para\u003e"},{"line_number":72,"context_line":"      \u003cpara\u003eWhen using the OpenStack Compute API to modify security groups the updated security group will be applied to all virtual interface ports on an instance. The reason for this is due to the OpenStack Compute security group APIs are instance based and not port based as found in OpenStack Networking.\u003c/para\u003e"},{"line_number":73,"context_line":"    \u003c/section\u003e"},{"line_number":74,"context_line":"    \u003csection xml:id\u003d\"networking-services-security-best-practices-quotas\"\u003e"},{"line_number":75,"context_line":"      \u003ctitle\u003eQuotas\u003c/title\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"fa32b979_9a8d21d5","line":72,"updated":"2015-06-18 16:51:17.000000000","message":"Insert a comma in the opening sentence after \"groups\".  Should be:  \"When using the OpenStack Compute API to modify security groups, the updated security group will be applied to all virtual interface ports on an instanced.\" \n\nAlso suggest modification of the final paragraph to add hyphenation for compound modifiers (i.e. instance-based and port-based), and to further simplify the sentence.  Suggest using:\n\n\"The reason for this is because the OpenStack Compute security group APIs are instance-based rather than port-based, as found in OpenStack Networking.\"","commit_id":"c8758ffd8afb5ccf59fda8f8badc0b9ea7878d36"},{"author":{"_account_id":12686,"name":"Brian Moss","email":"kallimachos@gmail.com","username":"bmoss"},"change_message_id":"c7cbba59418fb873c9376196aee049f6a46c928f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \u003c/listitem\u003e"},{"line_number":70,"context_line":"      \u003c/itemizedlist\u003e"},{"line_number":71,"context_line":"      \u003cpara\u003eA security group is a container for security group rules. Security groups and their rules allow administrators and tenants the ability to specify the type of traffic and direction (ingress/egress) that is allowed to pass through a virtual interface port. When a virtual interface port is created in OpenStack Networking it is associated with a security group. If a security group is not specified, the port will be associated with a \u0027default\u0027 security group. By default this group will drop all ingress traffic and allow all egress. Rules can be added to this group in order to change the behaviour.\u003c/para\u003e"},{"line_number":72,"context_line":"      \u003cpara\u003eWhen using the OpenStack Compute API to modify security groups, the updated security group will be applied to all virtual interface ports on an instance. The reason for this is because the OpenStack Compute security group APIs are instance-based rather than port-based, as found in OpenStack Networking.\u003c/para\u003e"},{"line_number":73,"context_line":"    \u003c/section\u003e"},{"line_number":74,"context_line":"    \u003csection xml:id\u003d\"networking-services-security-best-practices-quotas\"\u003e"},{"line_number":75,"context_line":"      \u003ctitle\u003eQuotas\u003c/title\u003e"}],"source_content_type":"application/xml","patch_set":2,"id":"fa32b979_80852b08","line":72,"updated":"2015-06-23 01:34:38.000000000","message":"Futures and passives should be avoided:\n\n\"the updated security group applies to all virtual interface ports on an instance.\"\n\nI would simplify this phrase further:\n\n\"This is due to the OpenStack Compute security group APIs being instance-based rather than port-based, as found in OpenStack Networking.\"","commit_id":"66d52b212c9a3076a2dece8b16d9762dd77a388d"},{"author":{"_account_id":14046,"name":"Chris Cannon","email":"ccannon@hp.com","username":"Helimaniac"},"change_message_id":"2625a8f4d86af14a3863c35d5f0ff494864f34eb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \u003c/listitem\u003e"},{"line_number":70,"context_line":"      \u003c/itemizedlist\u003e"},{"line_number":71,"context_line":"      \u003cpara\u003eA security group is a container for security group rules. Security groups and their rules allow administrators and tenants the ability to specify the type of traffic and direction (ingress/egress) that is allowed to pass through a virtual interface port. When a virtual interface port is created in OpenStack Networking it is associated with a security group. If a security group is not specified, the port will be associated with a \u0027default\u0027 security group. By default this group will drop all ingress traffic and allow all egress. Rules can be added to this group in order to change the behaviour.\u003c/para\u003e"},{"line_number":72,"context_line":"      \u003cpara\u003eWhen using the OpenStack Compute API to modify security groups, the updated security group applies to all virtual interface ports on an instance. This is due to the OpenStack Compute security group APIs are instance-based rather than port-based, as found in OpenStack Networking.\u003c/para\u003e"},{"line_number":73,"context_line":"    \u003c/section\u003e"},{"line_number":74,"context_line":"    \u003csection xml:id\u003d\"networking-services-security-best-practices-quotas\"\u003e"},{"line_number":75,"context_line":"      \u003ctitle\u003eQuotas\u003c/title\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"fa32b979_61068287","line":72,"updated":"2015-06-24 22:32:12.000000000","message":"Need to replace \"are\" with \"being\" in the final sentence of line 72 (see Brian M\u0027s suggestion in the previous patch review).  The correct sentence should read:  \"This is due to the OpenStack Compute security group APIs being instance-based rather than port-based, as found in OpenStack Networking.\"","commit_id":"edb3b07af6515bfa5e889f2baa08a7ebe49c9c78"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"c04572fafddbd45baa0ccf98c2ac39f70a341389","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \u003c/listitem\u003e"},{"line_number":70,"context_line":"      \u003c/itemizedlist\u003e"},{"line_number":71,"context_line":"      \u003cpara\u003eA security group is a container for security group rules. Security groups and their rules allow administrators and tenants the ability to specify the type of traffic and direction (ingress/egress) that is allowed to pass through a virtual interface port. When a virtual interface port is created in OpenStack Networking it is associated with a security group. If a security group is not specified, the port will be associated with a \u0027default\u0027 security group. By default this group will drop all ingress traffic and allow all egress. Rules can be added to this group in order to change the behaviour.\u003c/para\u003e"},{"line_number":72,"context_line":"      \u003cpara\u003eWhen using the OpenStack Compute API to modify security groups, the updated security group applies to all virtual interface ports on an instance. This is due to the OpenStack Compute security group APIs are instance-based rather than port-based, as found in OpenStack Networking.\u003c/para\u003e"},{"line_number":73,"context_line":"    \u003c/section\u003e"},{"line_number":74,"context_line":"    \u003csection xml:id\u003d\"networking-services-security-best-practices-quotas\"\u003e"},{"line_number":75,"context_line":"      \u003ctitle\u003eQuotas\u003c/title\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"fa32b979_27a08a41","line":72,"in_reply_to":"fa32b979_61068287","updated":"2015-06-24 23:37:43.000000000","message":"+1","commit_id":"edb3b07af6515bfa5e889f2baa08a7ebe49c9c78"}]}