)]}'
{"security-guide/source/dashboard/domains-dashboard-upgrades-basic-web-server-configuration.rst":[{"author":{"_account_id":10338,"name":"Daniel Speichert","email":"daniel@speichert.pl","username":"daniel"},"change_message_id":"ee262289bd8b527ca7134f87fce9a3bb968c4c09","unresolved":false,"context_lines":[{"line_number":59,"context_line":"the host or domain names that are served by the OpenStack dashboard. If you fail"},{"line_number":60,"context_line":"to configure this option or use wild card domains this can lead to security"},{"line_number":61,"context_line":"issues from non-identified traffic resulting in potential attacks."},{"line_number":62,"context_line":"If the value on the host header does not mach values in this list an error"},{"line_number":63,"context_line":"will be raised."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For further details, see the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa1b9901_5b712ca7","line":62,"updated":"2015-08-19 19:05:07.000000000","message":"typo in \"ma(t)ch\"","commit_id":"403135384ab8eaa296f6d529e16613612ac0ef13"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"21daaeec2792672badd4eec70f7e414370df95cc","unresolved":false,"context_lines":[{"line_number":56,"context_line":"~~~~~~~~~~~~~"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Configure the ``ALLOWED_HOSTS`` setting with"},{"line_number":59,"context_line":"the host or domain names that are served by the OpenStack dashboard. If you fail"},{"line_number":60,"context_line":"to configure this option or use wild card domains this can lead to security"},{"line_number":61,"context_line":"issues from non-identified traffic resulting in potential attacks."},{"line_number":62,"context_line":"If the value on the host header does not match values in this list an error"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa1b9901_0ad56e1a","line":59,"updated":"2015-08-20 15:14:42.000000000","message":"I believe that we want to recommend that the openstack admin supply host name(s)—that is, fully-qualified domain name(s)—specifically, for the ALLOWED_HOSTS setting.  I think that a domain name (meant here as anything but an FQDN) implies by definition a wildcard setting—that is, a wildcard in this context is either * by itself or, effectively, an implied subdomain wildcard.  If I\u0027m wrong about the subdomain wildcard issue, should we say that a wildcard here is, specifically, * by itself.","commit_id":"62414af92349e607cabef32c00b9e750b4ce8af8"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"338b0b243ce6d3f000990660df800a536203f0c9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"~~~~~~~~~~~~~"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Configure the ``ALLOWED_HOSTS`` setting with"},{"line_number":59,"context_line":"the host or domain names that are served by the OpenStack dashboard. If you fail"},{"line_number":60,"context_line":"to configure this option or use wild card domains this can lead to security"},{"line_number":61,"context_line":"issues from non-identified traffic resulting in potential attacks."},{"line_number":62,"context_line":"If the value on the host header does not match values in this list an error"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa1b9901_5540e606","line":59,"in_reply_to":"fa1b9901_0ad56e1a","updated":"2015-08-20 16:46:12.000000000","message":"Good point, changed wording to \u0027with the fully qualified host names\u0027.","commit_id":"62414af92349e607cabef32c00b9e750b4ce8af8"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"21daaeec2792672badd4eec70f7e414370df95cc","unresolved":false,"context_lines":[{"line_number":59,"context_line":"the host or domain names that are served by the OpenStack dashboard. If you fail"},{"line_number":60,"context_line":"to configure this option or use wild card domains this can lead to security"},{"line_number":61,"context_line":"issues from non-identified traffic resulting in potential attacks."},{"line_number":62,"context_line":"If the value on the host header does not match values in this list an error"},{"line_number":63,"context_line":"will be raised."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For further details, see the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa1b9901_aa948242","line":62,"updated":"2015-08-20 15:14:42.000000000","message":"Suggest making things a bit more explict by specifying that the Host request is on the HTTP header.","commit_id":"62414af92349e607cabef32c00b9e750b4ce8af8"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"21daaeec2792672badd4eec70f7e414370df95cc","unresolved":false,"context_lines":[{"line_number":60,"context_line":"to configure this option or use wild card domains this can lead to security"},{"line_number":61,"context_line":"issues from non-identified traffic resulting in potential attacks."},{"line_number":62,"context_line":"If the value on the host header does not match values in this list an error"},{"line_number":63,"context_line":"will be raised."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For further details, see the"},{"line_number":66,"context_line":"`Django documentation \u003chttps://docs.djangoproject.com/\u003e`_."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa1b9901_2a32b25f","line":63,"updated":"2015-08-20 15:14:42.000000000","message":"Suggest a slight rewording of the description of the implications of an absent or wildcard ALLOWED_HOST setting.  Also, suggest moving this sentence after the first.\n\nTo address these first points, possible rewording might be:\n\nConfigure the ``ALLOWED_HOSTS`` setting with a list of the host name(s) [and/or domain names??] that may be served by the OpenStack dashboard.  Once this setting is provided, then if the value of the Host header in an incoming HTTP does not match any of the values in the list, an error will be raised and the requester will not be able to proceed. Failing to configure this option or using wildcard names will allow the Dashboard to be vulnerable to security breaches associated with fake HTTP Host headers.","commit_id":"62414af92349e607cabef32c00b9e750b4ce8af8"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"338b0b243ce6d3f000990660df800a536203f0c9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"to configure this option or use wild card domains this can lead to security"},{"line_number":61,"context_line":"issues from non-identified traffic resulting in potential attacks."},{"line_number":62,"context_line":"If the value on the host header does not match values in this list an error"},{"line_number":63,"context_line":"will be raised."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For further details, see the"},{"line_number":66,"context_line":"`Django documentation \u003chttps://docs.djangoproject.com/\u003e`_."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa1b9901_f8eb31da","line":63,"in_reply_to":"fa1b9901_2a32b25f","updated":"2015-08-20 16:46:12.000000000","message":"I had the same sentiment regarding sentence reordering.","commit_id":"62414af92349e607cabef32c00b9e750b4ce8af8"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"21daaeec2792672badd4eec70f7e414370df95cc","unresolved":false,"context_lines":[{"line_number":63,"context_line":"will be raised."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For further details, see the"},{"line_number":66,"context_line":"`Django documentation \u003chttps://docs.djangoproject.com/\u003e`_."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Horizon image upload"},{"line_number":69,"context_line":"~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa1b9901_aa6c8235","line":66,"updated":"2015-08-20 15:14:42.000000000","message":"Do we want to  point the reader to the specific DJango doc page that describes this setting (https://docs.djangoproject.com/en/1.8/ref/settings/). (Downside: that would necessarily link to a specific Django version.)","commit_id":"62414af92349e607cabef32c00b9e750b4ce8af8"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"338b0b243ce6d3f000990660df800a536203f0c9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"will be raised."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For further details, see the"},{"line_number":66,"context_line":"`Django documentation \u003chttps://docs.djangoproject.com/\u003e`_."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Horizon image upload"},{"line_number":69,"context_line":"~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa1b9901_558226c9","line":66,"in_reply_to":"fa1b9901_aa6c8235","updated":"2015-08-20 16:46:12.000000000","message":"I think it would be better to avoid adding that technical debt; if we assume the reader is able to divine the location of the specific document, then leaving it less specific means less chance for documentation rot over time.","commit_id":"62414af92349e607cabef32c00b9e750b4ce8af8"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"89c83878318db26d9e3f66f3b6b805d0ce16df34","unresolved":false,"context_lines":[{"line_number":60,"context_line":"the value in the \"Host:\" header of an incoming HTTP request does not match any"},{"line_number":61,"context_line":"of the values in this list an error will be raised and the requestor will not"},{"line_number":62,"context_line":"be able to proceed.  Failing to configure this option, or the use of wild card"},{"line_number":63,"context_line":"characters in the specified host names, will cause the Dashboard to be"},{"line_number":64,"context_line":"vulnerable to security breaches associated with fake HTTP Host headers."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"For further details, see the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa1b9901_032f54f7","line":63,"updated":"2015-08-21 16:44:41.000000000","message":"lowercase dashboard according to conventions and also consistent with e.g. line 59.","commit_id":"f3072fa4eaeb29685104caf86763b45df4ca2d59"}]}