)]}'
{"security-guide/source/security-review.rst":[{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"04241c070ce698fee222ca12c487a2f063e2bde9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"The goal of security review in the OpenStack community is to identify"},{"line_number":6,"context_line":"weaknesses in design or implementation of OpenStack projects. While rare,"},{"line_number":7,"context_line":"these weaknesses could potentially have catestrophic effects on the security of"},{"line_number":8,"context_line":"an OpenStack deployment, and therefore work should be undertaken to minimise"},{"line_number":9,"context_line":"the likelihood of these defects in released projects. The OpenStack Security"},{"line_number":10,"context_line":"Project assert that after a security review the following are known and"},{"line_number":11,"context_line":"documented:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_a831faa3","line":8,"updated":"2016-08-18 16:24:07.000000000","message":"minimize :P","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"ce388675f26b518ebeffffb72a956f565ec1e392","unresolved":false,"context_lines":[{"line_number":7,"context_line":"these weaknesses could potentially have catestrophic effects on the security of"},{"line_number":8,"context_line":"an OpenStack deployment, and therefore work should be undertaken to minimise"},{"line_number":9,"context_line":"the likelihood of these defects in released projects. The OpenStack Security"},{"line_number":10,"context_line":"Project assert that after a security review the following are known and"},{"line_number":11,"context_line":"documented:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- All entry points into a system"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_e8e93280","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":27},"updated":"2016-08-18 17:13:38.000000000","message":"perhaps something like:\nonce a security review of a project has been completed, the following are known and documented:","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"04241c070ce698fee222ca12c487a2f063e2bde9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- Where data is persisted"},{"line_number":16,"context_line":"- How data travels between components of the system"},{"line_number":17,"context_line":"- Data formats and transformations"},{"line_number":18,"context_line":"- External dependencies of the project"},{"line_number":19,"context_line":"- Threat actors which the project is defending against (and not defending"},{"line_number":20,"context_line":"  against)"},{"line_number":21,"context_line":"- The impact of degrading security controls"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_083acee6","line":18,"updated":"2016-08-18 16:24:07.000000000","message":"I like external dependencies but we have to draw some line.  For example are we talking about any third party libraries?","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"04241c070ce698fee222ca12c487a2f063e2bde9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- How data travels between components of the system"},{"line_number":17,"context_line":"- Data formats and transformations"},{"line_number":18,"context_line":"- External dependencies of the project"},{"line_number":19,"context_line":"- Threat actors which the project is defending against (and not defending"},{"line_number":20,"context_line":"  against)"},{"line_number":21,"context_line":"- The impact of degrading security controls"},{"line_number":22,"context_line":"- An agreed set of findings and/or defects"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_080bee7d","line":19,"updated":"2016-08-18 16:24:07.000000000","message":"I\u0027d like to remove threat actors","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"ce388675f26b518ebeffffb72a956f565ec1e392","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- Data formats and transformations"},{"line_number":18,"context_line":"- External dependencies of the project"},{"line_number":19,"context_line":"- Threat actors which the project is defending against (and not defending"},{"line_number":20,"context_line":"  against)"},{"line_number":21,"context_line":"- The impact of degrading security controls"},{"line_number":22,"context_line":"- An agreed set of findings and/or defects"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_e845b26e","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":9},"updated":"2016-08-18 17:13:38.000000000","message":"Somewhat academic, I like the threat actor triangle as much as anyone but for OpenStack projects outside of Gov (which should have it\u0027s own review processes) the actors will likely always be the same. I\u0027m not sure it adds much in terms of value.","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"ce388675f26b518ebeffffb72a956f565ec1e392","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- External dependencies of the project"},{"line_number":19,"context_line":"- Threat actors which the project is defending against (and not defending"},{"line_number":20,"context_line":"  against)"},{"line_number":21,"context_line":"- The impact of degrading security controls"},{"line_number":22,"context_line":"- An agreed set of findings and/or defects"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"A common reason to perform a security review on an OpenStack project is to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_e8b77282","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":12},"updated":"2016-08-18 17:13:38.000000000","message":"While I think it makes sense for organisations like IBM or HPE to have this requirement, I\u0027m not convinced it makes as much sense for upstream openstack.","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"04241c070ce698fee222ca12c487a2f063e2bde9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- External dependencies of the project"},{"line_number":19,"context_line":"- Threat actors which the project is defending against (and not defending"},{"line_number":20,"context_line":"  against)"},{"line_number":21,"context_line":"- The impact of degrading security controls"},{"line_number":22,"context_line":"- An agreed set of findings and/or defects"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"A common reason to perform a security review on an OpenStack project is to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_68ec22bb","line":21,"updated":"2016-08-18 16:24:07.000000000","message":"maybe remove this?","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"04241c070ce698fee222ca12c487a2f063e2bde9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"architectural review of the best practice deployment for a project is an"},{"line_number":36,"context_line":"appropriate form of security review, balancing the need for review with the"},{"line_number":37,"context_line":"resource requirements for a project of the scale of OpenStack. Security"},{"line_number":38,"context_line":"architecture review is also often refered to as *threat analysis*, *security"},{"line_number":39,"context_line":"analysis* or *threat modelling*, in the context of OpenStack security review"},{"line_number":40,"context_line":"these terms are synonamous for an architectural security review which may"},{"line_number":41,"context_line":"identify defects in the design of a project or reference architecture, and may"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_c8c9d627","line":38,"updated":"2016-08-18 16:24:07.000000000","message":"referred","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"04241c070ce698fee222ca12c487a2f063e2bde9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"resource requirements for a project of the scale of OpenStack. Security"},{"line_number":38,"context_line":"architecture review is also often refered to as *threat analysis*, *security"},{"line_number":39,"context_line":"analysis* or *threat modelling*, in the context of OpenStack security review"},{"line_number":40,"context_line":"these terms are synonamous for an architectural security review which may"},{"line_number":41,"context_line":"identify defects in the design of a project or reference architecture, and may"},{"line_number":42,"context_line":"lead to further investigative work to verify parts of the implementation."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_28d98af3","line":40,"updated":"2016-08-18 16:24:07.000000000","message":"synonymous","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"04241c070ce698fee222ca12c487a2f063e2bde9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"There are two routes that an OpenStack project may take to completing a"},{"line_number":45,"context_line":"security review:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"#. Review by OpenStack Security Project."},{"line_number":48,"context_line":"#. Review by third party review body, with validation by OpenStack Security"},{"line_number":49,"context_line":"   Project."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_688d42d2","line":47,"updated":"2016-08-18 16:24:07.000000000","message":"remove \u0027.\u0027 here","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"04241c070ce698fee222ca12c487a2f063e2bde9","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"#. Review by OpenStack Security Project."},{"line_number":48,"context_line":"#. Review by third party review body, with validation by OpenStack Security"},{"line_number":49,"context_line":"   Project."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Security review by the OSSP is expected to be the normal route for new projects"},{"line_number":52,"context_line":"and for cases where third parties have not performed security reviews or are"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_48b32698","line":49,"updated":"2016-08-18 16:24:07.000000000","message":"Remove . at the end of this?","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"these weaknesses could potentially have catestrophic effects on the security of"},{"line_number":8,"context_line":"an OpenStack deployment, and therefore work should be undertaken to minimize"},{"line_number":9,"context_line":"the likelihood of these defects in released projects. The OpenStack Security"},{"line_number":10,"context_line":"Project assert that once a security review of a project has been completed,"},{"line_number":11,"context_line":"the following are known and documented:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- All entry points into a system"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_eedbe74d","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":14},"updated":"2016-10-17 15:47:54.000000000","message":"nit: asserts","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"these weaknesses could potentially have catestrophic effects on the security of"},{"line_number":8,"context_line":"an OpenStack deployment, and therefore work should be undertaken to minimize"},{"line_number":9,"context_line":"the likelihood of these defects in released projects. The OpenStack Security"},{"line_number":10,"context_line":"Project assert that once a security review of a project has been completed,"},{"line_number":11,"context_line":"the following are known and documented:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- All entry points into a system"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_c1b431d6","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":14},"in_reply_to":"fa6399be_eedbe74d","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- How data travels between components of the system"},{"line_number":17,"context_line":"- Data formats and transformations"},{"line_number":18,"context_line":"- External dependencies of the project"},{"line_number":19,"context_line":"- An agreed set of findings and/or defects"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"A common reason to perform a security review on an OpenStack project is to"},{"line_number":22,"context_line":"enable that project to achieve the *vulnerability:managed* governance tag. The"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_6ec7d764","line":19,"range":{"start_line":19,"start_character":15,"end_line":19,"end_character":16},"updated":"2016-10-17 15:47:54.000000000","message":"Should there be one more: How the project interacts with external dependencies?","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- How data travels between components of the system"},{"line_number":17,"context_line":"- Data formats and transformations"},{"line_number":18,"context_line":"- External dependencies of the project"},{"line_number":19,"context_line":"- An agreed set of findings and/or defects"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"A common reason to perform a security review on an OpenStack project is to"},{"line_number":22,"context_line":"enable that project to achieve the *vulnerability:managed* governance tag. The"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_21eb2db2","line":19,"range":{"start_line":19,"start_character":15,"end_line":19,"end_character":16},"in_reply_to":"fa6399be_6ec7d764","updated":"2016-10-17 17:35:04.000000000","message":"Good point, I have added this.","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- External dependencies of the project"},{"line_number":19,"context_line":"- An agreed set of findings and/or defects"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"A common reason to perform a security review on an OpenStack project is to"},{"line_number":22,"context_line":"enable that project to achieve the *vulnerability:managed* governance tag. The"},{"line_number":23,"context_line":"OpenStack Vulnerability Management Team (VMT) applies the"},{"line_number":24,"context_line":"`vulnerability:managed tag"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_ce8b831d","line":21,"range":{"start_line":21,"start_character":9,"end_line":21,"end_character":15},"updated":"2016-10-17 15:47:54.000000000","message":"nit: is `argument` better?","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- External dependencies of the project"},{"line_number":19,"context_line":"- An agreed set of findings and/or defects"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"A common reason to perform a security review on an OpenStack project is to"},{"line_number":22,"context_line":"enable that project to achieve the *vulnerability:managed* governance tag. The"},{"line_number":23,"context_line":"OpenStack Vulnerability Management Team (VMT) applies the"},{"line_number":24,"context_line":"`vulnerability:managed tag"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_01fd496e","line":21,"range":{"start_line":21,"start_character":9,"end_line":21,"end_character":15},"in_reply_to":"fa6399be_ce8b831d","updated":"2016-10-17 17:35:04.000000000","message":"Dont like argument here, will leave it and then improve later, maybe.","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"identify defects in the design of a project or reference architecture, and may"},{"line_number":39,"context_line":"lead to further investigative work to verify parts of the implementation."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"There are two routes that an OpenStack project may take to completing a"},{"line_number":42,"context_line":"security review:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#. Review by OpenStack Security Project"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_2ec95f5b","line":41,"range":{"start_line":41,"start_character":59,"end_line":41,"end_character":69},"updated":"2016-10-17 15:47:54.000000000","message":"complete","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"identify defects in the design of a project or reference architecture, and may"},{"line_number":39,"context_line":"lead to further investigative work to verify parts of the implementation."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"There are two routes that an OpenStack project may take to completing a"},{"line_number":42,"context_line":"security review:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#. Review by OpenStack Security Project"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_c12991f4","line":41,"range":{"start_line":41,"start_character":59,"end_line":41,"end_character":69},"in_reply_to":"fa6399be_2ec95f5b","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"There are two routes that an OpenStack project may take to completing a"},{"line_number":42,"context_line":"security review:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#. Review by OpenStack Security Project"},{"line_number":45,"context_line":"#. Review by third party review body, with validation by OpenStack Security"},{"line_number":46,"context_line":"   Project"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_8ed7cbec","line":44,"range":{"start_line":44,"start_character":32,"end_line":44,"end_character":39},"updated":"2016-10-17 15:47:54.000000000","message":"nit: project","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"There are two routes that an OpenStack project may take to completing a"},{"line_number":42,"context_line":"security review:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#. Review by OpenStack Security Project"},{"line_number":45,"context_line":"#. Review by third party review body, with validation by OpenStack Security"},{"line_number":46,"context_line":"   Project"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_01346948","line":44,"range":{"start_line":44,"start_character":32,"end_line":44,"end_character":39},"in_reply_to":"fa6399be_8ed7cbec","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"security review:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#. Review by OpenStack Security Project"},{"line_number":45,"context_line":"#. Review by third party review body, with validation by OpenStack Security"},{"line_number":46,"context_line":"   Project"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Security review by the OSSP is expected to be the normal route for new projects"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_0e101ba8","line":45,"range":{"start_line":45,"start_character":54,"end_line":45,"end_character":56},"updated":"2016-10-17 15:47:54.000000000","message":"should this be `from` ?","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"security review:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#. Review by OpenStack Security Project"},{"line_number":45,"context_line":"#. Review by third party review body, with validation by OpenStack Security"},{"line_number":46,"context_line":"   Project"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Security review by the OSSP is expected to be the normal route for new projects"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_010b897e","line":45,"range":{"start_line":45,"start_character":54,"end_line":45,"end_character":56},"in_reply_to":"fa6399be_0e101ba8","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#. Review by OpenStack Security Project"},{"line_number":45,"context_line":"#. Review by third party review body, with validation by OpenStack Security"},{"line_number":46,"context_line":"   Project"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Security review by the OSSP is expected to be the normal route for new projects"},{"line_number":49,"context_line":"and for cases where third parties have not performed security reviews or are"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_4e221303","line":46,"range":{"start_line":46,"start_character":3,"end_line":46,"end_character":10},"updated":"2016-10-17 15:47:54.000000000","message":"nit: project","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Security review by the OSSP is expected to be the normal route for new projects"},{"line_number":49,"context_line":"and for cases where third parties have not performed security reviews or are"},{"line_number":50,"context_line":"unable to share their results. Information for projects who require a security"},{"line_number":51,"context_line":"review by the OSSP is avaiable in"},{"line_number":52,"context_line":":doc:`security-review/openstack-security-review-process`."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_ce638340","line":50,"range":{"start_line":50,"start_character":56,"end_line":50,"end_character":59},"updated":"2016-10-17 15:47:54.000000000","message":"nit: that","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Security review by the OSSP is expected to be the normal route for new projects"},{"line_number":49,"context_line":"and for cases where third parties have not performed security reviews or are"},{"line_number":50,"context_line":"unable to share their results. Information for projects who require a security"},{"line_number":51,"context_line":"review by the OSSP is avaiable in"},{"line_number":52,"context_line":":doc:`security-review/openstack-security-review-process`."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_c177d106","line":50,"range":{"start_line":50,"start_character":56,"end_line":50,"end_character":59},"in_reply_to":"fa6399be_ce638340","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":52,"context_line":":doc:`security-review/openstack-security-review-process`."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"In cases where a security review has already been performed by a third party,"},{"line_number":55,"context_line":"or where a project prefers to use a third party to perform their review, there"},{"line_number":56,"context_line":"is information on how to take the output of that third party review and submit"},{"line_number":57,"context_line":"it to the OSSP for validation available here:"},{"line_number":58,"context_line":":doc:`security-review/third-party-security-review-process`."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_4e85b3ab","line":56,"range":{"start_line":55,"start_character":72,"end_line":56,"end_character":3},"updated":"2016-10-17 15:47:54.000000000","message":"this is not needed, please remove","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":52,"context_line":":doc:`security-review/openstack-security-review-process`."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"In cases where a security review has already been performed by a third party,"},{"line_number":55,"context_line":"or where a project prefers to use a third party to perform their review, there"},{"line_number":56,"context_line":"is information on how to take the output of that third party review and submit"},{"line_number":57,"context_line":"it to the OSSP for validation available here:"},{"line_number":58,"context_line":":doc:`security-review/third-party-security-review-process`."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_6169a525","line":56,"range":{"start_line":55,"start_character":72,"end_line":56,"end_character":3},"in_reply_to":"fa6399be_4e85b3ab","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"In cases where a security review has already been performed by a third party,"},{"line_number":55,"context_line":"or where a project prefers to use a third party to perform their review, there"},{"line_number":56,"context_line":"is information on how to take the output of that third party review and submit"},{"line_number":57,"context_line":"it to the OSSP for validation available here:"},{"line_number":58,"context_line":":doc:`security-review/third-party-security-review-process`."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"In either case, the requirements for documentation artifacts are similar - the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_4eacd335","line":57,"range":{"start_line":57,"start_character":29,"end_line":57,"end_character":30},"updated":"2016-10-17 15:47:54.000000000","message":"is","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"In cases where a security review has already been performed by a third party,"},{"line_number":55,"context_line":"or where a project prefers to use a third party to perform their review, there"},{"line_number":56,"context_line":"is information on how to take the output of that third party review and submit"},{"line_number":57,"context_line":"it to the OSSP for validation available here:"},{"line_number":58,"context_line":":doc:`security-review/third-party-security-review-process`."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"In either case, the requirements for documentation artifacts are similar - the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_e163f53f","line":57,"range":{"start_line":57,"start_character":29,"end_line":57,"end_character":30},"in_reply_to":"fa6399be_4eacd335","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"to projects where the report reception and disclosure of vulnerabilities is"},{"line_number":28,"context_line":"managed by the VMT, but one of the requirements for gaining the tag is that"},{"line_number":29,"context_line":"some form of security review, audit or threat analysis has been performed on"},{"line_number":30,"context_line":"the project."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The OpenStack Security Project (OSSP) has worked with the VMT to agree that an"},{"line_number":33,"context_line":"architectural review of the best practice deployment for a project is an"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_b0a9457e","line":30,"updated":"2016-10-17 18:53:35.000000000","message":"Bit of an awkward sentence, if you\u0027re doing other changes, maybe something like the below? (otherwise, please feel free to disregard if this is the only comment)\n\nThe OpenStack Vulnerability Management Team (VMT) applies the `vulnerability:managed tag \u003clink\u003e`__ to projects where the report reception and disclosure of vulnerabilities is managed by the VMT. One of the requirements for gaining the tag is that a security review, audit, or threat analysis has been performed on the project.","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"to projects where the report reception and disclosure of vulnerabilities is"},{"line_number":28,"context_line":"managed by the VMT, but one of the requirements for gaining the tag is that"},{"line_number":29,"context_line":"some form of security review, audit or threat analysis has been performed on"},{"line_number":30,"context_line":"the project."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The OpenStack Security Project (OSSP) has worked with the VMT to agree that an"},{"line_number":33,"context_line":"architectural review of the best practice deployment for a project is an"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_c8ffeda8","line":30,"in_reply_to":"fa6399be_b0a9457e","updated":"2016-10-17 19:54:02.000000000","message":"Done","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"appropriate form of security review, balancing the need for review with the"},{"line_number":35,"context_line":"resource requirements for a project of the scale of OpenStack. Security"},{"line_number":36,"context_line":"architecture review is also often referred to as *threat analysis*, *security"},{"line_number":37,"context_line":"analysis* or *threat modelling*, in the context of OpenStack security review"},{"line_number":38,"context_line":"these terms are synonymous for an architectural security review which may"},{"line_number":39,"context_line":"identify defects in the design of a project or reference architecture, and may"},{"line_number":40,"context_line":"lead to further investigative work to verify parts of the implementation."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_70cded5c","line":37,"range":{"start_line":37,"start_character":21,"end_line":37,"end_character":30},"updated":"2016-10-17 18:53:35.000000000","message":"I believe modeling should be one \u0027l\u0027","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"appropriate form of security review, balancing the need for review with the"},{"line_number":35,"context_line":"resource requirements for a project of the scale of OpenStack. Security"},{"line_number":36,"context_line":"architecture review is also often referred to as *threat analysis*, *security"},{"line_number":37,"context_line":"analysis* or *threat modelling*, in the context of OpenStack security review"},{"line_number":38,"context_line":"these terms are synonymous for an architectural security review which may"},{"line_number":39,"context_line":"identify defects in the design of a project or reference architecture, and may"},{"line_number":40,"context_line":"lead to further investigative work to verify parts of the implementation."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_e8867115","line":37,"range":{"start_line":37,"start_character":21,"end_line":37,"end_character":30},"in_reply_to":"fa6399be_70cded5c","updated":"2016-10-17 19:54:02.000000000","message":"Done","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"There are two routes that an OpenStack project may take to complete a security"},{"line_number":43,"context_line":"review:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"#. Review by OpenStack Security project"},{"line_number":46,"context_line":"#. Review by a third party review body, with validation from the OpenStack"},{"line_number":47,"context_line":"   Security project"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_f02e5df9","line":45,"range":{"start_line":45,"start_character":23,"end_line":45,"end_character":31},"updated":"2016-10-17 18:53:35.000000000","message":"I\u0027m confused - is this an individual review done by someone in the project looking to complete the security review? Or by the \"Security Project\" group? I personally would like to leave this as \"Project\" unless the style guide says otherwise. I will research this.","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"There are two routes that an OpenStack project may take to complete a security"},{"line_number":43,"context_line":"review:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"#. Review by OpenStack Security project"},{"line_number":46,"context_line":"#. Review by a third party review body, with validation from the OpenStack"},{"line_number":47,"context_line":"   Security project"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_c8728d49","line":45,"range":{"start_line":45,"start_character":23,"end_line":45,"end_character":31},"in_reply_to":"fa6399be_f02e5df9","updated":"2016-10-17 19:54:02.000000000","message":"Done","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"#. Review by OpenStack Security project"},{"line_number":46,"context_line":"#. Review by a third party review body, with validation from the OpenStack"},{"line_number":47,"context_line":"   Security project"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Security review by the OSSP is expected to be the normal route for new projects"},{"line_number":50,"context_line":"and for cases where third parties have not performed security reviews or are"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_3039b542","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":19},"updated":"2016-10-17 18:53:35.000000000","message":"Same as above","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"#. Review by OpenStack Security project"},{"line_number":46,"context_line":"#. Review by a third party review body, with validation from the OpenStack"},{"line_number":47,"context_line":"   Security project"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Security review by the OSSP is expected to be the normal route for new projects"},{"line_number":50,"context_line":"and for cases where third parties have not performed security reviews or are"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_489d9d58","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":19},"in_reply_to":"fa6399be_3039b542","updated":"2016-10-17 19:54:02.000000000","message":"Done","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Security review by the OSSP is expected to be the normal route for new projects"},{"line_number":50,"context_line":"and for cases where third parties have not performed security reviews or are"},{"line_number":51,"context_line":"unable to share their results. Information for projects that require a security"},{"line_number":52,"context_line":"review by the OSSP will be avaiable in the upcoming security review process."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"In cases where a security review has already been performed by a third party,"},{"line_number":55,"context_line":"or where a project prefers to use a third party to perform their review,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_6b0fbe2e","line":52,"range":{"start_line":52,"start_character":27,"end_line":52,"end_character":35},"updated":"2016-10-17 18:53:35.000000000","message":"available","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Security review by the OSSP is expected to be the normal route for new projects"},{"line_number":50,"context_line":"and for cases where third parties have not performed security reviews or are"},{"line_number":51,"context_line":"unable to share their results. Information for projects that require a security"},{"line_number":52,"context_line":"review by the OSSP will be avaiable in the upcoming security review process."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"In cases where a security review has already been performed by a third party,"},{"line_number":55,"context_line":"or where a project prefers to use a third party to perform their review,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_08648547","line":52,"range":{"start_line":52,"start_character":27,"end_line":52,"end_character":35},"in_reply_to":"fa6399be_6b0fbe2e","updated":"2016-10-17 19:54:02.000000000","message":"Done","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"In cases where a security review has already been performed by a third party,"},{"line_number":55,"context_line":"or where a project prefers to use a third party to perform their review,"},{"line_number":56,"context_line":"information on how to take the output of that third party review and submit it"},{"line_number":57,"context_line":"to the OSSP for validation will be avaiable in the upcoming third party"},{"line_number":58,"context_line":"security review process."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"In either case, the requirements for documentation artifacts are similar - the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_ab19d67b","line":57,"range":{"start_line":57,"start_character":35,"end_line":57,"end_character":43},"updated":"2016-10-17 18:53:35.000000000","message":"available","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"In cases where a security review has already been performed by a third party,"},{"line_number":55,"context_line":"or where a project prefers to use a third party to perform their review,"},{"line_number":56,"context_line":"information on how to take the output of that third party review and submit it"},{"line_number":57,"context_line":"to the OSSP for validation will be avaiable in the upcoming third party"},{"line_number":58,"context_line":"security review process."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"In either case, the requirements for documentation artifacts are similar - the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_6853416d","line":57,"range":{"start_line":57,"start_character":35,"end_line":57,"end_character":43},"in_reply_to":"fa6399be_ab19d67b","updated":"2016-10-17 19:54:02.000000000","message":"Done","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":7473,"name":"Grant Murphy","email":"grantcmurphy@gmail.com","username":"gm"},"change_message_id":"3ca38ee2939c1e76b2202bdae1bd50cfa111880b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"The goal of security review in the OpenStack community is to identify"},{"line_number":6,"context_line":"weaknesses in design or implementation of OpenStack projects. While rare,"},{"line_number":7,"context_line":"these weaknesses could potentially have catestrophic effects on the security of"},{"line_number":8,"context_line":"an OpenStack deployment, and therefore work should be undertaken to minimize"},{"line_number":9,"context_line":"the likelihood of these defects in released projects. The OpenStack Security"},{"line_number":10,"context_line":"Project asserts that once a security review of a project has been completed,"},{"line_number":11,"context_line":"the following are known and documented:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_4e0da536","line":8,"updated":"2016-10-17 20:17:03.000000000","message":"catestrophic \u003d catastrophic","commit_id":"95b56f407dca889e3504c8f67950c4bfa116c360"}],"security-guide/source/security-review/architecture-diagram-guidance.rst":[{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"ce388675f26b518ebeffffb72a956f565ec1e392","unresolved":false,"context_lines":[{"line_number":6,"context_line":"--------------------------"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"This page provides guidance on architecture diagrams for threat"},{"line_number":9,"context_line":"analysis, a template for architecture documentation is available at \u003clink\u003e."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Two types of diagrams are required for threat analysis:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_c301b706","line":9,"range":{"start_line":9,"start_character":69,"end_line":9,"end_character":73},"updated":"2016-08-18 17:13:38.000000000","message":"just a reminder to update this with an actual URL","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"ce388675f26b518ebeffffb72a956f565ec1e392","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Two types of diagrams are required for threat analysis:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"-  A service architecture diagram"},{"line_number":14,"context_line":"-  One or more information flow diagrams (either data flow diagrams,"},{"line_number":15,"context_line":"   sequence diagrams, or both)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Examples of each of these are given below. There are no firm diagramming"},{"line_number":18,"context_line":"toolchain requirements, but the tool used must be able to draw the diagrams"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_6780cc8c","line":15,"range":{"start_line":14,"start_character":24,"end_line":15,"end_character":24},"updated":"2016-08-18 17:13:38.000000000","message":"I\u0027d like to consider this as an optional thing. Either driven by us: \"Can we have a sequence diagram for X\" or by those creating the documentation.","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"ce388675f26b518ebeffffb72a956f565ec1e392","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Examples of each of these are given below. There are no firm diagramming"},{"line_number":18,"context_line":"toolchain requirements, but the tool used must be able to draw the diagrams"},{"line_number":19,"context_line":"discussed. It is generally preferable to use a text-based diagram"},{"line_number":20,"context_line":"generator so diagrams can be managed with gerrit. Some options for tools"},{"line_number":21,"context_line":"include:"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- draw.io (proprietary XML files, but very easy to use)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_4344a748","line":20,"updated":"2016-08-18 17:13:38.000000000","message":"While I agree with text based diagram generation in general, I\u0027m not sure it adds anything to call it out here, I think it may complicate things","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"ce388675f26b518ebeffffb72a956f565ec1e392","unresolved":false,"context_lines":[{"line_number":40,"context_line":"-  Components"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"   -  A rectangle containing a unique name is used to depict each"},{"line_number":43,"context_line":"      component"},{"line_number":44,"context_line":"   -  Components may be servers, clusters, or individual"},{"line_number":45,"context_line":"      processes"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_e4815ac5","line":43,"updated":"2016-08-18 17:13:38.000000000","message":"Do users count as components or should they have a different shape?","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"ce388675f26b518ebeffffb72a956f565ec1e392","unresolved":false,"context_lines":[{"line_number":52,"context_line":"         queue (use an elongated rectangle if horizontal cylinders are"},{"line_number":53,"context_line":"         unavailable)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"   -  A dashed rectangle indicates a future component"},{"line_number":56,"context_line":"   -  Multi-instances of a component should be indicated by a quantity after"},{"line_number":57,"context_line":"      the component name, for example (100), and if possible layered component"},{"line_number":58,"context_line":"      boxes"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_07c63849","line":55,"updated":"2016-08-18 17:13:38.000000000","message":"So far I\u0027ve used dotted line shapes to indicate third party things - things the system uses (like a logging system) but doesn\u0027t manage","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"ce388675f26b518ebeffffb72a956f565ec1e392","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   -  A dashed rectangle indicates a future component"},{"line_number":56,"context_line":"   -  Multi-instances of a component should be indicated by a quantity after"},{"line_number":57,"context_line":"      the component name, for example (100), and if possible layered component"},{"line_number":58,"context_line":"      boxes"},{"line_number":59,"context_line":"   -  Component shapes don’t need to be all the same size. Some component"},{"line_number":60,"context_line":"      shapes may be shrunk to allow application layers to be easily recognized,"},{"line_number":61,"context_line":"      without creating a maze of crossed interface lines"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_c738a040","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":11},"updated":"2016-08-18 17:13:38.000000000","message":"I don\u0027t think I\u0027ve ever seen this work nicely, a more common example is to stack the elements 3 times, most models that repeat elements involve a configurable number of objects so we tend to just use a small stack to mean 2..n","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"ce388675f26b518ebeffffb72a956f565ec1e392","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"This template illustrates the elements of a service architecture diagram."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":".. image:: ../figures/security_review_example_architecture-diagram.png"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Information flow diagram requirements"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_47731016","line":94,"range":{"start_line":94,"start_character":22,"end_line":94,"end_character":58},"updated":"2016-08-18 17:13:38.000000000","message":"I think we\u0027re at the point where we can change a few of the rules above and create our own example diagrams, possibly using Anchor or Barbican as examples","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"   -  An arrow connecting two components is used to depict an interface"},{"line_number":72,"context_line":"   -  Each interface has a unique number and name; listing the network"},{"line_number":73,"context_line":"      protocol (in parenthesis) is strongly recommended"},{"line_number":74,"context_line":"   -  Direction of interface arrow is from the component initiating the"},{"line_number":75,"context_line":"      connection; the arrowhead points to the listening/receiving component"},{"line_number":76,"context_line":"   -  A future interface is indicated as a dashed arrow"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_e91e815e","line":74,"range":{"start_line":74,"start_character":6,"end_line":74,"end_character":15},"updated":"2016-10-17 15:47:54.000000000","message":"Just curious, would a duplex connection require 2 of these?","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"   -  An arrow connecting two components is used to depict an interface"},{"line_number":72,"context_line":"   -  Each interface has a unique number and name; listing the network"},{"line_number":73,"context_line":"      protocol (in parenthesis) is strongly recommended"},{"line_number":74,"context_line":"   -  Direction of interface arrow is from the component initiating the"},{"line_number":75,"context_line":"      connection; the arrowhead points to the listening/receiving component"},{"line_number":76,"context_line":"   -  A future interface is indicated as a dashed arrow"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_81fb1947","line":74,"range":{"start_line":74,"start_character":6,"end_line":74,"end_character":15},"in_reply_to":"fa6399be_e91e815e","updated":"2016-10-17 17:35:04.000000000","message":"I think its unlikely that the connection would be initiated by either end, but if A connected to B and also B connected to A, then I guess A -\u003e B and seperately B -\u003e A.","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"}],"security-guide/source/security-review/architecture-page-guidance.rst":[{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"For example:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"\"Anchor is an public key infrastructure (PKI) service, which uses automated"},{"line_number":45,"context_line":"certificate request validation to automate issuing descisions. Certificates are"},{"line_number":46,"context_line":"issued for short time periods (typically 12-48 hours) to avoid the flawed"},{"line_number":47,"context_line":"revocation issues associated with CRLs and OCSP.\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_03f714f6","line":44,"range":{"start_line":44,"start_character":11,"end_line":44,"end_character":13},"updated":"2016-10-17 15:47:54.000000000","message":"nit: a","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"For example:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"\"Anchor is an public key infrastructure (PKI) service, which uses automated"},{"line_number":45,"context_line":"certificate request validation to automate issuing descisions. Certificates are"},{"line_number":46,"context_line":"issued for short time periods (typically 12-48 hours) to avoid the flawed"},{"line_number":47,"context_line":"revocation issues associated with CRLs and OCSP.\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_812eb9a3","line":44,"range":{"start_line":44,"start_character":11,"end_line":44,"end_character":13},"in_reply_to":"fa6399be_03f714f6","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"A list of the expected primary users of the implemented architecture and their"},{"line_number":54,"context_line":"uses cases. \u0027Users\u0027 can either be actors or other services within OpenStack."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"For example:"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_a35ca8f1","line":54,"range":{"start_line":54,"start_character":1,"end_line":54,"end_character":10},"updated":"2016-10-17 15:47:54.000000000","message":"nit: use-cases","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"A list of the expected primary users of the implemented architecture and their"},{"line_number":54,"context_line":"uses cases. \u0027Users\u0027 can either be actors or other services within OpenStack."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"For example:"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_a12bbd93","line":54,"range":{"start_line":54,"start_character":1,"end_line":54,"end_character":10},"in_reply_to":"fa6399be_a35ca8f1","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"For example:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- Nova compute service depends on an external Authentication and Authorization"},{"line_number":76,"context_line":"service. In a typical deployment this dependency will be fulfilled by the"},{"line_number":77,"context_line":"keystone service."},{"line_number":78,"context_line":"- Barbican depends on the use of Hardware Security Module (HSM) appliance."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_43910c52","line":75,"range":{"start_line":75,"start_character":2,"end_line":75,"end_character":6},"updated":"2016-10-17 15:47:54.000000000","message":"nit: nova or Compute service nova","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"For example:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- Nova compute service depends on an external Authentication and Authorization"},{"line_number":76,"context_line":"service. In a typical deployment this dependency will be fulfilled by the"},{"line_number":77,"context_line":"keystone service."},{"line_number":78,"context_line":"- Barbican depends on the use of Hardware Security Module (HSM) appliance."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_410bc12b","line":75,"range":{"start_line":75,"start_character":2,"end_line":75,"end_character":6},"in_reply_to":"fa6399be_43910c52","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"- Nova compute service depends on an external Authentication and Authorization"},{"line_number":76,"context_line":"service. In a typical deployment this dependency will be fulfilled by the"},{"line_number":77,"context_line":"keystone service."},{"line_number":78,"context_line":"- Barbican depends on the use of Hardware Security Module (HSM) appliance."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Components"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_237b382b","line":78,"range":{"start_line":78,"start_character":2,"end_line":78,"end_character":10},"updated":"2016-10-17 15:47:54.000000000","message":"barbican","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"- Nova compute service depends on an external Authentication and Authorization"},{"line_number":76,"context_line":"service. In a typical deployment this dependency will be fulfilled by the"},{"line_number":77,"context_line":"keystone service."},{"line_number":78,"context_line":"- Barbican depends on the use of Hardware Security Module (HSM) appliance."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Components"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_c4fd1f0a","line":78,"range":{"start_line":78,"start_character":2,"end_line":78,"end_character":10},"in_reply_to":"fa6399be_237b382b","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"A list of the components of the deployed project, excluding external entities."},{"line_number":85,"context_line":"Each component should be named and have a brief description of its purpose, and"},{"line_number":86,"context_line":"be labled with the primary technology used (e.g. python, mysql, rabbitmq)."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"For example:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_23f7b88d","line":86,"range":{"start_line":86,"start_character":49,"end_line":86,"end_character":55},"updated":"2016-10-17 15:47:54.000000000","message":"nit: Python, MySQL, RabbitMQ","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"A list of the components of the deployed project, excluding external entities."},{"line_number":85,"context_line":"Each component should be named and have a brief description of its purpose, and"},{"line_number":86,"context_line":"be labled with the primary technology used (e.g. python, mysql, rabbitmq)."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"For example:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_e429438b","line":86,"range":{"start_line":86,"start_character":49,"end_line":86,"end_character":55},"in_reply_to":"fa6399be_23f7b88d","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"For example:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"- keystone Listener Process (Python): Python process that consumes keystone"},{"line_number":91,"context_line":"  events published by the keystone service."},{"line_number":92,"context_line":"- Database (MySQL): MySQL database to store barbican state data related to its"},{"line_number":93,"context_line":"  managed entities and their metadata."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_433bcc38","line":90,"range":{"start_line":90,"start_character":11,"end_line":90,"end_character":19},"updated":"2016-10-17 15:47:54.000000000","message":"nit: listener","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"For example:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"- keystone Listener Process (Python): Python process that consumes keystone"},{"line_number":91,"context_line":"  events published by the keystone service."},{"line_number":92,"context_line":"- Database (MySQL): MySQL database to store barbican state data related to its"},{"line_number":93,"context_line":"  managed entities and their metadata."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_24241bae","line":90,"range":{"start_line":90,"start_character":11,"end_line":90,"end_character":19},"in_reply_to":"fa6399be_433bcc38","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The architecture diagram shows the logical layout of the system so the security"},{"line_number":100,"context_line":"reviewers can step through the architecture with the project team. It is a"},{"line_number":101,"context_line":"logical diagram which shows how the components interact, how they connect to"},{"line_number":102,"context_line":"external entities, and where communications cross trust boundaries. Further"},{"line_number":103,"context_line":"information on architecture diagram, including a key of symbols, is given in"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_a35e6877","line":100,"range":{"start_line":100,"start_character":14,"end_line":100,"end_character":26},"updated":"2016-10-17 15:47:54.000000000","message":"should this be: `go through`?","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The architecture diagram shows the logical layout of the system so the security"},{"line_number":100,"context_line":"reviewers can step through the architecture with the project team. It is a"},{"line_number":101,"context_line":"logical diagram which shows how the components interact, how they connect to"},{"line_number":102,"context_line":"external entities, and where communications cross trust boundaries. Further"},{"line_number":103,"context_line":"information on architecture diagram, including a key of symbols, is given in"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_a4302bea","line":100,"range":{"start_line":100,"start_character":14,"end_line":100,"end_character":26},"in_reply_to":"fa6399be_a35e6877","updated":"2016-10-17 17:35:04.000000000","message":"leaving this atm.","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"logical diagram which shows how the components interact, how they connect to"},{"line_number":102,"context_line":"external entities, and where communications cross trust boundaries. Further"},{"line_number":103,"context_line":"information on architecture diagram, including a key of symbols, is given in"},{"line_number":104,"context_line":":doc: `architecture-diagram-guidance`.. Diagrams can be drawn in any tool that"},{"line_number":105,"context_line":"can produce a diagram which uses the symbols in the key, however"},{"line_number":106,"context_line":"`draw.io https://draw.io`__ is strongly recommended."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_e3e6a0af","line":104,"range":{"start_line":104,"start_character":38,"end_line":104,"end_character":39},"updated":"2016-10-17 15:47:54.000000000","message":"nit: extra stop","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"logical diagram which shows how the components interact, how they connect to"},{"line_number":102,"context_line":"external entities, and where communications cross trust boundaries. Further"},{"line_number":103,"context_line":"information on architecture diagram, including a key of symbols, is given in"},{"line_number":104,"context_line":":doc: `architecture-diagram-guidance`.. Diagrams can be drawn in any tool that"},{"line_number":105,"context_line":"can produce a diagram which uses the symbols in the key, however"},{"line_number":106,"context_line":"`draw.io https://draw.io`__ is strongly recommended."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_04563706","line":104,"range":{"start_line":104,"start_character":38,"end_line":104,"end_character":39},"in_reply_to":"fa6399be_e3e6a0af","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":117,"context_line":"tokens or other items that an attacker may target. The set of data items will"},{"line_number":118,"context_line":"vary between projects, but in general it should be considered as classes of"},{"line_number":119,"context_line":"data which are vital to the intended operation of the project. The level of"},{"line_number":120,"context_line":"detail required is somewhat dependant on context, data can usually be grouped,"},{"line_number":121,"context_line":"such as \u0027user data\u0027, \u0027secret data\u0027 or \u0027configuration files\u0027 but may be"},{"line_number":122,"context_line":"singular, like \u0027admin identiy token\u0027 or \u0027user identiy token\u0027, or \u0027database"},{"line_number":123,"context_line":"configuration file\u0027."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_2376d8d8","line":120,"range":{"start_line":120,"start_character":40,"end_line":120,"end_character":48},"updated":"2016-10-17 15:47:54.000000000","message":"`the context` ?","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":117,"context_line":"tokens or other items that an attacker may target. The set of data items will"},{"line_number":118,"context_line":"vary between projects, but in general it should be considered as classes of"},{"line_number":119,"context_line":"data which are vital to the intended operation of the project. The level of"},{"line_number":120,"context_line":"detail required is somewhat dependant on context, data can usually be grouped,"},{"line_number":121,"context_line":"such as \u0027user data\u0027, \u0027secret data\u0027 or \u0027configuration files\u0027 but may be"},{"line_number":122,"context_line":"singular, like \u0027admin identiy token\u0027 or \u0027user identiy token\u0027, or \u0027database"},{"line_number":123,"context_line":"configuration file\u0027."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_e477839d","line":120,"range":{"start_line":120,"start_character":40,"end_line":120,"end_character":48},"in_reply_to":"fa6399be_2376d8d8","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"1. Client-\u003eAPI Process *[TLS]*:"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   - Assets in flight: User keystone Credentials, Plaintext Secrets, HTTP Verb,"},{"line_number":193,"context_line":"     Secret ID, Path"},{"line_number":194,"context_line":"   - Access to keystone credentials or plaintext secrets is considered a total"},{"line_number":195,"context_line":"     security failure of the system - this interface must have robust"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_ee5687cd","line":192,"range":{"start_line":192,"start_character":37,"end_line":192,"end_character":67},"updated":"2016-10-17 15:47:54.000000000","message":"credentials, plaintext secrets","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"1. Client-\u003eAPI Process *[TLS]*:"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   - Assets in flight: User keystone Credentials, Plaintext Secrets, HTTP Verb,"},{"line_number":193,"context_line":"     Secret ID, Path"},{"line_number":194,"context_line":"   - Access to keystone credentials or plaintext secrets is considered a total"},{"line_number":195,"context_line":"     security failure of the system - this interface must have robust"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_8e68ab89","line":192,"range":{"start_line":192,"start_character":74,"end_line":192,"end_character":78},"updated":"2016-10-17 15:47:54.000000000","message":"verb","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"1. Client-\u003eAPI Process *[TLS]*:"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   - Assets in flight: User keystone Credentials, Plaintext Secrets, HTTP Verb,"},{"line_number":193,"context_line":"     Secret ID, Path"},{"line_number":194,"context_line":"   - Access to keystone credentials or plaintext secrets is considered a total"},{"line_number":195,"context_line":"     security failure of the system - this interface must have robust"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_44958f86","line":192,"range":{"start_line":192,"start_character":74,"end_line":192,"end_character":78},"in_reply_to":"fa6399be_8e68ab89","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"1. Client-\u003eAPI Process *[TLS]*:"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   - Assets in flight: User keystone Credentials, Plaintext Secrets, HTTP Verb,"},{"line_number":193,"context_line":"     Secret ID, Path"},{"line_number":194,"context_line":"   - Access to keystone credentials or plaintext secrets is considered a total"},{"line_number":195,"context_line":"     security failure of the system - this interface must have robust"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_e485c359","line":192,"range":{"start_line":192,"start_character":37,"end_line":192,"end_character":67},"in_reply_to":"fa6399be_ee5687cd","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":190,"context_line":"1. Client-\u003eAPI Process *[TLS]*:"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   - Assets in flight: User keystone Credentials, Plaintext Secrets, HTTP Verb,"},{"line_number":193,"context_line":"     Secret ID, Path"},{"line_number":194,"context_line":"   - Access to keystone credentials or plaintext secrets is considered a total"},{"line_number":195,"context_line":"     security failure of the system - this interface must have robust"},{"line_number":196,"context_line":"     confidentiality and integrity controls, i.e. TLS."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_ee0da7e9","line":193,"range":{"start_line":193,"start_character":16,"end_line":193,"end_character":20},"updated":"2016-10-17 15:47:54.000000000","message":"path","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":190,"context_line":"1. Client-\u003eAPI Process *[TLS]*:"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   - Assets in flight: User keystone Credentials, Plaintext Secrets, HTTP Verb,"},{"line_number":193,"context_line":"     Secret ID, Path"},{"line_number":194,"context_line":"   - Access to keystone credentials or plaintext secrets is considered a total"},{"line_number":195,"context_line":"     security failure of the system - this interface must have robust"},{"line_number":196,"context_line":"     confidentiality and integrity controls, i.e. TLS."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_ce08e3dc","line":193,"range":{"start_line":193,"start_character":5,"end_line":193,"end_character":11},"updated":"2016-10-17 15:47:54.000000000","message":"secret","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"1. Client-\u003eAPI Process *[TLS]*:"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   - Assets in flight: User keystone Credentials, Plaintext Secrets, HTTP Verb,"},{"line_number":193,"context_line":"     Secret ID, Path"},{"line_number":194,"context_line":"   - Access to keystone credentials or plaintext secrets is considered a total"},{"line_number":195,"context_line":"     security failure of the system - this interface must have robust"},{"line_number":196,"context_line":"     confidentiality and integrity controls, i.e. TLS."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_047b977c","line":193,"range":{"start_line":193,"start_character":5,"end_line":193,"end_character":11},"in_reply_to":"fa6399be_ce08e3dc","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"1. Client-\u003eAPI Process *[TLS]*:"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   - Assets in flight: User keystone Credentials, Plaintext Secrets, HTTP Verb,"},{"line_number":193,"context_line":"     Secret ID, Path"},{"line_number":194,"context_line":"   - Access to keystone credentials or plaintext secrets is considered a total"},{"line_number":195,"context_line":"     security failure of the system - this interface must have robust"},{"line_number":196,"context_line":"     confidentiality and integrity controls, i.e. TLS."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_24809b46","line":193,"range":{"start_line":193,"start_character":16,"end_line":193,"end_character":20},"in_reply_to":"fa6399be_ee0da7e9","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":200,"context_line":"~~~~~~~~~"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"List resources relevant to the project, such as wiki pages describing its"},{"line_number":203,"context_line":"deployment useage and useage, a link to the repositories and links to relevant"},{"line_number":204,"context_line":"presentations."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_0e2adb2c","line":203,"range":{"start_line":203,"start_character":22,"end_line":203,"end_character":28},"updated":"2016-10-17 15:47:54.000000000","message":"nit: usage","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":200,"context_line":"~~~~~~~~~"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"List resources relevant to the project, such as wiki pages describing its"},{"line_number":203,"context_line":"deployment useage and useage, a link to the repositories and links to relevant"},{"line_number":204,"context_line":"presentations."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_ee24c761","line":203,"range":{"start_line":203,"start_character":11,"end_line":203,"end_character":17},"updated":"2016-10-17 15:47:54.000000000","message":"nit: usage","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"~~~~~~~~~"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"List resources relevant to the project, such as wiki pages describing its"},{"line_number":203,"context_line":"deployment useage and useage, a link to the repositories and links to relevant"},{"line_number":204,"context_line":"presentations."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_848fa774","line":203,"range":{"start_line":203,"start_character":22,"end_line":203,"end_character":28},"in_reply_to":"fa6399be_0e2adb2c","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"~~~~~~~~~"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"List resources relevant to the project, such as wiki pages describing its"},{"line_number":203,"context_line":"deployment useage and useage, a link to the repositories and links to relevant"},{"line_number":204,"context_line":"presentations."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_a48cab80","line":203,"range":{"start_line":203,"start_character":11,"end_line":203,"end_character":17},"in_reply_to":"fa6399be_ee24c761","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Project description and purpose"},{"line_number":35,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"A brief description of the purpose of the project, so someone who is totally"},{"line_number":38,"context_line":"new to it can understand what it is used for. This should be a paragraph"},{"line_number":39,"context_line":"or two and can be cut/paste from wiki or other documentation. Include links"},{"line_number":40,"context_line":"to relevant presentations and further documentation if available."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_eb774e9d","line":37,"updated":"2016-10-17 18:53:35.000000000","message":"This is a bit awkward for me, maybe start with \"This section will contain a brief description of the project for third parties to be introduced to the service.\" or something similar?","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Project description and purpose"},{"line_number":35,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"A brief description of the purpose of the project, so someone who is totally"},{"line_number":38,"context_line":"new to it can understand what it is used for. This should be a paragraph"},{"line_number":39,"context_line":"or two and can be cut/paste from wiki or other documentation. Include links"},{"line_number":40,"context_line":"to relevant presentations and further documentation if available."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_a8055915","line":37,"in_reply_to":"fa6399be_eb774e9d","updated":"2016-10-17 19:54:02.000000000","message":"Done","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"For example:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- nova compute service depends on an external Authentication and Authorization"},{"line_number":76,"context_line":"  service. In a typical deployment this dependency will be fulfilled by the"},{"line_number":77,"context_line":"  keystone service."},{"line_number":78,"context_line":"- barbican depends on the use of Hardware Security Module (HSM) appliance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_2bb866e5","line":75,"updated":"2016-10-17 18:53:35.000000000","message":"This is awkward to start a sentence in a lower case, I believe in titles and as the first word of the sentence we can capitalize the project names, or maybe just go to \"The Compute service (nova)...\"\n\nAdditionally, as these are going to be notes coming from service teams, I think we can put several examples of different formats, understanding that they will not be formatted to docs standards.","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"For example:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- nova compute service depends on an external Authentication and Authorization"},{"line_number":76,"context_line":"  service. In a typical deployment this dependency will be fulfilled by the"},{"line_number":77,"context_line":"  keystone service."},{"line_number":78,"context_line":"- barbican depends on the use of Hardware Security Module (HSM) appliance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_2b1f835c","line":75,"in_reply_to":"fa6399be_2bb866e5","updated":"2016-10-17 19:54:02.000000000","message":"Done","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"- nova compute service depends on an external Authentication and Authorization"},{"line_number":76,"context_line":"  service. In a typical deployment this dependency will be fulfilled by the"},{"line_number":77,"context_line":"  keystone service."},{"line_number":78,"context_line":"- barbican depends on the use of Hardware Security Module (HSM) appliance."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Components"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_abc4765f","line":78,"range":{"start_line":78,"start_character":2,"end_line":78,"end_character":10},"updated":"2016-10-17 18:53:35.000000000","message":"Same as above","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"- nova compute service depends on an external Authentication and Authorization"},{"line_number":76,"context_line":"  service. In a typical deployment this dependency will be fulfilled by the"},{"line_number":77,"context_line":"  keystone service."},{"line_number":78,"context_line":"- barbican depends on the use of Hardware Security Module (HSM) appliance."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Components"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_6b397bd8","line":78,"range":{"start_line":78,"start_character":2,"end_line":78,"end_character":10},"in_reply_to":"fa6399be_abc4765f","updated":"2016-10-17 19:54:02.000000000","message":"Done","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For example:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- *Secret data* : Passphrases, Encryption Keys, RSA Keys - persisted in"},{"line_number":130,"context_line":"  Database [PKCS#11] or HSM [KMIP] or [KMIP, Dogtag]"},{"line_number":131,"context_line":"- *RBAC rulesets* - persisted in policy.json"},{"line_number":132,"context_line":"- *RabbitMQ Credentials* - persisted in barbican.conf"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_eb666e28","line":129,"updated":"2016-10-17 18:53:35.000000000","message":"So why are these formatted (ie, with *\u0027s), while prior examples are not? Is there a visual reason? If not, can we maintain consistency between lists and remove the emphasis/formatting?","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For example:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- *Secret data* : Passphrases, Encryption Keys, RSA Keys - persisted in"},{"line_number":130,"context_line":"  Database [PKCS#11] or HSM [KMIP] or [KMIP, Dogtag]"},{"line_number":131,"context_line":"- *RBAC rulesets* - persisted in policy.json"},{"line_number":132,"context_line":"- *RabbitMQ Credentials* - persisted in barbican.conf"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_8b3defbd","line":129,"in_reply_to":"fa6399be_eb666e28","updated":"2016-10-17 19:54:02.000000000","message":"Because this is a copy/paste from the barbican review: https://review.openstack.org/#/c/357978/13","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- *Secret data* : Passphrases, Encryption Keys, RSA Keys - persisted in"},{"line_number":130,"context_line":"  Database [PKCS#11] or HSM [KMIP] or [KMIP, Dogtag]"},{"line_number":131,"context_line":"- *RBAC rulesets* - persisted in policy.json"},{"line_number":132,"context_line":"- *RabbitMQ Credentials* - persisted in barbican.conf"},{"line_number":133,"context_line":"- *keystone Event Queue Credentials* - persisted in barbican.conf"},{"line_number":134,"context_line":"- *Middleware configuration* - persisted in paste.ini"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_2b7146e1","line":131,"updated":"2016-10-17 18:53:35.000000000","message":"same as above","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- *Secret data* : Passphrases, Encryption Keys, RSA Keys - persisted in"},{"line_number":130,"context_line":"  Database [PKCS#11] or HSM [KMIP] or [KMIP, Dogtag]"},{"line_number":131,"context_line":"- *RBAC rulesets* - persisted in policy.json"},{"line_number":132,"context_line":"- *RabbitMQ Credentials* - persisted in barbican.conf"},{"line_number":133,"context_line":"- *keystone Event Queue Credentials* - persisted in barbican.conf"},{"line_number":134,"context_line":"- *Middleware configuration* - persisted in paste.ini"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_cb47e749","line":131,"in_reply_to":"fa6399be_2b7146e1","updated":"2016-10-17 19:54:02.000000000","message":"same as above","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"1. Client-\u003eAPI Process *[TLS]*:"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   - Assets in flight: User keystone Credentials, plaintext secrets, HTTP verb,"},{"line_number":193,"context_line":"     secret ID, path"},{"line_number":194,"context_line":"   - Access to keystone credentials or plaintext secrets is considered a total"},{"line_number":195,"context_line":"     security failure of the system - this interface must have robust"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_c6fd1f0a","line":192,"updated":"2016-10-17 18:53:35.000000000","message":"lowecase credentials","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"1. Client-\u003eAPI Process *[TLS]*:"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   - Assets in flight: User keystone Credentials, plaintext secrets, HTTP verb,"},{"line_number":193,"context_line":"     secret ID, path"},{"line_number":194,"context_line":"   - Access to keystone credentials or plaintext secrets is considered a total"},{"line_number":195,"context_line":"     security failure of the system - this interface must have robust"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_8b640fe6","line":192,"in_reply_to":"fa6399be_c6fd1f0a","updated":"2016-10-17 19:54:02.000000000","message":"Done","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":193,"context_line":"     secret ID, path"},{"line_number":194,"context_line":"   - Access to keystone credentials or plaintext secrets is considered a total"},{"line_number":195,"context_line":"     security failure of the system - this interface must have robust"},{"line_number":196,"context_line":"     confidentiality and integrity controls, i.e. TLS."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Resources"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_6b217eb4","line":196,"updated":"2016-10-17 18:53:35.000000000","message":"docs convention is to not use abbreviations such as \"i.e.\" or \"e.g.\" but to say \"such as\"","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"4e53d017f9a538bdd557f74060605758fad0df7b","unresolved":false,"context_lines":[{"line_number":193,"context_line":"     secret ID, path"},{"line_number":194,"context_line":"   - Access to keystone credentials or plaintext secrets is considered a total"},{"line_number":195,"context_line":"     security failure of the system - this interface must have robust"},{"line_number":196,"context_line":"     confidentiality and integrity controls, i.e. TLS."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Resources"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_abb8f32b","line":196,"in_reply_to":"fa6399be_6b217eb4","updated":"2016-10-17 19:54:02.000000000","message":"Done","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":12325,"name":"Nathaniel Dillon","email":"nathaniel.dillon@alumni.depaul.edu","username":"sicarie"},"change_message_id":"036b0eaf35a9631e612ed54c9053f04cc0c3a16c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"~~~~~~~~~"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"List resources relevant to the project, such as wiki pages describing its"},{"line_number":203,"context_line":"deployment and usage, a link to the repositories and links to relevant"},{"line_number":204,"context_line":"presentations."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_864a4754","line":203,"updated":"2016-10-17 18:53:35.000000000","message":"The second comma is really awkward for me, maybe something like:\n\n\"List resources relevant to the project, such as wiki pages describing its deployment and usage, as well as links to code repositories and relevant presentations.\"","commit_id":"fa940cb87b3501aa0a817b0c741a8079d7da74fd"},{"author":{"_account_id":7473,"name":"Grant Murphy","email":"grantcmurphy@gmail.com","username":"gm"},"change_message_id":"3ca38ee2939c1e76b2202bdae1bd50cfa111880b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Title, version information, contact details"},{"line_number":24,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This section titles the archtecture page, gives the status of the review"},{"line_number":27,"context_line":"(draft, ready for review, reviewed) and captures the release and version of the"},{"line_number":28,"context_line":"project (where relevant). It also records the PTL for the project, the"},{"line_number":29,"context_line":"project\u0027s architect who is responsible for producing the architecture page,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_ab571325","line":26,"updated":"2016-10-17 20:17:03.000000000","message":"archtecture \u003d architecture","commit_id":"95b56f407dca889e3504c8f67950c4bfa116c360"},{"author":{"_account_id":7473,"name":"Grant Murphy","email":"grantcmurphy@gmail.com","username":"gm"},"change_message_id":"3ca38ee2939c1e76b2202bdae1bd50cfa111880b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"  - Confidentially Failure Impact: A malicious user might be able to abuse"},{"line_number":163,"context_line":"    other OpenStack services (depending on keystone role configurations) but"},{"line_number":164,"context_line":"    barbican is unaffected. If the service account for token validation also"},{"line_number":165,"context_line":"    has barbican admin privilages, then a malicious user could manipulate"},{"line_number":166,"context_line":"    barbican admin functions."},{"line_number":167,"context_line":"  - Availability Failure Impact: barbican will not be able to validate user"},{"line_number":168,"context_line":"    credentials and fail. DoS."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_2b11435e","line":165,"updated":"2016-10-17 20:17:03.000000000","message":"privilages \u003d privileges","commit_id":"95b56f407dca889e3504c8f67950c4bfa116c360"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Architecture page guidance"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The purpose of an architecture page is to document the architecture, purpose"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_05e8e315","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":26},"updated":"2016-10-18 01:31:01.000000000","message":"guidelines?","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Architecture page guidance"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The purpose of an architecture page is to document the architecture, purpose"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_61bb3376","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":26},"in_reply_to":"fa6399be_05e8e315","updated":"2016-10-18 17:33:22.000000000","message":"Sticking with guidance, this page is intended to be guidance for someone trying to complete the architecture page template.","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are some key sections to the architecture page, which are explained in"},{"line_number":10,"context_line":"more detail below:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- title, version information, contact details"},{"line_number":13,"context_line":"- Project description and purpose"},{"line_number":14,"context_line":"- Primary users and use-cases"},{"line_number":15,"context_line":"- External dependencies \u0026 associated security assumptions"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_45f2db07","line":12,"range":{"start_line":12,"start_character":2,"end_line":12,"end_character":3},"updated":"2016-10-18 01:31:01.000000000","message":"s/t/T","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are some key sections to the architecture page, which are explained in"},{"line_number":10,"context_line":"more detail below:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- title, version information, contact details"},{"line_number":13,"context_line":"- Project description and purpose"},{"line_number":14,"context_line":"- Primary users and use-cases"},{"line_number":15,"context_line":"- External dependencies \u0026 associated security assumptions"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_ca242fc8","line":12,"range":{"start_line":12,"start_character":2,"end_line":12,"end_character":3},"in_reply_to":"fa6399be_45f2db07","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Title, version information, contact details"},{"line_number":24,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This section titles the architecture page, gives the status of the review"},{"line_number":27,"context_line":"(draft, ready for review, reviewed) and captures the release and version of the"},{"line_number":28,"context_line":"project (where relevant). It also records the PTL for the project, the"},{"line_number":29,"context_line":"project\u0027s architect who is responsible for producing the architecture page,"},{"line_number":30,"context_line":"diagrams and working through the review (this may or may not be the PTL), and"},{"line_number":31,"context_line":"the security reviewer(s)."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Project description and purpose"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_d2bdd303","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":25},"updated":"2016-10-18 01:31:01.000000000","message":"Might be nice to have this information as a bulleted list.","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Title, version information, contact details"},{"line_number":24,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This section titles the architecture page, gives the status of the review"},{"line_number":27,"context_line":"(draft, ready for review, reviewed) and captures the release and version of the"},{"line_number":28,"context_line":"project (where relevant). It also records the PTL for the project, the"},{"line_number":29,"context_line":"project\u0027s architect who is responsible for producing the architecture page,"},{"line_number":30,"context_line":"diagrams and working through the review (this may or may not be the PTL), and"},{"line_number":31,"context_line":"the security reviewer(s)."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Project description and purpose"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_017437cd","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":25},"in_reply_to":"fa6399be_d2bdd303","updated":"2016-10-18 17:33:22.000000000","message":"The template will contain a bulleted list, but this is intended to be a textual description to help you complete the template.","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"This section will contain a brief description of the project to introduce third"},{"line_number":38,"context_line":"parties to the service. This should be a paragraph or two and can be cut/paste"},{"line_number":39,"context_line":"from wiki or other documentation. Include links to relevant presentations and"},{"line_number":40,"context_line":"further documentation if available."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"For example:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_f2c49760","line":39,"range":{"start_line":38,"start_character":58,"end_line":39,"end_character":32},"updated":"2016-10-18 01:31:01.000000000","message":"I don\u0027t think we need to include this information?","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":35,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"This section will contain a brief description of the project to introduce third"},{"line_number":38,"context_line":"parties to the service. This should be a paragraph or two and can be cut/paste"},{"line_number":39,"context_line":"from wiki or other documentation. Include links to relevant presentations and"},{"line_number":40,"context_line":"further documentation if available."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"For example:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_bdc66447","line":39,"range":{"start_line":38,"start_character":58,"end_line":39,"end_character":32},"in_reply_to":"fa6399be_f2c49760","updated":"2016-10-18 17:33:22.000000000","message":"Trying to make it explicit that the PTL/Architect doesnt have to put lots of effort into making a wordy description of the project.","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"For example:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"\"Anchor is a public key infrastructure (PKI) service, which uses automated"},{"line_number":45,"context_line":"certificate request validation to automate issuing decisions. Certificates are"},{"line_number":46,"context_line":"issued for short time periods (typically 12-48 hours) to avoid the flawed"},{"line_number":47,"context_line":"revocation issues associated with CRLs and OCSP.\""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_32d7ef24","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":1},"updated":"2016-10-18 01:31:01.000000000","message":"s/\"/* for italics markup","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"For example:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"\"Anchor is a public key infrastructure (PKI) service, which uses automated"},{"line_number":45,"context_line":"certificate request validation to automate issuing decisions. Certificates are"},{"line_number":46,"context_line":"issued for short time periods (typically 12-48 hours) to avoid the flawed"},{"line_number":47,"context_line":"revocation issues associated with CRLs and OCSP.\""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_e15d8349","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":1},"in_reply_to":"fa6399be_32d7ef24","updated":"2016-10-18 17:33:22.000000000","message":"Should an example be in italics? I was actually aiming for quotes, but dont know what the best practise for textual examples is.","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\"Anchor is a public key infrastructure (PKI) service, which uses automated"},{"line_number":45,"context_line":"certificate request validation to automate issuing decisions. Certificates are"},{"line_number":46,"context_line":"issued for short time periods (typically 12-48 hours) to avoid the flawed"},{"line_number":47,"context_line":"revocation issues associated with CRLs and OCSP.\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Primary users and use-cases"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_72b887e6","line":47,"range":{"start_line":47,"start_character":48,"end_line":47,"end_character":49},"updated":"2016-10-18 01:31:01.000000000","message":"s/\"/* for italics markup","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\"Anchor is a public key infrastructure (PKI) service, which uses automated"},{"line_number":45,"context_line":"certificate request validation to automate issuing decisions. Certificates are"},{"line_number":46,"context_line":"issued for short time periods (typically 12-48 hours) to avoid the flawed"},{"line_number":47,"context_line":"revocation issues associated with CRLs and OCSP.\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Primary users and use-cases"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_41554f1b","line":47,"range":{"start_line":47,"start_character":48,"end_line":47,"end_character":49},"in_reply_to":"fa6399be_72b887e6","updated":"2016-10-18 17:33:22.000000000","message":"as above.","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"   quotas."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"External dependencies \u0026 associated security assumptions"},{"line_number":65,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"External dependencies are items outside of the control of the service that are"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_b2913f55","line":64,"range":{"start_line":64,"start_character":22,"end_line":64,"end_character":23},"updated":"2016-10-18 01:31:01.000000000","message":"s/\u0026/and","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":61,"context_line":"   quotas."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"External dependencies \u0026 associated security assumptions"},{"line_number":65,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"External dependencies are items outside of the control of the service that are"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_1d2af0e7","line":64,"range":{"start_line":64,"start_character":22,"end_line":64,"end_character":23},"in_reply_to":"fa6399be_b2913f55","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"External dependencies are items outside of the control of the service that are"},{"line_number":68,"context_line":"required for its operation, and may impact the service if they were compromised"},{"line_number":69,"context_line":"or became unavailable. These items are usually outside the control of the"},{"line_number":70,"context_line":"developer but within the control of the deployer, or they may be operated by a"},{"line_number":71,"context_line":"third party. Appliances should be regarded as external dependencies."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_12110bb0","line":68,"range":{"start_line":68,"start_character":63,"end_line":68,"end_character":67},"updated":"2016-10-18 01:31:01.000000000","message":"s/were/are","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":65,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"External dependencies are items outside of the control of the service that are"},{"line_number":68,"context_line":"required for its operation, and may impact the service if they were compromised"},{"line_number":69,"context_line":"or became unavailable. These items are usually outside the control of the"},{"line_number":70,"context_line":"developer but within the control of the deployer, or they may be operated by a"},{"line_number":71,"context_line":"third party. Appliances should be regarded as external dependencies."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_043e05b8","line":68,"range":{"start_line":68,"start_character":63,"end_line":68,"end_character":67},"in_reply_to":"fa6399be_12110bb0","updated":"2016-10-18 17:33:22.000000000","message":"Leaving this one, its more accurate as it is.","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"External dependencies are items outside of the control of the service that are"},{"line_number":68,"context_line":"required for its operation, and may impact the service if they were compromised"},{"line_number":69,"context_line":"or became unavailable. These items are usually outside the control of the"},{"line_number":70,"context_line":"developer but within the control of the deployer, or they may be operated by a"},{"line_number":71,"context_line":"third party. Appliances should be regarded as external dependencies."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_b2f4df87","line":69,"range":{"start_line":69,"start_character":3,"end_line":69,"end_character":9},"updated":"2016-10-18 01:31:01.000000000","message":"s/became unavailable/unavailable","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"External dependencies are items outside of the control of the service that are"},{"line_number":68,"context_line":"required for its operation, and may impact the service if they were compromised"},{"line_number":69,"context_line":"or became unavailable. These items are usually outside the control of the"},{"line_number":70,"context_line":"developer but within the control of the deployer, or they may be operated by a"},{"line_number":71,"context_line":"third party. Appliances should be regarded as external dependencies."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_244b095b","line":69,"range":{"start_line":69,"start_character":3,"end_line":69,"end_character":9},"in_reply_to":"fa6399be_b2f4df87","updated":"2016-10-18 17:33:22.000000000","message":"again, leaving this.","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"External dependencies are items outside of the control of the service that are"},{"line_number":68,"context_line":"required for its operation, and may impact the service if they were compromised"},{"line_number":69,"context_line":"or became unavailable. These items are usually outside the control of the"},{"line_number":70,"context_line":"developer but within the control of the deployer, or they may be operated by a"},{"line_number":71,"context_line":"third party. Appliances should be regarded as external dependencies."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"For example:"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_32e1afd1","line":71,"range":{"start_line":69,"start_character":23,"end_line":71,"end_character":11},"updated":"2016-10-18 01:31:01.000000000","message":"Can we say \"External dependencies are managed by deployers or a third party.\"","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"External dependencies are items outside of the control of the service that are"},{"line_number":68,"context_line":"required for its operation, and may impact the service if they were compromised"},{"line_number":69,"context_line":"or became unavailable. These items are usually outside the control of the"},{"line_number":70,"context_line":"developer but within the control of the deployer, or they may be operated by a"},{"line_number":71,"context_line":"third party. Appliances should be regarded as external dependencies."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"For example:"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_c4a96de1","line":71,"range":{"start_line":69,"start_character":23,"end_line":71,"end_character":11},"in_reply_to":"fa6399be_32e1afd1","updated":"2016-10-18 17:33:22.000000000","message":"Would rather leave this as it is.","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"For example:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- Nova compute service depends on an external Authentication and Authorization"},{"line_number":76,"context_line":"  service. In a typical deployment this dependency will be fulfilled by the"},{"line_number":77,"context_line":"  keystone service."},{"line_number":78,"context_line":"- Barbican depends on the use of Hardware Security Module (HSM) appliance."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_72396741","line":75,"range":{"start_line":75,"start_character":46,"end_line":75,"end_character":47},"updated":"2016-10-18 01:31:01.000000000","message":"lowercase","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"For example:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- Nova compute service depends on an external Authentication and Authorization"},{"line_number":76,"context_line":"  service. In a typical deployment this dependency will be fulfilled by the"},{"line_number":77,"context_line":"  keystone service."},{"line_number":78,"context_line":"- Barbican depends on the use of Hardware Security Module (HSM) appliance."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_d24873cf","line":75,"range":{"start_line":75,"start_character":65,"end_line":75,"end_character":66},"updated":"2016-10-18 01:31:01.000000000","message":"lowercase","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"For example:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- Nova compute service depends on an external Authentication and Authorization"},{"line_number":76,"context_line":"  service. In a typical deployment this dependency will be fulfilled by the"},{"line_number":77,"context_line":"  keystone service."},{"line_number":78,"context_line":"- Barbican depends on the use of Hardware Security Module (HSM) appliance."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_fde1bc9b","line":75,"range":{"start_line":75,"start_character":46,"end_line":75,"end_character":47},"in_reply_to":"fa6399be_72396741","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"For example:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- Nova compute service depends on an external Authentication and Authorization"},{"line_number":76,"context_line":"  service. In a typical deployment this dependency will be fulfilled by the"},{"line_number":77,"context_line":"  keystone service."},{"line_number":78,"context_line":"- Barbican depends on the use of Hardware Security Module (HSM) appliance."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_5de708ac","line":75,"range":{"start_line":75,"start_character":65,"end_line":75,"end_character":66},"in_reply_to":"fa6399be_d24873cf","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Components"},{"line_number":82,"context_line":"~~~~~~~~~~"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"A list of the components of the deployed project, excluding external entities."},{"line_number":85,"context_line":"Each component should be named and have a brief description of its purpose, and"},{"line_number":86,"context_line":"be  labeled with the primary technology used (e.g. Python, MySQL, RabbitMQ)."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_32644f48","line":84,"range":{"start_line":84,"start_character":48,"end_line":84,"end_character":49},"updated":"2016-10-18 01:31:01.000000000","message":"remove the comma","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Components"},{"line_number":82,"context_line":"~~~~~~~~~~"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"A list of the components of the deployed project, excluding external entities."},{"line_number":85,"context_line":"Each component should be named and have a brief description of its purpose, and"},{"line_number":86,"context_line":"be  labeled with the primary technology used (e.g. Python, MySQL, RabbitMQ)."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_1ded908e","line":84,"range":{"start_line":84,"start_character":48,"end_line":84,"end_character":49},"in_reply_to":"fa6399be_32644f48","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"A list of the components of the deployed project, excluding external entities."},{"line_number":85,"context_line":"Each component should be named and have a brief description of its purpose, and"},{"line_number":86,"context_line":"be  labeled with the primary technology used (e.g. Python, MySQL, RabbitMQ)."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"For example:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_725ec777","line":86,"range":{"start_line":86,"start_character":2,"end_line":86,"end_character":4},"updated":"2016-10-18 01:31:01.000000000","message":"remove double space","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"A list of the components of the deployed project, excluding external entities."},{"line_number":85,"context_line":"Each component should be named and have a brief description of its purpose, and"},{"line_number":86,"context_line":"be  labeled with the primary technology used (e.g. Python, MySQL, RabbitMQ)."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"For example:"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_1d94b0e6","line":86,"range":{"start_line":86,"start_character":2,"end_line":86,"end_character":4},"in_reply_to":"fa6399be_725ec777","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"tokens or other items that an attacker may target. The set of data items will"},{"line_number":118,"context_line":"vary between projects, but in general it should be considered as classes of"},{"line_number":119,"context_line":"data which are vital to the intended operation of the project. The level of"},{"line_number":120,"context_line":"detail required is somewhat dependent on the context, data can usually be"},{"line_number":121,"context_line":"grouped, such as \u0027user data\u0027, \u0027secret data\u0027 or \u0027configuration files\u0027 but may be"},{"line_number":122,"context_line":"singular, like \u0027admin identity token\u0027 or \u0027user identiy token\u0027, or \u0027database"},{"line_number":123,"context_line":"configuration file\u0027."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_b2acdf36","line":120,"range":{"start_line":120,"start_character":52,"end_line":120,"end_character":58},"updated":"2016-10-18 01:31:01.000000000","message":"End sentence. s/, data/. Data","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":117,"context_line":"tokens or other items that an attacker may target. The set of data items will"},{"line_number":118,"context_line":"vary between projects, but in general it should be considered as classes of"},{"line_number":119,"context_line":"data which are vital to the intended operation of the project. The level of"},{"line_number":120,"context_line":"detail required is somewhat dependent on the context, data can usually be"},{"line_number":121,"context_line":"grouped, such as \u0027user data\u0027, \u0027secret data\u0027 or \u0027configuration files\u0027 but may be"},{"line_number":122,"context_line":"singular, like \u0027admin identity token\u0027 or \u0027user identiy token\u0027, or \u0027database"},{"line_number":123,"context_line":"configuration file\u0027."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_7da3ec4f","line":120,"range":{"start_line":120,"start_character":52,"end_line":120,"end_character":58},"in_reply_to":"fa6399be_b2acdf36","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"vary between projects, but in general it should be considered as classes of"},{"line_number":119,"context_line":"data which are vital to the intended operation of the project. The level of"},{"line_number":120,"context_line":"detail required is somewhat dependent on the context, data can usually be"},{"line_number":121,"context_line":"grouped, such as \u0027user data\u0027, \u0027secret data\u0027 or \u0027configuration files\u0027 but may be"},{"line_number":122,"context_line":"singular, like \u0027admin identity token\u0027 or \u0027user identiy token\u0027, or \u0027database"},{"line_number":123,"context_line":"configuration file\u0027."},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_3267ef26","line":121,"range":{"start_line":121,"start_character":68,"end_line":121,"end_character":69},"updated":"2016-10-18 01:31:01.000000000","message":"Add comma","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"vary between projects, but in general it should be considered as classes of"},{"line_number":119,"context_line":"data which are vital to the intended operation of the project. The level of"},{"line_number":120,"context_line":"detail required is somewhat dependent on the context, data can usually be"},{"line_number":121,"context_line":"grouped, such as \u0027user data\u0027, \u0027secret data\u0027 or \u0027configuration files\u0027 but may be"},{"line_number":122,"context_line":"singular, like \u0027admin identity token\u0027 or \u0027user identiy token\u0027, or \u0027database"},{"line_number":123,"context_line":"configuration file\u0027."},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_f2a65752","line":121,"range":{"start_line":121,"start_character":43,"end_line":121,"end_character":44},"updated":"2016-10-18 01:31:01.000000000","message":"Add comma","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":118,"context_line":"vary between projects, but in general it should be considered as classes of"},{"line_number":119,"context_line":"data which are vital to the intended operation of the project. The level of"},{"line_number":120,"context_line":"detail required is somewhat dependent on the context, data can usually be"},{"line_number":121,"context_line":"grouped, such as \u0027user data\u0027, \u0027secret data\u0027 or \u0027configuration files\u0027 but may be"},{"line_number":122,"context_line":"singular, like \u0027admin identity token\u0027 or \u0027user identiy token\u0027, or \u0027database"},{"line_number":123,"context_line":"configuration file\u0027."},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_1dbbd076","line":121,"range":{"start_line":121,"start_character":68,"end_line":121,"end_character":69},"in_reply_to":"fa6399be_3267ef26","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":118,"context_line":"vary between projects, but in general it should be considered as classes of"},{"line_number":119,"context_line":"data which are vital to the intended operation of the project. The level of"},{"line_number":120,"context_line":"detail required is somewhat dependent on the context, data can usually be"},{"line_number":121,"context_line":"grouped, such as \u0027user data\u0027, \u0027secret data\u0027 or \u0027configuration files\u0027 but may be"},{"line_number":122,"context_line":"singular, like \u0027admin identity token\u0027 or \u0027user identiy token\u0027, or \u0027database"},{"line_number":123,"context_line":"configuration file\u0027."},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_3dc094e0","line":121,"range":{"start_line":121,"start_character":43,"end_line":121,"end_character":44},"in_reply_to":"fa6399be_f2a65752","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"data which are vital to the intended operation of the project. The level of"},{"line_number":120,"context_line":"detail required is somewhat dependent on the context, data can usually be"},{"line_number":121,"context_line":"grouped, such as \u0027user data\u0027, \u0027secret data\u0027 or \u0027configuration files\u0027 but may be"},{"line_number":122,"context_line":"singular, like \u0027admin identity token\u0027 or \u0027user identiy token\u0027, or \u0027database"},{"line_number":123,"context_line":"configuration file\u0027."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Data assets should include a statement of where that asset is persisted."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_f2f8174c","line":122,"range":{"start_line":122,"start_character":47,"end_line":122,"end_character":54},"updated":"2016-10-18 01:31:01.000000000","message":"s/identiy/identity","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":119,"context_line":"data which are vital to the intended operation of the project. The level of"},{"line_number":120,"context_line":"detail required is somewhat dependent on the context, data can usually be"},{"line_number":121,"context_line":"grouped, such as \u0027user data\u0027, \u0027secret data\u0027 or \u0027configuration files\u0027 but may be"},{"line_number":122,"context_line":"singular, like \u0027admin identity token\u0027 or \u0027user identiy token\u0027, or \u0027database"},{"line_number":123,"context_line":"configuration file\u0027."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Data assets should include a statement of where that asset is persisted."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_dda95826","line":122,"range":{"start_line":122,"start_character":47,"end_line":122,"end_character":54},"in_reply_to":"fa6399be_f2f8174c","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For example:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- *Secret data* : Passphrases, Encryption Keys, RSA Keys - persisted in"},{"line_number":130,"context_line":"  Database [PKCS#11] or HSM [KMIP] or [KMIP, Dogtag]"},{"line_number":131,"context_line":"- *RBAC rulesets* - persisted in policy.json"},{"line_number":132,"context_line":"- *RabbitMQ Credentials* - persisted in barbican.conf"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_65243faf","line":129,"range":{"start_line":129,"start_character":2,"end_line":129,"end_character":3},"updated":"2016-10-18 01:31:01.000000000","message":"For consistency, the other bullets lists aren\u0027t italicized?","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For example:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- *Secret data* : Passphrases, Encryption Keys, RSA Keys - persisted in"},{"line_number":130,"context_line":"  Database [PKCS#11] or HSM [KMIP] or [KMIP, Dogtag]"},{"line_number":131,"context_line":"- *RBAC rulesets* - persisted in policy.json"},{"line_number":132,"context_line":"- *RabbitMQ Credentials* - persisted in barbican.conf"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_9288bbc8","line":129,"range":{"start_line":129,"start_character":16,"end_line":129,"end_character":17},"updated":"2016-10-18 01:31:01.000000000","message":"For consistency, use a dash or colon for the bulleted list","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For example:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- *Secret data* : Passphrases, Encryption Keys, RSA Keys - persisted in"},{"line_number":130,"context_line":"  Database [PKCS#11] or HSM [KMIP] or [KMIP, Dogtag]"},{"line_number":131,"context_line":"- *RBAC rulesets* - persisted in policy.json"},{"line_number":132,"context_line":"- *RabbitMQ Credentials* - persisted in barbican.conf"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_dd05d814","line":129,"range":{"start_line":129,"start_character":16,"end_line":129,"end_character":17},"in_reply_to":"fa6399be_9288bbc8","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Data asset impact analysis"},{"line_number":138,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"The data asset impact analysis breaks down the impact of loss of"},{"line_number":141,"context_line":"confidentiality, integrity or availability for each data asset. Project"},{"line_number":142,"context_line":"architects should attempt to complete this, as they understand their project in"},{"line_number":143,"context_line":"the most detail, but the OSSP will work through this with the project during"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_72488788","line":140,"range":{"start_line":140,"start_character":56,"end_line":140,"end_character":57},"updated":"2016-10-18 01:31:01.000000000","message":"the","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Data asset impact analysis"},{"line_number":138,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"The data asset impact analysis breaks down the impact of loss of"},{"line_number":141,"context_line":"confidentiality, integrity or availability for each data asset. Project"},{"line_number":142,"context_line":"architects should attempt to complete this, as they understand their project in"},{"line_number":143,"context_line":"the most detail, but the OSSP will work through this with the project during"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_e4959188","line":140,"range":{"start_line":140,"start_character":56,"end_line":140,"end_character":57},"in_reply_to":"fa6399be_72488788","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"The data asset impact analysis breaks down the impact of loss of"},{"line_number":141,"context_line":"confidentiality, integrity or availability for each data asset. Project"},{"line_number":142,"context_line":"architects should attempt to complete this, as they understand their project in"},{"line_number":143,"context_line":"the most detail, but the OSSP will work through this with the project during"},{"line_number":144,"context_line":"the security review and are likely to add or update the impact details."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"For example:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_f202d70a","line":143,"range":{"start_line":143,"start_character":25,"end_line":143,"end_character":30},"updated":"2016-10-18 01:31:01.000000000","message":"Expand the acronym OSSP in the first instance.","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"The data asset impact analysis breaks down the impact of loss of"},{"line_number":141,"context_line":"confidentiality, integrity or availability for each data asset. Project"},{"line_number":142,"context_line":"architects should attempt to complete this, as they understand their project in"},{"line_number":143,"context_line":"the most detail, but the OSSP will work through this with the project during"},{"line_number":144,"context_line":"the security review and are likely to add or update the impact details."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"For example:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_321c4f77","line":143,"range":{"start_line":141,"start_character":64,"end_line":143,"end_character":29},"updated":"2016-10-18 01:31:01.000000000","message":"Project architects have a detailed understanding of the project and should complete this section. The OSSP","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":138,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"The data asset impact analysis breaks down the impact of loss of"},{"line_number":141,"context_line":"confidentiality, integrity or availability for each data asset. Project"},{"line_number":142,"context_line":"architects should attempt to complete this, as they understand their project in"},{"line_number":143,"context_line":"the most detail, but the OSSP will work through this with the project during"},{"line_number":144,"context_line":"the security review and are likely to add or update the impact details."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"For example:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_a4aab983","line":143,"range":{"start_line":141,"start_character":64,"end_line":143,"end_character":29},"in_reply_to":"fa6399be_321c4f77","updated":"2016-10-18 17:33:22.000000000","message":"Leaving because this is trying to say \u0027complete this if you can but dont get too hung up on it because we will go through it and help you fix it\u0027.","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":140,"context_line":"The data asset impact analysis breaks down the impact of loss of"},{"line_number":141,"context_line":"confidentiality, integrity or availability for each data asset. Project"},{"line_number":142,"context_line":"architects should attempt to complete this, as they understand their project in"},{"line_number":143,"context_line":"the most detail, but the OSSP will work through this with the project during"},{"line_number":144,"context_line":"the security review and are likely to add or update the impact details."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"For example:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_e054afcb","line":143,"range":{"start_line":143,"start_character":25,"end_line":143,"end_character":30},"in_reply_to":"fa6399be_f202d70a","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"For example:"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"- *RabbitMQ Credentials*:"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  - Integrity Failure Impact: barbican and Workers can no longer access the"},{"line_number":151,"context_line":"    queue. Denial of service."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_052543ad","line":148,"range":{"start_line":148,"start_character":12,"end_line":148,"end_character":13},"updated":"2016-10-18 01:31:01.000000000","message":"lowercase","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"For example:"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"- *RabbitMQ Credentials*:"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  - Integrity Failure Impact: barbican and Workers can no longer access the"},{"line_number":151,"context_line":"    queue. Denial of service."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_40be3bd5","line":148,"range":{"start_line":148,"start_character":12,"end_line":148,"end_character":13},"in_reply_to":"fa6399be_052543ad","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  - Availability Failure Impact: barbican could no longer create new secrets"},{"line_number":156,"context_line":"    without access to the queue."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"- *keystone Credentials*:"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  - Integrity Failure Impact: barbican will not be able to validate user"},{"line_number":161,"context_line":"    credentials and fail. DoS."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_a53657e5","line":158,"range":{"start_line":158,"start_character":12,"end_line":158,"end_character":13},"updated":"2016-10-18 01:31:01.000000000","message":"lowercase","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  - Availability Failure Impact: barbican could no longer create new secrets"},{"line_number":156,"context_line":"    without access to the queue."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"- *keystone Credentials*:"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  - Integrity Failure Impact: barbican will not be able to validate user"},{"line_number":161,"context_line":"    credentials and fail. DoS."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_60b33f0b","line":158,"range":{"start_line":158,"start_character":12,"end_line":158,"end_character":13},"in_reply_to":"fa6399be_a53657e5","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Interfaces"},{"line_number":172,"context_line":"~~~~~~~~~~"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"The interfaces listing captures interfaces within the scope of the review:"},{"line_number":175,"context_line":"connections between blocks on the architecture diagram which cross a trust"},{"line_number":176,"context_line":"boundary or do not use an industry standard encryption protocol such as TLS or"},{"line_number":177,"context_line":"SSH. For each interface the following information is capture: the protocol"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_c54a6b55","line":174,"range":{"start_line":174,"start_character":73,"end_line":174,"end_character":74},"updated":"2016-10-18 01:31:01.000000000","message":"s/:/. This includes","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Interfaces"},{"line_number":172,"context_line":"~~~~~~~~~~"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"The interfaces listing captures interfaces within the scope of the review:"},{"line_number":175,"context_line":"connections between blocks on the architecture diagram which cross a trust"},{"line_number":176,"context_line":"boundary or do not use an industry standard encryption protocol such as TLS or"},{"line_number":177,"context_line":"SSH. For each interface the following information is capture: the protocol"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_40f2bb70","line":174,"range":{"start_line":174,"start_character":73,"end_line":174,"end_character":74},"in_reply_to":"fa6399be_c54a6b55","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":174,"context_line":"The interfaces listing captures interfaces within the scope of the review:"},{"line_number":175,"context_line":"connections between blocks on the architecture diagram which cross a trust"},{"line_number":176,"context_line":"boundary or do not use an industry standard encryption protocol such as TLS or"},{"line_number":177,"context_line":"SSH. For each interface the following information is capture: the protocol"},{"line_number":178,"context_line":"used, any data assets in transit across that interface, information on"},{"line_number":179,"context_line":"authentication used to connect to that interface and a brief description of the"},{"line_number":180,"context_line":"purpose of the interfaces. This is recorded in the following format:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_85407337","line":177,"range":{"start_line":177,"start_character":53,"end_line":177,"end_character":60},"updated":"2016-10-18 01:31:01.000000000","message":"s/capture/captured","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":174,"context_line":"The interfaces listing captures interfaces within the scope of the review:"},{"line_number":175,"context_line":"connections between blocks on the architecture diagram which cross a trust"},{"line_number":176,"context_line":"boundary or do not use an industry standard encryption protocol such as TLS or"},{"line_number":177,"context_line":"SSH. For each interface the following information is capture: the protocol"},{"line_number":178,"context_line":"used, any data assets in transit across that interface, information on"},{"line_number":179,"context_line":"authentication used to connect to that interface and a brief description of the"},{"line_number":180,"context_line":"purpose of the interfaces. This is recorded in the following format:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_20edc78e","line":177,"range":{"start_line":177,"start_character":53,"end_line":177,"end_character":60},"in_reply_to":"fa6399be_85407337","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":174,"context_line":"The interfaces listing captures interfaces within the scope of the review:"},{"line_number":175,"context_line":"connections between blocks on the architecture diagram which cross a trust"},{"line_number":176,"context_line":"boundary or do not use an industry standard encryption protocol such as TLS or"},{"line_number":177,"context_line":"SSH. For each interface the following information is capture: the protocol"},{"line_number":178,"context_line":"used, any data assets in transit across that interface, information on"},{"line_number":179,"context_line":"authentication used to connect to that interface and a brief description of the"},{"line_number":180,"context_line":"purpose of the interfaces. This is recorded in the following format:"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"From-\u003eTo *[Transport]*"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_054c6375","line":180,"range":{"start_line":177,"start_character":62,"end_line":180,"end_character":26},"updated":"2016-10-18 01:31:01.000000000","message":"perhaps format this as a bulleted list?","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":174,"context_line":"The interfaces listing captures interfaces within the scope of the review:"},{"line_number":175,"context_line":"connections between blocks on the architecture diagram which cross a trust"},{"line_number":176,"context_line":"boundary or do not use an industry standard encryption protocol such as TLS or"},{"line_number":177,"context_line":"SSH. For each interface the following information is capture: the protocol"},{"line_number":178,"context_line":"used, any data assets in transit across that interface, information on"},{"line_number":179,"context_line":"authentication used to connect to that interface and a brief description of the"},{"line_number":180,"context_line":"purpose of the interfaces. This is recorded in the following format:"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"From-\u003eTo *[Transport]*"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_e4d031fa","line":180,"range":{"start_line":177,"start_character":62,"end_line":180,"end_character":26},"in_reply_to":"fa6399be_054c6375","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"~~~~~~~~~"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"List resources relevant to the project, such as wiki pages describing its"},{"line_number":203,"context_line":"deployment and usage, as well as links to code repositories and relevant"},{"line_number":204,"context_line":"presentations"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_856793e9","line":203,"range":{"start_line":203,"start_character":22,"end_line":203,"end_character":33},"updated":"2016-10-18 01:31:01.000000000","message":"and","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":200,"context_line":"~~~~~~~~~"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"List resources relevant to the project, such as wiki pages describing its"},{"line_number":203,"context_line":"deployment and usage, as well as links to code repositories and relevant"},{"line_number":204,"context_line":"presentations"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_c0ac0b38","line":203,"range":{"start_line":203,"start_character":22,"end_line":203,"end_character":33},"in_reply_to":"fa6399be_856793e9","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":10705,"name":"Darren Chan","email":"dazzachan@yahoo.com.au","username":"daz"},"change_message_id":"de7e6bc7211a1be32e61c140ba6a226bacd76c0f","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"List resources relevant to the project, such as wiki pages describing its"},{"line_number":203,"context_line":"deployment and usage, as well as links to code repositories and relevant"},{"line_number":204,"context_line":"presentations"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_a56497e5","line":204,"range":{"start_line":204,"start_character":12,"end_line":204,"end_character":13},"updated":"2016-10-18 01:31:01.000000000","message":"Add a period","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"20447c0413356bbab18978f77f8b31ae94715346","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"List resources relevant to the project, such as wiki pages describing its"},{"line_number":203,"context_line":"deployment and usage, as well as links to code repositories and relevant"},{"line_number":204,"context_line":"presentations"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa6399be_00a7e34f","line":204,"range":{"start_line":204,"start_character":12,"end_line":204,"end_character":13},"in_reply_to":"fa6399be_a56497e5","updated":"2016-10-18 17:33:22.000000000","message":"Done","commit_id":"16f264a17ea7710aefee656be7a707e5ddb69ec7"}],"security-guide/source/security-review/objectives.rst":[{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"9cf3c101a1948271f37a9c8dc151f53faddcc8a8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- Understand how data travels between components of the system"},{"line_number":12,"context_line":"- Understand data formats and transformations"},{"line_number":13,"context_line":"- Document external dependencies"},{"line_number":14,"context_line":"- Identified who we are (and are not) protecting against"},{"line_number":15,"context_line":"- Understand the impact of degrading controls"},{"line_number":16,"context_line":"- Have a list of agreed defects"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_ee8650da","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":23},"updated":"2016-08-18 19:38:08.000000000","message":"probably can drop this","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"9cf3c101a1948271f37a9c8dc151f53faddcc8a8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- Understand data formats and transformations"},{"line_number":13,"context_line":"- Document external dependencies"},{"line_number":14,"context_line":"- Identified who we are (and are not) protecting against"},{"line_number":15,"context_line":"- Understand the impact of degrading controls"},{"line_number":16,"context_line":"- Have a list of agreed defects"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ac371cc_4e6cc436","line":15,"updated":"2016-08-18 19:38:08.000000000","message":"Might be an over-reach","commit_id":"7222202301780789591895bb97bd9748f8a76a5f"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- Know where data is persisted"},{"line_number":11,"context_line":"- Understand how data travels between components of the system"},{"line_number":12,"context_line":"- Understand data formats and transformations"},{"line_number":13,"context_line":"- Document external dependencies"},{"line_number":14,"context_line":"- Have a list of agreed defects"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_09457516","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":11},"updated":"2016-10-17 15:47:54.000000000","message":"Should there be one more: `How data travels through boundaries to and from external systems`?","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- Know where data is persisted"},{"line_number":11,"context_line":"- Understand how data travels between components of the system"},{"line_number":12,"context_line":"- Understand data formats and transformations"},{"line_number":13,"context_line":"- Document external dependencies"},{"line_number":14,"context_line":"- Have a list of agreed defects"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_646e1398","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":11},"in_reply_to":"fa6399be_09457516","updated":"2016-10-17 17:35:04.000000000","message":"thanks but have deleted this file now, i think the list of objectives in the master page is sufficient. We can always reinstate later if necessary.","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- Understand how data travels between components of the system"},{"line_number":12,"context_line":"- Understand data formats and transformations"},{"line_number":13,"context_line":"- Document external dependencies"},{"line_number":14,"context_line":"- Have a list of agreed defects"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_c9d37d5e","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":31},"updated":"2016-10-17 15:47:54.000000000","message":"a question: What constitutes agreed defects?","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- Understand how data travels between components of the system"},{"line_number":12,"context_line":"- Understand data formats and transformations"},{"line_number":13,"context_line":"- Document external dependencies"},{"line_number":14,"context_line":"- Have a list of agreed defects"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_a4e3cb32","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":31},"in_reply_to":"fa6399be_c9d37d5e","updated":"2016-10-17 17:35:04.000000000","message":"A set of findings that we have agreed with the architect or PTL. See: https://review.openstack.org/#/c/357978/13/doc/source/artifacts/barbican/newton/review-findings.rst","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"}],"security-guide/source/security-review/openstack-security-review-process.rst":[{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  of the service, and captures the information that is required for an"},{"line_number":20,"context_line":"  effective threat analysis review. A template and instructions on how to"},{"line_number":21,"context_line":"  complete the architecture page is provided at \u003clink\u003e. If further"},{"line_number":22,"context_line":"  help or advice is needed, please reach out to the Security Project via the"},{"line_number":23,"context_line":"  openstack-dev@lists.openstack.org mailing list, tagging your email"},{"line_number":24,"context_line":"  [security]."},{"line_number":25,"context_line":"- The architecture page should describe a best practice deployment. If a"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_696b5186","line":22,"range":{"start_line":22,"start_character":61,"end_line":22,"end_character":68},"updated":"2016-10-17 15:47:54.000000000","message":"project","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"- Verify that the service’s architecture page contains all the sections"},{"line_number":44,"context_line":"  listed in the Architecture Page Template \u003clink\u003e."},{"line_number":45,"context_line":"- The architecture page should include diagrams as specified in the"},{"line_number":46,"context_line":"  Architecture Diagram guidance \u003clink\u003e. TODO"},{"line_number":47,"context_line":"- Send an email to the openstack-dev@lists.openstack.org mailing list with a"},{"line_number":48,"context_line":"  [security] tag to announce the up-coming threat analysis review."},{"line_number":49,"context_line":"- Prepare a threat analysis review etherpad, using this template \u003clink\u003e. TODO"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_09e1f5fe","line":46,"range":{"start_line":46,"start_character":2,"end_line":46,"end_character":22},"updated":"2016-10-17 15:47:54.000000000","message":"nit: architecture diagram","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"- Verify that the service’s architecture page contains all the sections"},{"line_number":44,"context_line":"  listed in the Architecture Page Template \u003clink\u003e."},{"line_number":45,"context_line":"- The architecture page should include diagrams as specified in the"},{"line_number":46,"context_line":"  Architecture Diagram guidance \u003clink\u003e. TODO"},{"line_number":47,"context_line":"- Send an email to the openstack-dev@lists.openstack.org mailing list with a"},{"line_number":48,"context_line":"  [security] tag to announce the up-coming threat analysis review."},{"line_number":49,"context_line":"- Prepare a threat analysis review etherpad, using this template \u003clink\u003e. TODO"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_441f4f09","line":46,"range":{"start_line":46,"start_character":2,"end_line":46,"end_character":22},"in_reply_to":"fa6399be_09e1f5fe","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  findings in the etherpad."},{"line_number":58,"context_line":"- Ask the project architect to briefly describe the purpose of the service,"},{"line_number":59,"context_line":"  typical uses cases, who will use it and how it will be deployed."},{"line_number":60,"context_line":"  Identify the data assets that might be at risk, eg peoples photos, cat"},{"line_number":61,"context_line":"  videos, databases. Assets in flight and at rest."},{"line_number":62,"context_line":"- Briefly consider potential abuse cases, what might an attacker want to use"},{"line_number":63,"context_line":"  this service for? Could an attacker use this service as a stepping stone to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_899b4572","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":2},"updated":"2016-10-17 15:47:54.000000000","message":"is this another point if so please use `-  `","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  findings in the etherpad."},{"line_number":58,"context_line":"- Ask the project architect to briefly describe the purpose of the service,"},{"line_number":59,"context_line":"  typical uses cases, who will use it and how it will be deployed."},{"line_number":60,"context_line":"  Identify the data assets that might be at risk, eg peoples photos, cat"},{"line_number":61,"context_line":"  videos, databases. Assets in flight and at rest."},{"line_number":62,"context_line":"- Briefly consider potential abuse cases, what might an attacker want to use"},{"line_number":63,"context_line":"  this service for? Could an attacker use this service as a stepping stone to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_84196725","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":2},"in_reply_to":"fa6399be_899b4572","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"- Ask the project architect to briefly describe the purpose of the service,"},{"line_number":59,"context_line":"  typical uses cases, who will use it and how it will be deployed."},{"line_number":60,"context_line":"  Identify the data assets that might be at risk, eg peoples photos, cat"},{"line_number":61,"context_line":"  videos, databases. Assets in flight and at rest."},{"line_number":62,"context_line":"- Briefly consider potential abuse cases, what might an attacker want to use"},{"line_number":63,"context_line":"  this service for? Could an attacker use this service as a stepping stone to"},{"line_number":64,"context_line":"  attack other services? Do not spend too long on this section, as abuse cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_095e5576","line":61,"range":{"start_line":61,"start_character":21,"end_line":61,"end_character":49},"updated":"2016-10-17 15:47:54.000000000","message":"Would this be better as : \" All assets including those in flight and at rest must be identified.\"","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"- Ask the project architect to briefly describe the purpose of the service,"},{"line_number":59,"context_line":"  typical uses cases, who will use it and how it will be deployed."},{"line_number":60,"context_line":"  Identify the data assets that might be at risk, eg peoples photos, cat"},{"line_number":61,"context_line":"  videos, databases. Assets in flight and at rest."},{"line_number":62,"context_line":"- Briefly consider potential abuse cases, what might an attacker want to use"},{"line_number":63,"context_line":"  this service for? Could an attacker use this service as a stepping stone to"},{"line_number":64,"context_line":"  attack other services? Do not spend too long on this section, as abuse cases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_a4166bef","line":61,"range":{"start_line":61,"start_character":21,"end_line":61,"end_character":49},"in_reply_to":"fa6399be_095e5576","updated":"2016-10-17 17:35:04.000000000","message":"Done","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  Identify the data assets that might be at risk, eg peoples photos, cat"},{"line_number":61,"context_line":"  videos, databases. Assets in flight and at rest."},{"line_number":62,"context_line":"- Briefly consider potential abuse cases, what might an attacker want to use"},{"line_number":63,"context_line":"  this service for? Could an attacker use this service as a stepping stone to"},{"line_number":64,"context_line":"  attack other services? Do not spend too long on this section, as abuse cases"},{"line_number":65,"context_line":"  will come up as the architecture is discussed."},{"line_number":66,"context_line":"- Ask the project architect to summarize the architecture by stepping through"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_2901593a","line":63,"range":{"start_line":63,"start_character":68,"end_line":63,"end_character":69},"updated":"2016-10-17 15:47:54.000000000","message":"nit: `-`","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"- Step through typical use-case diagrams. Again consider if sensitive data is"},{"line_number":94,"context_line":"  appropriately protected. Where an entry point is identified, consider how"},{"line_number":95,"context_line":"  risks of malicious input data can be mitigated."},{"line_number":96,"context_line":"- If any potential vulnerabilities are identified, they should be discussed"},{"line_number":97,"context_line":"  with the project team, if they agree that it is an issue then a note should"},{"line_number":98,"context_line":"  be made in the findings section of the etherpad, with a short title and"},{"line_number":99,"context_line":"  summary of the issue, including a note of who found it. If the project team"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_49212db4","line":96,"range":{"start_line":96,"start_character":39,"end_line":96,"end_character":49},"updated":"2016-10-17 15:47:54.000000000","message":"As etherpads are publicly accessible will this be a good practice to identify vulnerabilities especially if they can be mitigated/fixed?","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"914f13247015dcac57fb5ecada37bc202f12ba2c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"- Step through typical use-case diagrams. Again consider if sensitive data is"},{"line_number":94,"context_line":"  appropriately protected. Where an entry point is identified, consider how"},{"line_number":95,"context_line":"  risks of malicious input data can be mitigated."},{"line_number":96,"context_line":"- If any potential vulnerabilities are identified, they should be discussed"},{"line_number":97,"context_line":"  with the project team, if they agree that it is an issue then a note should"},{"line_number":98,"context_line":"  be made in the findings section of the etherpad, with a short title and"},{"line_number":99,"context_line":"  summary of the issue, including a note of who found it. If the project team"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_04aab785","line":96,"range":{"start_line":96,"start_character":39,"end_line":96,"end_character":49},"in_reply_to":"fa6399be_49212db4","updated":"2016-10-17 17:35:04.000000000","message":"This is something we are still going over, in practise this may need to be a google doc which we can access control. This is really only an issue if we come up with something that needs an embargo.","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"}],"security-guide/source/security-review/third-party-security-review-process.rst":[{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa6399be_9430bcea","updated":"2016-10-17 15:47:54.000000000","message":"similar comments from the openstack-secutiry-review-process.rst","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"}],"security-guide/source/security-review/todo.rst":[{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"#. TA Calendar"},{"line_number":10,"context_line":"#. Wiki page saying what TAs have been done, and havent."},{"line_number":11,"context_line":"#. Etherpad template for review tracking"},{"line_number":12,"context_line":"#. process"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_543d44ba","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":55},"updated":"2016-10-17 15:47:54.000000000","message":"nit: haven\u0027t","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"38f5c51f0b4b35649fc7321925a84ecffc48306d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#. TA Calendar"},{"line_number":10,"context_line":"#. Wiki page saying what TAs have been done, and havent."},{"line_number":11,"context_line":"#. Etherpad template for review tracking"},{"line_number":12,"context_line":"#. process"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Current Status"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa6399be_d477949d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":2},"updated":"2016-10-17 15:47:54.000000000","message":"is this needed, as this word is part of the previous sentence.","commit_id":"dd481adb785ea42b02f15cb9c6b8142d41a6ba2d"}],"security-threat-analysis/source/todo.rst":[{"author":{"_account_id":7473,"name":"Grant Murphy","email":"grantcmurphy@gmail.com","username":"gm"},"change_message_id":"3ca38ee2939c1e76b2202bdae1bd50cfa111880b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"~~~~~~"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"#. page saying what TAs have been done, and havent."},{"line_number":10,"context_line":"#. Etherpad template for review tracking"},{"line_number":11,"context_line":"#. process"},{"line_number":12,"context_line":"#. Improve documentation around context for OpenStack deployments, namely that"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_6bafbb2b","line":9,"updated":"2016-10-17 20:17:03.000000000","message":"havent \u003d haven\u0027t","commit_id":"95b56f407dca889e3504c8f67950c4bfa116c360"},{"author":{"_account_id":7473,"name":"Grant Murphy","email":"grantcmurphy@gmail.com","username":"gm"},"change_message_id":"3ca38ee2939c1e76b2202bdae1bd50cfa111880b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#. Etherpad template for review tracking"},{"line_number":11,"context_line":"#. process"},{"line_number":12,"context_line":"#. Improve documentation around context for OpenStack deployments, namely that"},{"line_number":13,"context_line":"   they reflect best practice, and the documentation shoud explain what to do"},{"line_number":14,"context_line":"   when things can be changed."},{"line_number":15,"context_line":"#. Add information on filling in interfaces table from diagram."},{"line_number":16,"context_line":"#. Remove U-C, O-C, I-C guidance"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_4ba3d74f","line":13,"updated":"2016-10-17 20:17:03.000000000","message":"shoud \u003d should","commit_id":"95b56f407dca889e3504c8f67950c4bfa116c360"},{"author":{"_account_id":7473,"name":"Grant Murphy","email":"grantcmurphy@gmail.com","username":"gm"},"change_message_id":"3ca38ee2939c1e76b2202bdae1bd50cfa111880b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#. Reviewer to build sequence diagrams in real time during the review"},{"line_number":20,"context_line":"#. Document how we assess a third party review to be in line with our key"},{"line_number":21,"context_line":"   security assertions. I think perhaps we need a mapping table or something."},{"line_number":22,"context_line":"#. Should we prioritise assets."},{"line_number":23,"context_line":"#. Data assets should be listed in the architecture page before the review."},{"line_number":24,"context_line":"#. Figure out how to protect etherpad contents while retaining ability to share"},{"line_number":25,"context_line":"   and collaboratively edit it."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_cb8fe7ca","line":22,"updated":"2016-10-17 20:17:03.000000000","message":"prioritise \u003d prioritize","commit_id":"95b56f407dca889e3504c8f67950c4bfa116c360"},{"author":{"_account_id":7473,"name":"Grant Murphy","email":"grantcmurphy@gmail.com","username":"gm"},"change_message_id":"3ca38ee2939c1e76b2202bdae1bd50cfa111880b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#. Best practice for each type of asset connection"},{"line_number":30,"context_line":"#. Document what a trust boundary is"},{"line_number":31,"context_line":"#. Document what an asset is. Config file? elements within a config file?"},{"line_number":32,"context_line":"#. Documnet what level of detail we want for external dependencies and give"},{"line_number":33,"context_line":"   examples."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa6399be_8bfecf36","line":32,"updated":"2016-10-17 20:17:03.000000000","message":"Documnet \u003d Document","commit_id":"95b56f407dca889e3504c8f67950c4bfa116c360"}]}