)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     xin9972 \u003cxin.bai@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-07 13:29:31 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"update for qos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibb88fc4b7f660dca5f1d417bf8144052867dc65f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a30ddce_2196984c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":14},"updated":"2017-03-08 10:03:22.000000000","message":"You\u0027ll need to make your commit message a bit more verbose. Something like: \n\nElaborating on QoSaaS\n\nAlso adds updates for traffic shaping through\nDSCP markings, rate-limiting on a per\nport/network/tenant basis, port mirroring (through open\nsource or third-party plug-ins) and flow analysis (through\nopen source or third-party plug-ins).\n\nCloses-bug: 1447743","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d386d17d794b0a3da9b6587fc6c28a734b815dc4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lana Brindley \u003copenstack@lanabrindley.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-10 12:23:44 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"update for qos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Edit based on comments"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ibb88fc4b7f660dca5f1d417bf8144052867dc65f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_440fb187","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":22},"updated":"2017-03-10 13:53:34.000000000","message":"As I mentioned previously, please also update your commit message:\n\nElaborating on QoSaaS\n\nAlso adds updates for traffic shaping through\nDSCP markings, rate-limiting on a per\nport/network/tenant basis, port mirroring (through open\nsource or third-party plug-ins) and flow analysis (through\nopen source or third-party plug-ins).\n\nCloses-bug: 1447743","commit_id":"b9eb80ab553ccd47162f90b9a068aded711c21ca"}],"security-guide/source/networking/services.rst":[{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":118,"context_line":"Quality of Service (QoS)"},{"line_number":119,"context_line":"------------------------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"By default QoS policies and rules will be managed by the cloud"},{"line_number":122,"context_line":"administrator, that makes the tenant unable to create specific qos"},{"line_number":123,"context_line":"rules, or attaching specific ports to policies. In some use cases, like"},{"line_number":124,"context_line":"telcos, the administrator may trust the tenants, and therefore let them"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_a18fe821","line":121,"range":{"start_line":121,"start_character":3,"end_line":121,"end_character":10},"updated":"2017-03-08 10:03:22.000000000","message":"By default, Quality of Service (QoS) policies ... *","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":17893,"name":"Luke Hinds","email":"lhinds@redhat.com","username":"lhinds"},"change_message_id":"f239a4b4301c1add04e98eea1a4be330a19b7194","unresolved":false,"context_lines":[{"line_number":119,"context_line":"------------------------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"By default QoS policies and rules will be managed by the cloud"},{"line_number":122,"context_line":"administrator, that makes the tenant unable to create specific qos"},{"line_number":123,"context_line":"rules, or attaching specific ports to policies. In some use cases, like"},{"line_number":124,"context_line":"telcos, the administrator may trust the tenants, and therefore let them"},{"line_number":125,"context_line":"create and attach their own policies to ports. Those use cases would be"},{"line_number":126,"context_line":"supported by modification of policy.json and specific documentation will"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_ddff5ea8","line":123,"range":{"start_line":122,"start_character":15,"end_line":123,"end_character":5},"updated":"2017-03-08 09:37:51.000000000","message":"which results in tenants being unable to create specific QoS rules","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":121,"context_line":"By default QoS policies and rules will be managed by the cloud"},{"line_number":122,"context_line":"administrator, that makes the tenant unable to create specific qos"},{"line_number":123,"context_line":"rules, or attaching specific ports to policies. In some use cases, like"},{"line_number":124,"context_line":"telcos, the administrator may trust the tenants, and therefore let them"},{"line_number":125,"context_line":"create and attach their own policies to ports. Those use cases would be"},{"line_number":126,"context_line":"supported by modification of policy.json and specific documentation will"},{"line_number":127,"context_line":"be released with the extension."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_019d1459","line":124,"range":{"start_line":124,"start_character":47,"end_line":124,"end_character":48},"updated":"2017-03-08 10:03:22.000000000","message":"remove","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":17893,"name":"Luke Hinds","email":"lhinds@redhat.com","username":"lhinds"},"change_message_id":"f239a4b4301c1add04e98eea1a4be330a19b7194","unresolved":false,"context_lines":[{"line_number":121,"context_line":"By default QoS policies and rules will be managed by the cloud"},{"line_number":122,"context_line":"administrator, that makes the tenant unable to create specific qos"},{"line_number":123,"context_line":"rules, or attaching specific ports to policies. In some use cases, like"},{"line_number":124,"context_line":"telcos, the administrator may trust the tenants, and therefore let them"},{"line_number":125,"context_line":"create and attach their own policies to ports. Those use cases would be"},{"line_number":126,"context_line":"supported by modification of policy.json and specific documentation will"},{"line_number":127,"context_line":"be released with the extension."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_fd2c224c","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":6},"updated":"2017-03-08 09:37:51.000000000","message":"telco","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":17893,"name":"Luke Hinds","email":"lhinds@redhat.com","username":"lhinds"},"change_message_id":"f239a4b4301c1add04e98eea1a4be330a19b7194","unresolved":false,"context_lines":[{"line_number":123,"context_line":"rules, or attaching specific ports to policies. In some use cases, like"},{"line_number":124,"context_line":"telcos, the administrator may trust the tenants, and therefore let them"},{"line_number":125,"context_line":"create and attach their own policies to ports. Those use cases would be"},{"line_number":126,"context_line":"supported by modification of policy.json and specific documentation will"},{"line_number":127,"context_line":"be released with the extension."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Neutron has supported Bandwidth limiting QoS support since Liberty. QoS"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_7de832e3","line":126,"range":{"start_line":126,"start_character":29,"end_line":126,"end_character":40},"updated":"2017-03-08 09:37:51.000000000","message":"please format filename ``policy.json``: see https://docs.openstack.org/contributor-guide/rst-conv/inline-markups.html#file-name-and-path","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":17893,"name":"Luke Hinds","email":"lhinds@redhat.com","username":"lhinds"},"change_message_id":"f239a4b4301c1add04e98eea1a4be330a19b7194","unresolved":false,"context_lines":[{"line_number":123,"context_line":"rules, or attaching specific ports to policies. In some use cases, like"},{"line_number":124,"context_line":"telcos, the administrator may trust the tenants, and therefore let them"},{"line_number":125,"context_line":"create and attach their own policies to ports. Those use cases would be"},{"line_number":126,"context_line":"supported by modification of policy.json and specific documentation will"},{"line_number":127,"context_line":"be released with the extension."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Neutron has supported Bandwidth limiting QoS support since Liberty. QoS"},{"line_number":130,"context_line":"rule was named the “QosBandwidthLimitRule” and it accepts two"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_bdc9ca7a","line":127,"range":{"start_line":126,"start_character":45,"end_line":127,"end_character":31},"updated":"2017-03-08 09:37:51.000000000","message":"which specific documentation is this?","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":123,"context_line":"rules, or attaching specific ports to policies. In some use cases, like"},{"line_number":124,"context_line":"telcos, the administrator may trust the tenants, and therefore let them"},{"line_number":125,"context_line":"create and attach their own policies to ports. Those use cases would be"},{"line_number":126,"context_line":"supported by modification of policy.json and specific documentation will"},{"line_number":127,"context_line":"be released with the extension."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Neutron has supported Bandwidth limiting QoS support since Liberty. QoS"},{"line_number":130,"context_line":"rule was named the “QosBandwidthLimitRule” and it accepts two"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_e1b000e0","line":127,"range":{"start_line":126,"start_character":45,"end_line":127,"end_character":31},"in_reply_to":"9a30ddce_bdc9ca7a","updated":"2017-03-08 10:03:22.000000000","message":"Link to the docs you speak of, Xin :)","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":126,"context_line":"supported by modification of policy.json and specific documentation will"},{"line_number":127,"context_line":"be released with the extension."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Neutron has supported Bandwidth limiting QoS support since Liberty. QoS"},{"line_number":130,"context_line":"rule was named the “QosBandwidthLimitRule” and it accepts two"},{"line_number":131,"context_line":"non-negative integers: max-kbps is the bandwidth measured in kilobits"},{"line_number":132,"context_line":"per second and max-burst-kbps is the burst buffer measured in kilobits."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_81c0242c","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":7},"updated":"2017-03-08 10:03:22.000000000","message":"The Networking service (neutron)","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":127,"context_line":"be released with the extension."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Neutron has supported Bandwidth limiting QoS support since Liberty. QoS"},{"line_number":130,"context_line":"rule was named the “QosBandwidthLimitRule” and it accepts two"},{"line_number":131,"context_line":"non-negative integers: max-kbps is the bandwidth measured in kilobits"},{"line_number":132,"context_line":"per second and max-burst-kbps is the burst buffer measured in kilobits."},{"line_number":133,"context_line":"The “QoSBandwidthLimitRule” has been implemented in the Neutron Open"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_e1e720e2","line":130,"range":{"start_line":130,"start_character":20,"end_line":130,"end_character":41},"updated":"2017-03-08 10:03:22.000000000","message":"``QosBandwidthLimitRule``","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":17893,"name":"Luke Hinds","email":"lhinds@redhat.com","username":"lhinds"},"change_message_id":"f239a4b4301c1add04e98eea1a4be330a19b7194","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Neutron has supported Bandwidth limiting QoS support since Liberty. QoS"},{"line_number":130,"context_line":"rule was named the “QosBandwidthLimitRule” and it accepts two"},{"line_number":131,"context_line":"non-negative integers: max-kbps is the bandwidth measured in kilobits"},{"line_number":132,"context_line":"per second and max-burst-kbps is the burst buffer measured in kilobits."},{"line_number":133,"context_line":"The “QoSBandwidthLimitRule” has been implemented in the Neutron Open"},{"line_number":134,"context_line":"vSwitch, linuxbridge and single root input/output virtualization"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_5d9d2e58","line":131,"range":{"start_line":131,"start_character":23,"end_line":131,"end_character":31},"updated":"2017-03-08 09:37:51.000000000","message":"needs formatting","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Neutron has supported Bandwidth limiting QoS support since Liberty. QoS"},{"line_number":130,"context_line":"rule was named the “QosBandwidthLimitRule” and it accepts two"},{"line_number":131,"context_line":"non-negative integers: max-kbps is the bandwidth measured in kilobits"},{"line_number":132,"context_line":"per second and max-burst-kbps is the burst buffer measured in kilobits."},{"line_number":133,"context_line":"The “QoSBandwidthLimitRule” has been implemented in the Neutron Open"},{"line_number":134,"context_line":"vSwitch, linuxbridge and single root input/output virtualization"},{"line_number":135,"context_line":"(SR-IOV) drivers."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_a104487e","line":132,"range":{"start_line":131,"start_character":23,"end_line":132,"end_character":71},"updated":"2017-03-08 10:03:22.000000000","message":"You could do\n\n\"two non-negative integers:\n* ``max-kbps`` is the bandwidth measured in kilobits\nper second.\n*`` max-burst-kbps`` is the burst buffer measured in kilobits.","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":130,"context_line":"rule was named the “QosBandwidthLimitRule” and it accepts two"},{"line_number":131,"context_line":"non-negative integers: max-kbps is the bandwidth measured in kilobits"},{"line_number":132,"context_line":"per second and max-burst-kbps is the burst buffer measured in kilobits."},{"line_number":133,"context_line":"The “QoSBandwidthLimitRule” has been implemented in the Neutron Open"},{"line_number":134,"context_line":"vSwitch, linuxbridge and single root input/output virtualization"},{"line_number":135,"context_line":"(SR-IOV) drivers."},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_0102746f","line":133,"range":{"start_line":133,"start_character":5,"end_line":133,"end_character":26},"updated":"2017-03-08 10:03:22.000000000","message":"``QoSBandwidthLimitRule``","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":130,"context_line":"rule was named the “QosBandwidthLimitRule” and it accepts two"},{"line_number":131,"context_line":"non-negative integers: max-kbps is the bandwidth measured in kilobits"},{"line_number":132,"context_line":"per second and max-burst-kbps is the burst buffer measured in kilobits."},{"line_number":133,"context_line":"The “QoSBandwidthLimitRule” has been implemented in the Neutron Open"},{"line_number":134,"context_line":"vSwitch, linuxbridge and single root input/output virtualization"},{"line_number":135,"context_line":"(SR-IOV) drivers."},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_21f93881","line":133,"range":{"start_line":133,"start_character":56,"end_line":133,"end_character":57},"updated":"2017-03-08 10:03:22.000000000","message":"neutron*","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":131,"context_line":"non-negative integers: max-kbps is the bandwidth measured in kilobits"},{"line_number":132,"context_line":"per second and max-burst-kbps is the burst buffer measured in kilobits."},{"line_number":133,"context_line":"The “QoSBandwidthLimitRule” has been implemented in the Neutron Open"},{"line_number":134,"context_line":"vSwitch, linuxbridge and single root input/output virtualization"},{"line_number":135,"context_line":"(SR-IOV) drivers."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"The most recent addition to the QoS rules is the “QosDscpMarkingRule”,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_81ee64b2","line":134,"range":{"start_line":134,"start_character":9,"end_line":134,"end_character":20},"updated":"2017-03-08 10:03:22.000000000","message":"Linux bridge","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":134,"context_line":"vSwitch, linuxbridge and single root input/output virtualization"},{"line_number":135,"context_line":"(SR-IOV) drivers."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"The most recent addition to the QoS rules is the “QosDscpMarkingRule”,"},{"line_number":138,"context_line":"which merged in the Newton cycle. This rule marks the Differentiated"},{"line_number":139,"context_line":"Service Code Point (DSCP) value in the “type of service” header on ipv4"},{"line_number":140,"context_line":"(RFC 2474) and “traffic class” header on ipv6 on all traffic leaving a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_413b8c38","line":137,"range":{"start_line":137,"start_character":50,"end_line":137,"end_character":68},"updated":"2017-03-08 10:03:22.000000000","message":"``QosDscpMarkingRule``","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"The most recent addition to the QoS rules is the “QosDscpMarkingRule”,"},{"line_number":138,"context_line":"which merged in the Newton cycle. This rule marks the Differentiated"},{"line_number":139,"context_line":"Service Code Point (DSCP) value in the “type of service” header on ipv4"},{"line_number":140,"context_line":"(RFC 2474) and “traffic class” header on ipv6 on all traffic leaving a"},{"line_number":141,"context_line":"virtual machine that the rule is applied to. This is a 6-bit header with"},{"line_number":142,"context_line":"21 valid values that denote the drop priority of a packet as it crosses"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_612170fb","line":139,"range":{"start_line":139,"start_character":67,"end_line":139,"end_character":71},"updated":"2017-03-08 10:03:22.000000000","message":"IPv4 *","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"The most recent addition to the QoS rules is the “QosDscpMarkingRule”,"},{"line_number":138,"context_line":"which merged in the Newton cycle. This rule marks the Differentiated"},{"line_number":139,"context_line":"Service Code Point (DSCP) value in the “type of service” header on ipv4"},{"line_number":140,"context_line":"(RFC 2474) and “traffic class” header on ipv6 on all traffic leaving a"},{"line_number":141,"context_line":"virtual machine that the rule is applied to. This is a 6-bit header with"},{"line_number":142,"context_line":"21 valid values that denote the drop priority of a packet as it crosses"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_814584b4","line":139,"range":{"start_line":139,"start_character":39,"end_line":139,"end_character":56},"updated":"2017-03-08 10:03:22.000000000","message":"remove quotes","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":137,"context_line":"The most recent addition to the QoS rules is the “QosDscpMarkingRule”,"},{"line_number":138,"context_line":"which merged in the Newton cycle. This rule marks the Differentiated"},{"line_number":139,"context_line":"Service Code Point (DSCP) value in the “type of service” header on ipv4"},{"line_number":140,"context_line":"(RFC 2474) and “traffic class” header on ipv6 on all traffic leaving a"},{"line_number":141,"context_line":"virtual machine that the rule is applied to. This is a 6-bit header with"},{"line_number":142,"context_line":"21 valid values that denote the drop priority of a packet as it crosses"},{"line_number":143,"context_line":"networks should it meet congestion. It can also be used by firewalls to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_4169cc24","line":140,"range":{"start_line":140,"start_character":41,"end_line":140,"end_character":45},"updated":"2017-03-08 10:03:22.000000000","message":"IPv6","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":137,"context_line":"The most recent addition to the QoS rules is the “QosDscpMarkingRule”,"},{"line_number":138,"context_line":"which merged in the Newton cycle. This rule marks the Differentiated"},{"line_number":139,"context_line":"Service Code Point (DSCP) value in the “type of service” header on ipv4"},{"line_number":140,"context_line":"(RFC 2474) and “traffic class” header on ipv6 on all traffic leaving a"},{"line_number":141,"context_line":"virtual machine that the rule is applied to. This is a 6-bit header with"},{"line_number":142,"context_line":"21 valid values that denote the drop priority of a packet as it crosses"},{"line_number":143,"context_line":"networks should it meet congestion. It can also be used by firewalls to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_a179a8fe","line":140,"range":{"start_line":140,"start_character":15,"end_line":140,"end_character":30},"updated":"2017-03-08 10:03:22.000000000","message":"remove quotes","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":143,"context_line":"networks should it meet congestion. It can also be used by firewalls to"},{"line_number":144,"context_line":"match valid or invalid traffic against its access control list."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Tap-as-a-Service (TaaS) is an extension to the OpenStack network service"},{"line_number":147,"context_line":"(Neutron). It provides remote port mirroring capability for tenant"},{"line_number":148,"context_line":"virtual networks. Port mirroring involves sending a copy of packets"},{"line_number":149,"context_line":"entering and/or leaving one port to another port, which is usually"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_617890f3","line":146,"range":{"start_line":146,"start_character":57,"end_line":146,"end_character":64},"updated":"2017-03-08 10:03:22.000000000","message":"Networking*","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":144,"context_line":"match valid or invalid traffic against its access control list."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Tap-as-a-Service (TaaS) is an extension to the OpenStack network service"},{"line_number":147,"context_line":"(Neutron). It provides remote port mirroring capability for tenant"},{"line_number":148,"context_line":"virtual networks. Port mirroring involves sending a copy of packets"},{"line_number":149,"context_line":"entering and/or leaving one port to another port, which is usually"},{"line_number":150,"context_line":"different from the original destinations of the packets being mirrored."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_8173c414","line":147,"range":{"start_line":147,"start_character":1,"end_line":147,"end_character":2},"updated":"2017-03-08 10:03:22.000000000","message":"lowercase","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":146,"context_line":"Tap-as-a-Service (TaaS) is an extension to the OpenStack network service"},{"line_number":147,"context_line":"(Neutron). It provides remote port mirroring capability for tenant"},{"line_number":148,"context_line":"virtual networks. Port mirroring involves sending a copy of packets"},{"line_number":149,"context_line":"entering and/or leaving one port to another port, which is usually"},{"line_number":150,"context_line":"different from the original destinations of the packets being mirrored."},{"line_number":151,"context_line":"This service has been primarily designed to help tenants"},{"line_number":152,"context_line":"(or the cloud administrator) debug complex virtual networks and gain"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_2155b84f","line":149,"range":{"start_line":149,"start_character":9,"end_line":149,"end_character":13},"updated":"2017-03-08 10:03:22.000000000","message":"remove, just have \u0027or\u0027","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":155,"context_line":"capable of spanning across multiple compute and network nodes. It serves"},{"line_number":156,"context_line":"as an essential infrastructure component that can be utilized for"},{"line_number":157,"context_line":"supplying data to a variety of network analytics and security"},{"line_number":158,"context_line":"applications (e.g. IDS)."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Load balancing"},{"line_number":161,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_e1d1e0ce","line":158,"range":{"start_line":158,"start_character":14,"end_line":158,"end_character":18},"updated":"2017-03-08 10:03:22.000000000","message":"For example, IDS. * (Do not use e.g)","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":17893,"name":"Luke Hinds","email":"lhinds@redhat.com","username":"lhinds"},"change_message_id":"f239a4b4301c1add04e98eea1a4be330a19b7194","unresolved":false,"context_lines":[{"line_number":143,"context_line":"networks should it meet congestion. It can also be used by firewalls to"},{"line_number":144,"context_line":"match valid or invalid traffic against its access control list."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Tap-as-a-Service (TaaS) is an extension to the OpenStack network service"},{"line_number":147,"context_line":"(Neutron). It provides remote port mirroring capability for tenant"},{"line_number":148,"context_line":"virtual networks. Port mirroring involves sending a copy of packets"},{"line_number":149,"context_line":"entering and/or leaving one port to another port, which is usually"},{"line_number":150,"context_line":"different from the original destinations of the packets being mirrored."},{"line_number":151,"context_line":"This service has been primarily designed to help tenants"},{"line_number":152,"context_line":"(or the cloud administrator) debug complex virtual networks and gain"},{"line_number":153,"context_line":"visibility into their VMs, by monitoring the network traffic associated"},{"line_number":154,"context_line":"with them. TaaS honors tenant boundaries and its mirror sessions are"},{"line_number":155,"context_line":"capable of spanning across multiple compute and network nodes. It serves"},{"line_number":156,"context_line":"as an essential infrastructure component that can be utilized for"},{"line_number":157,"context_line":"supplying data to a variety of network analytics and security"},{"line_number":158,"context_line":"applications (e.g. IDS)."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Load balancing"},{"line_number":161,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_1d1656a7","line":158,"range":{"start_line":146,"start_character":0,"end_line":158,"end_character":24},"updated":"2017-03-08 09:37:51.000000000","message":"this is a useful, well written paragraph - but I don\u0027t see how it relates directly to QoS?","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bcdd45d491b2252b166948db36bc4ac0e082ef07","unresolved":false,"context_lines":[{"line_number":143,"context_line":"networks should it meet congestion. It can also be used by firewalls to"},{"line_number":144,"context_line":"match valid or invalid traffic against its access control list."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Tap-as-a-Service (TaaS) is an extension to the OpenStack network service"},{"line_number":147,"context_line":"(Neutron). It provides remote port mirroring capability for tenant"},{"line_number":148,"context_line":"virtual networks. Port mirroring involves sending a copy of packets"},{"line_number":149,"context_line":"entering and/or leaving one port to another port, which is usually"},{"line_number":150,"context_line":"different from the original destinations of the packets being mirrored."},{"line_number":151,"context_line":"This service has been primarily designed to help tenants"},{"line_number":152,"context_line":"(or the cloud administrator) debug complex virtual networks and gain"},{"line_number":153,"context_line":"visibility into their VMs, by monitoring the network traffic associated"},{"line_number":154,"context_line":"with them. TaaS honors tenant boundaries and its mirror sessions are"},{"line_number":155,"context_line":"capable of spanning across multiple compute and network nodes. It serves"},{"line_number":156,"context_line":"as an essential infrastructure component that can be utilized for"},{"line_number":157,"context_line":"supplying data to a variety of network analytics and security"},{"line_number":158,"context_line":"applications (e.g. IDS)."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Load balancing"},{"line_number":161,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_6177b03a","line":158,"range":{"start_line":146,"start_character":0,"end_line":158,"end_character":24},"in_reply_to":"9a30ddce_1d1656a7","updated":"2017-03-08 10:03:22.000000000","message":"Luke - Xin was focusing on updating the request for information from this bug: https://bugs.launchpad.net/ossp-security-documentation/+bug/1447743\n\nI have asked him to update the commit message to reflect that so there is no confusion :)","commit_id":"6288d9835a9e9884d43f7bc009079c50b0d50cba"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"a95b37a0c2dbdb9f213b7cd5519d525b3dda835b","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"The Networking service (neutron) supports bandwidth-limiting QoS rules in"},{"line_number":132,"context_line":"Liberty and later. This QoS rule is named ``QosBandwidthLimitRule`` and it"},{"line_number":133,"context_line":"accepts two non-negative integers: ``max-kbps`` is the bandwidth and"},{"line_number":134,"context_line":"``max-burst-kbps`` is the burst buffer, both measured in kilobits per second."},{"line_number":135,"context_line":"The ``QoSBandwidthLimitRule`` has been implemented in the Neutron Open"},{"line_number":136,"context_line":"vSwitch, Linux bridge and single root input/output virtualization (SR-IOV)"},{"line_number":137,"context_line":"drivers."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a30ddce_991f5507","line":134,"range":{"start_line":133,"start_character":8,"end_line":134,"end_character":77},"updated":"2017-03-10 11:38:51.000000000","message":"okay this reads funny. As per my previous suggestion, I think go with a little list:\n\"... accepts two non-negative integers measured in kilobits per second:\n* ``max-kbps``: bandwidth\n* ``max-burst-kbps``: burst buffer\"","commit_id":"b9eb80ab553ccd47162f90b9a068aded711c21ca"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"a95b37a0c2dbdb9f213b7cd5519d525b3dda835b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"Liberty and later. This QoS rule is named ``QosBandwidthLimitRule`` and it"},{"line_number":133,"context_line":"accepts two non-negative integers: ``max-kbps`` is the bandwidth and"},{"line_number":134,"context_line":"``max-burst-kbps`` is the burst buffer, both measured in kilobits per second."},{"line_number":135,"context_line":"The ``QoSBandwidthLimitRule`` has been implemented in the Neutron Open"},{"line_number":136,"context_line":"vSwitch, Linux bridge and single root input/output virtualization (SR-IOV)"},{"line_number":137,"context_line":"drivers."},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a30ddce_39dbc950","line":135,"range":{"start_line":135,"start_character":58,"end_line":135,"end_character":59},"updated":"2017-03-10 11:38:51.000000000","message":"lowercase","commit_id":"b9eb80ab553ccd47162f90b9a068aded711c21ca"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"a95b37a0c2dbdb9f213b7cd5519d525b3dda835b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"networks should it meet congestion. It can also be used by firewalls to"},{"line_number":145,"context_line":"match valid or invalid traffic against its access control list."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Tap-as-a-Service (TaaS) is an extension to the OpenStack networking"},{"line_number":148,"context_line":"service (neutron). It provides remote port mirroring capability for"},{"line_number":149,"context_line":"tenant virtual networks. Port mirroring involves sending a copy of"},{"line_number":150,"context_line":"packets entering or leaving one port to another port, which is usually"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a30ddce_59b79df4","line":147,"range":{"start_line":147,"start_character":0,"end_line":147,"end_character":23},"updated":"2017-03-10 11:38:51.000000000","message":"this doesn\u0027t appear to really flow with the above information that\u0027s all about QoS.\nHow does QoS and TaaS link? You probably need another para between. Or, another section.","commit_id":"b9eb80ab553ccd47162f90b9a068aded711c21ca"}]}