)]}'
{"id":"openstack%2Fsecurity-doc~596607","triplet_id":"openstack%2Fsecurity-doc~master~If0537575f44e5a42be38bdf72106f170b38922da","project":"openstack/security-doc","branch":"master","hashtags":[],"change_id":"If0537575f44e5a42be38bdf72106f170b38922da","subject":"Fix the wrong link URL of \u0027doc-contrib-guide\u0027 for cleanup","status":"MERGED","created":"2018-08-26 15:04:27.000000000","updated":"2018-08-29 02:28:35.000000000","submitted":"2018-08-29 02:28:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"596607-1535509715641-77e378f6","meta_rev_id":"51b339fe2dbaf6114e6a2e7fa00dab18b2cb250a","_number":596607,"virtual_id_number":596607,"owner":{"_account_id":14320,"name":"xuan.mingyi","email":"xuan.mingyi@99cloud.net","username":"mingyi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14320,"name":"xuan.mingyi","email":"xuan.mingyi@99cloud.net","username":"mingyi"},{"value":0,"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"value":2,"date":"2018-08-29 02:28:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"disliked":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"all":[{"value":0,"_account_id":14320,"name":"xuan.mingyi","email":"xuan.mingyi@99cloud.net","username":"mingyi"},{"value":-1,"date":"2018-08-28 00:58:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},{"value":2,"date":"2018-08-28 10:35:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":2,"date":"2018-08-29 02:20:58.000000000","_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"all":[{"value":0,"_account_id":14320,"name":"xuan.mingyi","email":"xuan.mingyi@99cloud.net","username":"mingyi"},{"value":0,"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":1,"date":"2018-08-29 02:20:58.000000000","_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":14320,"name":"xuan.mingyi","email":"xuan.mingyi@99cloud.net","username":"mingyi"},{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-08-28 00:58:25.000000000","updated_by":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"reviewer":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"state":"REVIEWER"},{"updated":"2018-08-28 10:35:28.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2018-08-29 02:20:58.000000000","updated_by":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"reviewer":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"state":"REVIEWER"},{"updated":"2018-08-29 02:28:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4ae6d64969fc8593f7e99a95f9b825b9e535ac7e","author":{"_account_id":14320,"name":"xuan.mingyi","email":"xuan.mingyi@99cloud.net","username":"mingyi"},"date":"2018-08-26 15:04:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9a01988ac9d17b7341de98ff4889ebb2484a13cf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-26 15:08:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-linters http://logs.openstack.org/07/596607/1/check/openstack-tox-linters/c05690c/ : SUCCESS in 2m 40s\n- build-tox-manuals-checkbuild http://logs.openstack.org/07/596607/1/check/build-tox-manuals-checkbuild/e7ce94d/publish-docs/ : SUCCESS in 2m 49s","accounts_in_message":[],"_revision_number":1},{"id":"1d5be3aa93bd22d0d4376eac2f42ce527802c640","author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"date":"2018-08-27 10:37:23.000000000","message":"Patch Set 1: Code-Review-2\n\nAs we have redirect rules[1], this URL still works. If we merged this one, someone else may commit a same patch to correct such URL. It makes little sense.\n\n[1] https://github.com/openstack/openstack-manuals/blob/master/www/redirect-tests.txt#L164","accounts_in_message":[],"_revision_number":1},{"id":"a2af5afa6da1bd85ade98726637811a4d4a4b9fd","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2018-08-27 11:20:56.000000000","message":"Patch Set 1:\n\nwe have a redirect rule - but should change the link to point to new page. Redirect rule says \"moved permanently\" - we want to remove old redirect rules at one point. I suggest to merge this.\n\nI suggest we merge a single patch that fixes *all* cases in this repo.","accounts_in_message":[],"_revision_number":1},{"id":"19b955b0da65053ff44432e3edfb38f325dc730f","author":{"_account_id":14320,"name":"xuan.mingyi","email":"xuan.mingyi@99cloud.net","username":"mingyi"},"date":"2018-08-27 12:56:53.000000000","message":"Patch Set 1:\n\n\u003e we have a redirect rule - but should change the link to point to\n \u003e new page. Redirect rule says \"moved permanently\" - we want to\n \u003e remove old redirect rules at one point. I suggest to merge this.\n \u003e \n \u003e I suggest we merge a single patch that fixes *all* cases in this\n \u003e repo.\n\nThere is only one \u0027rst\u0027 file has this wrong url, so this patch fixes *all* cases in this repo.","accounts_in_message":[],"_revision_number":1},{"id":"4f17d8a240ad60b5131f3ff7242ffae42a6112ce","author":{"_account_id":14320,"name":"xuan.mingyi","email":"xuan.mingyi@99cloud.net","username":"mingyi"},"date":"2018-08-27 13:03:35.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"360c50691e3ae0b4ab89f8cad5e2b9b430eb4b40","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-27 13:10:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-linters http://logs.openstack.org/07/596607/2/check/openstack-tox-linters/8668e5c/ : SUCCESS in 2m 26s\n- build-tox-manuals-checkbuild http://logs.openstack.org/07/596607/2/check/build-tox-manuals-checkbuild/1a73f2f/publish-docs/ : SUCCESS in 3m 35s","accounts_in_message":[],"_revision_number":2},{"id":"e307dd05b4c403a4e9505122377315ca23875be0","author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"date":"2018-08-28 00:58:25.000000000","message":"Patch Set 2: Code-Review-1\n\nChange my -2 to -1. If others need this patch, ignore my -1.","accounts_in_message":[],"_revision_number":2},{"id":"c75d0897ad363bc05fa2ebc911cc0eb5bdcabd8f","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2018-08-28 10:35:28.000000000","message":"Patch Set 2: Code-Review+2\n\nYes, I think this change is fine and we should take it.\n\nAlso, let\u0027s do one change for a whole repo - there\u0027s https://review.openstack.org/#/c/596606/ with additional fixes. I would rather have one going forward.","accounts_in_message":[],"_revision_number":2},{"id":"0c8d13dccfb0be547becc9ba5d0f4108c11b48b6","author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"date":"2018-08-29 02:20:58.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6f5ca5f621c5a05b9660f85e413672daaabeb100","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-29 02:21:09.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"56bb5b8094072c734ec3ec658b5bfd7310618f3c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-29 02:28:35.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-linters http://logs.openstack.org/07/596607/2/gate/openstack-tox-linters/be6977e/ : SUCCESS in 2m 36s\n- build-tox-manuals-checkbuild http://logs.openstack.org/07/596607/2/gate/build-tox-manuals-checkbuild/2dcd039/publish-docs/ : SUCCESS in 2m 42s","accounts_in_message":[],"_revision_number":2},{"id":"51b339fe2dbaf6114e6a2e7fa00dab18b2cb250a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-29 02:28:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d3e9356d227a8a958a12024c35bf8174fa76eb64","revisions":{"d3b7049188a36480f44691e8dd4cfcaa79b612be":{"kind":"REWORK","_number":1,"created":"2018-08-26 15:04:27.000000000","uploader":{"_account_id":14320,"name":"xuan.mingyi","email":"xuan.mingyi@99cloud.net","username":"mingyi"},"ref":"refs/changes/07/596607/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/security-doc","ref":"refs/changes/07/596607/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/security-doc refs/changes/07/596607/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/security-doc refs/changes/07/596607/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/security-doc refs/changes/07/596607/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/security-doc refs/changes/07/596607/1"}}},"commit":{"parents":[{"commit":"2021d1ed339fc7e70fc575b071a458219f1fe0a9","subject":"Update the zabbix link to https","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/security-doc/commit/2021d1ed339fc7e70fc575b071a458219f1fe0a9"}]}],"author":{"name":"root","email":"xuan.mingyi@99cloud.net","date":"2018-08-26 15:03:41.000000000","tz":0},"committer":{"name":"root","email":"xuan.mingyi@99cloud.net","date":"2018-08-26 15:04:25.000000000","tz":0},"subject":"Fix the wrong link URL of \u0027doc-contrib-guide\u0027","message":"Fix the wrong link URL of \u0027doc-contrib-guide\u0027\n\nSince Queens update the link URL of \u0027Documentation Contributor Guide\u0027\nto distinguish this document from the new document aimed at all\nnew OpenStack contributors. So this patch correct the wrong url.\nRefer to \u0027https://docs.openstack.org/releasenotes/openstack-manuals/queens\u0027\n\nChange-Id: If0537575f44e5a42be38bdf72106f170b38922da\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/security-doc/commit/d3b7049188a36480f44691e8dd4cfcaa79b612be"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/security-doc/commit/d3b7049188a36480f44691e8dd4cfcaa79b612be"}]},"branch":"refs/heads/master"},"d3e9356d227a8a958a12024c35bf8174fa76eb64":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2018-08-27 13:03:35.000000000","uploader":{"_account_id":14320,"name":"xuan.mingyi","email":"xuan.mingyi@99cloud.net","username":"mingyi"},"ref":"refs/changes/07/596607/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/security-doc","ref":"refs/changes/07/596607/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/security-doc refs/changes/07/596607/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/security-doc refs/changes/07/596607/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/security-doc refs/changes/07/596607/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/security-doc refs/changes/07/596607/2"}}},"commit":{"parents":[{"commit":"2021d1ed339fc7e70fc575b071a458219f1fe0a9","subject":"Update the zabbix link to https","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/security-doc/commit/2021d1ed339fc7e70fc575b071a458219f1fe0a9"}]}],"author":{"name":"root","email":"xuan.mingyi@99cloud.net","date":"2018-08-26 15:03:41.000000000","tz":0},"committer":{"name":"xuan.mingyi","email":"xuan.mingyi@99cloud.net","date":"2018-08-27 13:03:28.000000000","tz":0},"subject":"Fix the wrong link URL of \u0027doc-contrib-guide\u0027 for cleanup","message":"Fix the wrong link URL of \u0027doc-contrib-guide\u0027 for cleanup\n\nSince Queens update the link URL of \u0027Documentation Contributor Guide\u0027\nto distinguish this document from the new document aimed at all\nnew OpenStack contributors. So this patch correct the wrong url.\nRefer to \u0027https://docs.openstack.org/releasenotes/openstack-manuals/queens\u0027\n\nChange-Id: If0537575f44e5a42be38bdf72106f170b38922da\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/security-doc/commit/d3e9356d227a8a958a12024c35bf8174fa76eb64"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/security-doc/commit/d3e9356d227a8a958a12024c35bf8174fa76eb64"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}