)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5494ce0e1ad1651b5c95abd19060fefeff24fde4","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bump minimum tox version to 3.18.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"for fix https://zuul.opendev.org/t/openstack/build/48cdb19fc6da46468e8586691cf3b8b6"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I91bdbb298c14f6335c52cf84e3d49017000f5e7a"},{"line_number":12,"context_line":"Signed-off-by: Ivan Anfimov \u003clazekteam@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3911ce90_dcc63873","line":9,"updated":"2025-07-15 15:13:47.000000000","message":"The real issue you are addressing is that generatepot-rst.sh was not in the allowlist_externals.  Bumping tox to 3.18.0 is required because that\u0027s the minimum version that recognizes \u0027allowlist_externals\u0027.  You are also changing the min version of doc8 and openstackdocstheme ... it would be worth saying why you are making those changes.","commit_id":"90ff6221f2d35964431bdf3e8dade842262f4a02"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"476b4c554f47adc3ca305bd72f49479f202a905c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bump minimum tox version to 3.18.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"for fix https://zuul.opendev.org/t/openstack/build/48cdb19fc6da46468e8586691cf3b8b6"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I91bdbb298c14f6335c52cf84e3d49017000f5e7a"},{"line_number":12,"context_line":"Signed-off-by: Ivan Anfimov \u003clazekteam@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"d3a36247_0c2cb67c","line":9,"in_reply_to":"3911ce90_dcc63873","updated":"2025-07-15 15:25:37.000000000","message":"Hello,\n\nYes, this right, even without these changes we will still get the required versions, you are right:\n\nhttps://zuul.opendev.org/t/openstack/build/ee13d7a84b9c4bdf8530cb16f1f28be3/console\n\n  Downloading https://mirror.bhs1.ovh.opendev.org/pypifiles/packages/b9/46/7d336cf9e68e21c57813afcef4957691c90a3b4608938ee11f6fba406fd7/openstackdocstheme-3.5.0-py3-none-any.whl.metadata (2.7 kB)\nCollecting Babel!\u003d2.4.0,\u003e\u003d2.3.4 (from -r /home/zuul/src/opendev.org/openstack/security-doc/test-requirements.txt (line 11))","commit_id":"90ff6221f2d35964431bdf3e8dade842262f4a02"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"006320c0999a47354432aa096ebbcead979380e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a4fea5b7_45684539","updated":"2025-07-15 14:14:13.000000000","message":"The build link shows the following error but I don\u0027t think any of the change proposed in this review fixes it ...\n\n\n```\ngeneratepot-rst: failed with /home/zuul/src/opendev.org/openstack/security-doc/tools/generatepot-rst.sh (resolves to /home/zuul/src/opendev.org/openstack/security-doc/tools/generatepot-rst.sh) is not allowed, use allowlist_externals to allow it\n```","commit_id":"4b0d2f9703c486e2c9f670ec24363f44425bacc8"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"b44b29f7e6f1f155f0700c23d7e7d60b4d474fcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9c0b41c0_d3aec998","in_reply_to":"1563eb76_a2c404de","updated":"2025-07-15 14:21:17.000000000","message":"Hello @kajinamit@oss.nttdata.com\n\nYes, your right, add small new change in 59 line in tox.ini.","commit_id":"4b0d2f9703c486e2c9f670ec24363f44425bacc8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"94d917765ea23d4a6c56c2d26197a9fbaaded6f2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1563eb76_a2c404de","in_reply_to":"a4fea5b7_45684539","updated":"2025-07-15 14:19:53.000000000","message":"Again, this does not fix the problem you mentioned. What you need to allow is `{toxinidir}/tools/generatepot-rst.sh` and the change of tox.ini has no effect.\n\nAlso I don\u0027t know the exact reason why we need to explicitly bump min version of test requirements.","commit_id":"4b0d2f9703c486e2c9f670ec24363f44425bacc8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5494ce0e1ad1651b5c95abd19060fefeff24fde4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"382f9fc3_ee75cb8f","updated":"2025-07-15 15:13:47.000000000","message":"Thanks for fixing this.  See comment inline.","commit_id":"90ff6221f2d35964431bdf3e8dade842262f4a02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7303b2317aeb76f00d89c80ee855c9be839c1e53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f4191698_6a1e3fe0","updated":"2025-09-12 17:37:26.000000000","message":"recheck","commit_id":"73ff8e45aa0f9716b8457c0308248c2c0aef2f70"}],"tox.ini":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"25753a01777eb0fd5348637e5d104ce14089af94","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 4.6.0"},{"line_number":3,"context_line":"envlist \u003d linters,publishdocs"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"8a06e791_8b24fd99","line":2,"range":{"start_line":2,"start_character":13,"end_line":2,"end_character":18},"updated":"2025-07-15 14:14:40.000000000","message":"We don\u0027t need 4.6.0 but 3.18.0 may be enough to sue allowlist_externals.","commit_id":"4b0d2f9703c486e2c9f670ec24363f44425bacc8"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"1ec1212d11b44de4afc81ca6c547400487c8ea52","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 4.6.0"},{"line_number":3,"context_line":"envlist \u003d linters,publishdocs"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"e95ceba7_94f711b6","line":2,"range":{"start_line":2,"start_character":13,"end_line":2,"end_character":18},"in_reply_to":"8a06e791_8b24fd99","updated":"2025-07-15 14:18:14.000000000","message":"Done","commit_id":"4b0d2f9703c486e2c9f670ec24363f44425bacc8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"33bfe40cd4cce856ae88865aef87ab2d4ce3e321","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"[testenv:generatepot-rst]"},{"line_number":54,"context_line":"allowlist_externals \u003d"},{"line_number":55,"context_line":"  mkdir"},{"line_number":56,"context_line":"  rm"},{"line_number":57,"context_line":"  rsync"},{"line_number":58,"context_line":"  bash"},{"line_number":59,"context_line":"  {toxinidir}/tools/generatepot-rst.sh"},{"line_number":60,"context_line":"# Generate POT files for translation, needs {posargs} like:"},{"line_number":61,"context_line":"# tox -e generatepot-rst -- security-guide"}],"source_content_type":"text/x-properties","patch_set":7,"id":"5ec2ce8e_1c062ebb","line":58,"range":{"start_line":55,"start_character":1,"end_line":58,"end_character":6},"updated":"2025-07-15 14:21:51.000000000","message":"you don\u0027t need to allow these, because none of these is used in commands.","commit_id":"d7fba1487092bc3db03fe005198d0bc8f1e2cbca"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"8f3b5b55bc41533121b5cedff621c156ccc9992b","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"[testenv:generatepot-rst]"},{"line_number":54,"context_line":"allowlist_externals \u003d"},{"line_number":55,"context_line":"  mkdir"},{"line_number":56,"context_line":"  rm"},{"line_number":57,"context_line":"  rsync"},{"line_number":58,"context_line":"  bash"},{"line_number":59,"context_line":"  {toxinidir}/tools/generatepot-rst.sh"},{"line_number":60,"context_line":"# Generate POT files for translation, needs {posargs} like:"},{"line_number":61,"context_line":"# tox -e generatepot-rst -- security-guide"}],"source_content_type":"text/x-properties","patch_set":7,"id":"c502239f_64730b23","line":58,"range":{"start_line":55,"start_character":1,"end_line":58,"end_character":6},"in_reply_to":"5ec2ce8e_1c062ebb","updated":"2025-07-15 14:27:43.000000000","message":"Done","commit_id":"d7fba1487092bc3db03fe005198d0bc8f1e2cbca"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"8a64ef90fcc97f56d3c15672a0f56639f07d9822","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"[testenv:generatepot-rst]"},{"line_number":54,"context_line":"allowlist_externals \u003d"},{"line_number":55,"context_line":"  mkdir"},{"line_number":56,"context_line":"  rm"},{"line_number":57,"context_line":"  rsync"},{"line_number":58,"context_line":"  bash"},{"line_number":59,"context_line":"  {toxinidir}/tools/generatepot-rst.sh"},{"line_number":60,"context_line":"# Generate POT files for translation, needs {posargs} like:"},{"line_number":61,"context_line":"# tox -e generatepot-rst -- security-guide"}],"source_content_type":"text/x-properties","patch_set":7,"id":"df5cdd66_31f82211","line":58,"range":{"start_line":55,"start_character":1,"end_line":58,"end_character":6},"in_reply_to":"c502239f_64730b23","updated":"2025-07-15 14:28:21.000000000","message":"Yep, your right, just in training repo rm need too.. Sorry, sorted.","commit_id":"d7fba1487092bc3db03fe005198d0bc8f1e2cbca"}]}