)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"671771e1c4092807e162c5c119b327cb5d574961","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"976a1661_9b7def0f","updated":"2026-04-22 13:34:20.000000000","message":"Suggestion inline.  The question is aimed more at Jeremy, who\u0027s been working on this longer than any of us.","commit_id":"614cbcd30fd5ce2f055ca9c68970e7280277da0c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"38fe222e52b5af4c435f798f7816c35507e3d711","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"94f127f5_7846e806","updated":"2026-04-22 21:21:10.000000000","message":"LGTM.","commit_id":"fe8e1554d7be22ed9a7aeabc1dfe925b35f3161c"}],"security-notes/OSSN-0095":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"235fc80a6d719abc85ff89e9ba96c8e813f06987","unresolved":true,"context_lines":[{"line_number":30,"context_line":"### Recommended Actions ###"},{"line_number":31,"context_line":"Upgrade to a version of neutron containing the fix"},{"line_number":32,"context_line":"(https://review.opendev.org/c/openstack/neutron/+/976832) and"},{"line_number":33,"context_line":"restart the neutron OVN services. The maintenance task will"},{"line_number":34,"context_line":"correct pre-existing rules automatically. Operators should verify"},{"line_number":35,"context_line":"that orphaned ACLs from previously deleted rules are removed."},{"line_number":36,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"8652f000_33b6cff9","line":33,"range":{"start_line":33,"start_character":20,"end_line":33,"end_character":32},"updated":"2026-04-22 20:21:30.000000000","message":"I would just change this to \u0027services\u0027 as it\u0027s the neutron server that will do this.","commit_id":"8100a601d28230154a1e6fec93a6e50f905a3a0c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0244ec0bbf430f9b2024c401075e687982eedd4d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"### Recommended Actions ###"},{"line_number":31,"context_line":"Upgrade to a version of neutron containing the fix"},{"line_number":32,"context_line":"(https://review.opendev.org/c/openstack/neutron/+/976832) and"},{"line_number":33,"context_line":"restart the neutron OVN services. The maintenance task will"},{"line_number":34,"context_line":"correct pre-existing rules automatically. Operators should verify"},{"line_number":35,"context_line":"that orphaned ACLs from previously deleted rules are removed."},{"line_number":36,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"d0d3a27a_e2686cf3","line":33,"range":{"start_line":33,"start_character":20,"end_line":33,"end_character":32},"in_reply_to":"8652f000_33b6cff9","updated":"2026-04-22 20:52:37.000000000","message":"Ack, thanks for raising this; makes sense","commit_id":"8100a601d28230154a1e6fec93a6e50f905a3a0c"}],"test-requirements.txt":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"671771e1c4092807e162c5c119b327cb5d574961","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"doc8 # Apache-2.0"},{"line_number":6,"context_line":"openstack-doc-tools\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":7,"context_line":"sphinx\u003e\u003d2.0.0,!\u003d2.1.0 # BSD"},{"line_number":8,"context_line":"openstackdocstheme\u003e\u003d2.1.1 # Apache-2.0"},{"line_number":9,"context_line":""}],"source_content_type":"text/plain","patch_set":2,"id":"29c71cf4_1421de4c","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":26},"updated":"2026-04-22 13:34:20.000000000","message":"We should make this \u003e\u003d2.0.0,!\u003d4.0.2\n\nThat will unblock us now, and we\u0027ll have to do it anyway regardless of how long it takes your fix to get into openstack-doc-tools and a new release cut and upper constraints is updated.","commit_id":"614cbcd30fd5ce2f055ca9c68970e7280277da0c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"be5bb8a35a7f9520d1f5e1c97688a72d12eeff3e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"doc8 # Apache-2.0"},{"line_number":6,"context_line":"openstack-doc-tools\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":7,"context_line":"sphinx\u003e\u003d2.0.0,!\u003d2.1.0 # BSD"},{"line_number":8,"context_line":"openstackdocstheme\u003e\u003d2.1.1 # Apache-2.0"},{"line_number":9,"context_line":""}],"source_content_type":"text/plain","patch_set":2,"id":"04af4dfd_2dd66f12","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":26},"in_reply_to":"29c71cf4_1421de4c","updated":"2026-04-22 15:14:46.000000000","message":"Ack, makes sense. Thank you both.","commit_id":"614cbcd30fd5ce2f055ca9c68970e7280277da0c"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"0849e58ce1aea21e134a77a84ed87d46053d28f2","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"doc8 # Apache-2.0"},{"line_number":6,"context_line":"openstack-doc-tools\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":7,"context_line":"sphinx\u003e\u003d2.0.0,!\u003d2.1.0 # BSD"},{"line_number":8,"context_line":"openstackdocstheme\u003e\u003d2.1.1 # Apache-2.0"},{"line_number":9,"context_line":""}],"source_content_type":"text/plain","patch_set":2,"id":"ac02c211_4ff2ecb8","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":26},"in_reply_to":"29c71cf4_1421de4c","updated":"2026-04-22 13:49:40.000000000","message":"Agreed, that\u0027ll avoid waiting for a new release, but if you don\u0027t want to wait for the fix to merge you\u0027ll also need to remove its Depends-On trailer from this commit message.","commit_id":"614cbcd30fd5ce2f055ca9c68970e7280277da0c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bf53d559689000378903908c676ae90d97195aea","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"doc8 # Apache-2.0"},{"line_number":6,"context_line":"openstack-doc-tools\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":7,"context_line":"sphinx\u003e\u003d2.0.0,!\u003d2.1.0 # BSD"},{"line_number":8,"context_line":"openstackdocstheme\u003e\u003d2.1.1 # Apache-2.0"},{"line_number":9,"context_line":""}],"source_content_type":"text/plain","patch_set":2,"id":"478840d9_d9bde0f8","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":26},"in_reply_to":"ac02c211_4ff2ecb8","updated":"2026-04-22 13:59:54.000000000","message":"good point!","commit_id":"614cbcd30fd5ce2f055ca9c68970e7280277da0c"}],"tox.ini":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"671771e1c4092807e162c5c119b327cb5d574961","unresolved":true,"context_lines":[{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d"},{"line_number":8,"context_line":"  VIRTUAL_ENV\u003d{envdir}"},{"line_number":9,"context_line":"deps \u003d"},{"line_number":10,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":11,"context_line":"allowlist_externals \u003d"},{"line_number":12,"context_line":"  bash"}],"source_content_type":"text/x-properties","patch_set":2,"id":"6f3e360a_88c37b2f","line":9,"updated":"2026-04-22 13:34:20.000000000","message":"It wouldn\u0027t have helped for this particular issue, but is there a reason why we don\u0027t use upper constraints for these environments?","commit_id":"614cbcd30fd5ce2f055ca9c68970e7280277da0c"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"0849e58ce1aea21e134a77a84ed87d46053d28f2","unresolved":true,"context_lines":[{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d"},{"line_number":8,"context_line":"  VIRTUAL_ENV\u003d{envdir}"},{"line_number":9,"context_line":"deps \u003d"},{"line_number":10,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":11,"context_line":"allowlist_externals \u003d"},{"line_number":12,"context_line":"  bash"}],"source_content_type":"text/x-properties","patch_set":2,"id":"ade7b7d8_2b10e157","line":9,"in_reply_to":"6f3e360a_88c37b2f","updated":"2026-04-22 13:49:40.000000000","message":"I don\u0027t see any reason it couldn\u0027t use upper-constraints.txt from requirements, as long as the requirements files in this repo don\u0027t conflict with the global-requirements.txt (and we might need an additional job to confirm that).","commit_id":"614cbcd30fd5ce2f055ca9c68970e7280277da0c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"be5bb8a35a7f9520d1f5e1c97688a72d12eeff3e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d"},{"line_number":8,"context_line":"  VIRTUAL_ENV\u003d{envdir}"},{"line_number":9,"context_line":"deps \u003d"},{"line_number":10,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":11,"context_line":"allowlist_externals \u003d"},{"line_number":12,"context_line":"  bash"}],"source_content_type":"text/x-properties","patch_set":2,"id":"faab259f_dac99dc4","line":9,"in_reply_to":"ade7b7d8_2b10e157","updated":"2026-04-22 15:14:46.000000000","message":"yeah, can do in a different patch..","commit_id":"614cbcd30fd5ce2f055ca9c68970e7280277da0c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"876d14dca53e82293db6c10a111489572b70aaaa","unresolved":false,"context_lines":[{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d"},{"line_number":8,"context_line":"  VIRTUAL_ENV\u003d{envdir}"},{"line_number":9,"context_line":"deps \u003d"},{"line_number":10,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":11,"context_line":"allowlist_externals \u003d"},{"line_number":12,"context_line":"  bash"}],"source_content_type":"text/x-properties","patch_set":2,"id":"a7bb44e0_4d1bc590","line":9,"in_reply_to":"faab259f_dac99dc4","updated":"2026-04-22 21:47:36.000000000","message":"doing that here: https://review.opendev.org/c/openstack/security-doc/+/985897/","commit_id":"614cbcd30fd5ce2f055ca9c68970e7280277da0c"}]}
