)]}'
{"specs/kilo/anchor/seperate-validator-functionality.rst":[{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"aed645bd97edd89e138a0fee2f8939e810a031a0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently the Anchor CSR validation functionality is all located in the"},{"line_number":19,"context_line":"Anchor package. This prevents this functionality easily being imported"},{"line_number":20,"context_line":"and used by other projects. Therefore, the validation functionality"},{"line_number":21,"context_line":"should be split out into a module under anchor, so it can be imported by"},{"line_number":22,"context_line":"other projects. This will probide a simple API to the validation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_0a125509","line":19,"updated":"2015-09-29 22:11:24.000000000","message":"missing a word and sounds a little odd, maybe something along the lines of:\n\n    This prevents the functionality from being easily imported and used by other projects.","commit_id":"e000f9d549bccad58b41684cfd516579701ed315"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"aed645bd97edd89e138a0fee2f8939e810a031a0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Anchor package. This prevents this functionality easily being imported"},{"line_number":20,"context_line":"and used by other projects. Therefore, the validation functionality"},{"line_number":21,"context_line":"should be split out into a module under anchor, so it can be imported by"},{"line_number":22,"context_line":"other projects. This will probide a simple API to the validation"},{"line_number":23,"context_line":"functionality, that can be used by both Anchor and other projects."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This will enable re-use of the CSR validation functionality in other"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_caf8ddc5","line":22,"updated":"2015-09-29 22:11:24.000000000","message":"s/probide/provide","commit_id":"e000f9d549bccad58b41684cfd516579701ed315"}],"specs/liberty/anchor/seperate-validator-functionality.rst":[{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"7c6efd7b754a71bc972b0e50ca15f0b0b314c133","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Currently the Anchor CSR validation functionality is all located in the"},{"line_number":26,"context_line":"Anchor package. This prevents this functionality easily being imported"},{"line_number":27,"context_line":"and used by other projects. Therefore, the validation functionality"},{"line_number":28,"context_line":"should be split out so it can be imported by other projects."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Secondly, the code that performs validation of a CSR aborts when one of"},{"line_number":31,"context_line":"the validators fails - this works ok for Anchor, but the validation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_c841643b","line":28,"updated":"2015-09-24 23:58:08.000000000","message":"I\u0027m not sure about separating validators into a different package though. Do you know of a specific use case for it? It seems very much Anchor-specific. If we do go for this, we\u0027d have to split not only the validators, but make Anchor 3 packages:\n\n- Anchor the dispatcher/runner\n\n- Anchor.x509 (all the certificate parsers / abstractions / interface / ...)\n\n- Anchor.validators (actual validators collection)\n\nPotentially x509 and validators could be the same package, but the main point is that validators depend on the way we use abstractions. The split itself shouldn\u0027t be an issue, but additional overhead in managing this is going to be a pain. It adds the problem of managing versions between anchor and anchor.validators which we\u0027d have to get through global-requirements. (since we don\u0027t really control our versions anymore)","commit_id":"5f41227c79a39fdaecba0815c28782c5044cb5f4"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"7c6efd7b754a71bc972b0e50ca15f0b0b314c133","unresolved":false,"context_lines":[{"line_number":31,"context_line":"the validators fails - this works ok for Anchor, but the validation"},{"line_number":32,"context_line":"engine can be extended to provide added value for other services by"},{"line_number":33,"context_line":"running all validators and returning a dictionary, giving the result"},{"line_number":34,"context_line":"of each validator that was run."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_48ba34e3","line":34,"updated":"2015-09-24 23:58:08.000000000","message":"I agree this would be very useful, even inside Anchor itself. It would give us some nicer errors in the logs instead of just the first failure.\n\nShouldn\u0027t it be a separate change from the first point? They seem completely independent.","commit_id":"5f41227c79a39fdaecba0815c28782c5044cb5f4"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"7c6efd7b754a71bc972b0e50ca15f0b0b314c133","unresolved":false,"context_lines":[{"line_number":42,"context_line":"throw an exception if an error occured."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Modify certificate_ops.py to work with the new validation.py and"},{"line_number":45,"context_line":"dictionary return, while catching any exceptions thrown."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Fix the tests to work with this new functionality."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_a852f0db","line":45,"updated":"2015-09-24 23:58:08.000000000","message":"This seems to suggest something different than problem description: \"Currently the Anchor CSR validation functionality is all located in the Anchor package.\" This change would still keep everything in one package, just with the runner in a separate file.\n\nJust to make it clear - are you proposing different packages, or a clear library-like API in the current package?\n\nIt would be easier to discuss if there was a clear \"who\u0027s going to use it, why, and for what purpose\".","commit_id":"5f41227c79a39fdaecba0815c28782c5044cb5f4"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"7c6efd7b754a71bc972b0e50ca15f0b0b314c133","unresolved":false,"context_lines":[{"line_number":56,"context_line":"----------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Target Milestone for completion:"},{"line_number":59,"context_line":"  Liberty-1"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Work Items"},{"line_number":62,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_28b900ea","line":59,"updated":"2015-09-24 23:58:08.000000000","message":"Too late :)","commit_id":"5f41227c79a39fdaecba0815c28782c5044cb5f4"}]}