)]}'
{"specs/mikata/bandit/config-change.rst":[{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"cd1abf0c6d367cfb729c3352d2ac8674166ad25a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Tunable Options"},{"line_number":26,"context_line":"---------------"},{"line_number":27,"context_line":"A number of tunable options are provided in the bandit config. It was"},{"line_number":28,"context_line":"originally foreseen that these would be useful in configuring Bandits runtime"},{"line_number":29,"context_line":"behavior. In all practical scenarios however, these options are redundant and"},{"line_number":30,"context_line":"remain at the default setting."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a8ffd7b_fec976ad","line":28,"updated":"2015-11-24 18:25:48.000000000","message":"s/Bandits/Bandit\u0027s/","commit_id":"6608f9a9066b1379e3f72d3e865d733290970237"},{"author":{"_account_id":11029,"name":"Jamie Finnigan","email":"jamiefinnigan@gmail.com","username":"jamiefinnigan"},"change_message_id":"b9520ec7fb573ea9a8da595f8a843a2c7d6bc4f8","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Problem description"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The Bandit config file has grown in complexity and size as more testing plugins"},{"line_number":8,"context_line":"and options have been added to the project. It has been highlighted by adopters"},{"line_number":9,"context_line":"that maintaining a bandit config file in each projects repository is an"},{"line_number":10,"context_line":"undesirable pain point."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_1cc52f3b","line":7,"updated":"2015-11-25 15:16:17.000000000","message":"The OCD in me says we should be able to proper-noun s/bandit/Bandit/ through most of this doc.  Also are capitalization styles of section titles is mixed.  Feel free to ignore. :)","commit_id":"53a08652e54c7c452032cd629b9c6244e1aa0986"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"415159bb1ff798fa2673a43cbd60bab46f37510b","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Problem description"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"The Bandit config file has grown in complexity and size as more testing plugins"},{"line_number":8,"context_line":"and options have been added to the project. It has been highlighted by adopters"},{"line_number":9,"context_line":"that maintaining a bandit config file in each projects repository is an"},{"line_number":10,"context_line":"undesirable pain point."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_d388f224","line":7,"in_reply_to":"9a8ffd7b_1cc52f3b","updated":"2015-11-25 15:52:19.000000000","message":"heh yeah, your not wrong, I\u0027ll update :)","commit_id":"53a08652e54c7c452032cd629b9c6244e1aa0986"},{"author":{"_account_id":11029,"name":"Jamie Finnigan","email":"jamiefinnigan@gmail.com","username":"jamiefinnigan"},"change_message_id":"b9520ec7fb573ea9a8da595f8a843a2c7d6bc4f8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"behavior. In all practical scenarios however, these options are redundant and"},{"line_number":30,"context_line":"remain at the default setting."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Our proposed strategy is to remove these unnecessary config options and rely on"},{"line_number":33,"context_line":"sensible values provided by the Bandit authors."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Plugin Options"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_5c5f3741","line":32,"updated":"2015-11-25 15:16:17.000000000","message":"Makes sense.  As far as actual implementation goes, I suggest that we remove the unused configuration options by no longer exposing them to the user, but not removing them from the underlying framework.  Probably move them to bandit/core/constants.py, so we still have flexibility there if the need arises in future?","commit_id":"53a08652e54c7c452032cd629b9c6244e1aa0986"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"415159bb1ff798fa2673a43cbd60bab46f37510b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"behavior. In all practical scenarios however, these options are redundant and"},{"line_number":30,"context_line":"remain at the default setting."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Our proposed strategy is to remove these unnecessary config options and rely on"},{"line_number":33,"context_line":"sensible values provided by the Bandit authors."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Plugin Options"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_93ab4a89","line":32,"in_reply_to":"9a8ffd7b_5c5f3741","updated":"2015-11-25 15:52:19.000000000","message":"agreed","commit_id":"53a08652e54c7c452032cd629b9c6244e1aa0986"},{"author":{"_account_id":11029,"name":"Jamie Finnigan","email":"jamiefinnigan@gmail.com","username":"jamiefinnigan"},"change_message_id":"b9520ec7fb573ea9a8da595f8a843a2c7d6bc4f8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"Our proposed strategy is to modify the plugin system to provide sensible"},{"line_number":46,"context_line":"defaults for all configurable test plugins, directly in the plugin code. This"},{"line_number":47,"context_line":"data can then be overridden in an external configuration only when desirable."},{"line_number":48,"context_line":"This removes the need for any configuration data when default functioning is"},{"line_number":49,"context_line":"sufficient, and this should be in the majority of cases."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"To accomplish this, the test plugin system will be modified to use classes for"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_bff655f7","line":48,"updated":"2015-11-25 15:16:17.000000000","message":"Nice!  Not requiring a config file and using sane global \u0026 per-plugin defaults is good.","commit_id":"53a08652e54c7c452032cd629b9c6244e1aa0986"},{"author":{"_account_id":11029,"name":"Jamie Finnigan","email":"jamiefinnigan@gmail.com","username":"jamiefinnigan"},"change_message_id":"b9520ec7fb573ea9a8da595f8a843a2c7d6bc4f8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"functions, and one method to return a default configuration shared by all"},{"line_number":55,"context_line":"testing methods provided by that class. In the default case, this configuration"},{"line_number":56,"context_line":"data will be sent back to each test method, or it may be overridden by an"},{"line_number":57,"context_line":"external configuration if present."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"In addition to removing the need for a configuration file this approach has two"},{"line_number":60,"context_line":"advantages. Firstly, it allows external plugins from third parties to provide"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_1ff3e19f","line":57,"updated":"2015-11-25 15:16:17.000000000","message":"Somewhat related - wondering whether it makes sense to (probably as a separate piece of work) move the currently-separate docs structure into the plugins classes?  Each plugin class will provide its own documentation within itself (docstrings), and sphinx/autodoc could be used to combine into a standalone docs set as needed.  This would make it clear what docs belong to what plugin, make the docs accessible to a pip-installed user via interactive class usage (\u0027help(pluginClassName)\u0027), and simplify development / review.","commit_id":"53a08652e54c7c452032cd629b9c6244e1aa0986"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"415159bb1ff798fa2673a43cbd60bab46f37510b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"functions, and one method to return a default configuration shared by all"},{"line_number":55,"context_line":"testing methods provided by that class. In the default case, this configuration"},{"line_number":56,"context_line":"data will be sent back to each test method, or it may be overridden by an"},{"line_number":57,"context_line":"external configuration if present."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"In addition to removing the need for a configuration file this approach has two"},{"line_number":60,"context_line":"advantages. Firstly, it allows external plugins from third parties to provide"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_b3b76ef4","line":57,"in_reply_to":"9a8ffd7b_1ff3e19f","updated":"2015-11-25 15:52:19.000000000","message":"I like that idea, but agree that it should be separate task in itself","commit_id":"53a08652e54c7c452032cd629b9c6244e1aa0986"},{"author":{"_account_id":11029,"name":"Jamie Finnigan","email":"jamiefinnigan@gmail.com","username":"jamiefinnigan"},"change_message_id":"b9520ec7fb573ea9a8da595f8a843a2c7d6bc4f8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"configured."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"To further improve upon the current state of affairs, again borrowing from"},{"line_number":89,"context_line":"hacking/flake8/pep8, Bandit will support a canonical numbering system for test"},{"line_number":90,"context_line":"plugins. These numeric names may be used anywhere that the usual descriptive,"},{"line_number":91,"context_line":"but often unwieldy, full test names would be used."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a8ffd7b_a26e3ec7","line":89,"updated":"2015-11-25 15:16:17.000000000","message":"Excellent - this has been on the mental to-do list for a while.","commit_id":"53a08652e54c7c452032cd629b9c6244e1aa0986"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"1a926bc9c565c21ee468f8cef27f9dfde8a6b48f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"new approach to configuration. Support for the old configuration file will"},{"line_number":112,"context_line":"remain, but its use will be marked as deprecated and a message indicating this"},{"line_number":113,"context_line":"will be presented to the user when utilizing the text formatted output and an"},{"line_number":114,"context_line":"old style configuration."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Assignee(s)"},{"line_number":117,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a8ffd7b_3129fee6","line":114,"updated":"2015-11-26 14:16:39.000000000","message":"If the old configuration file is still supported, maybe we could have a tool that generates the new config file from the old one, as this would make it easier for people to switch. WDYT?","commit_id":"378cd6dd99ad9c945fc515ea9b3aab565e66052c"}]}