)]}'
{"senlin_tempest_plugin/tests/api/clusters/test_cluster_delete.py":[{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"2608efa28f7b3fd221913a21939c15e2137b6180","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.client.wait_for_status(\u0027actions\u0027, action_id, \u0027SUCCEEDED\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class TestClusterDeleteWithPolicy(base.BaseSenlinAPITest):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def setUp(self):"},{"line_number":49,"context_line":"        super(TestClusterDeleteWithPolicy, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_ef49ec8a","line":46,"range":{"start_line":46,"start_character":6,"end_line":46,"end_character":33},"updated":"2019-05-09 16:28:47.000000000","message":"Is there a reason why you created new classes rather than add the two methods to the existing TestClusterDelete?\nI think by having three separate classes, tempest could schedule all 3 to run in parallel.  This would cause a problem because they are all creating the same profile and cluster.","commit_id":"456c3a70fa1b518bfd9702cb0ece8dded1d97921"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"8f8b5aab971ae25784622714e158918a23ce5856","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.client.wait_for_status(\u0027actions\u0027, action_id, \u0027SUCCEEDED\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class TestClusterDeleteWithPolicy(base.BaseSenlinAPITest):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def setUp(self):"},{"line_number":49,"context_line":"        super(TestClusterDeleteWithPolicy, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_210954dc","line":46,"range":{"start_line":46,"start_character":6,"end_line":46,"end_character":33},"in_reply_to":"dfbec78f_6acaca6d","updated":"2019-05-09 22:25:20.000000000","message":"Makes sense.","commit_id":"456c3a70fa1b518bfd9702cb0ece8dded1d97921"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"6e64ca464681e6e01c414e6c0f063968a0cf4780","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.client.wait_for_status(\u0027actions\u0027, action_id, \u0027SUCCEEDED\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class TestClusterDeleteWithPolicy(base.BaseSenlinAPITest):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def setUp(self):"},{"line_number":49,"context_line":"        super(TestClusterDeleteWithPolicy, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_6acaca6d","line":46,"range":{"start_line":46,"start_character":6,"end_line":46,"end_character":33},"in_reply_to":"dfbec78f_ef49ec8a","updated":"2019-05-09 16:55:49.000000000","message":"The reason I have them as three separate classes is because of the clean-ups. If I have them all work as test_cluster_delete_in_active_status then after the cluster deletes the cleanups will try to run. When the cleanups run they error out looking for the cluster. \n\nI don\u0027t see a problem with having these as 3 separate classes.","commit_id":"456c3a70fa1b518bfd9702cb0ece8dded1d97921"}]}