)]}'
{"senlin/db/api.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"3527f9f044cb5bd187bf62f4037449fe0d3482ea","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    return IMPL.action_check_status(context, action_id, timestamp)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"def action_delete_by_target(context, target, exceptions\u003dNone):"},{"line_number":340,"context_line":"    return IMPL.action_delete_by_target(context, target, exceptions\u003dexceptions)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_6c84c50a","line":339,"range":{"start_line":339,"start_character":45,"end_line":339,"end_character":55},"updated":"2016-06-17 10:58:13.000000000","message":"should we rename this to \u0027excludes\u0027?\n\nexceptions is very misleading ...","commit_id":"ab0d99dde76aa57d2f7a49588e598761bf107208"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"fda077db3bb70520d66cfa67163bda206ce9673d","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    return IMPL.action_check_status(context, action_id, timestamp)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"def action_delete_by_target(context, target, exceptions\u003dNone):"},{"line_number":340,"context_line":"    return IMPL.action_delete_by_target(context, target, exceptions\u003dexceptions)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_98083d82","line":339,"in_reply_to":"7aa08908_6c84c50a","updated":"2016-06-17 11:22:44.000000000","message":"yes, excludes is better, will change.","commit_id":"ab0d99dde76aa57d2f7a49588e598761bf107208"}],"senlin/tests/unit/db/test_action_api.py":[{"author":{"_account_id":19902,"name":"zzxwill","email":"zzxwill@gmail.com","username":"zzxwill"},"change_message_id":"7fb7dd4e80706e84389e5761c5dca4a80e7deb34","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        self.assertEqual(1, len(actions))"},{"line_number":436,"context_line":"        self.assertEqual(\u0027CLUSTER_DELETE\u0027, actions[0].action)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def test_action_delete_by_target_with_status(self):"},{"line_number":439,"context_line":"        action1 \u003d _create_action(self.ctx, action\u003d\u0027CLUSTER_CREATE\u0027,"},{"line_number":440,"context_line":"                                 target\u003d\u0027CLUSTER_ID\u0027, status\u003d\u0027SUCCEEDED\u0027)"},{"line_number":441,"context_line":"        action2 \u003d _create_action(self.ctx, action\u003d\u0027CLUSTER_DELETE\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_3affbd68","line":438,"range":{"start_line":438,"start_character":8,"end_line":438,"end_character":48},"updated":"2016-06-21 06:21:34.000000000","message":"Just curious whether we should add a function \u0027test_action_delete_by_target_with_excludes_status\u0027 to execute function action_delete_by_target with parameter excludes and status? Thanks.","commit_id":"28666c2c7becd07a59159fc036500194dbcbd4e1"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"fa0574b0d23102f7a24e3f4af4586e5b6a6e2921","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        self.assertEqual(1, len(actions))"},{"line_number":436,"context_line":"        self.assertEqual(\u0027CLUSTER_DELETE\u0027, actions[0].action)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def test_action_delete_by_target_with_status(self):"},{"line_number":439,"context_line":"        action1 \u003d _create_action(self.ctx, action\u003d\u0027CLUSTER_CREATE\u0027,"},{"line_number":440,"context_line":"                                 target\u003d\u0027CLUSTER_ID\u0027, status\u003d\u0027SUCCEEDED\u0027)"},{"line_number":441,"context_line":"        action2 \u003d _create_action(self.ctx, action\u003d\u0027CLUSTER_DELETE\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_ee2f363c","line":438,"range":{"start_line":438,"start_character":8,"end_line":438,"end_character":48},"in_reply_to":"5a9d85d2_3affbd68","updated":"2016-06-21 06:55:05.000000000","message":"Hi, filters based on action.action and action.status are actually orthogonal. So I think it\u0027s not necessary to test them both in the same case.","commit_id":"28666c2c7becd07a59159fc036500194dbcbd4e1"}]}