)]}'
{"senlin/engine/node.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"d11e4141f1b884a7ce14019031207a03995a8b37","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            self._handle_exception(context, \u0027create\u0027, self.ERROR, ex)"},{"line_number":258,"context_line":"            return False"},{"line_number":259,"context_line":"        if not physical_id:"},{"line_number":260,"context_line":"            self.set_status(context, self.ERROR, reason\u003d\u0027Physical is is none\u0027)"},{"line_number":261,"context_line":"            return False"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        status_reason \u003d \u0027Creation succeeded\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_6e038bb9","line":260,"range":{"start_line":260,"start_character":57,"end_line":260,"end_character":76},"updated":"2016-07-27 14:33:01.000000000","message":"please revise this string.","commit_id":"36d5972642c09b707b29e583321e2c7b88e4a6f3"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"a95fd83d2fc076d572f6f7bb63f5ad09c8a3344b","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            self._handle_exception(context, \u0027create\u0027, self.ERROR, ex)"},{"line_number":258,"context_line":"            return False"},{"line_number":259,"context_line":"        if not physical_id:"},{"line_number":260,"context_line":"            self.set_status(context, self.ERROR, reason\u003d\u0027Physical id is None\u0027)"},{"line_number":261,"context_line":"            return False"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        status_reason \u003d \u0027Creation succeeded\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_4d4dcd71","line":260,"updated":"2016-07-28 04:11:31.000000000","message":"Currently, sdk exceptions like resourcetimeout has been handled and converted to internalerror eception in the following code:\nhttp://git.openstack.org/cgit/openstack/senlin/tree/senlin/drivers/openstack/sdk.py#n70\n\nSo physical_id\u003d\u003dNone means exception happened during Profile.create_object and it was not caught correctly. It would be better if we can catch the reason and log it into the \u0027reason\u0027 field.","commit_id":"cb954a7ea7e61343df93750b42a4a3a83ba17e2f"}]}