)]}'
{"senlin/engine/cluster.py":[{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"7d7605685497e0943712ff1d4eef8186bff4fcb7","unresolved":false,"context_lines":[{"line_number":514,"context_line":"    def eval_status(self, ctx, operation):"},{"line_number":515,"context_line":"        \"\"\"Re-evaluate cluster\u0027s health status."},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        :param ctx: The requesting context."},{"line_number":518,"context_line":"        :param operation: The operation that triggers this status evaluation."},{"line_number":519,"context_line":"        :returns: ``None``."},{"line_number":520,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_b19212f4","line":517,"updated":"2016-08-24 07:43:59.000000000","message":"request context?","commit_id":"c2884f13c363f5be52a593162f59cafb1d61d61d"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0ed66620d32404287e8b185abd423bdc4f63778a","unresolved":false,"context_lines":[{"line_number":514,"context_line":"    def eval_status(self, ctx, operation):"},{"line_number":515,"context_line":"        \"\"\"Re-evaluate cluster\u0027s health status."},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        :param ctx: The requesting context."},{"line_number":518,"context_line":"        :param operation: The operation that triggers this status evaluation."},{"line_number":519,"context_line":"        :returns: ``None``."},{"line_number":520,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_6b054344","line":517,"in_reply_to":"1ac06dbe_b19212f4","updated":"2016-08-24 09:16:05.000000000","message":"em, could be fine. can change if you insist.","commit_id":"c2884f13c363f5be52a593162f59cafb1d61d61d"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"7d7605685497e0943712ff1d4eef8186bff4fcb7","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        elif self.max_size \u003c 0 or active_count \u003c self.max_size:"},{"line_number":539,"context_line":"            status \u003d self.ACTIVE"},{"line_number":540,"context_line":"            reason \u003d _(\"%(o)s: number of active nodes is above \""},{"line_number":541,"context_line":"                       \"desired_capacity \""},{"line_number":542,"context_line":"                       \"(%(n)d).\") % {\u0027o\u0027: operation,"},{"line_number":543,"context_line":"                                      \u0027n\u0027: self.desired_capacity}"},{"line_number":544,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_9129d69d","line":541,"updated":"2016-08-24 07:43:59.000000000","message":"but less than max_size?","commit_id":"c2884f13c363f5be52a593162f59cafb1d61d61d"},{"author":{"_account_id":17645,"name":"Shan Guo","email":"guoshan.jolie@gmail.com","username":"guoshan"},"change_message_id":"a097b52381cd79e08c5c2c4721e30a40e9464002","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        elif self.max_size \u003c 0 or active_count \u003c self.max_size:"},{"line_number":539,"context_line":"            status \u003d self.ACTIVE"},{"line_number":540,"context_line":"            reason \u003d _(\"%(o)s: number of active nodes is above \""},{"line_number":541,"context_line":"                       \"desired_capacity \""},{"line_number":542,"context_line":"                       \"(%(n)d).\") % {\u0027o\u0027: operation,"},{"line_number":543,"context_line":"                                      \u0027n\u0027: self.desired_capacity}"},{"line_number":544,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_f42d41fe","line":541,"in_reply_to":"1ac06dbe_2bd06bc8","updated":"2016-08-25 09:43:52.000000000","message":"Agree with Teng. The situation \"number of active nodes is below desired_capacity (5) and above min_size (2)\" is already considered, no necessary to list it alone.","commit_id":"c2884f13c363f5be52a593162f59cafb1d61d61d"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0ed66620d32404287e8b185abd423bdc4f63778a","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        elif self.max_size \u003c 0 or active_count \u003c self.max_size:"},{"line_number":539,"context_line":"            status \u003d self.ACTIVE"},{"line_number":540,"context_line":"            reason \u003d _(\"%(o)s: number of active nodes is above \""},{"line_number":541,"context_line":"                       \"desired_capacity \""},{"line_number":542,"context_line":"                       \"(%(n)d).\") % {\u0027o\u0027: operation,"},{"line_number":543,"context_line":"                                      \u0027n\u0027: self.desired_capacity}"},{"line_number":544,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_2bd06bc8","line":541,"in_reply_to":"1ac06dbe_9129d69d","updated":"2016-08-24 09:16:05.000000000","message":"that is a little bit wordy ... if we say that, we will have to change everything else to describe a range, e.g. \n\nCHECK: number of active nodes is below desired_capacity (5) and above min_size (2).\n\nseems no necessary","commit_id":"c2884f13c363f5be52a593162f59cafb1d61d61d"}]}