)]}'
{"senlin/engine/service.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"a03c3aadf7022ce0dbeef92e44a2ed10d8ad0722","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        metadata \u003d {}"},{"line_number":427,"context_line":"        if req.profile.obj_attr_is_set(\u0027metadata\u0027):"},{"line_number":428,"context_line":"            metadata \u003d req.porile.metadata"},{"line_number":429,"context_line":"        profile \u003d self._validate_profile(ctx, req.profile.spec, name\u003dname,"},{"line_number":430,"context_line":"                                         metadata\u003dmetadata)"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_d0c05d7f","line":428,"range":{"start_line":428,"start_character":27,"end_line":428,"end_character":33},"updated":"2016-11-22 01:55:35.000000000","message":"typo ...\n\nthis should have been found by unit test if there are unit tests covering every paths.","commit_id":"b9009de404f92017d238a51e0eee03235c5af63c"},{"author":{"_account_id":9323,"name":"lvdongbing","email":"dongbing.lv@kylin-cloud.com","username":"lvdongbing"},"change_message_id":"58c1c036234e74806c66f3e758b3fd02cd3a85e5","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        metadata \u003d {}"},{"line_number":427,"context_line":"        if req.profile.obj_attr_is_set(\u0027metadata\u0027):"},{"line_number":428,"context_line":"            metadata \u003d req.porile.metadata"},{"line_number":429,"context_line":"        profile \u003d self._validate_profile(ctx, req.profile.spec, name\u003dname,"},{"line_number":430,"context_line":"                                         metadata\u003dmetadata)"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_08e70913","line":428,"range":{"start_line":428,"start_character":27,"end_line":428,"end_character":33},"in_reply_to":"7a77a97e_d0c05d7f","updated":"2016-11-22 03:47:59.000000000","message":"Oops, will add related tests.","commit_id":"b9009de404f92017d238a51e0eee03235c5af63c"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"a03c3aadf7022ce0dbeef92e44a2ed10d8ad0722","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        profile \u003d self._validate_profile(ctx, req.profile.spec, name\u003dname,"},{"line_number":430,"context_line":"                                         metadata\u003dmetadata)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        LOG.info(_LI(\"Creating profile %(type)s \u0027%(name)s\u0027.\"),"},{"line_number":433,"context_line":"                 {\u0027type\u0027: profile.type, \u0027name\u0027: profile.name})"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        profile.store(ctx)"},{"line_number":436,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_70406908","line":433,"range":{"start_line":432,"start_character":0,"end_line":433,"end_character":62},"updated":"2016-11-22 01:55:35.000000000","message":"this should be moved before line 429.","commit_id":"b9009de404f92017d238a51e0eee03235c5af63c"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"8cb31e1343cf05d1e2e27a1cf382a885d26a8043","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        profile \u003d self._validate_profile(ctx, req.profile.spec, name\u003dname,"},{"line_number":430,"context_line":"                                         metadata\u003dmetadata)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        LOG.info(_LI(\"Creating profile %(type)s \u0027%(name)s\u0027.\"),"},{"line_number":433,"context_line":"                 {\u0027type\u0027: profile.type, \u0027name\u0027: profile.name})"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        profile.store(ctx)"},{"line_number":436,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_8eede190","line":433,"range":{"start_line":432,"start_character":0,"end_line":433,"end_character":62},"in_reply_to":"7a77a97e_48f101cd","updated":"2016-11-22 05:16:04.000000000","message":"since the bulk of work is done in _validate_profile, the two LOG.info calls are becoming meaningless if we keep it here. Maybe moving it before line 429 and remove the \u0027profile.type\u0027 reference would be okay.","commit_id":"b9009de404f92017d238a51e0eee03235c5af63c"},{"author":{"_account_id":9323,"name":"lvdongbing","email":"dongbing.lv@kylin-cloud.com","username":"lvdongbing"},"change_message_id":"58c1c036234e74806c66f3e758b3fd02cd3a85e5","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        profile \u003d self._validate_profile(ctx, req.profile.spec, name\u003dname,"},{"line_number":430,"context_line":"                                         metadata\u003dmetadata)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        LOG.info(_LI(\"Creating profile %(type)s \u0027%(name)s\u0027.\"),"},{"line_number":433,"context_line":"                 {\u0027type\u0027: profile.type, \u0027name\u0027: profile.name})"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        profile.store(ctx)"},{"line_number":436,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_48f101cd","line":433,"range":{"start_line":432,"start_character":0,"end_line":433,"end_character":62},"in_reply_to":"7a77a97e_70406908","updated":"2016-11-22 03:47:59.000000000","message":"Actually, I think should better keep this here, because it\u0027s better to get profile_type by profile.type here.","commit_id":"b9009de404f92017d238a51e0eee03235c5af63c"},{"author":{"_account_id":9323,"name":"lvdongbing","email":"dongbing.lv@kylin-cloud.com","username":"lvdongbing"},"change_message_id":"633629f446d392a07da9632758be9ba5a73c7ba3","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        profile \u003d self._validate_profile(ctx, req.profile.spec, name\u003dname,"},{"line_number":430,"context_line":"                                         metadata\u003dmetadata)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        LOG.info(_LI(\"Creating profile %(type)s \u0027%(name)s\u0027.\"),"},{"line_number":433,"context_line":"                 {\u0027type\u0027: profile.type, \u0027name\u0027: profile.name})"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        profile.store(ctx)"},{"line_number":436,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_316a701b","line":433,"range":{"start_line":432,"start_character":0,"end_line":433,"end_character":62},"in_reply_to":"7a77a97e_8eede190","updated":"2016-11-22 05:55:07.000000000","message":"Done","commit_id":"b9009de404f92017d238a51e0eee03235c5af63c"}]}
