)]}'
{"senlin/drivers/openstack/mistral_v2.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"94551f034776dfb3d4dd908b06902e80e8c0cc32","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            timeout \u003d cfg.CONF.default_action_timeout"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        execution_obj \u003d self.conn.workflow.find_execution(execution, False)"},{"line_number":69,"context_line":"        self.conn.workflow.wait_for_execution(execution_obj, status\u003dstatus,"},{"line_number":70,"context_line":"                                              failures\u003dfailures,"},{"line_number":71,"context_line":"                                              interval\u003dinterval,"},{"line_number":72,"context_line":"                                              wait\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_08cb6d54","line":69,"range":{"start_line":69,"start_character":27,"end_line":69,"end_character":45},"updated":"2017-01-16 02:00:00.000000000","message":"this can just reuse the wait_for_status method ...","commit_id":"9685a9bc24d9297ab65d130c54ef385efee03ea1"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"a6bfe0f52cf4e205266849a3d3cbcbd0467447d2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            timeout \u003d cfg.CONF.default_action_timeout"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        execution_obj \u003d self.conn.workflow.find_execution(execution, False)"},{"line_number":69,"context_line":"        self.conn.workflow.wait_for_execution(execution_obj, status\u003dstatus,"},{"line_number":70,"context_line":"                                              failures\u003dfailures,"},{"line_number":71,"context_line":"                                              interval\u003dinterval,"},{"line_number":72,"context_line":"                                              wait\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_23504a5e","line":69,"range":{"start_line":69,"start_character":27,"end_line":69,"end_character":45},"in_reply_to":"7a3c09a3_08cb6d54","updated":"2017-01-16 02:58:27.000000000","message":"Done","commit_id":"9685a9bc24d9297ab65d130c54ef385efee03ea1"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"4dc0f0684f731d773641042fd70f74cbb1864658","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            timeout \u003d cfg.CONF.default_action_timeout"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        execution_obj \u003d self.conn.workflow.find_execution(execution, False)"},{"line_number":69,"context_line":"        self.conn.workflow.wait_for_status(execution_obj, status\u003dstatus,"},{"line_number":70,"context_line":"                                           failures\u003dfailures,"},{"line_number":71,"context_line":"                                           interval\u003dinterval,"},{"line_number":72,"context_line":"                                           wait\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a3c09a3_e0a54d04","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":26},"updated":"2017-01-16 09:05:11.000000000","message":"status is a positional argument, so no need to use \u0027status\u003dstatus\u0027.","commit_id":"212acc57188ff5332ea18dfe19fba2dc0f0dad87"}],"senlin/policies/health_policy.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"92acf00638b8736a2cae41aff57402c51ad8478e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                                _(\"Type of action to execute.\"),"},{"line_number":135,"context_line":"                                constraints\u003d["},{"line_number":136,"context_line":"                                    constraints.AllowedValues("},{"line_number":137,"context_line":"                                        RECOVERY_ACTION_VALUES),"},{"line_number":138,"context_line":"                                ],"},{"line_number":139,"context_line":"                            ),"},{"line_number":140,"context_line":"                            ACTION_PARAMS: schema.Map("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_8e619307","line":137,"range":{"start_line":137,"start_character":40,"end_line":137,"end_character":62},"updated":"2017-01-07 07:15:23.000000000","message":"This conflicts/duplicates with the ACTION_NAME on line 125.\n\nThe \u0027type\u0027 property, if provided, is meant to differentiate \"external\" actions from built-in ones.\n\nTo save users\u0027 efforts thus simplifies the design, maybe we can just add a \u0027WORKFLOW\u0027 into the RECOVERY_ACTION_VALUES.\n\nThe complexity is then pushed to the \u0027ACTION_PARMS\u0027 on line 140. We will need to provide \u0027name\u0027 and \u0027inputs\u0027 for mistral workflows.","commit_id":"d13f14e05a008d9796728282e91be655122d6d6b"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"ed0d809996a07c3d81a2be6d94785d13dd62fa5c","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                                _(\"Type of action to execute.\"),"},{"line_number":135,"context_line":"                                constraints\u003d["},{"line_number":136,"context_line":"                                    constraints.AllowedValues("},{"line_number":137,"context_line":"                                        RECOVERY_ACTION_VALUES),"},{"line_number":138,"context_line":"                                ],"},{"line_number":139,"context_line":"                            ),"},{"line_number":140,"context_line":"                            ACTION_PARAMS: schema.Map("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_490ec5e5","line":137,"range":{"start_line":137,"start_character":40,"end_line":137,"end_character":62},"in_reply_to":"ba5201f7_8e619307","updated":"2017-01-07 08:24:37.000000000","message":"Once I proposed the WORKFLOW as name design in the spec discussion. But feel better when I see your design including \u0027type\u0027, which gives more respect to the intuition when firstly reading and is more elegant for the users to check the sequence by chain all the names. \n\nIn the commited version of spec, the key of \u0027Name\u0027 is used to declare the name of the action and \u0027type\u0027 will be used to switch among different drivers, not only workflow. Just this is not any required field since there is no need to point type for embeded actions.","commit_id":"d13f14e05a008d9796728282e91be655122d6d6b"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0892c9996f031aacbc4f1da4e38ccc43bb428afd","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    )"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    RECOVERY_ACTION_TYPES \u003d ("},{"line_number":80,"context_line":"        EMBEDDED, WORKFLOW"},{"line_number":81,"context_line":"    ) \u003d ("},{"line_number":82,"context_line":"        \"EMBEDDED\", \"WORKFLOW\","},{"line_number":83,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_c9dab516","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":16},"updated":"2017-01-07 08:56:21.000000000","message":"overall, this patch looks better.\n\nI don\u0027t like the word \u0027embedded\u0027, can we use \u0027default\u0027 or \u0027system\u0027 or \u0027builtin\u0027?","commit_id":"fdd87565c10d4d9295151b7243e76ef6b02a01c3"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0892c9996f031aacbc4f1da4e38ccc43bb428afd","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    RECOVERY_ACTION_TYPES \u003d ("},{"line_number":80,"context_line":"        EMBEDDED, WORKFLOW"},{"line_number":81,"context_line":"    ) \u003d ("},{"line_number":82,"context_line":"        \"EMBEDDED\", \"WORKFLOW\","},{"line_number":83,"context_line":"    )"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    FENCING_OPTION_VALUES \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_290a618a","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":30},"updated":"2017-01-07 08:56:21.000000000","message":"As for these two values, can we use one of the followings?\n\n  \"DEFAULT\", \"MISTRAL_WORKFLOW\", or\n\n  \"os.senlin.action\", \"os.mistral.workflow\"","commit_id":"fdd87565c10d4d9295151b7243e76ef6b02a01c3"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"530444cd61a199ca5d417b2fe65524f240fa3b8e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    RECOVERY_ACTION_TYPES \u003d ("},{"line_number":80,"context_line":"        EMBEDDED, WORKFLOW"},{"line_number":81,"context_line":"    ) \u003d ("},{"line_number":82,"context_line":"        \"EMBEDDED\", \"WORKFLOW\","},{"line_number":83,"context_line":"    )"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    FENCING_OPTION_VALUES \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_498245c9","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":30},"in_reply_to":"ba5201f7_290a618a","updated":"2017-01-07 09:16:24.000000000","message":"Thanks for the review. When I try to update this patch with these suggestions. I note this change will disturb the consistency with the constraints Allow values of ACTION_NAME already there. So return to the patch 7 to maintain the user experience. Accordingly, I will update the spec too.","commit_id":"fdd87565c10d4d9295151b7243e76ef6b02a01c3"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0892c9996f031aacbc4f1da4e38ccc43bb428afd","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                constraints\u003d["},{"line_number":142,"context_line":"                                    constraints.AllowedValues("},{"line_number":143,"context_line":"                                        RECOVERY_ACTION_TYPES),"},{"line_number":144,"context_line":"                                ],"},{"line_number":145,"context_line":"                            ),"},{"line_number":146,"context_line":"                            ACTION_PARAMS: schema.Map("},{"line_number":147,"context_line":"                                _(\"Parameters for the action\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_49fde56c","line":144,"range":{"start_line":144,"start_character":33,"end_line":144,"end_character":34},"updated":"2017-01-07 08:56:21.000000000","message":"better add a default value, e.g. \u0027default\u003dBUILTIN\u0027","commit_id":"fdd87565c10d4d9295151b7243e76ef6b02a01c3"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"94551f034776dfb3d4dd908b06902e80e8c0cc32","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        REBUILD, RECREATE, WORKFLOW"},{"line_number":77,"context_line":"        # REBOOT, MIGRATE, EVACUATE,"},{"line_number":78,"context_line":"    ) \u003d ("},{"line_number":79,"context_line":"        \"REBUILD\", \"RECREATE\", \"WORKFLOW\""},{"line_number":80,"context_line":"        # \u0027REBOOT\u0027, \u0027MIGRATE\u0027, \u0027EVACUATE\u0027,"},{"line_number":81,"context_line":"    )"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_68c0712b","line":79,"updated":"2017-01-16 02:00:00.000000000","message":"This should be added in the end of this series of patches.","commit_id":"9685a9bc24d9297ab65d130c54ef385efee03ea1"}]}