)]}'
{"senlin/cmd/manage.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"57d8b58c4d75a93fadee10fdd96f9ec0d9b1203e","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def do_event_purge():"},{"line_number":46,"context_line":"    \u0027\u0027\u0027Purge the specified event records in senlin\u0027s database.\u0027\u0027\u0027"},{"line_number":47,"context_line":"    if CONF.command.granularity not in [None, \u0027None\u0027, \u0027days\u0027, \u0027hours\u0027,"},{"line_number":48,"context_line":"                                        \u0027minutes\u0027, \u0027seconds\u0027]:"},{"line_number":49,"context_line":"        print(\"If specified granularity, it should be days/\""},{"line_number":50,"context_line":"              \"hours/minutes/seconds. Otherwise, it should be None.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_ed70efde","line":47,"range":{"start_line":47,"start_character":40,"end_line":47,"end_character":54},"updated":"2017-01-20 10:35:43.000000000","message":"why do we want to support None and \"None\"?","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"73247789db3c0b6bd39d72bf1349744060373892","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def do_event_purge():"},{"line_number":46,"context_line":"    \u0027\u0027\u0027Purge the specified event records in senlin\u0027s database.\u0027\u0027\u0027"},{"line_number":47,"context_line":"    if CONF.command.granularity not in [None, \u0027None\u0027, \u0027days\u0027, \u0027hours\u0027,"},{"line_number":48,"context_line":"                                        \u0027minutes\u0027, \u0027seconds\u0027]:"},{"line_number":49,"context_line":"        print(\"If specified granularity, it should be days/\""},{"line_number":50,"context_line":"              \"hours/minutes/seconds. Otherwise, it should be None.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_9713300d","line":47,"range":{"start_line":47,"start_character":40,"end_line":47,"end_character":54},"in_reply_to":"5a3905b3_956c9fd1","updated":"2017-01-25 09:03:29.000000000","message":"string \u0027None\u0027 is strange. Instead, I\u0027d prefer we refactor the code in the following way:\n\n   granularity \u003d CONF.command.granularity\n\n   if granularity and granularity not in [\u0027days\u0027, hours, \u0027minutes\u0027, \u0027seconds\u0027]:\n      print(\"Granularity must be one of \u0027days\u0027, \u0027hours\u0027, ...\")\n      return\n   else:\n      # either we provide a default, or we print error that\n      # granularity must be provided","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"26d61c5f0050bf138f8c1dbd5a2ceb2158ba7de5","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def do_event_purge():"},{"line_number":46,"context_line":"    \u0027\u0027\u0027Purge the specified event records in senlin\u0027s database.\u0027\u0027\u0027"},{"line_number":47,"context_line":"    if CONF.command.granularity not in [None, \u0027None\u0027, \u0027days\u0027, \u0027hours\u0027,"},{"line_number":48,"context_line":"                                        \u0027minutes\u0027, \u0027seconds\u0027]:"},{"line_number":49,"context_line":"        print(\"If specified granularity, it should be days/\""},{"line_number":50,"context_line":"              \"hours/minutes/seconds. Otherwise, it should be None.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_956c9fd1","line":47,"range":{"start_line":47,"start_character":40,"end_line":47,"end_character":54},"in_reply_to":"5a3905b3_ed70efde","updated":"2017-01-22 01:24:44.000000000","message":"In patch4, string \u0027None\u0027 is useless, but None should be kept, because ‘granularity\u0027 is not required parameter. If user does not input it, the value will be None.","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"57d8b58c4d75a93fadee10fdd96f9ec0d9b1203e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \u0027\u0027\u0027Purge the specified event records in senlin\u0027s database.\u0027\u0027\u0027"},{"line_number":47,"context_line":"    if CONF.command.granularity not in [None, \u0027None\u0027, \u0027days\u0027, \u0027hours\u0027,"},{"line_number":48,"context_line":"                                        \u0027minutes\u0027, \u0027seconds\u0027]:"},{"line_number":49,"context_line":"        print(\"If specified granularity, it should be days/\""},{"line_number":50,"context_line":"              \"hours/minutes/seconds. Otherwise, it should be None.\")"},{"line_number":51,"context_line":"        return"},{"line_number":52,"context_line":"    api.event_purge(api.get_engine(),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_28abc5d7","line":49,"range":{"start_line":49,"start_character":41,"end_line":49,"end_character":54},"updated":"2017-01-20 10:35:43.000000000","message":"it should be one of ...","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"57d8b58c4d75a93fadee10fdd96f9ec0d9b1203e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    if CONF.command.granularity not in [None, \u0027None\u0027, \u0027days\u0027, \u0027hours\u0027,"},{"line_number":48,"context_line":"                                        \u0027minutes\u0027, \u0027seconds\u0027]:"},{"line_number":49,"context_line":"        print(\"If specified granularity, it should be days/\""},{"line_number":50,"context_line":"              \"hours/minutes/seconds. Otherwise, it should be None.\")"},{"line_number":51,"context_line":"        return"},{"line_number":52,"context_line":"    api.event_purge(api.get_engine(),"},{"line_number":53,"context_line":"                    CONF.command.oname,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_8d4a0b82","line":50,"range":{"start_line":50,"start_character":38,"end_line":50,"end_character":67},"updated":"2017-01-20 10:35:43.000000000","message":"This is strange.","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"26d61c5f0050bf138f8c1dbd5a2ceb2158ba7de5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    if CONF.command.granularity not in [None, \u0027None\u0027, \u0027days\u0027, \u0027hours\u0027,"},{"line_number":48,"context_line":"                                        \u0027minutes\u0027, \u0027seconds\u0027]:"},{"line_number":49,"context_line":"        print(\"If specified granularity, it should be days/\""},{"line_number":50,"context_line":"              \"hours/minutes/seconds. Otherwise, it should be None.\")"},{"line_number":51,"context_line":"        return"},{"line_number":52,"context_line":"    api.event_purge(api.get_engine(),"},{"line_number":53,"context_line":"                    CONF.command.oname,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_d56aa7b2","line":50,"range":{"start_line":50,"start_character":38,"end_line":50,"end_character":67},"in_reply_to":"5a3905b3_8d4a0b82","updated":"2017-01-22 01:24:44.000000000","message":"can be removed.","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"57d8b58c4d75a93fadee10fdd96f9ec0d9b1203e","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    parser \u003d subparsers.add_parser(\u0027event_purge\u0027)"},{"line_number":136,"context_line":"    parser.set_defaults(func\u003ddo_event_purge)"},{"line_number":137,"context_line":"    parser.add_argument(\u0027--oname\u0027,"},{"line_number":138,"context_line":"                        nargs\u003d\u0027?\u0027,"},{"line_number":139,"context_line":"                        help\u003d\u0027Purge event records with specified oname. \u0027"},{"line_number":140,"context_line":"                             \u0027All of the filters should be used to choose \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_8d312b0e","line":137,"range":{"start_line":137,"start_character":24,"end_line":137,"end_character":32},"updated":"2017-01-20 10:35:43.000000000","message":"oname is a db column name, exposing to users doesn\u0027t make sense.","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"26d61c5f0050bf138f8c1dbd5a2ceb2158ba7de5","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    parser \u003d subparsers.add_parser(\u0027event_purge\u0027)"},{"line_number":136,"context_line":"    parser.set_defaults(func\u003ddo_event_purge)"},{"line_number":137,"context_line":"    parser.add_argument(\u0027--oname\u0027,"},{"line_number":138,"context_line":"                        nargs\u003d\u0027?\u0027,"},{"line_number":139,"context_line":"                        help\u003d\u0027Purge event records with specified oname. \u0027"},{"line_number":140,"context_line":"                             \u0027All of the filters should be used to choose \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_15618fd3","line":137,"range":{"start_line":137,"start_character":24,"end_line":137,"end_character":32},"in_reply_to":"5a3905b3_8d312b0e","updated":"2017-01-22 01:24:44.000000000","message":"objectname?","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"57d8b58c4d75a93fadee10fdd96f9ec0d9b1203e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                        help\u003d\u0027Purge event records with specified status. \u0027"},{"line_number":146,"context_line":"                             \u0027This can be specified multiple times, or once \u0027"},{"line_number":147,"context_line":"                             \u0027with parameters separated by a semicolon.\u0027,"},{"line_number":148,"context_line":"                        action\u003d\u0027append\u0027)"},{"line_number":149,"context_line":"    parser.add_argument(\u0027--project\u0027,"},{"line_number":150,"context_line":"                        nargs\u003d\u0027?\u0027,"},{"line_number":151,"context_line":"                        metavar\u003d\u0027\u003cproject1;project2...\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_e80c5d3d","line":148,"range":{"start_line":148,"start_character":24,"end_line":148,"end_character":40},"updated":"2017-01-20 10:35:43.000000000","message":"why the previous argument doesn\u0027t have this?","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"26d61c5f0050bf138f8c1dbd5a2ceb2158ba7de5","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                        help\u003d\u0027Purge event records with specified status. \u0027"},{"line_number":146,"context_line":"                             \u0027This can be specified multiple times, or once \u0027"},{"line_number":147,"context_line":"                             \u0027with parameters separated by a semicolon.\u0027,"},{"line_number":148,"context_line":"                        action\u003d\u0027append\u0027)"},{"line_number":149,"context_line":"    parser.add_argument(\u0027--project\u0027,"},{"line_number":150,"context_line":"                        nargs\u003d\u0027?\u0027,"},{"line_number":151,"context_line":"                        metavar\u003d\u0027\u003cproject1;project2...\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_f5aec3e4","line":148,"range":{"start_line":148,"start_character":24,"end_line":148,"end_character":40},"in_reply_to":"5a3905b3_e80c5d3d","updated":"2017-01-22 01:24:44.000000000","message":"yanyan said \u0027status\u0027 and \u0027project\u0027 should support list. so I add them. ok, \u0027oname\u0027 will support list in next patch.","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"57d8b58c4d75a93fadee10fdd96f9ec0d9b1203e","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                             \u0027This can be specified multiple times, or once \u0027"},{"line_number":147,"context_line":"                             \u0027with parameters separated by a semicolon.\u0027,"},{"line_number":148,"context_line":"                        action\u003d\u0027append\u0027)"},{"line_number":149,"context_line":"    parser.add_argument(\u0027--project\u0027,"},{"line_number":150,"context_line":"                        nargs\u003d\u0027?\u0027,"},{"line_number":151,"context_line":"                        metavar\u003d\u0027\u003cproject1;project2...\u003e\u0027,"},{"line_number":152,"context_line":"                        help\u003d\u0027Purge event records with specified project. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_0869a9be","line":149,"range":{"start_line":149,"start_character":27,"end_line":149,"end_character":34},"updated":"2017-01-20 10:35:43.000000000","message":"internally, we are using \u0027project\u0027 for \u0027project_id\u0027. For users, are they supposed to know that we support project ID only and we don\u0027t support project name?","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"26d61c5f0050bf138f8c1dbd5a2ceb2158ba7de5","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                             \u0027This can be specified multiple times, or once \u0027"},{"line_number":147,"context_line":"                             \u0027with parameters separated by a semicolon.\u0027,"},{"line_number":148,"context_line":"                        action\u003d\u0027append\u0027)"},{"line_number":149,"context_line":"    parser.add_argument(\u0027--project\u0027,"},{"line_number":150,"context_line":"                        nargs\u003d\u0027?\u0027,"},{"line_number":151,"context_line":"                        metavar\u003d\u0027\u003cproject1;project2...\u003e\u0027,"},{"line_number":152,"context_line":"                        help\u003d\u0027Purge event records with specified project. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_5584f75c","line":149,"range":{"start_line":149,"start_character":27,"end_line":149,"end_character":34},"in_reply_to":"5a3905b3_0869a9be","updated":"2017-01-22 01:24:44.000000000","message":"change to project_id","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"61e1a37ca4a3bdb43f60f8daea18f1e707be8932","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                             \u0027in the specified time. The time is specified \u0027"},{"line_number":167,"context_line":"                             \u0027by age and granularity. For example, \u0027"},{"line_number":168,"context_line":"                             \u0027granularity\u003dhours and age\u003d2 means to purge \u0027"},{"line_number":169,"context_line":"                             \u0027the events which are created two hours ago.\u0027)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"command_opt \u003d cfg.SubCommandOpt(\u0027command\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_ded40449","line":169,"updated":"2017-02-03 08:47:23.000000000","message":"since you have both \u0027age\u0027 and \u0027granularity\u0027 specified as \"nargs\u003d\u0027?\u0027, how do you want to process this command?\n\n   senlin-manage event_purge --age 1 --age 2 --granularity days --granularity hours","commit_id":"4bc0d482a054d315ac3913795c94a108b382c221"}],"senlin/db/sqlalchemy/api.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"8bc042bf0943eeb3960fdbc73ea068486f5bc764","unresolved":false,"context_lines":[{"line_number":920,"context_line":"        return query.delete(synchronize_session\u003d\u0027fetch\u0027)"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"def event_purge():"},{"line_number":924,"context_line":"    with session_for_write() as session:"},{"line_number":925,"context_line":"        query \u003d session.query(models.Event).with_for_update()"},{"line_number":926,"context_line":"        return query.delete(synchronize_session\u003d\u0027fetch\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_c7de9d6c","line":923,"range":{"start_line":923,"start_character":4,"end_line":923,"end_character":15},"updated":"2017-01-16 12:48:54.000000000","message":"we should rethink about this and about the use cases.\n\nHow would users use this functionality?\n\nWhen they observe that events table is growing large, what would they do? If you are the user, are you going to delete all events unconditionally in this way?","commit_id":"132d815516942a0061fc208d169787481f28b69d"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"8bc042bf0943eeb3960fdbc73ea068486f5bc764","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"def action_purge():"},{"line_number":1022,"context_line":"    with session_for_write() as session:"},{"line_number":1023,"context_line":"        query \u003d session.query(models.Action).with_for_update()"},{"line_number":1024,"context_line":"        return query.delete(synchronize_session\u003d\u0027fetch\u0027)"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"def dependency_get_depended(context, action_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_676249af","line":1024,"updated":"2017-01-16 12:48:54.000000000","message":"We had a discussion about this during the meetup last weekend. This is complicated to what is written here.\n\nThere are actions being processed, waiting to be processed, completed with a success, completed with an error, failed execution but can be retried.\n\nUnconditionally deleting all actions is not acceptable.","commit_id":"132d815516942a0061fc208d169787481f28b69d"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"99c735f0ce5e2e46333f02ebe78c073aec731cf5","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        return query.delete(synchronize_session\u003d\u0027fetch\u0027)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"def event_purge(oname, status, project, time_before, time_after):"},{"line_number":925,"context_line":"    with session_for_write() as session:"},{"line_number":926,"context_line":"        query \u003d session.query(models.Event).with_for_update()"},{"line_number":927,"context_line":"        if oname is not None and oname !\u003d \u0027None\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_272506c2","line":924,"updated":"2017-01-19 05:09:22.000000000","message":"this is on the right track now ..\n\nplease refer to how Heat is doing event purging here:\n\nhttp://git.openstack.org/cgit/openstack/heat/tree/heat/db/sqlalchemy/api.py#n1204\n\nForcing users to input a datetime string is error prone.","commit_id":"ee9d91cb3e9c6b7267de621217005b08d2b72569"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"99c735f0ce5e2e46333f02ebe78c073aec731cf5","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        return q.delete(synchronize_session\u003d\u0027fetch\u0027)"},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"def action_purge(target, status, project):"},{"line_number":1040,"context_line":"    with session_for_write() as session:"},{"line_number":1041,"context_line":"        query \u003d session.query(models.Action).with_for_update()"},{"line_number":1042,"context_line":"        if target is not None and target !\u003d \u0027None\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_0749ea8b","line":1039,"updated":"2017-01-19 05:09:22.000000000","message":"this is not needed based on team\u0027s discussion during meetup. A cluster\u0027s actions will be cleaned when the cluster is deleted.","commit_id":"ee9d91cb3e9c6b7267de621217005b08d2b72569"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"bd6cb02e687b7bc3a8c764cb0f6d06a2527e3342","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        return q.delete(synchronize_session\u003d\u0027fetch\u0027)"},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"def action_purge(target, status, project):"},{"line_number":1040,"context_line":"    with session_for_write() as session:"},{"line_number":1041,"context_line":"        query \u003d session.query(models.Action).with_for_update()"},{"line_number":1042,"context_line":"        if target is not None and target !\u003d \u0027None\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_f6565105","line":1039,"in_reply_to":"5a3905b3_0749ea8b","updated":"2017-01-19 06:09:29.000000000","message":"When node is deleted, but the related cluster is not deleted, whether we should consider to enable purging the actions belong to the deleted node?","commit_id":"ee9d91cb3e9c6b7267de621217005b08d2b72569"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"41d0da5e10b0c9b7845a99da321a2f3426419ee6","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        return q.delete(synchronize_session\u003d\u0027fetch\u0027)"},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"def action_purge(target, status, project):"},{"line_number":1040,"context_line":"    with session_for_write() as session:"},{"line_number":1041,"context_line":"        query \u003d session.query(models.Action).with_for_update()"},{"line_number":1042,"context_line":"        if target is not None and target !\u003d \u0027None\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_f6e651e7","line":1039,"in_reply_to":"5a3905b3_367c5920","updated":"2017-01-19 06:30:24.000000000","message":"keep the code here or move it from senlin-manage to engine layer?","commit_id":"ee9d91cb3e9c6b7267de621217005b08d2b72569"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"6d6fb77bec13afc074f69c087d15af4d66ca6abe","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        return q.delete(synchronize_session\u003d\u0027fetch\u0027)"},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"def action_purge(target, status, project):"},{"line_number":1040,"context_line":"    with session_for_write() as session:"},{"line_number":1041,"context_line":"        query \u003d session.query(models.Action).with_for_update()"},{"line_number":1042,"context_line":"        if target is not None and target !\u003d \u0027None\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_367c5920","line":1039,"in_reply_to":"5a3905b3_f6565105","updated":"2017-01-19 06:26:36.000000000","message":"yes, I think so.","commit_id":"ee9d91cb3e9c6b7267de621217005b08d2b72569"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"60c407e91fec2ec133a8aa267fa1e8554f98d17d","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        return q.delete(synchronize_session\u003d\u0027fetch\u0027)"},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":""},{"line_number":1039,"context_line":"def action_purge(target, status, project):"},{"line_number":1040,"context_line":"    with session_for_write() as session:"},{"line_number":1041,"context_line":"        query \u003d session.query(models.Action).with_for_update()"},{"line_number":1042,"context_line":"        if target is not None and target !\u003d \u0027None\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_6f49a0d0","line":1039,"in_reply_to":"5a3905b3_f6e651e7","updated":"2017-01-19 08:05:30.000000000","message":"I\u0027d suggest we remove it ...\n\nadding it back in future when there is such a need doesn\u0027t sound a big problem.","commit_id":"ee9d91cb3e9c6b7267de621217005b08d2b72569"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"cdb2126c84bcaee8b4aa1aee7afe744c3f6dd91f","unresolved":false,"context_lines":[{"line_number":924,"context_line":"def event_purge(oname, status, project, granularity, age):"},{"line_number":925,"context_line":"    with session_for_write() as session:"},{"line_number":926,"context_line":"        query \u003d session.query(models.Event).with_for_update()"},{"line_number":927,"context_line":"        if oname is not None and oname !\u003d \u0027None\u0027:"},{"line_number":928,"context_line":"            query \u003d query.filter_by(oname\u003doname)"},{"line_number":929,"context_line":"        if status is not None and status !\u003d \u0027None\u0027:"},{"line_number":930,"context_line":"            query \u003d query.filter_by(status\u003dstatus)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_aee538a9","line":927,"range":{"start_line":927,"start_character":32,"end_line":927,"end_character":48},"updated":"2017-01-19 13:55:47.000000000","message":"1) what is this?\n\n2) what is the use case of deleting events related to a named object?\n\n3) same question for status and project.","commit_id":"b7acdd189654dda810e1b68ca86c0fdf47d909bf"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"c080b06450ffd47486a5027cef5006d017191e7a","unresolved":false,"context_lines":[{"line_number":924,"context_line":"def event_purge(oname, status, project, granularity, age):"},{"line_number":925,"context_line":"    with session_for_write() as session:"},{"line_number":926,"context_line":"        query \u003d session.query(models.Event).with_for_update()"},{"line_number":927,"context_line":"        if oname is not None and oname !\u003d \u0027None\u0027:"},{"line_number":928,"context_line":"            query \u003d query.filter_by(oname\u003doname)"},{"line_number":929,"context_line":"        if status is not None and status !\u003d \u0027None\u0027:"},{"line_number":930,"context_line":"            query \u003d query.filter_by(status\u003dstatus)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_c84a5783","line":927,"range":{"start_line":927,"start_character":32,"end_line":927,"end_character":48},"in_reply_to":"5a3905b3_aee538a9","updated":"2017-01-20 01:07:04.000000000","message":"1)When one filter doesn\u0027t need to be cared, filled with \u0027None\"\n2)When events increased too much, user can choose to purge the events which are created by deleted node for example.\n3)If the project is obsolete, or the status is not cared by user, He can use the filters to delete.","commit_id":"b7acdd189654dda810e1b68ca86c0fdf47d909bf"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"79ed53cd0a88b11630810741b1c9951313571102","unresolved":false,"context_lines":[{"line_number":924,"context_line":"def event_purge(oname, status, project, granularity, age):"},{"line_number":925,"context_line":"    with session_for_write() as session:"},{"line_number":926,"context_line":"        query \u003d session.query(models.Event).with_for_update()"},{"line_number":927,"context_line":"        if oname is not None and oname !\u003d \u0027None\u0027:"},{"line_number":928,"context_line":"            query \u003d query.filter_by(oname\u003doname)"},{"line_number":929,"context_line":"        if status is not None and status !\u003d \u0027None\u0027:"},{"line_number":930,"context_line":"            query \u003d query.filter_by(status\u003dstatus)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_5942bb3f","line":927,"range":{"start_line":927,"start_character":32,"end_line":927,"end_character":48},"in_reply_to":"5a3905b3_c84a5783","updated":"2017-01-20 02:05:41.000000000","message":"hi, hongbao, if we do need to filter event purging by status and project, I think we should support to use a list of statuses and projects as filter, like this:\n\n    if status:\n        q \u003d q.filter(models.Event.status.in_(status))","commit_id":"b7acdd189654dda810e1b68ca86c0fdf47d909bf"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"57d8b58c4d75a93fadee10fdd96f9ec0d9b1203e","unresolved":false,"context_lines":[{"line_number":924,"context_line":"def event_purge(oname, status, project, granularity, age):"},{"line_number":925,"context_line":"    with session_for_write() as session:"},{"line_number":926,"context_line":"        query \u003d session.query(models.Event).with_for_update()"},{"line_number":927,"context_line":"        if oname is not None and oname !\u003d \u0027None\u0027:"},{"line_number":928,"context_line":"            query \u003d query.filter_by(oname\u003doname)"},{"line_number":929,"context_line":"        if status is not None and status !\u003d \u0027None\u0027:"},{"line_number":930,"context_line":"            query \u003d query.filter(models.Event.status.in_(status))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_0dcffb7f","line":927,"range":{"start_line":927,"start_character":29,"end_line":927,"end_character":48},"updated":"2017-01-20 10:35:43.000000000","message":"what is the purpose of doing this check?\n\nIf I don\u0027t want to do oname filtering, I should specify oname\u003dNone?","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"26d61c5f0050bf138f8c1dbd5a2ceb2158ba7de5","unresolved":false,"context_lines":[{"line_number":924,"context_line":"def event_purge(oname, status, project, granularity, age):"},{"line_number":925,"context_line":"    with session_for_write() as session:"},{"line_number":926,"context_line":"        query \u003d session.query(models.Event).with_for_update()"},{"line_number":927,"context_line":"        if oname is not None and oname !\u003d \u0027None\u0027:"},{"line_number":928,"context_line":"            query \u003d query.filter_by(oname\u003doname)"},{"line_number":929,"context_line":"        if status is not None and status !\u003d \u0027None\u0027:"},{"line_number":930,"context_line":"            query \u003d query.filter(models.Event.status.in_(status))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_95f1ff03","line":927,"range":{"start_line":927,"start_character":29,"end_line":927,"end_character":48},"in_reply_to":"5a3905b3_0dcffb7f","updated":"2017-01-22 01:24:44.000000000","message":"In patch4, it can be removed, since the argparse has been changed.","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"57d8b58c4d75a93fadee10fdd96f9ec0d9b1203e","unresolved":false,"context_lines":[{"line_number":932,"context_line":"            query \u003d query.filter(models.Event.project.in_(project))"},{"line_number":933,"context_line":"        if granularity is not None and granularity !\u003d \u0027None\u0027 and \\"},{"line_number":934,"context_line":"           age is not None and age !\u003d \u0027None\u0027:"},{"line_number":935,"context_line":"            age \u003d int(age)"},{"line_number":936,"context_line":"            if granularity \u003d\u003d \u0027days\u0027:"},{"line_number":937,"context_line":"                age \u003d age * 86400"},{"line_number":938,"context_line":"            elif granularity \u003d\u003d \u0027hours\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_2d9f5751","line":935,"range":{"start_line":935,"start_character":0,"end_line":935,"end_character":26},"updated":"2017-01-20 10:35:43.000000000","message":"should we do a try... except here?","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"26d61c5f0050bf138f8c1dbd5a2ceb2158ba7de5","unresolved":false,"context_lines":[{"line_number":932,"context_line":"            query \u003d query.filter(models.Event.project.in_(project))"},{"line_number":933,"context_line":"        if granularity is not None and granularity !\u003d \u0027None\u0027 and \\"},{"line_number":934,"context_line":"           age is not None and age !\u003d \u0027None\u0027:"},{"line_number":935,"context_line":"            age \u003d int(age)"},{"line_number":936,"context_line":"            if granularity \u003d\u003d \u0027days\u0027:"},{"line_number":937,"context_line":"                age \u003d age * 86400"},{"line_number":938,"context_line":"            elif granularity \u003d\u003d \u0027hours\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_358ccb7e","line":935,"range":{"start_line":935,"start_character":0,"end_line":935,"end_character":26},"in_reply_to":"5a3905b3_2d9f5751","updated":"2017-01-22 01:24:44.000000000","message":"ok","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"57d8b58c4d75a93fadee10fdd96f9ec0d9b1203e","unresolved":false,"context_lines":[{"line_number":938,"context_line":"            elif granularity \u003d\u003d \u0027hours\u0027:"},{"line_number":939,"context_line":"                age \u003d age * 3600"},{"line_number":940,"context_line":"            elif granularity \u003d\u003d \u0027minutes\u0027:"},{"line_number":941,"context_line":"                age \u003d age * 60"},{"line_number":942,"context_line":"            time_line \u003d timeutils.utcnow() - datetime.timedelta(seconds\u003dage)"},{"line_number":943,"context_line":"            query \u003d query.filter(models.Event.timestamp \u003c time_line)"},{"line_number":944,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_8dbccb6d","line":941,"updated":"2017-01-20 10:35:43.000000000","message":"what if granularity is \"boom\" ?","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"26d61c5f0050bf138f8c1dbd5a2ceb2158ba7de5","unresolved":false,"context_lines":[{"line_number":938,"context_line":"            elif granularity \u003d\u003d \u0027hours\u0027:"},{"line_number":939,"context_line":"                age \u003d age * 3600"},{"line_number":940,"context_line":"            elif granularity \u003d\u003d \u0027minutes\u0027:"},{"line_number":941,"context_line":"                age \u003d age * 60"},{"line_number":942,"context_line":"            time_line \u003d timeutils.utcnow() - datetime.timedelta(seconds\u003dage)"},{"line_number":943,"context_line":"            query \u003d query.filter(models.Event.timestamp \u003c time_line)"},{"line_number":944,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_158fcf75","line":941,"in_reply_to":"5a3905b3_8dbccb6d","updated":"2017-01-22 01:24:44.000000000","message":"actually it will not be other value, since we check it in manage.py.","commit_id":"f42020e8a689160af9e43ac8bce5033f3f55e7ea"}]}
