)]}'
{"senlin/api/openstack/v1/clusters.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0addce0e995b93555a2f6ca4ebbfe25141737c94","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _do_resize(self, req, cluster_id, data):"},{"line_number":131,"context_line":"        params \u003d {}"},{"line_number":132,"context_line":"        if data.get(consts.ADJUSTMENT_TYPE, None):"},{"line_number":133,"context_line":"            params[\u0027adjustment_type\u0027] \u003d data.get(consts.ADJUSTMENT_TYPE)"},{"line_number":134,"context_line":"        if data.get(consts.ADJUSTMENT_NUMBER, None) is not None:"},{"line_number":135,"context_line":"            params[\u0027number\u0027] \u003d data.get(consts.ADJUSTMENT_NUMBER)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_29597335","line":132,"range":{"start_line":132,"start_character":11,"end_line":132,"end_character":50},"updated":"2017-02-09 07:54:30.000000000","message":"what\u0027s the benefit in setting a None as default value?","commit_id":"e339d873c80eefa49c2439c1c8a7f38c7a57065e"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0addce0e995b93555a2f6ca4ebbfe25141737c94","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        params \u003d {}"},{"line_number":132,"context_line":"        if data.get(consts.ADJUSTMENT_TYPE, None):"},{"line_number":133,"context_line":"            params[\u0027adjustment_type\u0027] \u003d data.get(consts.ADJUSTMENT_TYPE)"},{"line_number":134,"context_line":"        if data.get(consts.ADJUSTMENT_NUMBER, None) is not None:"},{"line_number":135,"context_line":"            params[\u0027number\u0027] \u003d data.get(consts.ADJUSTMENT_NUMBER)"},{"line_number":136,"context_line":"        if data.get(consts.ADJUSTMENT_MIN_SIZE, None) is not None:"},{"line_number":137,"context_line":"            params[\u0027min_size\u0027] \u003d data.get(consts.ADJUSTMENT_MIN_SIZE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_4944ff48","line":134,"range":{"start_line":134,"start_character":51,"end_line":134,"end_character":63},"updated":"2017-02-09 07:54:30.000000000","message":"why do we need to check this way?","commit_id":"e339d873c80eefa49c2439c1c8a7f38c7a57065e"},{"author":{"_account_id":15917,"name":"Aaron-DH","email":"344677472@qq.com","username":"aaron"},"change_message_id":"d11500956835cbd9976d0f85e079b23561d99ee2","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        params \u003d {}"},{"line_number":132,"context_line":"        if data.get(consts.ADJUSTMENT_TYPE, None):"},{"line_number":133,"context_line":"            params[\u0027adjustment_type\u0027] \u003d data.get(consts.ADJUSTMENT_TYPE)"},{"line_number":134,"context_line":"        if data.get(consts.ADJUSTMENT_NUMBER, None) is not None:"},{"line_number":135,"context_line":"            params[\u0027number\u0027] \u003d data.get(consts.ADJUSTMENT_NUMBER)"},{"line_number":136,"context_line":"        if data.get(consts.ADJUSTMENT_MIN_SIZE, None) is not None:"},{"line_number":137,"context_line":"            params[\u0027min_size\u0027] \u003d data.get(consts.ADJUSTMENT_MIN_SIZE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_cc2d5dff","line":134,"range":{"start_line":134,"start_character":51,"end_line":134,"end_character":63},"in_reply_to":"1a430d35_4944ff48","updated":"2017-02-09 08:38:09.000000000","message":"hi, Qiming\nthis way you can check the situation that param is in the request but with None value.","commit_id":"e339d873c80eefa49c2439c1c8a7f38c7a57065e"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"5d0b6b15b1cdfa3244e9193cf7c26a602187b7db","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        params \u003d {}"},{"line_number":132,"context_line":"        if data.get(consts.ADJUSTMENT_TYPE, None):"},{"line_number":133,"context_line":"            params[\u0027adjustment_type\u0027] \u003d data.get(consts.ADJUSTMENT_TYPE)"},{"line_number":134,"context_line":"        if data.get(consts.ADJUSTMENT_NUMBER, None) is not None:"},{"line_number":135,"context_line":"            params[\u0027number\u0027] \u003d data.get(consts.ADJUSTMENT_NUMBER)"},{"line_number":136,"context_line":"        if data.get(consts.ADJUSTMENT_MIN_SIZE, None) is not None:"},{"line_number":137,"context_line":"            params[\u0027min_size\u0027] \u003d data.get(consts.ADJUSTMENT_MIN_SIZE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_e1077715","line":134,"range":{"start_line":134,"start_character":51,"end_line":134,"end_character":63},"in_reply_to":"1a430d35_cc2d5dff","updated":"2017-02-09 13:20:39.000000000","message":"in Python, the following code can test if value is None, right?\n\n   if value:\n      some code here","commit_id":"e339d873c80eefa49c2439c1c8a7f38c7a57065e"},{"author":{"_account_id":15917,"name":"Aaron-DH","email":"344677472@qq.com","username":"aaron"},"change_message_id":"a5a08bd9b69f386be016ee12aca7ad45a92ad644","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        params \u003d {}"},{"line_number":132,"context_line":"        if data.get(consts.ADJUSTMENT_TYPE, None):"},{"line_number":133,"context_line":"            params[\u0027adjustment_type\u0027] \u003d data.get(consts.ADJUSTMENT_TYPE)"},{"line_number":134,"context_line":"        if data.get(consts.ADJUSTMENT_NUMBER, None) is not None:"},{"line_number":135,"context_line":"            params[\u0027number\u0027] \u003d data.get(consts.ADJUSTMENT_NUMBER)"},{"line_number":136,"context_line":"        if data.get(consts.ADJUSTMENT_MIN_SIZE, None) is not None:"},{"line_number":137,"context_line":"            params[\u0027min_size\u0027] \u003d data.get(consts.ADJUSTMENT_MIN_SIZE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_d164f34a","line":134,"range":{"start_line":134,"start_character":51,"end_line":134,"end_character":63},"in_reply_to":"1a430d35_e1077715","updated":"2017-02-10 01:32:20.000000000","message":"yes, both `if None` and `if 0` can return False\nbut we just need to judge the None value since 0 maybe is the actual value of ADJUSTMENT_NUMBER, same with other integer params","commit_id":"e339d873c80eefa49c2439c1c8a7f38c7a57065e"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"fc3fb75595cfaf624c377133a3400915b646b18e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        params \u003d {}"},{"line_number":132,"context_line":"        if data.get(consts.ADJUSTMENT_TYPE, None):"},{"line_number":133,"context_line":"            params[\u0027adjustment_type\u0027] \u003d data.get(consts.ADJUSTMENT_TYPE)"},{"line_number":134,"context_line":"        if data.get(consts.ADJUSTMENT_NUMBER, None) is not None:"},{"line_number":135,"context_line":"            params[\u0027number\u0027] \u003d data.get(consts.ADJUSTMENT_NUMBER)"},{"line_number":136,"context_line":"        if data.get(consts.ADJUSTMENT_MIN_SIZE, None) is not None:"},{"line_number":137,"context_line":"            params[\u0027min_size\u0027] \u003d data.get(consts.ADJUSTMENT_MIN_SIZE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_87bb190e","line":134,"range":{"start_line":134,"start_character":51,"end_line":134,"end_character":63},"in_reply_to":"fa31d9ce_d164f34a","updated":"2017-02-10 02:27:08.000000000","message":"Ah, I see, it is a guard against 0 values. That sounds legitimate.","commit_id":"e339d873c80eefa49c2439c1c8a7f38c7a57065e"}]}