)]}'
{"senlin/policies/lb_policy.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0c4e60381e3f2432136dd3284f6c31c4cf72c041","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        failed_nodes \u003d []"},{"line_number":450,"context_line":"        for node_id in candidates:"},{"line_number":451,"context_line":"            node \u003d nm.Node.load(action.context, node_id\u003dnode_id)"},{"line_number":452,"context_line":"            member_id \u003d node.data.get(\u0027lb_member\u0027, None)"},{"line_number":453,"context_line":"            if member_id is None:"},{"line_number":454,"context_line":"                LOG.warning(_LW(\u0027Node %(n)s not found in lb pool %(p)s.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_5d6d52cb","line":451,"range":{"start_line":451,"start_character":11,"end_line":451,"end_character":64},"updated":"2017-02-28 12:24:22.000000000","message":"maybe we should do this:\n\n  node \u003d nodeobj.Node.Get() \n\nthen on line 461-462, we can do a nodeobj.Node.Update()\n\nthis will save some overhead.","commit_id":"827ec4e924c0ef237f8970020403642f04a2e700"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"e1d4aa778bcade539f32a733cef7ba7a63144fec","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            else:"},{"line_number":467,"context_line":"                node.data.pop(\u0027lb_member\u0027, None)"},{"line_number":468,"context_line":"                values[\u0027data\u0027] \u003d node.data"},{"line_number":469,"context_line":"            node.update(action.context, node_id, values)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        return failed_nodes"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_2a4dbf72","line":469,"range":{"start_line":469,"start_character":12,"end_line":469,"end_character":16},"updated":"2017-03-01 05:29:27.000000000","message":"no.Node.update()","commit_id":"0f2fd2625b2835f849df08cf79e071bdfee8e44c"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"e1d4aa778bcade539f32a733cef7ba7a63144fec","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            else:"},{"line_number":499,"context_line":"                node.data.update({\u0027lb_member\u0027: member_id})"},{"line_number":500,"context_line":"                values[\u0027data\u0027] \u003d node.data"},{"line_number":501,"context_line":"            node.update(action.context, node_id, values)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        return failed_nodes"},{"line_number":504,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_4a52f314","line":501,"range":{"start_line":501,"start_character":12,"end_line":501,"end_character":16},"updated":"2017-03-01 05:29:27.000000000","message":"no.Node.update","commit_id":"0f2fd2625b2835f849df08cf79e071bdfee8e44c"}]}