)]}'
{"senlin/policies/lb_policy.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0375de070449a0853f7ad8ea1660bf2d1fb36505","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        if action.action \u003d\u003d consts.NODE_CREATE:"},{"line_number":511,"context_line":"            added \u003d [action.node.id]"},{"line_number":512,"context_line":"        elif action.action \u003d\u003d consts.CLUSTER_RECOVER:"},{"line_number":513,"context_line":"            added \u003d action.data.get(\u0027initiate\u0027, [])"},{"line_number":514,"context_line":"            removed \u003d action.data.get(\u0027uninitiate\u0027, [])"},{"line_number":515,"context_line":"        else:"},{"line_number":516,"context_line":"            creation \u003d action.data.get(\u0027creation\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_4ac2e134","line":513,"range":{"start_line":513,"start_character":37,"end_line":513,"end_character":45},"updated":"2017-03-01 13:31:39.000000000","message":"this and the \u0027uninitiate\u0027 below are strange.","commit_id":"bf5b0a99b5491fc8e9d783e8ba7be4c2fff50f35"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"a03e8a6b73df450ab4b51d5f11cfdc3d3eb4b5be","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        if action.action \u003d\u003d consts.NODE_CREATE:"},{"line_number":511,"context_line":"            added \u003d [action.node.id]"},{"line_number":512,"context_line":"        elif action.action \u003d\u003d consts.CLUSTER_RECOVER:"},{"line_number":513,"context_line":"            added \u003d action.data.get(\u0027initiate\u0027, [])"},{"line_number":514,"context_line":"            removed \u003d action.data.get(\u0027uninitiate\u0027, [])"},{"line_number":515,"context_line":"        else:"},{"line_number":516,"context_line":"            creation \u003d action.data.get(\u0027creation\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_d183c4ca","line":513,"range":{"start_line":513,"start_character":37,"end_line":513,"end_character":45},"in_reply_to":"ba2be162_48ac8d35","updated":"2017-03-02 02:49:58.000000000","message":"yes, cannot figure out why we are adding new keys into action.data. the name is confusing as well.","commit_id":"bf5b0a99b5491fc8e9d783e8ba7be4c2fff50f35"},{"author":{"_account_id":23401,"name":"RUIJIE YUAN","email":"cnjie0616@gmail.com","username":"ruijie"},"change_message_id":"7b9046b00d7cc0267656a36c5a5b69faaabc3e6a","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        if action.action \u003d\u003d consts.NODE_CREATE:"},{"line_number":511,"context_line":"            added \u003d [action.node.id]"},{"line_number":512,"context_line":"        elif action.action \u003d\u003d consts.CLUSTER_RECOVER:"},{"line_number":513,"context_line":"            added \u003d action.data.get(\u0027initiate\u0027, [])"},{"line_number":514,"context_line":"            removed \u003d action.data.get(\u0027uninitiate\u0027, [])"},{"line_number":515,"context_line":"        else:"},{"line_number":516,"context_line":"            creation \u003d action.data.get(\u0027creation\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_48ac8d35","line":513,"range":{"start_line":513,"start_character":37,"end_line":513,"end_character":45},"in_reply_to":"ba2be162_4ac2e134","updated":"2017-03-02 02:03:13.000000000","message":"Qiming, you mean the name?","commit_id":"bf5b0a99b5491fc8e9d783e8ba7be4c2fff50f35"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"71832ff62e7ccaa2421f19582a8d471b9919dcea","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        lb_driver.lb_status_timeout \u003d self.lb_status_timeout"},{"line_number":570,"context_line":"        cp \u003d cluster_policy.ClusterPolicy.load(action.context, cluster_id,"},{"line_number":571,"context_line":"                                               self.id)"},{"line_number":572,"context_line":"        if action.action \u003d\u003d consts.CLUSTER_RECOVER:"},{"line_number":573,"context_line":"            self._remove_member(candidates, cp, action, lb_driver,"},{"line_number":574,"context_line":"                                handle_err\u003dFalse)"},{"line_number":575,"context_line":"        # Add new nodes to lb pool"},{"line_number":576,"context_line":"        failed_nodes \u003d self._add_member(candidates, cp, action, lb_driver)"},{"line_number":577,"context_line":"        if failed_nodes:"},{"line_number":578,"context_line":"            error \u003d _(\u0027Failed in adding nodes into lb pool: %s\u0027) % failed_nodes"},{"line_number":579,"context_line":"            action.data[\u0027status\u0027] \u003d base.CHECK_ERROR"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_fd0fb6de","line":576,"range":{"start_line":572,"start_character":0,"end_line":576,"end_character":74},"updated":"2017-03-02 06:09:56.000000000","message":"this logic means we will be refreshing the lb member pool completely?\n\nI\u0027m fine with it although I am a little bit worried about the huge amount of delays.","commit_id":"cae9067ed6e74490e83521b9b28937e9dd9fa479"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"46a14d02b8b9c82f9b33b0555f8c53b8dceb8b01","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        if action.action \u003d\u003d consts.NODE_CREATE:"},{"line_number":510,"context_line":"            candidates \u003d [action.node.id]"},{"line_number":511,"context_line":"        elif action.action \u003d\u003d consts.NODE_RECOVER:"},{"line_number":512,"context_line":"            candidates \u003d action.output.get(\u0027operate_lb\u0027, [])"},{"line_number":513,"context_line":"        else:"},{"line_number":514,"context_line":"            creation \u003d action.data.get(\u0027creation\u0027, None)"},{"line_number":515,"context_line":"            candidates \u003d creation.get(\u0027nodes\u0027, []) if creation else []"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_9b7ddbe9","line":512,"range":{"start_line":512,"start_character":44,"end_line":512,"end_character":54},"updated":"2017-03-02 10:07:30.000000000","message":"we\u0027d better avoid mentioning the intent for a field in a generic data structure. Here \u0027operate_lb\u0027 is too specific for this scenario. My guess is that you want to check whether the node has been successfully recovered and you may want to know if the node\u0027s IP has changed etc. Such information may get used somewhere else, not just here.\n\nFor a NODE_RECOVER action, you may want to improve it to record its outputs as facts. The LB policy can then deduce its own knowledge based on the generic outputs.","commit_id":"69095db8a4862b35e8ffa220c7e861a3c83fe9a0"}]}