)]}'
{"id":"openstack%2Fsenlin~439975","triplet_id":"openstack%2Fsenlin~master~Id6dd73322a4f945fdcca262734196f88b2cf5d1a","project":"openstack/senlin","branch":"master","topic":"remove-a-todo","hashtags":[],"change_id":"Id6dd73322a4f945fdcca262734196f88b2cf5d1a","subject":"Remove a TODO item in node object module","status":"MERGED","created":"2017-03-02 03:38:15.000000000","updated":"2017-03-02 06:41:07.000000000","submitted":"2017-03-02 06:41:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fb0e00953fb45626c027933f42110d0078a814bd","_number":439975,"virtual_id_number":439975,"owner":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-03-02 06:41:07.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22998,"name":"XueFengLiu","email":"liu.xuefeng1@zte.com.cn","username":"sgfeng"},{"value":0,"_account_id":23401,"name":"RUIJIE YUAN","email":"cnjie0616@gmail.com","username":"ruijie"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22998,"name":"XueFengLiu","email":"liu.xuefeng1@zte.com.cn","username":"sgfeng"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-03-02 05:24:22.000000000","_account_id":22998,"name":"XueFengLiu","email":"liu.xuefeng1@zte.com.cn","username":"sgfeng"},{"value":2,"date":"2017-03-02 05:59:45.000000000","_account_id":23401,"name":"RUIJIE YUAN","email":"cnjie0616@gmail.com","username":"ruijie"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23401,"name":"RUIJIE YUAN","email":"cnjie0616@gmail.com","username":"ruijie"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22998,"name":"XueFengLiu","email":"liu.xuefeng1@zte.com.cn","username":"sgfeng"},{"value":1,"date":"2017-03-02 05:59:45.000000000","_account_id":23401,"name":"RUIJIE YUAN","email":"cnjie0616@gmail.com","username":"ruijie"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22998,"name":"XueFengLiu","email":"liu.xuefeng1@zte.com.cn","username":"sgfeng"},{"_account_id":23401,"name":"RUIJIE YUAN","email":"cnjie0616@gmail.com","username":"ruijie"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-02 05:24:22.000000000","updated_by":{"_account_id":22998,"name":"XueFengLiu","email":"liu.xuefeng1@zte.com.cn","username":"sgfeng"},"reviewer":{"_account_id":22998,"name":"XueFengLiu","email":"liu.xuefeng1@zte.com.cn","username":"sgfeng"},"state":"REVIEWER"},{"updated":"2017-03-02 05:59:45.000000000","updated_by":{"_account_id":23401,"name":"RUIJIE YUAN","email":"cnjie0616@gmail.com","username":"ruijie"},"reviewer":{"_account_id":23401,"name":"RUIJIE YUAN","email":"cnjie0616@gmail.com","username":"ruijie"},"state":"REVIEWER"},{"updated":"2017-03-02 06:41:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5c83902c95df1c16b49305407765800bce119b51","author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"date":"2017-03-02 03:38:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b5bbb9bcd0ce92295770d360d8727861ebe62614","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-02 04:20:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-senlin-docs-ubuntu-xenial http://docs-draft.openstack.org/75/439975/1/check/gate-senlin-docs-ubuntu-xenial/fd37d43//doc/build/html/ : SUCCESS in 2m 40s\n- gate-senlin-pep8-ubuntu-xenial http://logs.openstack.org/75/439975/1/check/gate-senlin-pep8-ubuntu-xenial/e54591d/ : SUCCESS in 4m 55s\n- gate-senlin-python27-ubuntu-xenial http://logs.openstack.org/75/439975/1/check/gate-senlin-python27-ubuntu-xenial/204096c/ : SUCCESS in 3m 34s\n- gate-senlin-python35 http://logs.openstack.org/75/439975/1/check/gate-senlin-python35/e4d213f/ : SUCCESS in 5m 49s\n- senlin-coverage-ubuntu-xenial-nv http://logs.openstack.org/75/439975/1/check/senlin-coverage-ubuntu-xenial-nv/838e0f9/ : SUCCESS in 5m 52s (non-voting)\n- gate-senlin-dsvm-tempest-api http://logs.openstack.org/75/439975/1/check/gate-senlin-dsvm-tempest-api/f50b9da/ : SUCCESS in 39m 40s\n- gate-senlin-dsvm-tempest-functional http://logs.openstack.org/75/439975/1/check/gate-senlin-dsvm-tempest-functional/0a3f5d5/ : SUCCESS in 32m 15s\n- gate-senlin-dsvm-tempest-integration-nv http://logs.openstack.org/75/439975/1/check/gate-senlin-dsvm-tempest-integration-nv/3582a49/ : SUCCESS in 36m 18s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"561775f04f7a4dd33a8af2dc23e91f1a7453ed8c","author":{"_account_id":22998,"name":"XueFengLiu","email":"liu.xuefeng1@zte.com.cn","username":"sgfeng"},"date":"2017-03-02 05:24:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"680cc563b112d9b08d34d71622517ad58ee465a1","author":{"_account_id":23401,"name":"RUIJIE YUAN","email":"cnjie0616@gmail.com","username":"ruijie"},"date":"2017-03-02 05:59:45.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"20b399fd3df421bc643fe744b50ac0131888bf54","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-02 05:59:55.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"b21fcc744fc59cb3809f56b654777adc9efe5933","date":"2017-03-02 06:41:07.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"68c556a6a4c0050f0b16abc736febff51125f177","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-02 06:41:07.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-senlin-docs-ubuntu-xenial http://docs-draft.openstack.org/75/439975/1/gate/gate-senlin-docs-ubuntu-xenial/bc2c4e1//doc/build/html/ : SUCCESS in 2m 23s\n- gate-senlin-pep8-ubuntu-xenial http://logs.openstack.org/75/439975/1/gate/gate-senlin-pep8-ubuntu-xenial/d9eea75/ : SUCCESS in 5m 14s\n- gate-senlin-python27-ubuntu-xenial http://logs.openstack.org/75/439975/1/gate/gate-senlin-python27-ubuntu-xenial/9ec82ed/ : SUCCESS in 5m 14s\n- gate-senlin-python35 http://logs.openstack.org/75/439975/1/gate/gate-senlin-python35/95318a0/ : SUCCESS in 5m 59s\n- gate-senlin-dsvm-tempest-api http://logs.openstack.org/75/439975/1/gate/gate-senlin-dsvm-tempest-api/9bb81cd/ : SUCCESS in 39m 38s\n- gate-senlin-dsvm-tempest-functional http://logs.openstack.org/75/439975/1/gate/gate-senlin-dsvm-tempest-functional/7174efc/ : SUCCESS in 33m 10s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"33aa4a1296e936588152b4706fb1ad4f4a3b1698","revisions":{"33aa4a1296e936588152b4706fb1ad4f4a3b1698":{"kind":"REWORK","_number":1,"created":"2017-03-02 03:38:15.000000000","uploader":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"ref":"refs/changes/75/439975/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/senlin","ref":"refs/changes/75/439975/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/senlin refs/changes/75/439975/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/senlin refs/changes/75/439975/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/senlin refs/changes/75/439975/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/senlin refs/changes/75/439975/1"}}},"commit":{"parents":[{"commit":"f6ba8ea6c47dd6aadd801bea03e3ecf2acc7aaae","subject":"Merge \"Use ids_by_cluster() object call when appropriate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/senlin/commit/f6ba8ea6c47dd6aadd801bea03e3ecf2acc7aaae"}]}],"author":{"name":"tengqm","email":"tengqim@cn.ibm.com","date":"2017-03-02 03:36:31.000000000","tz":-300},"committer":{"name":"tengqm","email":"tengqim@cn.ibm.com","date":"2017-03-02 03:36:31.000000000","tz":-300},"subject":"Remove a TODO item in node object module","message":"Remove a TODO item in node object module\n\nThe get_all() method is heavy weight and the result is always paginated.\nIn recent changes, we have eliminated the calls to get_all() leaving\nonly the service level node_list() function calling this method. This\nTODO is now resolved. We can remove it.\n\nChange-Id: Id6dd73322a4f945fdcca262734196f88b2cf5d1a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/senlin/commit/33aa4a1296e936588152b4706fb1ad4f4a3b1698"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/senlin/commit/33aa4a1296e936588152b4706fb1ad4f4a3b1698"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
