)]}'
{"senlin/drivers/container/docker_v1.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"14227af5a87d6f488751a50142eaf2840a68cfeb","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @sdk.translate_exception"},{"line_number":52,"context_line":"    def stop(self, container, timeout\u003dNone):"},{"line_number":53,"context_line":"        params \u003d {\u0027timeout\u0027: timeout} if timeout else {}"},{"line_number":54,"context_line":"        self._dockerclient.stop(container, **params)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_5960d5cf","line":53,"updated":"2018-05-26 07:33:25.000000000","message":"Is timeout\u003d0 a valid timeout?","commit_id":"b72e9a68c6ba9f8e32430f05607492ba2d7fd413"}],"senlin/profiles/container/docker.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"3fb9051db49667e0141e71ca36efe746c93814b5","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            dockerclient \u003d self.docker(obj)"},{"line_number":303,"context_line":"            db_api.node_add_dependents(ctx, self.host.id, obj.id)"},{"line_number":304,"context_line":"            container \u003d dockerclient.container_create(**params)"},{"line_number":305,"context_line":"            # container start"},{"line_number":306,"context_line":"            dockerclient.start(container[\u0027Id\u0027])"},{"line_number":307,"context_line":"        except exc.InternalError as ex:"},{"line_number":308,"context_line":"            raise exc.EResourceCreation(type\u003d\u0027container\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_237ce4e9","line":305,"updated":"2018-05-24 03:13:30.000000000","message":"don\u0027t think we need this comment\n\u003e start container is part of the call","commit_id":"6e2340b4dec4b785a8a4efdb050c2de633af91f2"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"2f5ca36347ac503d33c0a8508b3d2724c99d2093","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            dockerclient \u003d self.docker(obj)"},{"line_number":303,"context_line":"            db_api.node_add_dependents(ctx, self.host.id, obj.id)"},{"line_number":304,"context_line":"            container \u003d dockerclient.container_create(**params)"},{"line_number":305,"context_line":"            dockerclient.start(container[\u0027Id\u0027])"},{"line_number":306,"context_line":"        except exc.InternalError as ex:"},{"line_number":307,"context_line":"            raise exc.EResourceCreation(type\u003d\u0027container\u0027,"},{"line_number":308,"context_line":"                                        message\u003dsix.text_type(ex))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_835ff83f","line":305,"updated":"2018-05-24 03:42:17.000000000","message":"Can you add unit-test coverage for this as well?","commit_id":"69e5c55befac1f5ce9cdc2dec702b46d14a0a127"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"f654c03ae0f5d5d477ebf72a32bc21545b829697","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            return"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        try:"},{"line_number":323,"context_line":"            self.docker(obj).container_delete(obj.physical_id)"},{"line_number":324,"context_line":"        except exc.InternalError as ex:"},{"line_number":325,"context_line":"            raise exc.EResourceDeletion(type\u003d\u0027container\u0027,"},{"line_number":326,"context_line":"                                        id\u003dobj.physical_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_9efe6f36","line":323,"range":{"start_line":323,"start_character":29,"end_line":323,"end_character":45},"updated":"2018-05-24 05:15:27.000000000","message":"I think you need to stop the container here before calling container_delete.","commit_id":"69e5c55befac1f5ce9cdc2dec702b46d14a0a127"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"cef601111002675d713da1f22ad11b50f1126882","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    def handle_stop(self, obj, **options):"},{"line_number":392,"context_line":"        \"\"\"Handler for the stop operation.\"\"\""},{"line_number":393,"context_line":"        if not obj.physical_id:"},{"line_number":394,"context_line":"            return True"},{"line_number":395,"context_line":"        if \u0027timeout\u0027 in options:"},{"line_number":396,"context_line":"            params \u003d {\u0027timeout\u0027: options[\u0027timeout\u0027]}"},{"line_number":397,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c210735c","line":394,"range":{"start_line":394,"start_character":19,"end_line":394,"end_character":23},"updated":"2018-05-25 16:18:24.000000000","message":"Return value should be empty instead of True.","commit_id":"208638064073e8cbcb8d9ba50f1417c344e57f6b"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"14227af5a87d6f488751a50142eaf2840a68cfeb","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        \"\"\"Handler for the stop operation.\"\"\""},{"line_number":393,"context_line":"        if not obj.physical_id:"},{"line_number":394,"context_line":"            return"},{"line_number":395,"context_line":"        if \u0027timeout\u0027 in options:"},{"line_number":396,"context_line":"            params \u003d {\u0027timeout\u0027: options[\u0027timeout\u0027]}"},{"line_number":397,"context_line":"        else:"},{"line_number":398,"context_line":"            params \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_39a159f9","line":395,"updated":"2018-05-26 07:33:25.000000000","message":"Something like this might be cleaner (and matches the implementation of DockerClient)\n\ntimeout \u003d options.get(\u0027timeout\u0027)\nparams \u003d {\u0027timeout\u0027: timeout} if timeout else {}","commit_id":"b72e9a68c6ba9f8e32430f05607492ba2d7fd413"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"94de547ca11151563f2c3ea0a77e019114cd865e","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        \"\"\"Handler for the stop operation.\"\"\""},{"line_number":393,"context_line":"        if not obj.physical_id:"},{"line_number":394,"context_line":"            return"},{"line_number":395,"context_line":"        if \u0027timeout\u0027 in options:"},{"line_number":396,"context_line":"            params \u003d {\u0027timeout\u0027: options[\u0027timeout\u0027]}"},{"line_number":397,"context_line":"        else:"},{"line_number":398,"context_line":"            params \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_d96945f8","line":395,"in_reply_to":"5f7c97a3_39a159f9","updated":"2018-05-26 17:09:05.000000000","message":"The above would not allow 0 or None to be valid values for timeout.","commit_id":"b72e9a68c6ba9f8e32430f05607492ba2d7fd413"}]}