)]}'
{"senlin/db/sqlalchemy/api.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"45776e6e5f99d0045b06ebda0134a076e78a31c1","unresolved":false,"context_lines":[{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"        query \u003d session.query(models.ActionDependency)"},{"line_number":1256,"context_line":"        query \u003d query.filter_by(depended\u003daction_id)"},{"line_number":1257,"context_line":"        dependents \u003d [d.dependent for d in query.all()]"},{"line_number":1258,"context_line":"        query.delete(synchronize_session\u003dFalse)"},{"line_number":1259,"context_line":""},{"line_number":1260,"context_line":"    if parent_status_update_needed(action):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_482d2ca6","line":1257,"updated":"2019-01-31 19:37:24.000000000","message":"If you do query.all() above, can\u0027t you just reuse that here?","commit_id":"0367baa1451c1ed02f8b5af44187097127abc1b6"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"2b09594a0f710a4fc7b2f544187c4b456f6f7d72","unresolved":false,"context_lines":[{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"        query \u003d session.query(models.ActionDependency)"},{"line_number":1256,"context_line":"        query \u003d query.filter_by(depended\u003daction_id)"},{"line_number":1257,"context_line":"        dependents \u003d [d.dependent for d in query.all()]"},{"line_number":1258,"context_line":"        query.delete(synchronize_session\u003dFalse)"},{"line_number":1259,"context_line":""},{"line_number":1260,"context_line":"    if parent_status_update_needed(action):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_2b2ea291","line":1257,"in_reply_to":"9fdfeff1_482d2ca6","updated":"2019-01-31 19:39:46.000000000","message":"nvm - I see that it is a different query. Maybe we should be more verbose on our variable naming here? :D","commit_id":"0367baa1451c1ed02f8b5af44187097127abc1b6"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"45776e6e5f99d0045b06ebda0134a076e78a31c1","unresolved":false,"context_lines":[{"line_number":1697,"context_line":""},{"line_number":1698,"context_line":"    Return value for update_parent_status key in action inputs"},{"line_number":1699,"context_line":"    \"\"\""},{"line_number":1700,"context_line":"    return (len(action) \u003e 0 and hasattr(action[0], \u0027inputs\u0027) and"},{"line_number":1701,"context_line":"            action[0].inputs.get(\u0027update_parent_status\u0027, True))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_a82298b7","line":1700,"updated":"2019-01-31 19:37:24.000000000","message":"This logic is a little unclear to me. Is actions a list? Do we care if there are 1...2.3...4 action(s)?","commit_id":"0367baa1451c1ed02f8b5af44187097127abc1b6"}],"senlin/tests/unit/db/test_action_api.py":[{"author":{"_account_id":28321,"name":"Jack Kuei","email":"jkuei@blizzard.com"},"change_message_id":"ffb4053315125df023eacf09235e48055f2661da","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                              [id_of[\u0027A02\u0027], id_of[\u0027A03\u0027], id_of[\u0027A04\u0027]],"},{"line_number":431,"context_line":"                              id_of[\u0027A01\u0027])"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        # A05, A06, A07 each has dependent A01"},{"line_number":434,"context_line":"        db_api.dependency_add(self.ctx,"},{"line_number":435,"context_line":"                              id_of[\u0027A01\u0027],"},{"line_number":436,"context_line":"                              [id_of[\u0027A05\u0027], id_of[\u0027A06\u0027], id_of[\u0027A07\u0027]])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_737cca1e","line":433,"updated":"2019-01-30 01:42:55.000000000","message":"Nitpick, is it possible to have cluster action depends on another cluster action?","commit_id":"0367baa1451c1ed02f8b5af44187097127abc1b6"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"03f858b6dc480d0d71f137f9a28d899d98c80f71","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                              [id_of[\u0027A02\u0027], id_of[\u0027A03\u0027], id_of[\u0027A04\u0027]],"},{"line_number":431,"context_line":"                              id_of[\u0027A01\u0027])"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        # A05, A06, A07 each has dependent A01"},{"line_number":434,"context_line":"        db_api.dependency_add(self.ctx,"},{"line_number":435,"context_line":"                              id_of[\u0027A01\u0027],"},{"line_number":436,"context_line":"                              [id_of[\u0027A05\u0027], id_of[\u0027A06\u0027], id_of[\u0027A07\u0027]])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_c897dc39","line":433,"in_reply_to":"9fdfeff1_737cca1e","updated":"2019-01-31 19:14:52.000000000","message":"I think so.  At least that\u0027s how the code is written right now.","commit_id":"0367baa1451c1ed02f8b5af44187097127abc1b6"}]}