)]}'
{"senlin/profiles/os/nova/server.py":[{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"ebaaa52148d3c0c911e9fd79aadd8b92c3c198f1","unresolved":false,"context_lines":[{"line_number":895,"context_line":"                try:"},{"line_number":896,"context_line":"                    obj.physical_id \u003d server.id"},{"line_number":897,"context_line":"                    self.do_delete(obj)"},{"line_number":898,"context_line":"                    self.compute(obj).wait_for_server_delete(server.id)"},{"line_number":899,"context_line":"                except:"},{"line_number":900,"context_line":"                    pass"},{"line_number":901,"context_line":"            if ports:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4731cc58","line":898,"range":{"start_line":898,"start_character":20,"end_line":898,"end_character":71},"updated":"2019-10-11 02:10:01.000000000","message":"i think this line don\u0027t need because in self.do_delete was had. and if You make a volume and it not attach to VM, we also need delete, i think we should care about it.","commit_id":"16e81584b986b597c3f4c3f80ebb43b58e8cf794"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"713e8b1210cb66deabefe01a11ef2011be860664","unresolved":false,"context_lines":[{"line_number":895,"context_line":"                try:"},{"line_number":896,"context_line":"                    obj.physical_id \u003d server.id"},{"line_number":897,"context_line":"                    self.do_delete(obj)"},{"line_number":898,"context_line":"                    self.compute(obj).wait_for_server_delete(server.id)"},{"line_number":899,"context_line":"                except:"},{"line_number":900,"context_line":"                    pass"},{"line_number":901,"context_line":"            if ports:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2dfca7b3","line":898,"range":{"start_line":898,"start_character":20,"end_line":898,"end_character":71},"in_reply_to":"3fa7e38b_4731cc58","updated":"2019-10-11 17:21:54.000000000","message":"I will remove the wait.\nI believe this will also delete VMs that failed to create a volume.","commit_id":"16e81584b986b597c3f4c3f80ebb43b58e8cf794"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"626b4ba51fbc9636ba27eb3a9118eb9ca026df32","unresolved":false,"context_lines":[{"line_number":895,"context_line":"                try:"},{"line_number":896,"context_line":"                    obj.physical_id \u003d server.id"},{"line_number":897,"context_line":"                    self.do_delete(obj)"},{"line_number":898,"context_line":"                    self.compute(obj).wait_for_server_delete(server.id)"},{"line_number":899,"context_line":"                except:"},{"line_number":900,"context_line":"                    pass"},{"line_number":901,"context_line":"            if ports:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e748f8b3","line":898,"range":{"start_line":898,"start_character":20,"end_line":898,"end_character":71},"in_reply_to":"3fa7e38b_4731cc58","updated":"2019-10-11 02:31:16.000000000","message":"Yea - do_delete also waits. Might be worth just call it directly.\n\u003e self.compute(obj).server_force_delete(server_id, ignore_missing\u003dTrue)\n\u003e self.compute(obj).wait_for_server_delete(server.id)","commit_id":"16e81584b986b597c3f4c3f80ebb43b58e8cf794"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"713e8b1210cb66deabefe01a11ef2011be860664","unresolved":false,"context_lines":[{"line_number":895,"context_line":"                try:"},{"line_number":896,"context_line":"                    obj.physical_id \u003d server.id"},{"line_number":897,"context_line":"                    self.do_delete(obj)"},{"line_number":898,"context_line":"                    self.compute(obj).wait_for_server_delete(server.id)"},{"line_number":899,"context_line":"                except:"},{"line_number":900,"context_line":"                    pass"},{"line_number":901,"context_line":"            if ports:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4df9e3c5","line":898,"range":{"start_line":898,"start_character":20,"end_line":898,"end_character":71},"in_reply_to":"3fa7e38b_e748f8b3","updated":"2019-10-11 17:21:54.000000000","message":"Done","commit_id":"16e81584b986b597c3f4c3f80ebb43b58e8cf794"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"626b4ba51fbc9636ba27eb3a9118eb9ca026df32","unresolved":false,"context_lines":[{"line_number":896,"context_line":"                    obj.physical_id \u003d server.id"},{"line_number":897,"context_line":"                    self.do_delete(obj)"},{"line_number":898,"context_line":"                    self.compute(obj).wait_for_server_delete(server.id)"},{"line_number":899,"context_line":"                except:"},{"line_number":900,"context_line":"                    pass"},{"line_number":901,"context_line":"            if ports:"},{"line_number":902,"context_line":"                self._delete_ports(obj, ports)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_87c7c412","line":899,"updated":"2019-10-11 02:31:16.000000000","message":"Probably worth at least logging if this fails.","commit_id":"16e81584b986b597c3f4c3f80ebb43b58e8cf794"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"713e8b1210cb66deabefe01a11ef2011be860664","unresolved":false,"context_lines":[{"line_number":896,"context_line":"                    obj.physical_id \u003d server.id"},{"line_number":897,"context_line":"                    self.do_delete(obj)"},{"line_number":898,"context_line":"                    self.compute(obj).wait_for_server_delete(server.id)"},{"line_number":899,"context_line":"                except:"},{"line_number":900,"context_line":"                    pass"},{"line_number":901,"context_line":"            if ports:"},{"line_number":902,"context_line":"                self._delete_ports(obj, ports)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_cd2e3342","line":899,"in_reply_to":"3fa7e38b_87c7c412","updated":"2019-10-11 17:21:54.000000000","message":"Done","commit_id":"16e81584b986b597c3f4c3f80ebb43b58e8cf794"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"5910083100e4339121b863058777b1da58a51ebd","unresolved":false,"context_lines":[{"line_number":920,"context_line":"        ignore_missing \u003d params.get(\u0027ignore_missing\u0027, True)"},{"line_number":921,"context_line":"        internal_ports \u003d obj.data.get(\u0027internal_ports\u0027, [])"},{"line_number":922,"context_line":"        force \u003d params.get(\u0027force\u0027, False)"},{"line_number":923,"context_line":"        timeout \u003d params.get(\u0027timeout\u0027, None)"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"        try:"},{"line_number":926,"context_line":"            if server_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_de0b378b","line":923,"updated":"2019-10-11 20:39:07.000000000","message":"Do we want to add a timeout here? We probably don\u0027t want to get stuck waiting forever if there is an issue with the specific VM.","commit_id":"da53e83b83152a7d10f37d2907123db6684a34f9"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"a26d323e966031be496a5c37bb2f6ef857f2e0f5","unresolved":false,"context_lines":[{"line_number":920,"context_line":"        ignore_missing \u003d params.get(\u0027ignore_missing\u0027, True)"},{"line_number":921,"context_line":"        internal_ports \u003d obj.data.get(\u0027internal_ports\u0027, [])"},{"line_number":922,"context_line":"        force \u003d params.get(\u0027force\u0027, False)"},{"line_number":923,"context_line":"        timeout \u003d params.get(\u0027timeout\u0027, None)"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"        try:"},{"line_number":926,"context_line":"            if server_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_397705d7","line":923,"in_reply_to":"3fa7e38b_de0b378b","updated":"2019-10-11 22:37:52.000000000","message":"Done","commit_id":"da53e83b83152a7d10f37d2907123db6684a34f9"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"5910083100e4339121b863058777b1da58a51ebd","unresolved":false,"context_lines":[{"line_number":926,"context_line":"            if server_id:"},{"line_number":927,"context_line":"                driver \u003d self.compute(obj)"},{"line_number":928,"context_line":"                if force:"},{"line_number":929,"context_line":"                    driver.server_force_delete(server_id, ignore_missing)"},{"line_number":930,"context_line":"                else:"},{"line_number":931,"context_line":"                    driver.server_delete(server_id, ignore_missing)"},{"line_number":932,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_be067b85","line":929,"updated":"2019-10-11 20:39:07.000000000","message":"What is the difference between force and non-force?","commit_id":"da53e83b83152a7d10f37d2907123db6684a34f9"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"a26d323e966031be496a5c37bb2f6ef857f2e0f5","unresolved":false,"context_lines":[{"line_number":926,"context_line":"            if server_id:"},{"line_number":927,"context_line":"                driver \u003d self.compute(obj)"},{"line_number":928,"context_line":"                if force:"},{"line_number":929,"context_line":"                    driver.server_force_delete(server_id, ignore_missing)"},{"line_number":930,"context_line":"                else:"},{"line_number":931,"context_line":"                    driver.server_delete(server_id, ignore_missing)"},{"line_number":932,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_592201bb","line":929,"in_reply_to":"3fa7e38b_be067b85","updated":"2019-10-11 22:37:52.000000000","message":"Haha, I had the same question yesterday.  I still don\u0027t know. One calls the regular nova delete while the other one calls the nova force-delete API, but from the nova docs I can\u0027t figure what the difference is.","commit_id":"da53e83b83152a7d10f37d2907123db6684a34f9"}]}