)]}'
{"senlin/conf/authentication.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"337c32211e00c8246ff140538e7bf5eff7922d20","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.StrOpt(\u0027service_project_domain\u0027, default\u003d\u0027Default\u0027,"},{"line_number":29,"context_line":"               help\u003d_(\u0027Name of the domain for the service project.\u0027)),"},{"line_number":30,"context_line":"    cfg.BoolOpt(\u0027verify_ssl\u0027, default\u003dTrue,"},{"line_number":31,"context_line":"            help\u003d_(\u0027Verify HTTPS connections.\u0027)),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027interface\u0027, default\u003d\u0027public\u0027,"},{"line_number":33,"context_line":"            help\u003d_(\u0027Interface to use for the API endpoints.\u0027)),"},{"line_number":34,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e1e7ac45","line":31,"updated":"2020-09-04 08:02:08.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"9e96739531b4f270d6bed8df7169a81698123e2a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"337c32211e00c8246ff140538e7bf5eff7922d20","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    cfg.BoolOpt(\u0027verify_ssl\u0027, default\u003dTrue,"},{"line_number":31,"context_line":"            help\u003d_(\u0027Verify HTTPS connections.\u0027)),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027interface\u0027, default\u003d\u0027public\u0027,"},{"line_number":33,"context_line":"            help\u003d_(\u0027Interface to use for the API endpoints.\u0027)),"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c1ea680c","line":33,"updated":"2020-09-04 08:02:08.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"9e96739531b4f270d6bed8df7169a81698123e2a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"9b743718cd41c3e140dd0c96ed7b1bed3ed3a1ca","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.StrOpt(\u0027service_project_domain\u0027, default\u003d\u0027Default\u0027,"},{"line_number":29,"context_line":"               help\u003d_(\u0027Name of the domain for the service project.\u0027)),"},{"line_number":30,"context_line":"    cfg.BoolOpt(\u0027verify_ssl\u0027, default\u003dTrue,"},{"line_number":31,"context_line":"               help\u003d_(\u0027Verify HTTPS connections.\u0027)),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027interface\u0027, default\u003d\u0027public\u0027,"},{"line_number":33,"context_line":"               help\u003d_(\u0027Interface to use for the API endpoints.\u0027)),"},{"line_number":34,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7cbfbfa9","line":31,"updated":"2020-09-04 09:36:21.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"29ea4066ca1965234945a4320e3bc3fb72bdc333"}],"senlin/drivers/os/keystone_v3.py":[{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"58d5e5d185eb7e59b3f67f14846d29e1692c0c87","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return access_info[\u0027user_id\u0027]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @classmethod"},{"line_number":108,"context_line":"    def get_service_credentials(cls, **kwargs):"},{"line_number":109,"context_line":"        \"\"\"Senlin service credential to use with Keystone."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        :param kwargs: An additional keyword argument list that can be used"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_2548d488","line":108,"updated":"2020-10-01 00:44:59.000000000","message":"This method is called from different places in Senlin but usually the return value of this method is not directly passed to the openstack sdk Connection.  Instead it is wrapped by another dictionary that is eventually passed to the openstack sdk Connection constructor.  E.g. see https://github.com/openstack/senlin/blob/master/senlin/api/middleware/webhook.py#L56\nIn that example, certain keys are taken from return value of the get_service_credentials call and put inside another dictionary called kwargs.  The kwargs dictionary is then passed to _get_token which calls the openstack SDK Connection constructor down the line.\n\nIn order for the \u0027verify\u0027 and \u0027interface\u0027 keys to get passed to Openstack SDK, all the calls to get_service_credentials need to be checked and those keys need to be extracted as well to be passed on.","commit_id":"20edfd6ba846c3b34efa31d799762a25264e7754"}],"senlin/engine/notifications/message.py":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"9375665794a377b0cfe8f24793d19dac1425df38","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            \u0027password\u0027: service_creds.get(\u0027password\u0027),"},{"line_number":64,"context_line":"            \u0027auth_url\u0027: service_creds.get(\u0027auth_url\u0027),"},{"line_number":65,"context_line":"            \u0027user_domain_name\u0027: service_creds.get(\u0027user_domain_name\u0027),"},{"line_number":66,"context_line":"            \u0027project_domain_name\u0027: service_creds.get(\u0027project_domain_name\u0027),"},{"line_number":67,"context_line":"            \u0027verify\u0027: service_creds.get(\u0027verify\u0027),"},{"line_number":68,"context_line":"            \u0027interface\u0027: service_creds.get(\u0027interface\u0027),"},{"line_number":69,"context_line":"        }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        cred \u003d co.Credential.get(oslo_context.get_current(), user, project)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_d9b28b06","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":56},"updated":"2020-10-02 08:54:51.000000000","message":"I think I need a bit of help with that part, as I\u0027m not sure why all these params are None, while we have defaults... Looks like it\u0027s a bit different from others?","commit_id":"8499a1471466cd85fd119f36a7feddee6b35e7b7"}]}
