)]}'
{"senlin/profiles/os/nova/server.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"0900c89a936f237a02400ff6af7a538bac621e5b","unresolved":true,"context_lines":[{"line_number":659,"context_line":"                      ) % {\u0027v\u0027: vnic_type})"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"        # Check vnic_type"},{"line_number":662,"context_line":"        error \u003d self._check_vnic_type(nc, net_spec, result)"},{"line_number":663,"context_line":"        _verify(error)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"        # Check security_groups"}],"source_content_type":"text/x-python","patch_set":2,"id":"7b5cd27d_0a53ab9a","line":662,"updated":"2020-12-03 04:42:22.000000000","message":"_check_vnic_type does not actually return anything besides None. Probably want to add some validation that returns an error, or we can just drop _verify(error).","commit_id":"0ade81740a0e5aaa4b757ef67db791f869f0d724"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"9a0be77813b852fc4e2992785ac3dad8ac51c66c","unresolved":true,"context_lines":[{"line_number":659,"context_line":"                      ) % {\u0027v\u0027: vnic_type})"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"        # Check vnic_type"},{"line_number":662,"context_line":"        error \u003d self._check_vnic_type(nc, net_spec, result)"},{"line_number":663,"context_line":"        _verify(error)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"        # Check security_groups"}],"source_content_type":"text/x-python","patch_set":2,"id":"8141af5e_91527d1a","line":662,"in_reply_to":"7b5cd27d_0a53ab9a","updated":"2020-12-03 05:54:01.000000000","message":"You are suggesting to remove _verify(error) line because it\u0027s always return None. I can do that if that is good an idea. I literally copy paste that line to make sure we don\u0027t have drastic new copy style.","commit_id":"0ade81740a0e5aaa4b757ef67db791f869f0d724"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"b8df06d38a5985a134f67299861147281c9df045","unresolved":false,"context_lines":[{"line_number":645,"context_line":"                          \"cannot be specified at the same time\""},{"line_number":646,"context_line":"                          ) % {\u0027p\u0027: self.PORT, \u0027fip\u0027: self.FIXED_IP})"},{"line_number":647,"context_line":"            result[self.FIXED_IP] \u003d fixed_ip"},{"line_number":648,"context_line":" "},{"line_number":649,"context_line":"        # Validate vnic_type input"},{"line_number":650,"context_line":"        vnic_type \u003d net_spec.get(self.VNIC_TYPE)"},{"line_number":651,"context_line":"        if vnic_type is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"c4b1ca65_6eaca515","line":648,"in_reply_to":"7831fe42_f3df1523","updated":"2020-12-03 15:15:12.000000000","message":"\u003e pep8: W293 blank line contains whitespace\n\nPlease fix.","commit_id":"12874ebbbe18bdd765ffaede8fe1f57bcd1f9afd"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"dc3b4543f2fff374505420eb92291d3dfec2b6be","unresolved":true,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        # Validate vnic_type input"},{"line_number":650,"context_line":"        vnic_type \u003d net_spec.get(self.VNIC_TYPE)"},{"line_number":651,"context_line":"        if vnic_type is None:"},{"line_number":652,"context_line":"            supported_vnic_types \u003d [\u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027]"},{"line_number":653,"context_line":"            try:"},{"line_number":654,"context_line":"                supported_vnic_types.index(vnic_type)"}],"source_content_type":"text/x-python","patch_set":4,"id":"8634216b_4ddbccd7","line":651,"updated":"2020-12-05 04:09:15.000000000","message":"I think this logic is backwards. This will always be None, so why even try to check vnic_type. This should probably be if vnic_type is not None:","commit_id":"6660a0d3bebf48fff061b3f0ea7b7c50f108874d"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"f5d331dfdf20541b93874c19d763a330f83a3583","unresolved":true,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        # Validate vnic_type input"},{"line_number":650,"context_line":"        vnic_type \u003d net_spec.get(self.VNIC_TYPE)"},{"line_number":651,"context_line":"        if vnic_type is None:"},{"line_number":652,"context_line":"            supported_vnic_types \u003d [\u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027]"},{"line_number":653,"context_line":"            try:"},{"line_number":654,"context_line":"                supported_vnic_types.index(vnic_type)"}],"source_content_type":"text/x-python","patch_set":4,"id":"41d7b83e_5f6d0c84","line":651,"updated":"2020-12-04 17:41:47.000000000","message":"You can simplify this without using a try except like this:\n\nif vnic_type not in [\u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027]:\n     _verify(_(\"vnic_type: \u0027%(v)s\u0027 is not supported.\"\n               \"(supported types are: normal, direct, macvtap)\"\n            ) % {\u0027v\u0027: vnic_type})\nresult[self.VNIC_TYPE] \u003d vnic_type\n\nThen you can get rid of the _check_vnic_type function.","commit_id":"6660a0d3bebf48fff061b3f0ea7b7c50f108874d"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"9bd8fb979af705019a3f8b11174c4467ba4fcd31","unresolved":false,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        # Validate vnic_type input"},{"line_number":650,"context_line":"        vnic_type \u003d net_spec.get(self.VNIC_TYPE)"},{"line_number":651,"context_line":"        if vnic_type is None:"},{"line_number":652,"context_line":"            supported_vnic_types \u003d [\u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027]"},{"line_number":653,"context_line":"            try:"},{"line_number":654,"context_line":"                supported_vnic_types.index(vnic_type)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c67c8bcc_a2376c22","line":651,"in_reply_to":"41d7b83e_5f6d0c84","updated":"2020-12-05 05:10:59.000000000","message":"Done","commit_id":"6660a0d3bebf48fff061b3f0ea7b7c50f108874d"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"9bd8fb979af705019a3f8b11174c4467ba4fcd31","unresolved":false,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        # Validate vnic_type input"},{"line_number":650,"context_line":"        vnic_type \u003d net_spec.get(self.VNIC_TYPE)"},{"line_number":651,"context_line":"        if vnic_type is None:"},{"line_number":652,"context_line":"            supported_vnic_types \u003d [\u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027]"},{"line_number":653,"context_line":"            try:"},{"line_number":654,"context_line":"                supported_vnic_types.index(vnic_type)"}],"source_content_type":"text/x-python","patch_set":4,"id":"22d33cce_fb63b2d0","line":651,"in_reply_to":"8634216b_4ddbccd7","updated":"2020-12-05 05:10:59.000000000","message":"Done","commit_id":"6660a0d3bebf48fff061b3f0ea7b7c50f108874d"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"89c272f8d9fa437543e53e639677bf77ea79cdee","unresolved":true,"context_lines":[{"line_number":632,"context_line":"            result[self.FIXED_IP] \u003d fixed_ip"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        # Validate vnic_type input"},{"line_number":635,"context_line":"        vnic_type \u003d net_spec.get(self.VNIC_TYPE)"},{"line_number":636,"context_line":"        if vnic_type is not None:"},{"line_number":637,"context_line":"            if vnic_type not in [\u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027]:"},{"line_number":638,"context_line":"                _verify(_(\"vnic_type: \u0027%(v)s\u0027 is not supported.\""}],"source_content_type":"text/x-python","patch_set":6,"id":"44c69b40_9864b99c","line":635,"updated":"2020-12-07 22:09:50.000000000","message":"I think this has to provide the default value:\nvnic_type \u003d net_spec.get(self.VNIC_TYPE, None)","commit_id":"1cd1407559940450612d15c636e393a8d7452a5e"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"7181a20f5ba030473fe3e05fb9e9ddecd737cc7d","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            result[self.FIXED_IP] \u003d fixed_ip"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        # Validate vnic_type input"},{"line_number":635,"context_line":"        vnic_type \u003d net_spec.get(self.VNIC_TYPE)"},{"line_number":636,"context_line":"        if vnic_type is not None:"},{"line_number":637,"context_line":"            if vnic_type not in [\u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027]:"},{"line_number":638,"context_line":"                _verify(_(\"vnic_type: \u0027%(v)s\u0027 is not supported.\""}],"source_content_type":"text/x-python","patch_set":6,"id":"2decdc35_1c444463","line":635,"in_reply_to":"44c69b40_9864b99c","updated":"2020-12-07 22:39:09.000000000","message":"Done","commit_id":"1cd1407559940450612d15c636e393a8d7452a5e"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"dce32ddd7ea68135ddcf6ff77278e0bf86b030da","unresolved":true,"context_lines":[{"line_number":638,"context_line":"                _verify(_(\"vnic_type: \u0027%(v)s\u0027 is not supported.\""},{"line_number":639,"context_line":"                          \"(supported types are: normal, direct, macvtap)\""},{"line_number":640,"context_line":"                          ) % {\u0027v\u0027: vnic_type})"},{"line_number":641,"context_line":"        result[self.VNIC_TYPE] \u003d vnic_type"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        # Check security_groups"},{"line_number":644,"context_line":"        error \u003d self._check_security_groups(nc, net_spec, result)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fea73b5_4a6b1406","line":641,"updated":"2020-12-07 22:40:15.000000000","message":"This line should be inside the if.  Only if the vnic_type is set (meaning not None) should you add it to the result.","commit_id":"458d1933c128428181d576e6570167940c0e1a8b"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"fa147bf7d08ad0c945a2618a19140f48713a45b4","unresolved":false,"context_lines":[{"line_number":638,"context_line":"                _verify(_(\"vnic_type: \u0027%(v)s\u0027 is not supported.\""},{"line_number":639,"context_line":"                          \"(supported types are: normal, direct, macvtap)\""},{"line_number":640,"context_line":"                          ) % {\u0027v\u0027: vnic_type})"},{"line_number":641,"context_line":"        result[self.VNIC_TYPE] \u003d vnic_type"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        # Check security_groups"},{"line_number":644,"context_line":"        error \u003d self._check_security_groups(nc, net_spec, result)"}],"source_content_type":"text/x-python","patch_set":8,"id":"43cc3908_8a199088","line":641,"in_reply_to":"5fea73b5_4a6b1406","updated":"2020-12-08 03:01:45.000000000","message":"Done","commit_id":"458d1933c128428181d576e6570167940c0e1a8b"}]}