)]}'
{"senlin/policies/lb_policy.py":[{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"c10f3c07e122363eb661e78d3c96f8a39b84a53a","unresolved":true,"context_lines":[{"line_number":341,"context_line":"        # validate flavor_id"},{"line_number":342,"context_line":"        flavor_id \u003d self.flavor_id_spec"},{"line_number":343,"context_line":"        if flavor_id is not None:"},{"line_number":344,"context_line":"            oc.conn.load_balancer.get_flavor(flavor_id)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        # validate VIP subnet or network"},{"line_number":347,"context_line":"        subnet_name_or_id \u003d self.vip_spec.get(self.VIP_SUBNET)"}],"source_content_type":"text/x-python","patch_set":9,"id":"aa05ec5a_76848ee0","line":344,"updated":"2021-01-04 16:44:30.000000000","message":"This needs to be wrapped in a try except like it is done for validate pool subnet above.","commit_id":"6d432cda7432b0c15833292920861faab2f9b394"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"6595d813430cb28cf499687479c70957ce9fe994","unresolved":true,"context_lines":[{"line_number":303,"context_line":"            default\u003dNone,"},{"line_number":304,"context_line":"        ),"},{"line_number":305,"context_line":"        FLAVOR_ID: schema.String("},{"line_number":306,"context_line":"            _(\u0027ID of octavia loadbalancer flavor to use for creattion \u0027"},{"line_number":307,"context_line":"              \u0027of the loadbalancer.\u0027),"},{"line_number":308,"context_line":"            default\u003dNone,"},{"line_number":309,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"a170a9db_107bed18","line":306,"updated":"2021-01-05 01:28:47.000000000","message":"typo: creation","commit_id":"6d4297842a94601f256e051abb69ca02c8e10ed0"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"35eb864707231895ea7af7dc5d112036e35bf57f","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            default\u003dNone,"},{"line_number":304,"context_line":"        ),"},{"line_number":305,"context_line":"        FLAVOR_ID: schema.String("},{"line_number":306,"context_line":"            _(\u0027ID of octavia loadbalancer flavor to use for creattion \u0027"},{"line_number":307,"context_line":"              \u0027of the loadbalancer.\u0027),"},{"line_number":308,"context_line":"            default\u003dNone,"},{"line_number":309,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"897538a8_38161b6a","line":306,"in_reply_to":"a170a9db_107bed18","updated":"2021-01-07 06:25:13.000000000","message":"Done","commit_id":"6d4297842a94601f256e051abb69ca02c8e10ed0"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"6595d813430cb28cf499687479c70957ce9fe994","unresolved":true,"context_lines":[{"line_number":341,"context_line":"        # validate flavor_id"},{"line_number":342,"context_line":"        flavor_id \u003d self.flavor_id_spec"},{"line_number":343,"context_line":"        if flavor_id is not None:"},{"line_number":344,"context_line":"            oc.conn.load_balancer.get_flavor(flavor_id)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        # validate VIP subnet or network"},{"line_number":347,"context_line":"        subnet_name_or_id \u003d self.vip_spec.get(self.VIP_SUBNET)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2cd321_f17c4152","line":344,"updated":"2021-01-05 01:28:47.000000000","message":"Can you add the try/except to like it is done for the subnet above?","commit_id":"6d4297842a94601f256e051abb69ca02c8e10ed0"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"35eb864707231895ea7af7dc5d112036e35bf57f","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        # validate flavor_id"},{"line_number":342,"context_line":"        flavor_id \u003d self.flavor_id_spec"},{"line_number":343,"context_line":"        if flavor_id is not None:"},{"line_number":344,"context_line":"            oc.conn.load_balancer.get_flavor(flavor_id)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        # validate VIP subnet or network"},{"line_number":347,"context_line":"        subnet_name_or_id \u003d self.vip_spec.get(self.VIP_SUBNET)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f178767_d4256f5d","line":344,"in_reply_to":"7a2cd321_f17c4152","updated":"2021-01-07 06:25:13.000000000","message":"Done","commit_id":"6d4297842a94601f256e051abb69ca02c8e10ed0"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"07bfd35e50cb9b61d03643d50d31bdad22ea3238","unresolved":true,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # validate flavor_id"},{"line_number":342,"context_line":"        flavor_id \u003d self.flavor_id_spec"},{"line_number":343,"context_line":"        if flavor_id is not None:"},{"line_number":344,"context_line":"            try:"},{"line_number":345,"context_line":"                oc.flavor_get(flavor_id)"},{"line_number":346,"context_line":"            except exc.InternalError:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa1df64_e4b6aa05","line":343,"updated":"2021-01-07 17:07:05.000000000","message":"You can just say\nif flavor_id:","commit_id":"08a82863d09851277503d2d39b9af4a497f1b153"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"8caa99de6dff667105c428a2acb6b438ca025771","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # validate flavor_id"},{"line_number":342,"context_line":"        flavor_id \u003d self.flavor_id_spec"},{"line_number":343,"context_line":"        if flavor_id is not None:"},{"line_number":344,"context_line":"            try:"},{"line_number":345,"context_line":"                oc.flavor_get(flavor_id)"},{"line_number":346,"context_line":"            except exc.InternalError:"}],"source_content_type":"text/x-python","patch_set":12,"id":"266afc9f_ed21897e","line":343,"in_reply_to":"9aa1df64_e4b6aa05","updated":"2021-01-07 17:21:15.000000000","message":"Done","commit_id":"08a82863d09851277503d2d39b9af4a497f1b153"}]}