)]}'
{"senlin/drivers/os/octavia_v2.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"2ed785361be76d77a62a6664dd2bdd37bdde7c50","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # Use following name when name variable not set"},{"line_number":51,"context_line":"        if name is None:"},{"line_number":52,"context_line":"            name \u003d (\"senlin-lb-\" + name_id)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        if vip_subnet_id is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"52133d74_70197de0","line":51,"updated":"2021-03-30 18:14:55.000000000","message":"This is probably fine to just be\n\u003e if not name:\nSince I doubt an empty string would be valid as well?","commit_id":"3ca7062f99a7e567f4a2e9bdd5163ade39ad94f9"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"cc39471ce3bb3ca3ef3c511037ebdae9efc16d98","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        }"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # Use following name when name variable not set"},{"line_number":51,"context_line":"        if name is None:"},{"line_number":52,"context_line":"            name \u003d (\"senlin-lb-\" + name_id)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        if vip_subnet_id is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9bde2fa7_0fcc6ae2","line":51,"in_reply_to":"52133d74_70197de0","updated":"2021-03-30 18:38:11.000000000","message":"Done","commit_id":"3ca7062f99a7e567f4a2e9bdd5163ade39ad94f9"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"d609a59c6848c1d622cd76fe7fae34c0040b3b21","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # Use following name when name variable not set"},{"line_number":51,"context_line":"        if name is None:"},{"line_number":52,"context_line":"            name \u003d (\"senlin-lb-\" + name_id)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        if vip_subnet_id is not None:"},{"line_number":55,"context_line":"            kwargs[\u0027vip_subnet_id\u0027] \u003d vip_subnet_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"21b975cb_4985793b","line":52,"updated":"2021-03-30 18:14:07.000000000","message":"No need for the () here.\n\u003e name \u003d \u0027senlin-lb-%s\u0027 % name_id\nIs probably the preferred style.","commit_id":"3ca7062f99a7e567f4a2e9bdd5163ade39ad94f9"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"cc39471ce3bb3ca3ef3c511037ebdae9efc16d98","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # Use following name when name variable not set"},{"line_number":51,"context_line":"        if name is None:"},{"line_number":52,"context_line":"            name \u003d (\"senlin-lb-\" + name_id)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        if vip_subnet_id is not None:"},{"line_number":55,"context_line":"            kwargs[\u0027vip_subnet_id\u0027] \u003d vip_subnet_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"82e8d3b2_5a0d5479","line":52,"in_reply_to":"21b975cb_4985793b","updated":"2021-03-30 18:38:11.000000000","message":"Done","commit_id":"3ca7062f99a7e567f4a2e9bdd5163ade39ad94f9"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"bf7ff722ae257cb8ee312d5baa605cfa6a697eea","unresolved":true,"context_lines":[{"line_number":15,"context_line":"from senlin.drivers import sdk"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Generate unique name_id for name variable"},{"line_number":18,"context_line":"name_id \u003d uuid.uuid4().hex[:5]"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class OctaviaClient(base.DriverBase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"f207b667_74648f37","line":18,"updated":"2021-03-30 18:40:43.000000000","message":"This is a singleton and will always be the same. Is that fine?","commit_id":"f05650e4132069ae5e7f5143eefe310db24ae4b3"}],"senlin/policies/lb_policy.py":[{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"a93456152688e04d6801661c61d555bdbc688272","unresolved":true,"context_lines":[{"line_number":309,"context_line":"            default\u003dNone,"},{"line_number":310,"context_line":"        ),"},{"line_number":311,"context_line":"        LB_NAME: schema.String("},{"line_number":312,"context_line":"            _(\u0027Name of octavia loadbalancer.\u0027),"},{"line_number":313,"context_line":"            default\u003dNone,"},{"line_number":314,"context_line":"        )"},{"line_number":315,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":8,"id":"c8211929_307243ce","line":312,"updated":"2021-03-31 16:09:42.000000000","message":"I don\u0027t think it is a good idea to let users specify the LB name in the policy.  All the load balancers will end up with the same name because a policy could be attached to multiple clusters.","commit_id":"8e94b05666f0624e81cef15a9af15b4163a13244"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"bb8a91306bbd5fa896cd7c121985726cbd222aab","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            default\u003dNone,"},{"line_number":310,"context_line":"        ),"},{"line_number":311,"context_line":"        LB_NAME: schema.String("},{"line_number":312,"context_line":"            _(\u0027Name of octavia loadbalancer.\u0027),"},{"line_number":313,"context_line":"            default\u003dNone,"},{"line_number":314,"context_line":"        )"},{"line_number":315,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":8,"id":"83338edc_6121120a","line":312,"in_reply_to":"c8211929_307243ce","updated":"2021-03-31 20:17:27.000000000","message":"Done","commit_id":"8e94b05666f0624e81cef15a9af15b4163a13244"}],"senlin/tests/unit/drivers/test_lbaas.py":[{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"513b294ecf266f59994cf268ae8071b04458b3ae","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        self.oc.listener_create.assert_called_once_with("},{"line_number":333,"context_line":"            \u0027LB_ID\u0027, self.vip[\u0027protocol\u0027], self.vip[\u0027protocol_port\u0027],"},{"line_number":334,"context_line":"            self.vip[\u0027connection_limit\u0027], self.vip[\u0027admin_state_up\u0027]"},{"line_number":335,"context_line":"            name\u003dlistener_name)"},{"line_number":336,"context_line":"        self.lb_driver._wait_for_lb_ready.assert_called_with(\u0027LB_ID\u0027)"},{"line_number":337,"context_line":"        self.lb_driver.lb_delete.assert_called_once_with("},{"line_number":338,"context_line":"            loadbalancer\u003d\u0027LB_ID\u0027, listener\u003d\u0027LISTENER_ID\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"777d143e_7c29e2ec","line":335,"updated":"2021-04-01 22:19:32.000000000","message":"You are missing a comma at the end of the previous line.","commit_id":"2a87acab76f25336b2a0ae84b03f5d239661e5c1"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"4cd945e09b01e3a29c8de49131edda7e11614909","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        self.oc.listener_create.assert_called_once_with("},{"line_number":333,"context_line":"            \u0027LB_ID\u0027, self.vip[\u0027protocol\u0027], self.vip[\u0027protocol_port\u0027],"},{"line_number":334,"context_line":"            self.vip[\u0027connection_limit\u0027], self.vip[\u0027admin_state_up\u0027]"},{"line_number":335,"context_line":"            name\u003dlistener_name)"},{"line_number":336,"context_line":"        self.lb_driver._wait_for_lb_ready.assert_called_with(\u0027LB_ID\u0027)"},{"line_number":337,"context_line":"        self.lb_driver.lb_delete.assert_called_once_with("},{"line_number":338,"context_line":"            loadbalancer\u003d\u0027LB_ID\u0027, listener\u003d\u0027LISTENER_ID\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"d3a1d44d_eafc9596","line":335,"in_reply_to":"777d143e_7c29e2ec","updated":"2021-04-02 01:14:38.000000000","message":"That was good catch!","commit_id":"2a87acab76f25336b2a0ae84b03f5d239661e5c1"},{"author":{"_account_id":28752,"name":"Satish Patel","email":"satish.txt@gmail.com","username":"spatel"},"change_message_id":"923aa16fc63f38ad0075795b5edf16b26059989c","unresolved":true,"context_lines":[{"line_number":430,"context_line":"        self.nc.subnet_get.return_value \u003d subnet_obj"},{"line_number":431,"context_line":"        self.lb_driver.lb_delete \u003d mock.Mock()"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        status, res \u003d self.lb_driver.lb_create(self.vip, self.pool, self.hm)"},{"line_number":434,"context_line":"        self.assertFalse(status)"},{"line_number":435,"context_line":"        msg \u003d _(\u0027Failed in creating health monitor (%s).\u0027) % \u0027HEALTHMONITOR_ID\u0027"},{"line_number":436,"context_line":"        self.assertEqual(msg, res)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba2f9238_62bbd26b","line":433,"updated":"2021-04-02 17:36:08.000000000","message":"Do you think i need \"cluster_name\" parameter here?","commit_id":"628063d64387bf82a89f92bf43fd74abe7c4289d"},{"author":{"_account_id":27224,"name":"Duc Truong","email":"duc.openstack@gmail.com","username":"dtruong2"},"change_message_id":"8a06e95b05affbf84a6232c91fce8ac52c638cea","unresolved":true,"context_lines":[{"line_number":430,"context_line":"        self.nc.subnet_get.return_value \u003d subnet_obj"},{"line_number":431,"context_line":"        self.lb_driver.lb_delete \u003d mock.Mock()"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        status, res \u003d self.lb_driver.lb_create(self.vip, self.pool, self.hm)"},{"line_number":434,"context_line":"        self.assertFalse(status)"},{"line_number":435,"context_line":"        msg \u003d _(\u0027Failed in creating health monitor (%s).\u0027) % \u0027HEALTHMONITOR_ID\u0027"},{"line_number":436,"context_line":"        self.assertEqual(msg, res)"}],"source_content_type":"text/x-python","patch_set":14,"id":"8ce4f03e_15dc7be3","line":433,"in_reply_to":"ba2f9238_62bbd26b","updated":"2021-04-06 16:19:57.000000000","message":"Yes, add cluster_name.  That\u0027s why it is failing the unit test.","commit_id":"628063d64387bf82a89f92bf43fd74abe7c4289d"}]}