)]}'
{"shade/__init__.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"65760ad7b3cde6db7f5a1be8aeebe15bfb500b22","unresolved":false,"context_lines":[{"line_number":784,"context_line":"        elif ips:"},{"line_number":785,"context_line":"            self.add_ip_list(server, ips)"},{"line_number":786,"context_line":"        elif auto_ip:"},{"line_number":787,"context_line":"            server_dict \u003d self.get_server_dict(server.id)"},{"line_number":788,"context_line":"            if server_dict.get(\u0027accessIPv4\u0027, None):"},{"line_number":789,"context_line":"                return server"},{"line_number":790,"context_line":"            self.add_auto_ip(server)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_a8b82076","line":787,"updated":"2015-02-16 19:28:24.000000000","message":"This seems unnecessary to retrieve the server object yet again. We should be able to just call self.get_openstack_vars() here with the server object.","commit_id":"acfb5757c481303e7992b862318a95b07e869b80"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b00691be84567195a1c3bd53a9bec7c659722358","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        elif auto_ip:"},{"line_number":787,"context_line":"            server_dict \u003d self.get_openstack_vars(server)"},{"line_number":788,"context_line":"            if server_dict.get(\u0027accessIPv4\u0027, None):"},{"line_number":789,"context_line":"                return server"},{"line_number":790,"context_line":"            self.add_auto_ip(server)"},{"line_number":791,"context_line":"        else:"},{"line_number":792,"context_line":"            return server"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_a5c6279a","line":789,"updated":"2015-02-18 21:42:39.000000000","message":"I think I am with jeblair, there is a get_server_public_ip method, is there a reason we don\u0027t use that here to avoid code duplication? Also dict.get() returns None by default but it doesn\u0027t hurt to be explicit.","commit_id":"834ed0fd3839bf754fbc693463a17e536fcc99a7"}]}
